From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.1656.1654653351220721120 for ; Tue, 07 Jun 2022 18:55:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=GaxYCCBj; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=015880cd5a=abner.chang@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 257NW5JJ029296; Wed, 8 Jun 2022 01:40:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=0LXZrehMYhn0nfMss6C1bXTZtRnbqndtM6Y9rkY4cHA=; b=GaxYCCBjrEv5ZTiFh3PkyBlqJB3l/R4naotGK72cwXfIVbLtpIqP1eG6NCjHsyyCd4Qu vZokikOQR7qIs3GKOwV+YC7vksGWXUCkA3LEPedONOb/KegeAo0zpZ24K70ChyhnU7qz MgfSqPAzp+2WRfLXlnyEyOHY3kLD+tDPh5f675Ukmu34Aw1uNWqmhYm9V4t5Ru3G3ccx 6hWSfeAD1Kw0GHsx946k/GysH0ZxA9V36C6YFQ331hmVlWkXZlbGBs9NrPPZmXW+Dt3p VEi/iPxFfU6BFtCt/KYyxbeQez/zztt+hmG4WEbrzzByqXHz0LMthUSdqV7KZ6isMcXI mg== Received: from p1lg14880.it.hpe.com (p1lg14880.it.hpe.com [16.230.97.201]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3gj9scvhfs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jun 2022 01:40:46 +0000 Received: from p1wg14926.americas.hpqcorp.net (unknown [10.119.18.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14880.it.hpe.com (Postfix) with ESMTPS id A7606800252; Wed, 8 Jun 2022 01:40:44 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Tue, 7 Jun 2022 13:40:35 -1200 Received: from p1wg14927.americas.hpqcorp.net (10.119.18.117) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Tue, 7 Jun 2022 13:40:34 -1200 Received: from p1wg14920.americas.hpqcorp.net (16.230.19.123) by p1wg14927.americas.hpqcorp.net (10.119.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15 via Frontend Transport; Tue, 7 Jun 2022 13:40:34 -1200 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Tue, 7 Jun 2022 13:40:34 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZgMllqYpjWQIXDb3yyiaHE6oKt0frvsegKnlqqkylf0MG1GSAS2kd4PLFD1XGtJFvXNuyDf2hsEc0PrKLIV/ywwCuinvLW+JrB4m0BXElJ3FsuRoD7DcAWh8BjZd/4XBwPkJB9HWnbUOxWwcC4GG1oYeHjnUtMpUkUaBBd5fdDLoLkrvddG6RFNyy7RgYO3q6srwnik6CUCSJKe7K1u3A/1jgBCxfq92H1x7WijrkfjGN5mjS0P6o3e+DGar5svVDHSQpZNulVWBuYHCYUGwepH6yA4YS7boJFyd5/dmkSmWjVX+1QFIpt+qxEz+/Mu21ZuZQ0xXYczOnYIydH+75Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0LXZrehMYhn0nfMss6C1bXTZtRnbqndtM6Y9rkY4cHA=; b=NftVtXjyyQ6FK/7q9p3hQLpby6iq6+6yeD8jCwZurFC+UAjT+zrEClXMPIe1D+kTjyyTiL8giUEvP11e/yYVSuca2SKJfXgUTU73a17BbBm2ocGHn7fSVPFcVz9H24yJuAFkgMQSigBbS7sx5ywvyQzTjJk4VlMtvjdfpMHn5S8BQVgoU+95YwAee2qSTgfb86qHgZ6JcLChAlIUTqyY1Rv1YLV7iHItZO7cMi2L/g6ug4pRNxGvh56kHHdef1BCD+nkzir0R5N6yuWZhdFH7cGVn1FUy5HukpavAWAIZJMQr7wN48HYckCBBztKcf/bcdVx4T49KlE4wG1PxpUzDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:173::6) by PH0PR84MB1788.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:162::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Wed, 8 Jun 2022 01:40:32 +0000 Received: from PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM ([fe80::89d1:6a2d:b8a5:8b0d]) by PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM ([fe80::89d1:6a2d:b8a5:8b0d%7]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 01:40:32 +0000 From: "Abner Chang" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Jiewen Yao , Oliver Steffen , Leif Lindholm , Pawel Polawski , Hao A Wu , Liming Gao , Ray Ni , Jordan Justen , Jian J Wang , "Ard Biesheuvel" , Ard Biesheuvel Subject: Re: [PATCH v6 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Thread-Topic: [PATCH v6 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Thread-Index: AQHYWJAsGLjYK3KrKkipnv4oozHhja1FAAJw Date: Wed, 8 Jun 2022 01:40:32 +0000 Message-ID: References: <20220425103446.496763-1-kraxel@redhat.com> <20220425103446.496763-2-kraxel@redhat.com> In-Reply-To: <20220425103446.496763-2-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2699a931-8e11-45c2-bf74-08da48efe04e x-ms-traffictypediagnostic: PH0PR84MB1788:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dG+0QIb2y5vWGKZ9haF2SUpforOmnNFbwCSYGdomWU8oQreZbRtIDcmoXhibIDGV5y1Lar8K/mfGKOlZxrbzB0fxzEig+zwbwo7JCXO2z1B3v7+V8yQGnleECC80cNlGMnk6SZJlo43xbv/rJCwboaL8wrow2LDieRCVNmKa3oHx2Jszy/R1lPYupnW1oo33BzMbua9DJYPpnKvMoXCaM7SboCvThCqWpBls2tYuYzYL7QEHu1T7VahmZnvqpilrwQeV1/yboiV5qLbi+kgm8Ez0HPp5tjo/N8UberN57BJQcFLU5LYFF9WXWTr2X4auiHjHkcVyqK0cjwImm9iORvAtK3DIubctbjoEOL6qWPiP2Us4YXf7SYlJuGL2OmsR6pvNNGCnrUrkioCUl/bNM/7mKgUKsws6Dv8Y4HBukxCrLZEY9llBSslpJC0Uo7N+ZrrJWdGjVfWWH7+o9cFED7qEiebn6MAeRUz3rD6DabVBPfVRd8I2VlkrwwMjqRlDwVFJkumZSiKsqGlwsFVMNdKDdPRGPX00r0+pkOoJxGKvUCkAxPllCbqeknu64BRnlfi06N2HydLlGNbEVGjEeXCIWfSqNMlzDdY3AMqK5U5v5HZJsFArMNZ+deM/FpJ9y6B5aYJIU6vxPdyOu84x74cCTdDZy3ZX7F3QaTrS2u7lwf+aw9E9siFo9bqtdoHwpK1HHFrIT7huE/bg9JbIXg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(366004)(33656002)(316002)(7416002)(54906003)(8676002)(55016003)(110136005)(76116006)(66476007)(5660300002)(66446008)(508600001)(66946007)(64756008)(66556008)(8936002)(4326008)(2906002)(52536014)(6506007)(7696005)(53546011)(9686003)(26005)(82960400001)(83380400001)(38100700002)(86362001)(186003)(71200400001)(122000001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1xpcJ4Y/Pni0UHG8xiA47c44/zYJlyj6i8ry36SBQCPjD7PZdxKFU0CQYBga?= =?us-ascii?Q?0IbKmmDF4Pk4cjyTKPyLN50dIRt2p+DR5uvAl1t983CN+CJr2IyUQYQydjn/?= =?us-ascii?Q?1WZJuy+QgnpKqmUrVg1iglGFuSAv7DESy3qnMKDIZyRcH2nOFzfhud4JDf8O?= =?us-ascii?Q?nyf9QIFM+MqTjz5oD57VXIZ7XlxEbNoojAb4PpbxbnMFtD9ta60KW9v7LSV3?= =?us-ascii?Q?+HizPdbvhV81iv1+YhqPUw/ZU6WsxghdiDOF9qFdnqh5qzV1uSCECqGMlAEC?= =?us-ascii?Q?7iRvRP08No64yVaXzQX0ZPGLqZIv98THtgtSIi6pshymStBAyqXJdH6q++tZ?= =?us-ascii?Q?lYkimCH2Z4ZyfF9yqsLQhXSY3tJdTm0KiHHF6wlZU7mb2iXvTqWQz72Rz1RW?= =?us-ascii?Q?BcxLxVMVRtWYaLmBATwtlI6UlwHgRMbiq22aHNLsR22fjicz0JJ5MC3nt53N?= =?us-ascii?Q?rd53ui3qu3b6iZLq8XX/fZOwTBe83LEm4rI8SKi7wvVJv5IQY6ZFkGBdHn0f?= =?us-ascii?Q?s4h+dcSRZd5Ji5VdQz9YzVuKYU8B1glOoa1uNf+HTuw1lDJbDTKKCgWIDNOr?= =?us-ascii?Q?SAXv4ujMGm4UoMciTTmEXGuvOlEiCiBIWuZEFWXREdc6USDTqFrShl4plgwd?= =?us-ascii?Q?9FBNE2JYhum73YwycqDHosM2jtERPgfSQsbtI7XmrV/wSO5XOt3hoRL6k/1d?= =?us-ascii?Q?BYcTzdboNu6PoON0sDC1JC+cCi1ADS5ETrJLrxPAePtDDT5rUFeTZS04oiO+?= =?us-ascii?Q?PYOAnCbmeEjjGrk1YWgyPezYhSAR09GZPzLTbMtNU5QssYiZNQVehXIwcba2?= =?us-ascii?Q?KNNSPH3STb+KUPsW3LTwCsnRGmzJJORzuYB753DHgJYeDC/aVXviSDUNdxTd?= =?us-ascii?Q?MuzICHJwRZMFNGxMvsO3wTIEwL1/C33DaYhZUrHZz5koS5RlwHfHq04Kua3H?= =?us-ascii?Q?xx0CxtF03+5/NHZ2VtNY4hS+gJ3rpGUYSCggXeD+GcdRSQE8ndEXrjl1n5dN?= =?us-ascii?Q?963uo5SUk7/tsyiwPiTQuaRoXkDoAccejVjyJLcLNwa/Vzd/ZVlzQysc5yni?= =?us-ascii?Q?J0vZzy2dgMIBZf4pnrJwiyaAQqzP0jV+V4Ds71wTxCetu0HRjGvw3A0X+5BV?= =?us-ascii?Q?bq39+xZtgF8bXs9pJ9sR0fKeieS/7l6KZzIx3dAPVzfCItjmc55WkpvcoJPn?= =?us-ascii?Q?uvRdW+gNpRnsPhaiemcZsz93cQAeWzgiIYFvqjQvckJPfNQwRgZUzQDa7RcS?= =?us-ascii?Q?ZGyXeWgIamrM3OBj3Uf+pLwBntFu8JvhFwtDZXDwDkutt0EYZI0h63PZHYD/?= =?us-ascii?Q?iLaMIWIoq+k9y+UGMA5+OJStwTi2h5vkt5iq1ci9XbZAkffxKEo89LDpY4R7?= =?us-ascii?Q?KDOZ9TMhV8RXD4sMrfJyqMEQwQx/Gsir9fSuJO1toNhoxDJhyV9zAsrXDSPc?= =?us-ascii?Q?lC2fRGrbMZjLm5gdZECjLgGDTwsEZSnA8N3cIIm1lTcDPn9AqJ2amwvM2Q7K?= =?us-ascii?Q?aOnyVNvGY2wLvrHT0cDBH4JAalXxhKqXMeLkK9qAGqob2p+LkzKqiwAuevUv?= =?us-ascii?Q?k8naCikFrR1QJablL8UzTZ0ZVmj+DGwpb1iMBhEFe0MpkJOnY/ZL2GuKsQ05?= =?us-ascii?Q?ykx5yYRXO3zOf0n16J1id5KmW3q5+N36aeBHhwMhmXzP7VrU8YOohqM3doOH?= =?us-ascii?Q?hsW8NycKmvxJLaIyJ6jIfCCgJhDF/G5nr3JHcICftSALFMsUgR5Rjl8ffDM/?= =?us-ascii?Q?ZeE0LoHrOQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR84MB1647.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2699a931-8e11-45c2-bf74-08da48efe04e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 01:40:32.3518 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TlcKYSl/5NPooHjq+laDJsSXbrvIlUI6eSPwwnfdM1tf7S9KQPMsKfrdt45gHmR7qgGyg9k73jeOOlLPiQQLkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB1788 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: RFs7_OUxLJCSTP-BXuJp-CA3y3zMBTE_ X-Proofpoint-ORIG-GUID: RFs7_OUxLJCSTP-BXuJp-CA3y3zMBTE_ X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-07_11,2022-06-07_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 spamscore=0 clxscore=1011 impostorscore=0 mlxlogscore=909 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206080005 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Abner Chang > -----Original Message----- > From: Gerd Hoffmann > Sent: Monday, April 25, 2022 6:35 PM > To: devel@edk2.groups.io > Cc: Jiewen Yao ; Oliver Steffen > ; Leif Lindholm ; Pawel > Polawski ; Hao A Wu ; Chang, > Abner (HPS SW/FW Technologist) ; Liming Gao > ; Ray Ni ; Jordan Justen > ; Jian J Wang ; Ard > Biesheuvel ; Gerd Hoffmann > ; Ard Biesheuvel > Subject: [PATCH v6 1/6] MdeModulePkg/PciHostBridge: io range is not > mandatory >=20 > io range is not mandatory according to pcie spec, > so allow bridge configurations without io address > space assigned. >=20 > Signed-off-by: Gerd Hoffmann > Reviewed-by: Ard Biesheuvel > --- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > index b20bcd310ad5..712662707931 100644 > --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > @@ -1085,6 +1085,9 @@ NotifyPhase ( > RootBridge->ResAllocNode[Index].Base =3D BaseAddress; > RootBridge->ResAllocNode[Index].Status =3D ResAllocated; > DEBUG ((DEBUG_INFO, "Success\n")); > + } else if ((Index =3D=3D TypeIo) && (RootBridge->Io.Base =3D= =3D MAX_UINT64)) { > + /* optional on PCIe */ > + DEBUG ((DEBUG_INFO, "PCI Root Bridge does not provide IO > Resources.\n")); > } else { > ReturnStatus =3D EFI_OUT_OF_RESOURCES; > DEBUG ((DEBUG_ERROR, "Out Of Resource!\n")); > -- > 2.35.1