From: "Min Xu" <min.m.xu@intel.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor
Date: Mon, 2 Jan 2023 23:18:27 +0000 [thread overview]
Message-ID: <PH0SPR01MB0012367AC237EEEA8D08F594C5F79@PH0SPR01MB0012.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BY5PR11MB4401D611C92F76DFEA7DC913EAF79@BY5PR11MB4401.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 6095 bytes --]
Hi, Sebastien
The issue is fixed. Please see https://edk2.groups.io/g/devel/message/97720
From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
Sent: Monday, January 2, 2023 6:07 PM
To: Xu, Min M <min.m.xu@intel.com>; Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; kraxel@redhat.com
Subject: Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor
Hi folks,
Sorry I was on vacation.
Min, did you figure out how to fix that issue? Please let me know if/how I can help with that.
Thanks,
Sebastien
________________________________
From: Xu, Min M <min.m.xu@intel.com<mailto:min.m.xu@intel.com>>
Sent: Thursday, December 22, 2022 2:08 PM
To: Ard Biesheuvel <ardb@kernel.org<mailto:ardb@kernel.org>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Boeuf, Sebastien <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; kraxel@redhat.com<mailto:kraxel@redhat.com> <kraxel@redhat.com<mailto:kraxel@redhat.com>>
Subject: RE: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor
I am looking at the issue and will provide the fix soon.
BTW, the previous patch-set passed the EDK2 CI. It seems there is something missed in the EDK2 CI.
Thanks
Min
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org<mailto:ardb@kernel.org>>
> Sent: Thursday, December 22, 2022 7:05 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Boeuf, Sebastien <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Xu, Min M <min.m.xu@intel.com<mailto:min.m.xu@intel.com>>;
> kraxel@redhat.com<mailto:kraxel@redhat.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with
> Cloud Hypervisor
>
> This series has broken all platforms that incorporate
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf but do not provide a
> resolution for CcProbeLib
>
> Please provide a fix
>
> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4748/console
>
>
>
> On Fri, 16 Dec 2022 at 09:46, Boeuf, Sebastien <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
> wrote:
> >
> > Thank you Jiewen :)
> > ________________________________
> > From: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> > Sent: Friday, December 16, 2022 4:03:00 AM
> > To: Boeuf, Sebastien <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>
> > Cc: Xu, Min M <min.m.xu@intel.com<mailto:min.m.xu@intel.com>>; kraxel@redhat.com<mailto:kraxel@redhat.com>
> > <kraxel@redhat.com<mailto:kraxel@redhat.com>>
> > Subject: RE: [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud
> > Hypervisor
> >
> > Merged: https://github.com/tianocore/edk2/pull/3778
> >
> > > -----Original Message-----
> > > From: Boeuf, Sebastien <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
> > > Sent: Thursday, December 15, 2022 11:10 PM
> > > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > > Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Xu, Min M
> > > <min.m.xu@intel.com<mailto:min.m.xu@intel.com>>; kraxel@redhat.com<mailto:kraxel@redhat.com>; Boeuf, Sebastien
> > > <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
> > > Subject: [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud
> > > Hypervisor
> > >
> > > From: Sebastien Boeuf <sebastien.boeuf@intel.com<mailto:sebastien.boeuf@intel.com>>
> > >
> > > The IntelTdxX64 OVMF target wasn't working with Cloud Hypervisor on
> > > TDX platform. This was due to the way the OVMF code expects Cloud
> > > Hypervisor to rely on PVH to retrieve information like memory below
> > > 4GiB as well as the ACPI tables.
> > >
> > > This is why this series takes care of identifying when running on
> > > TDX in order to handle things differently. For the memory below
> > > 4GiB, it falls back onto the CMOS to retrieve the correct
> > > information, and for the ACPI tables, it relies on the HOB to obtain
> > > every table individually before to expose them to the guest OS.
> > >
> > > With these two use cases properly handled by this series, it is now
> > > possible to use the IntelTdxX64 target to build an OVMF binary that
> > > works both for QEMU and Cloud Hypervisor on a TDX platform.
> > >
> > > Sebastien Boeuf (3):
> > > OvmfPkg/PlatformInitLib: Differentiate TDX case for Cloud Hypervisor
> > > OvmfPkg/PlatformInitLib: Transfer GUID Extension HOB
> > > OvmfPkg/AcpiPlatformDxe: Differentiate TDX case for Cloud
> > > Hypervisor
> > >
> > > ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> > > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 8 +-
> > > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 6 ++
> > > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 3 +
> > > OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 87
> +++++++++++++++++++++
> > > OvmfPkg/Library/PlatformInitLib/IntelTdx.c | 5 ++
> > > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 5 +-
> > > OvmfPkg/OvmfPkg.dec | 1 +
> > > 8 files changed, 114 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 2.34.1
> >
> > ---------------------------------------------------------------------
> > Intel Corporation SAS (French simplified joint stock company)
> > Registered headquarters: "Les Montalets"- 2, rue de Paris,
> > 92196 Meudon Cedex, France
> > Registration Number: 302 456 199 R.C.S. NANTERRE
> > Capital: 5 208 026.16 Euros
> >
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). Any review or distribution
> > by others is strictly prohibited. If you are not the intended
> > recipient, please contact the sender and delete all copies.
> >
> >
[-- Attachment #2: Type: text/html, Size: 11833 bytes --]
next prev parent reply other threads:[~2023-01-02 23:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 15:10 [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor Boeuf, Sebastien
2022-12-15 15:10 ` [PATCH v2 1/3] OvmfPkg/PlatformInitLib: Differentiate TDX case for " Boeuf, Sebastien
2022-12-15 15:10 ` [PATCH v2 2/3] OvmfPkg/PlatformInitLib: Transfer GUID Extension HOB Boeuf, Sebastien
2022-12-15 15:10 ` [PATCH v2 3/3] OvmfPkg/AcpiPlatformDxe: Differentiate TDX case for Cloud Hypervisor Boeuf, Sebastien
2022-12-16 3:03 ` [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with " Yao, Jiewen
2022-12-16 8:46 ` Boeuf, Sebastien
2022-12-22 11:05 ` [edk2-devel] " Ard Biesheuvel
2022-12-22 13:08 ` Min Xu
2023-01-02 10:06 ` Boeuf, Sebastien
2023-01-02 23:18 ` Min Xu [this message]
2023-01-03 8:30 ` Boeuf, Sebastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0SPR01MB0012367AC237EEEA8D08F594C5F79@PH0SPR01MB0012.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox