public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Min Xu" <min.m.xu@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Anthony Perard <anthony.perard@citrix.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Brijesh Singh <brijesh.singh@amd.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Julien Grall <julien@xen.org>, Laszlo Ersek <lersek@redhat.com>,
	Peter Grehan <grehan@freebsd.org>,
	Rebecca Cran <rebecca@bsdio.com>,
	"Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB
Date: Fri, 6 Jan 2023 00:49:21 +0000	[thread overview]
Message-ID: <PH0SPR01MB0012DAA69B333F9FA4711FC2C5FB9@PH0SPR01MB0012.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230105113158.lq5r5zxuyrgapqjy@sirius.home.kraxel.org>

On January 5, 2023 7:32 PM, Gerd Hoffmann wrote:
> 
> On Thu, Jan 05, 2023 at 03:21:05PM +0800, Min Xu wrote:
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4236
> >
> > Similarly to the "cadence" mentioned in commit d272449 ("OvmfPkg:
> > raise DXEFV size to 11 MB", 2018-05-29), it's been ~1.75 years since
> > commit 5e75c4d ("OvmfPkg: raise DXEFV size to 12 MB", 2020-03-11), and
> > we've outgrown DXEFV again (with NOOPT builds).  Increase the DXEFV
> > size of IntelTdxX64 to 13MB now.
> 
> Not sure this makes sense given that you want split DXEFV into two smaller
> volumes for IntelTdx (patch series sent in december IIRC).
> 
Thanks Gerd for the comments.
I think raising DXEFV size and split DXEFV into 2 FVs are for different purpose and they're not conflicted.

The purpose of raising DXEFV size is to enlarge the FV so that more drivers can be hosted.

The purpose of splitting DXEFV are:
1) Reduce the attack surface in CC guest.
2) Improve boot perf in CC guest.

I think IntelTdxX64 needs both 2 changes.

Thanks
Min

  parent reply	other threads:[~2023-01-06  0:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05  7:21 [PATCH V1 1/1] OvmfPkg/IntelTdxX64: Raise DXEFV size to 13MB Min Xu
2023-01-05 11:31 ` Gerd Hoffmann
2023-01-05 16:28   ` Laszlo Ersek
2023-01-06  6:40     ` Gerd Hoffmann
2023-01-06  0:49   ` Min Xu [this message]
2023-01-06  6:48     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0SPR01MB0012DAA69B333F9FA4711FC2C5FB9@PH0SPR01MB0012.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox