Re: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length region

[minhn@amperecomputing.com]

Hi Wang,

 Thanks for this point, you're right. It's a redundant change and I will update in v2 patches, but the second change is necessary. How do you think about that?

Thanks,
Minh Nguyen

-----Original Message-----
From: Nickle Wang <nicklew@nvidia.com> 
Sent: Friday, April 14, 2023 4:04 PM
To: Minh Nguyen OS <minhnguyen@os.amperecomputing.com>; devel@edk2.groups.io
Cc: Open Source Submission <patches@amperecomputing.com>; abner.chang@amd.com; igork@ami.com; Nhi Pham OS <nhi@os.amperecomputing.com>; Tinh Nguyen OS <tinhnguyen@os.amperecomputing.com>; Vu Nguyen OS <vunguyen@os.amperecomputing.com>
Subject: RE: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length region

[EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.]


Hi Minh,

> Prevent assertion of allocate zero length region

May I know where does zero length allocation happen? According to my understanding, setting the "SubnetAddrInfoIPv6Number" to zero here and it will be handled by below condition check:

https://github.com/tianocore/edk2/blob/55b67b6950e648338adfe8ec54aeb26ed89d2c97/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c#L1005

Then the code leaves function with EFI_NOT_FOUND error.

Thanks,
Nickle

> -----Original Message-----
> From: Minh Nguyen <minhnguyen@os.amperecomputing.com>
> Sent: Friday, April 14, 2023 4:19 PM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; abner.chang@amd.com; Nickle Wang 
> <nicklew@nvidia.com>; igork@ami.com; nhi@os.amperecomputing.com; 
> tinhnguyen@os.amperecomputing.com; Vu Nguyen 
> <vunguyen@os.amperecomputing.com>; Minh Nguyen 
> <minhnguyen@os.amperecomputing.com>
> Subject: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero 
> length region
>
> External email: Use caution opening links or attachments
>
>
> From: Vu Nguyen <vunguyen@os.amperecomputing.com>
>
> This change also fix miscellaneous errors on condition checking and 
> debug argument missing.
>
> Signed-off-by: Minh Nguyen <minhnguyen@os.amperecomputing.com>
> ---
>  RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> index 583c6f78e19c..29e7b0624ebf 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> @@ -5,6 +5,7 @@
>    (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
>    Copyright (c) 2022, AMD Incorporated. All rights reserved.
>    Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -272,7 +273,7 @@ Tcp6GetSubnetInfo (
>    if (IpModedata.AddressCount == 0) {
>      DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __func__));
>      Instance->SubnetAddrInfoIPv6Number = 0;
> -    return EFI_SUCCESS;
> +    return EFI_NOT_FOUND;
>    }
>
>    if (Instance->SubnetAddrInfoIPv6 != NULL) { @@ -926,7 +927,7 @@ 
> AddAndSignalNewRedfishService (
>      }
>
>      Status = gBS->SignalEvent (Instance->DiscoverToken->Event);
> -    if (!EFI_ERROR (Status)) {
> +    if (EFI_ERROR (Status)) {
>        DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__));
>      }
>    }
> --
> 2.39.0