From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by mx.groups.io with SMTP id smtpd.web11.801.1687986369016564793 for ; Wed, 28 Jun 2023 14:06:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@ventanamicro.com header.s=google header.b=GPcL22or; spf=pass (domain: ventanamicro.com, ip: 209.85.166.171, mailfrom: tphan@ventanamicro.com) Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-34271602c32so1192505ab.0 for ; Wed, 28 Jun 2023 14:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1687986368; x=1690578368; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=I5bxSnWKPyVtHvQfcjJk/a6wfdyTiLiBqDoYHWF7+v0=; b=GPcL22orTydCMw8WMB10Hf+UQ74uq+bpbumYfhcl9S7vo9HQCPQ/TThJX2ApnunYt0 QZcbTh7Hngf3gfddwmkLeyAs3yIMFGEiUCC8mBKhx6KpPo8paHUbGKOpqq5D06+qVa31 tdaJ7qbf0qRtMjztTfkKlWPJp6T5DZIehkRx7wxdyD7jFbP84ZWUx73tzkhAfJVV63xt EIEVRaAj2cn8CRTApNn94JQz10ERAi7fioDN88TgveNlOlT5XNJxGQ44QeSo0+wTpzRQ v1Hx5Peu/Woj1XmgZQ1vk4I+S0ymarOOMa8clgAeQAfljNZ73i+TCWx0J+8mD4zfF5Mr 13Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687986368; x=1690578368; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I5bxSnWKPyVtHvQfcjJk/a6wfdyTiLiBqDoYHWF7+v0=; b=U3Dmptoi3NR0ViBmGQF2BWEFC67t59sR1wB2T5FceaNwM/S/DW+7TBCYm6nfH7ap0f hl6eHpVeIOd6sOz5w3jy6AAWYGsLLcwoq8Jn7x7RmNKt/Lx64By/1Nq9OvnI4wc+sibA K8hczQesnZpQb3eaClnOs+4MhptOhPYyUF4nOaUz791eA8mk7q3Nf1JWpGA1ShGKssWc nluvsyorUCyZ319/9Tn9PgUndSgpy0eCfod3HgOw3ojX2Ps2sXI2EHza5TPLgwoHnRhm db/lkWrbmDHoS+ErdXh7oAjCGn9XAxMObjiUZW04ZLtnI9y325TyTkImSlEo0Dg9JpHm Be7Q== X-Gm-Message-State: AC+VfDy7RnB64NmW7LekURR9Mz+talZ8806GUYf7MJxqHhmkJwngPksP kTCbYFov4CdD834PJZHNwaPW3w== X-Google-Smtp-Source: ACHHUZ63zmKOaCbg76MrNFyz1VlahpjIEB8R7juE4qt1Glm2bwdwEWtTFyanwztvy02fjWRaY1/cmg== X-Received: by 2002:a92:d8d0:0:b0:345:c8d4:1147 with SMTP id l16-20020a92d8d0000000b00345c8d41147mr2642701ilo.16.1687986368189; Wed, 28 Jun 2023 14:06:08 -0700 (PDT) Return-Path: Received: from PH7PR10MB6335.namprd10.prod.outlook.com ([2603:1036:30c:842::5]) by smtp.gmail.com with ESMTPSA id t14-20020a92c0ce000000b00345950d7e94sm3031418ilf.20.2023.06.28.14.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 14:06:07 -0700 (PDT) From: "Tuan Phan" To: Sunil V L CC: "devel@edk2.groups.io" , "andrei.warkentin@intel.com" Subject: Re: [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not working correctly Thread-Topic: [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not working correctly Thread-Index: AW4tNzUyj9Ezi7JubLIY9495OMcBCzk1d3FH1S/t+R8= X-MS-Exchange-MessageSentRepresentingType: 1 Date: Wed, 28 Jun 2023 21:06:06 +0000 Message-ID: References: <20230628011557.4713-1-tphan@ventanamicro.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 MIME-Version: 1.0 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR10MB633536CF3C9596EA63D32C16A724APH7PR10MB6335namp_" --_000_PH7PR10MB633536CF3C9596EA63D32C16A724APH7PR10MB6335namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Sunil, Updated pull request: https://github.com/tianocore/edk2/pull/4585 Please help merge it if no objection. Thanks, From: Sunil V L Date: Wednesday, June 28, 2023 at 7:43 AM To: Tuan Phan Cc: devel@edk2.groups.io , andrei.warkentin@intel.com= Subject: Re: [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not wo= rking correctly On Tue, Jun 27, 2023 at 06:15:57PM -0700, Tuan Phan wrote: > The timer notify function should be called with timer period, not the > value read from timer register. > > Signed-off-by: Tuan Phan > --- LGTM. Reviewed-by: Sunil V L Thanks! Sunil --_000_PH7PR10MB633536CF3C9596EA63D32C16A724APH7PR10MB6335namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks Sunil,<= /o:p>

Updated pull reques= t: https://github.com/tianocore/edk2/pull/4585

Please help merge i= t if no objection.

 

Thanks,<= /span>

 

From: Sunil V L <sunil= vl@ventanamicro.com>
Date: Wednesday, June 28, 2023 at 7:43 AM
To: Tuan Phan <tphan@ventanamicro.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>, andrei.warken= tin@intel.com <andrei.warkentin@intel.com>
Subject: Re: [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event= not working correctly

On Tue, Jun 27, 202= 3 at 06:15:57PM -0700, Tuan Phan wrote:
> The timer notify function should be called with timer period, not the<= br> > value read from timer register.
>
> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> ---

LGTM.

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks!
Sunil

--_000_PH7PR10MB633536CF3C9596EA63D32C16A724APH7PR10MB6335namp_--