From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.40506.1673478878302016028 for ; Wed, 11 Jan 2023 15:14:38 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RQBp1N9i; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673478878; x=1705014878; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VIdkhKPu3OkgxwkqAxcbiT7EI3f6oxNUuejmb2sWWHQ=; b=RQBp1N9iWzIgEjtuLMFnN8LD8yI0Fn92KNxLMQ2wxB6m6G8eo8YPe8HW JFZEatLW+4Ix1RA8K/dJjp5e0ZoZnWWjzO0TYmMwj5AUZyCKdBoMMLaE4 IVxqRrtYw8SJq3RjOzBF5QOJk/DL98zhYMbEJHTb084Rs8vHdT7fCnyNQ dMQSf6JuT3dDM/XoXCAVrkc1m/MMRg0A/hyoKpcvNe4X6PlY2Vl6tORUm 22zBZ79Mfia+OagR+RVcjL5SoCt9cC0sVIzHJ6UT/Cxv3FTmCfOcBENEg gBHJkdqp6FN+wTXK5s/A7uxTwfoRKluYWhXNbds8x5lKhw/xSwrpm28xG A==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="350788210" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="350788210" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 15:14:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="799997550" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="799997550" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2023 15:14:37 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 15:14:37 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 15:14:37 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 15:14:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DHXTQWyxXoT2ff+UK9lYUoZhYOSbJpfijC5kyQSuGh5fhofoL33Uwp4v+hzlBi3+Kf65waOqFox+/GhJT0BKJ5k7hIvmoUyyY5EJ8W08P7VQtdeS0Iba0XsIX43O4Crsj4YViXuo7GvYVicp7ssP6Dgssj51izODC0eO1/l5vwjzT87VgRoY4B1FLjKenEfI/KdfFUlVJITMFn70sMAgWIT4NvHbGQaACNi2eqEJvUU+dq5AJMH7dZilyjPsPqm64vJXcFvEqJyae6qQy7MUrZn27nMxW6tb1Ma1XFqYNZiwT9sCwMH//evaHZBxj2FEyZ5SURt54pvuuaL+K9fn+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n4WYIG6M/zt2J5EkodonVRHYkbWLULG6JqQ+oO/sHds=; b=Qjk9VMuxnfJa5eNJ9IXC3RKCT+yiKM3FXakrpiaOdoNkvIylvlJKg+zjuzMGrjtDJ6qlQoyzuUhUnNJa/G9iPQGtnx132aQXRUjXoc/0Gxo1r7pP20hoIK8Ai4HeclZVxQBxGivYeemmkl5I0br3rzLfCLkHy0e3WmbkVgZbgjCLjzwUlC9oVSghWDcfpcxnOTfyRqzz1AIAQW/ISJy2iosJ32cBuktRrHBws2UdnaAG2ueRF8aNzPp8D3spPbqScVdD8SGDON+6tsn4QAtUYAJHqO8FLdJtLyGWUz5GOQcKU/F28ED0tJabD7z37qYqJBJwn44BjK4o2jdgK1PViQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5795.namprd11.prod.outlook.com (2603:10b6:510:132::6) by DM4PR11MB6287.namprd11.prod.outlook.com (2603:10b6:8:a6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 23:14:34 +0000 Received: from PH7PR11MB5795.namprd11.prod.outlook.com ([fe80::9310:50b3:204c:5b17]) by PH7PR11MB5795.namprd11.prod.outlook.com ([fe80::9310:50b3:204c:5b17%4]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 23:14:34 +0000 From: "Isaac Oram" To: "Chang, Abner" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Index: AQHZIR8LWofAPDAH8EaQaIRDPPizoK6QC/DAgAAJh+CAAJR7sIAJN/zA Date: Wed, 11 Jan 2023 23:14:34 +0000 Message-ID: References: <20230105160100.772-1-abner.chang@amd.com> <17377895696F6651.2132@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-06T02:27:23Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c30d0ee5-a699-4b3c-9099-cd112f954d1f; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5795:EE_|DM4PR11MB6287:EE_ x-ms-office365-filtering-correlation-id: dff82e8d-b269-4456-0e0d-08daf4299a03 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: omFGdPvUoXVkWhTNSv06Q1OdIh6cWdy/NcVSX8TadIbJZ7sKMWfXdpGX3h9L+oBBxIEauagPWY8n60DOnRUNzppAux16FSGLxL0/m3DZHbsLQ5T8O5408B30HZ+hPfjPIUQIhJBrxQoJGovv5ndT09ydTQc2cLfQU1WPyRtELowZyjLRIgA84hgwgI8GYdc5DT928XaWLUOkaWb9mz38b515H3EYC3TwoUQCfDIoy/U4oAQ1UK+6Kla4Ty5kpMnXfyIEtRtbP0o1CKrcuzTdnerQQ4y+T2Wzc2e5/WVi3Q61Pr88aF6e5gFEmp+O+CZnyJJ7E3kocyn72Fr8EMeKiFXqJ/gUz4nIVcIatnhfKH4i06KAhq02mU/ORsD4PAzC1/lrwor7c2nGQvjH8F9r61DGbSDwMmUq30onTMqrOIIBL0F8TyfE5Nbsb7nOMgAR8SwrB38sjm61hxvLoveh1zhnAiJxu06SvZRg9u+HU1TDaqK5RGxuGl4volEySTFT/5RM5wy5lKeM36xsW/SaPSdc0Sjd9SEVDc4z/7p0IhlmP0uYcIaz45HTyfYCm9JMdpwCVwP9VyCH+HciICj78LFIlH4Fda7GPW4MJREfzuX1pQNXwBT9BNDLuYkcIG5HqsLqOqrog0gKzDKYJZS5tA8npmVxbPkJR2NzfNs5V6MperllW4paD3x8JM3e/RmUXayg9jbarYQdT0VVhGEWqaDk0AAj7PP0LVxIXkdRSDs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5795.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(366004)(396003)(376002)(451199015)(66899015)(66556008)(52536014)(2906002)(5660300002)(8936002)(66946007)(66446008)(64756008)(8676002)(41300700001)(66476007)(71200400001)(76116006)(7696005)(316002)(4326008)(54906003)(53546011)(110136005)(478600001)(26005)(6506007)(186003)(45080400002)(966005)(9686003)(55016003)(33656002)(86362001)(82960400001)(83380400001)(38100700002)(122000001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S2vc0rL4Ahabgjfh+HEh/UBik6xPV5fDZ1D35o87qVLvR7XYSxdgGtGPrIHn?= =?us-ascii?Q?+LfKm3dTwwjMT/lw5CEe+O5DTga4RxR0Cyvg+9/lgo9LTQKciY2jXLcHFylF?= =?us-ascii?Q?06krMTf4VQvWTF1wWVX7bP9teb1WBm7Nh02zaDbRgRxJd/MCA+pS/i9nHEhS?= =?us-ascii?Q?KrV+H26cbMlMB1BcNLt4klatjVl8EkE6CxvsxRgbntgEAOCNSL+ovBiaHviI?= =?us-ascii?Q?XrgZYxCr3JnWEiK4uc3nh9BUUrF+ry1rVTwiSQeAnrw0tTEvP3tkagY7YTPu?= =?us-ascii?Q?ofIQMTo1kZIEcQ5167pZweZ2jpE1xUty3e2ecqY+vIaXktbwLer7rDU8Qz20?= =?us-ascii?Q?Y2ATAMYIRkYuQTOTeloisWQD8Rp2RVtpjGOVzIPkWJ3e354w/aDzl/2sksgy?= =?us-ascii?Q?y9k3HntodCliE9V3infyxOUapuVosvPNepTvxZ0+cNosAP0YXNb2cDWm2y7n?= =?us-ascii?Q?CyZO3xD8tyfCVmr4WrSSRCMlpxkbjhF92DwvBR3/RnO0xpa5dRgraoxWT+JL?= =?us-ascii?Q?2bCn9ylu3uRSekJRWo+Q1AyGOcsxR7cvsmb8Jw7qAtWQW0vX3GTvliKwjnsj?= =?us-ascii?Q?zzvWm0+YdkrfhcHKNv6OtdVQnXHnA0xDyYsnq9wm2MjyX0Q8CQbrYR0MFZKN?= =?us-ascii?Q?9g/91mt6aDH0+ZprlyXqVYfJ0+Dg9+NGCWvyfYRLA5Qcu5MGlY4XAE4CUso+?= =?us-ascii?Q?1nyQORMCEpQSojUUtygVSbgJDKqh+/cOSxGljv+N4GooWyMkUF9HoKpu9lrv?= =?us-ascii?Q?oj7PU1VUtuzf+WIS9dy3KD0Rde9i5lQRt05RAk20Cglao2dHTm81hDs8Z2Uc?= =?us-ascii?Q?vTS+tECnZOwPHpTud123oh5LC99ncqUSpE3iyGJ+SahlV7x866WcIMJ6ZogU?= =?us-ascii?Q?MYgeloEGKtzlAo5iTyUwuvKwxO85V3Dfu88AyifECcJaJBc8oBPBl/gUMdhI?= =?us-ascii?Q?HKiUzMDTPgaYYZQDmEGxGvtf0mnXSljrlORdqkDswfQk0NJBcX/wSKfGrr8B?= =?us-ascii?Q?f6W3r1Mk3uHbdDc4jaXfI2MUm0Cns0meFA0cl2M9q98PAdquA6Wy+BKYPnGe?= =?us-ascii?Q?ZThW8p6S536uGquu9Mevyhhc51pUHstT+QXgLiZIAZYm29ER0g24XdUt3XBm?= =?us-ascii?Q?Wulvj9AhhNi/HoAOlnnkkZm1uIqf7XOe+h2MNMZF5cZeYYFujXldE8Ol315o?= =?us-ascii?Q?bKPRq4SIErIP02J/NpBpfRBM3KA9oJ1/AXAXUCeac0CGtRqeEL2h9fZVHU2t?= =?us-ascii?Q?8H7GN5tjdsVEF8UCjUS/ultnY1dEzUZBjQHhv6E3Q9qHsClLmyR0ccu5zcDE?= =?us-ascii?Q?OnB0G4ExP5azioThpy9vGCyAfBg7333nE5THL+J934PKFwgLbAdGCJHXX3YV?= =?us-ascii?Q?y14c79d6yuxfM6kax+EyatAzximcIA0OegmKpNYrbuy9ffKpj/hSEB2+qUAm?= =?us-ascii?Q?wff8EmkjNMdorYZK/OYJmR2s0jz8F4+mE9ZDWxYVQHnfXUOjgIPtQjiM8v6A?= =?us-ascii?Q?7Gi3/zGZHBb5gdqe66zmWVoMCnGv/LM6G7hrX1YESbDMwLeGK0gy9gnWDDmn?= =?us-ascii?Q?tYZKLHnJ0oH5GixOnvEvCS8VikTNt84yrUNWF2e9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dff82e8d-b269-4456-0e0d-08daf4299a03 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 23:14:34.0449 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7/PxtnCaMxUrZIUUrlw1xvBuRDBCEwWtR3MxmeyrfnUtC3sM4SKB2lOgSKsRelx3qDbOBFmE0YdS/aaV869V0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6287 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I believe that this edk2-platforms series is dependent on the changes in ht= tps://edk2.groups.io/g/devel/message/98051 and they have not been merged ye= t. I had those changes under review in the branch I used for testing this patc= h series for edk2-platforms so my testing missed this. Regards, Isaac -----Original Message----- From: Chang, Abner =20 Sent: Thursday, January 5, 2023 6:27 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Kinney, Michael= D ; Gao, Liming ; Li= u, Zhiguang ; Nickle Wang ; Igo= r Kulchytskyy Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfi= sh [AMD Official Use Only - General] Hi Isaac, I am not quite understand, this patch set should be independent of edk2. Wh= at do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg is goo= d now?=20 Abner > -----Original Message----- > From: Oram, Isaac W > Sent: Friday, January 6, 2023 1:42 AM > To: devel@edk2.groups.io; Oram, Isaac W ;=20 > Chang, Abner > Cc: Desimone, Nathaniel L ; Kinney,=20 > Michael D ; Gao, Liming=20 > ; Liu, Zhiguang ;=20 > Nickle Wang ; Igor Kulchytskyy > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for=20 > Redfish >=20 > Caution: This message originated from an External Source. Use proper=20 > caution when opening attachments, clicking links, or responding. >=20 >=20 > Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. > f5da8af6befbfc655fd3e4cb899eda158dd9ede5 >=20 > My apologies, I was sloppy and didn't ensure the edk2 changes were=20 > pushed first, so IpmiFeaturePkg build is currently broken pending=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=3D05%7C01%7Ca > bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896 > 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DtBhHMIQhVL8AI3bof > YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=3D0 being pushed. >=20 > Regards, > Isaac >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Isaac=20 > Oram > Sent: Thursday, January 5, 2023 9:05 AM > To: abner.chang@amd.com; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Kinney,=20 > Michael D ; Gao, Liming=20 > ; Liu, Zhiguang ;=20 > Nickle Wang ; Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for=20 > Redfish >=20 > Series Reviewed-by: Isaac Oram >=20 > -----Original Message----- > From: abner.chang@amd.com > Sent: Thursday, January 5, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L=20 > ; Kinney, Michael D=20 > ; Gao, Liming ;=20 > Liu, Zhiguang ; Nickle Wang=20 > ; Igor Kulchytskyy > Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish >=20 > From: Abner Chang >=20 > In V2: Addressed the comments from Isaac. >=20 > BZ# 4214 > This patch adds IPMI functions for building up SMBIOS 42 record for=20 > the USB NIC host interface exposed by BMC. > The corresponding updates on edk2 is in the separate pacth. >=20 > This is the part I of upstream, the follow up patche sets are: > - RedfishPlatformCredentialLib contributed by NVidia. > - Relocate IpmiCommandLib.h from edk2-platforms > to edk2/MdePkg. A NULL instance of IpmiCommandLib is created > and located under MdePkg. With above, RedfishPkg doesn't have the > dependence with edk2-platforms. The implementation of IpmiCommandLib > stays in edk2-platforms without relocation, which can be pulled in > to platform DSC as needed. > - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging > temporarily because some requirements are necessray to be spec out > in the Redfish section in UEFI spec. >=20 > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Nickle Wang > Cc: Igor Kulchytskyy >=20 > Abner Chang (3): > Features/IpmiFeaturePkg: Add IPMI functions > IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions > IpmiFeaturePkg: Add reference of IpmiBaseLib >=20 > .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++ > .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++ > .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 > +++++++++++++++++++ > .../IpmiCommandLibNetFnTransport.c | 43 +++++++++ > 4 files changed, 198 insertions(+) >=20 > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20