From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.40334.1673478672696885131 for ; Wed, 11 Jan 2023 15:11:12 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KHJ0L39p; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673478672; x=1705014672; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=mOMmBM5GgWaGga7n1M3Y9hwMhtqFshHxeexMuskH9pw=; b=KHJ0L39p5g57bFxOQR4b0IRlYBTC7RCibEzGTQp3FcoiwLIpdcuv+GVK gqlTfgPSeaAdhJ4BqIkzABtzsBFt2MWHcPC578j4ZqiR7A0TC8Ol+GXbx /1WEVCGU68wblLzTEKgMff6M3ApouLM2mWsaqwOi7Arpfn5EJoDkxKa/F iHO43wPoIpmxmA1uuAKLIPBzudiIkueoSWTMMMV17rIL7dzGiL4fQYTM+ /56L2PdlmkvP1CzlLoCFo0uTixDAgco4f/bNl7YtVLD5t6c/rcaKg4ixb jT4CPRnIqhUr0dD6bZV6G3XkudUyVjZrp1Z4y7ATAhJ+zka8w8i4qCei7 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="350787270" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="350787270" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 15:11:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="799996970" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="799996970" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2023 15:11:12 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 15:11:11 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 15:11:11 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 15:11:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dmz2MD2+Kgc88mcFpQ4YS8RyS3V6Z8/EwX3Vg8MvOfQHtOzyNMELILmwy4aPSNyRYW5MV7EKoyzx/KuU2RDhGzyksV+JSPyzFDbDKaN2Xkqv6KbEt0juGEhKtEgHXvoT9yds5EF9A3zD8JKtVCF8x8tqFrtgIBbVi6+5gUYshptKsgg9U6lt9H/1NCPbn82OnD64J3w70TcMT8SFpOfBtBNshoOPZt9uxCaz+tiZNcID2qoUHva0Wgp6paRtieQcvxm8r4v3rZdCaAlS7/NnqkAR62R9PK7tkf8tvhdjaYVW3bwAoFcBEBwT2ensdp2UzLzxSsSrVA+8P5YX0rj2lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RMkrsDDPqgtJ1//CNgpbMLwSg/NWszHVuOeny6ohnQ4=; b=F53y5ll03/Z8xBOfwrbjoWKKv9IWZUw2VJlmataSjIN1j0ZDqmK3rw5A5UCG/T4AdNanzrnc1845RNo1OZnQiPVzSOH0c0teVO6FoJdcmgJoqDwUFBuhM6I45hoGhfzFYwiwMLYmYpujTi9OlhvePbI5LdWvpLLgGOYh8EwVzTGiEMunGUej94Iutyd2QvK40783H/kZGB+D3jkvGbL1wU9cayEaG0ltXUajxZXx8G5dHM5+5eLY64Wrj+l/NS8TGKojoVQ1sgrO5LxHp2Ra/uFKaAkcci5lfpS/QsX3GYMO6dxucUghm+GMs81HE8bGl5Q55to2Q9S3RrPY6KJ+LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5795.namprd11.prod.outlook.com (2603:10b6:510:132::6) by PH8PR11MB7118.namprd11.prod.outlook.com (2603:10b6:510:216::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 23:11:07 +0000 Received: from PH7PR11MB5795.namprd11.prod.outlook.com ([fe80::9310:50b3:204c:5b17]) by PH7PR11MB5795.namprd11.prod.outlook.com ([fe80::9310:50b3:204c:5b17%4]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 23:11:07 +0000 From: "Isaac Oram" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "Nickle Wang" , Igor Kulchytskyy , "Desimone, Nathaniel L" Subject: Re: [PATCH V4 0/3] IPMI changes for Redfish Thread-Topic: [PATCH V4 0/3] IPMI changes for Redfish Thread-Index: AQHZIXrB4VYSKxRdVUqRyGmWpiz3y66Z4ONw Date: Wed, 11 Jan 2023 23:11:07 +0000 Message-ID: References: <20230106025756.1184-1-abner.chang@amd.com> In-Reply-To: <20230106025756.1184-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5795:EE_|PH8PR11MB7118:EE_ x-ms-office365-filtering-correlation-id: 6a2e3aec-2da3-49dd-a9a0-08daf4291e9f x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uc7IAqxZvbfuVaTCjec+nOGz0Z4SJj6d5ClDrS8HLv5EVqiQl7D5XtVklE76zYAlvvfvVsCXMoobTmJy/CeOdAGHOTBKxa47DUI/f1kJC5LL3IOk8BPITDM5YUfpBnHBa2N+WHZh1NnmR2nvaOdUDIgSicGEdsnrtyyCy2qs08hSMckZFJ0GDEQbv01zwxOn/CHa1apMdapzzVT0pk0ER1VNVzcMY+76S+U9kadiYU/tqtaekL3UuynsofZ2F/IA7vmtSq8QsWndCP7yocopZB66hSkj89Zz0QsmCMbzXUrfUBf1KcmsdmPM2iSnVuhQ4muOm/eQHBscPZPET7jD3FiykSC4uwsVScAu74U/BvI4mFFrmJeWRT8cgefpH+S7NGAM7fj5zmz0XlMU9qvDyLRLB4419eNHokUV2ErllFeZg/TzlVQrNSV8wpNP1xtczBI5bU1xWDV4OGH9A/0g8jCykDWMEr8EJ7Z9KhuT6skxJLm0LfbBMraZEsHFlb0wFCsDogmSc3MHFCRIJ+OwwTWXAZNjr11brcKhhX/WRsFgslAPIzcD9t8+IqzhqMd6E/ox7YvccR/dqGT3012vuCpNegDDX+0HXd213j/WLEZ8ibaVDe+A/FQVGlq9BLcwEbp4NM4GsiINgeHrUElElljf1QmGW3TKOPfUArn3naIyqL3HO97sIxgQCz+cX5U70MONDH1M7hAaPLXOzx6QvQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5795.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(39860400002)(136003)(346002)(366004)(451199015)(2906002)(83380400001)(66446008)(66556008)(66476007)(64756008)(55016003)(66946007)(33656002)(5660300002)(9686003)(52536014)(8936002)(107886003)(53546011)(122000001)(26005)(186003)(6506007)(7696005)(478600001)(82960400001)(41300700001)(38100700002)(110136005)(8676002)(86362001)(54906003)(76116006)(38070700005)(316002)(4326008)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U+zv/a5GvxIywe5D7eDXcqQLpqF3hNy3zjNH7k4OF6w0f4DSM+R7CXCX6Jy7?= =?us-ascii?Q?UHN6oqiMAU/H3YQwWh0Hy8zpVugXsJ55rmTFycExh902oWlmaOlcjja9d6Pf?= =?us-ascii?Q?MEb7cAegwY86fkrJE57M7ZP/OHPHlHExvjo9rRH+vkHTd6IjbcuOwVK5gfXw?= =?us-ascii?Q?+BzMAHhifEz7Z+TkH63F6wV1uUaup/DS7vmOWM41bqniKllK/9BQaeG8/5Qo?= =?us-ascii?Q?w8etbo6uhzBPckiputoksp2GD7FXRkvouuCOJFTokJosyeqJ55Vgt0zILoUg?= =?us-ascii?Q?wMcZT3G8TeagGW2kagJtzKW5xVkLE4xe7Znm+Sh2ghw5vFnKgEFVMVclKhOs?= =?us-ascii?Q?72Jft61mNeSA8JlGNRuY8NUhMh3KjhANyAjBoTLGziJcnb8TajhWfGs3X2/r?= =?us-ascii?Q?qC6t44ankp1C1kpBL3XDDGzACvcOCM3Z+YSjLSz8/CJdZpveTEkoz9h7I0Dm?= =?us-ascii?Q?0+ZtS8ggZfnY+J1Fu8UEwhZeZuhMchlYx/yN93JlN/3LN2KXY+Z485KxfvrK?= =?us-ascii?Q?9oCp81oUhTIkKZrtOBJexG7yvfexemk0g4WbW5OQm/Wwto0hN8Fz8m9mO0bb?= =?us-ascii?Q?vBo4p1oI+mkb9B7KW3ILesSTQtsNBYcs9h24TjMm0mxLSclPlkYAQayvvLZj?= =?us-ascii?Q?1MpoflXL9aZZ4eCcpeCtPLcFpCgy4yb0/oYcZvB2fihruEJp5Dnt0gc06P21?= =?us-ascii?Q?oAY0ai4r+pVwDdQD2/ELzhRALIDz4qztSg9MB8rr1jT5SqzPDKrvgc9t7gzZ?= =?us-ascii?Q?10d4qebOLEIFAlTg86OdEHlOQnNIqpulEzBPzpl9RfmFL204gBF0eCMqap4B?= =?us-ascii?Q?tUNJqKV3xTjwOaqbdQOvIxZr94akNfQZrr31MmFfDmTfGgKwSPD+mPRta9Os?= =?us-ascii?Q?2WTBKLUXkbwsL0irgHvDiBZuNrT4ER9H6kmaHPRnf0JeVpLlR3t/hpmSGEdU?= =?us-ascii?Q?OCxvI/jgvbGiZgzZnq1/PphH9e+877WlZ+VFhxR8wWPgUgSquJwKOFQY9NKT?= =?us-ascii?Q?ktlhjWuQ11N3snH27buWr85Kcj0uNGl6ScruYuj5wiIIveg8iBGgxvqQvikf?= =?us-ascii?Q?wJxfvIAW3wYnlb8jQPskOzKWv3s7PLUcR6BMg+XaH352REjhzE338DTPrAEo?= =?us-ascii?Q?Syykn+4LITb6+JC6sValsad79HAWJd0rbYzan4xTBSi9ZxM9MEgWc5qdhH4O?= =?us-ascii?Q?XIl0ygLmp09X32hfw2SYj1NiHUXdr2JtW8fUk9TrNKXpdCyB+Lf3kvEFQK+k?= =?us-ascii?Q?fn8RrhXUwpjdCLC2EFRV4lok1xh03yew5Y7Te6pyPBorYU94BZ3jHtYbaeST?= =?us-ascii?Q?BfXGK64ZifLVd3ZbDrRTFdajVEamHhaD/epfVXt4nyWcop4I0fWQOU0pnwDR?= =?us-ascii?Q?OXE5hBSFfSaG37ksKRUnSLLAgRwhW4XvZlPX9EtARbEuPc434abTP+AkBsmX?= =?us-ascii?Q?FdlxZX4/dlcKowYxiKJaY6gDOFvAO26A1b4JiOKqQXP05tkHu2NQ8LEtkH+a?= =?us-ascii?Q?arHNqR1OJ85pvZ7BcMyqGTaz08hUwMWHiIoOvX9fzrYDfQA5kfhqXqYXE/ES?= =?us-ascii?Q?qoUqNgPCrnrZyQ9TNlOZ+hWKhskCoOdVqVzeBlYX?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a2e3aec-2da3-49dd-a9a0-08daf4291e9f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 23:11:07.0650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p/uIK2g/mGhFSdqwNRVydcA8v0Ps4ssKmMFjrn+D1CRZ1dyf56dgKQ552AtKrRKelueSRSdhMxsk97KmIRQBuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7118 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Isaac Oram -----Original Message----- From: abner.chang@amd.com =20 Sent: Thursday, January 5, 2023 6:58 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Nickle Wang ; Igor Kulchytskyy ; Oram, Isaac W ; Desimone, Nathaniel L Subject: [PATCH V4 0/3] IPMI changes for Redfish From: Abner Chang In V4: Updateed copyright to 2023 Addressd the comment from Isaac on V3 2/3 In V3: Addressd the commen= ts on V1 2/3 In V2: Addressd the comments on V1 3/3 This patch updates IPMI related definitions for supporting Redfish Host int= erface Credential bootstrapping spec and building up SMBIOS 42 record for t= he USB NIC host interface exposed by BMC. The corresponding updates on IpmiFeaturePkg is in the separate pacth for ed= k2-platforms. This is the part I of upstream, the follow up patche sets are: - RedfishPlatformCredentialLib contributed by NVidia. - Relocate IpmiCommandLib.h from edk2-platforms to edk2/MdePkg. A NULL instance of IpmiCommandLib is created and located under MdePkg. With above, RedfishPkg doesn't have the dependence with edk2-platforms. The implementation of IpmiCommandLib stays in edk2-platforms without relocation, which can be pulled in to platform DSC as needed. - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging temporarily because some requirements are necessray to be spec out in the Redfish section in UEFI spec. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Isaac Oram Cc: Nate DeSimone Abner Chang (3): MdePkg/IndustryStandard: Update IPMI definitions RedfishPkg/Include: Add Redfish IPMI definitions RedfishPkg/Include: Redfish USB Interface V2 update MdePkg/Include/IndustryStandard/Ipmi.h | 17 +++++++ .../Include/IndustryStandard/IpmiNetFnApp.h | 37 ++++++++++++-- .../IndustryStandard/IpmiNetFnTransport.h | 32 ++++++++++++ .../IndustryStandard/RedfishHostInterface.h | 25 ++++++++- .../RedfishHostInterfaceIpmi.h | 51 +++++++++++++++++++ 5 files changed, 157 insertions(+), 5 deletions(-) create mode 100644 Red= fishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h -- 2.37.1.windows.1