From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.18410.1666612373073767265 for ; Mon, 24 Oct 2022 04:52:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=b3pG4PsI; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666612373; x=1698148373; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=O6+0stdfHU3BaOf3q+TBZDExvyS6mDyirBOO9T7eq7s=; b=b3pG4PsIvekwKV+pUMxPrRJXfSdTvzC+IkLcdva9L7aaxvLE3ZdSSWFx vVSzjZW9tpvy5lBhbM0p+xYvMXZjsdwcxbTfkB5obIZVN9u9zyNjypCU+ IzjukauWhvlonMUtz8xakxD3M1/izs4XkDYThR6tZVOC5Zre7HrLSDGRV Ht8KchQIo4n5yyv/X2bdJscvXS+KmKjjH6tDVByTx/tRbl8375Rhsot4+ mpFNz64DHh0MEI5E2tdpePw+XuVv9Ube/8hGB8kZUzmvc6wNpFgpzBoIh vfSmS7Sp+xbzLV7jYk3BUUklWggkGCidBVgvHs3wE4CxvmPK/g0J3L2qN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="369465665" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="369465665" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 04:52:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="626046833" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="626046833" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 24 Oct 2022 04:52:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 04:52:52 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 24 Oct 2022 04:52:52 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 24 Oct 2022 04:52:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PbGXbdtIs372X8tYDXwqiarAMwvb74JEOcfZdYbK1tdUpdhMqlh/KGXDXOnUmV1CtdbAlzDZRUfFlDz939rol3PV442HWzEjXbWr299EnTK7kbSpRcZu6qWR4RQurwdLc2OzMYKDLsh0yO2vN3XeirbTH5PyZPZQP4PCFJURtEvhPly4yRCLa3XZXqeShC6oQj+2b+OiDGt1EXH0mzesdimg7Dg/+Zk9ZKL8yFraBIziTG3fq66HycUOT0eKroRDPclTaIUkNWw9Bz4D+l/5lnmcGz3tcT0Zfy44P1c0hMWbAyV9k8e/o4Ifd82HFDyzm1TOrLLogkqPFqigh5TC8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMe/9Nxs7a5lJr0r0mShFdgvzgIKZyLUBxNsEfrLmTk=; b=UHbSlbvn16Ix+fKVV35hPWw+cGW6DrNttrCQLkwB9h2s31GMqsoAj/+EvxgpGla1C8JHhTcsG3po4pofJClo23t/c7qR1wJE6Amal12g79eivYOVFpaNrjwK8i6zOkFNeTJ0KZprgNeHBrVK7zHlt/3JnL5taDQlMFEWoylChpxe+TuZBDprFiQIhohnYUNYjg/HFmlSuxgnUhsRCOsxxJNf/tTXYOTv3ySwU4nxnufN14KvEFGgN0of90vm9IwJ8kFZSnCgHA/h5apTzVPh7I6XaH4h0RD3NeyCMBE1hopwD/k38ygW4x5PnfADQ+0xTymhCACIbqsrLOe4seaLwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by CH0PR11MB5443.namprd11.prod.outlook.com (2603:10b6:610:d2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 24 Oct 2022 11:52:41 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::5a9e:911b:b5fd:6503]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::5a9e:911b:b5fd:6503%5]) with mapi id 15.20.5723.033; Mon, 24 Oct 2022 11:52:41 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "ardb@kernel.org" CC: "quic_llindhol@quicinc.com" , "Gao, Liming" , "rebecca@bsdio.com" Subject: Re: [edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND Thread-Topic: [edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND Thread-Index: AQHY53BARqmAX8YavkCrDuY7XGHrr64dbxEQ Date: Mon, 24 Oct 2022 11:52:40 +0000 Message-ID: References: <20221024061633.105276-1-ardb@kernel.org> In-Reply-To: <20221024061633.105276-1-ardb@kernel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|CH0PR11MB5443:EE_ x-ms-office365-filtering-correlation-id: d8dbeabd-d78f-4330-1dc2-08dab5b64148 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4UUJLAFrRZw8jSShijwSps993leSPS9E57ZDCPj1nsxSb9VkErWJPwNaB+8RSBWJ5ALhHQ0gR+tJX9uW4Oo08E0gUkb5nzIX5WWHR7QkAbWt1IRAlv9MJjgVyG40dORj2/LEcrwdOcLhBBE6ylXYw0IHkegsZ2aHUDQbKD/+LMkEhbPrYrsuQOkeUT5KKy9lZITfVicyFx9gWv16vlblEv/DlHlJhiUTn7YcGgPkajYXxSKa1VbmjeYd3Oe2WRI4LUR2Ej/LRKx2NRI1eCrkROmAbLxHdI4//pvHrnOFD/EhFHJSsGWKtWoGLZbORPnT4OgAiA4JHtbkquzpr1fv9bDbsSvNo/LrM2zhNJajTewkaban2L8g+xGCRNRUqql6N7KfQ8IMdMki+FdgPTUxTREfFltEn20E+/9oY07BtmQnUDXAik7dgdPbWUwDQlPaTDSYpbXKmESqOyIjSNzDHCrBvC2M9kix/PsQCvbNWMh76iwSmLfvxfcngOHG3+GfeZByNUmSdHUpWEnVYveiPbqPImO54S+3lIlCvNhrbDAOOOypXysmnQrK9z/zxxv3ssDLwyBIDML9GBD89YJV9xJY2LfgnL0bGTpXkbfLORCDJguvN3oO+PoNQsio+1m264W8GTZJkPxoEGJxnOr1oDVbDH2DUKvQTA+Lob5lgnk+pvGdeDhKOMD55D0e7jyRn4TOqnmW19BBrlvjRf+vXL5HHbzxsqr+29lg4xbFMdS/Y9N5ntKNp9VJof/MBMhWsQDCoe3Foi9SJ9jn4/ctxy/1oZ6NsT3zdxZBUUaqyMEMbz3nOuqfpt5LLZWjjOa2V318vXm8PRsK5hgw+2Ay6w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(966005)(38100700002)(54906003)(478600001)(66899015)(38070700005)(122000001)(53546011)(33656002)(71200400001)(8676002)(66556008)(316002)(82960400001)(64756008)(186003)(66946007)(66476007)(76116006)(110136005)(5660300002)(83380400001)(41300700001)(2906002)(8936002)(66446008)(86362001)(7696005)(55016003)(4326008)(52536014)(9686003)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T5rhtJRfsfSn2J8nAZWN6/0YALr+1GBngX1igznJ1vsO3ZXU7Ddeh4V1spGc?= =?us-ascii?Q?Z/eN5hhNo1tmt/n86zkZdF8LhDGsfY83Dx53lURYXsdcwnSoUZBLAZmsEoRf?= =?us-ascii?Q?5NaQ1/DUm11KPPsK3ugsq02DDw8Fy84HGQogD0txzaeSfukd1dciV7NfdcUw?= =?us-ascii?Q?PT2ekyoK6UXISTpasz/UAhWCHsr+IiN0F40Ea3dntjkIiZqHijDGoANlR9kR?= =?us-ascii?Q?Mja2OC7IAbYjZey/fV7HzkPFpJ0HgFf+yrAuWU2CjLhsKntJ6O6rXP3JEA7h?= =?us-ascii?Q?PS4n7TROYu2y9pW5SH/Qr4LO0t4V7i3a9HVJ6dokHesyaZk1nxWyQzgsztUK?= =?us-ascii?Q?3VLphidRQOLzXoE6ucfvbzo7Pb1uue4AsirLcF7VlzErBGLHD3m0yhA0gT5O?= =?us-ascii?Q?X0/jquSFbYu4tAPXPtY5oAl3Kq9u2bvdjapfbTGaGmwUBJ+5iCHzAna7vL3f?= =?us-ascii?Q?AJP/+XJEPqcTbF/ndYzd1DwN/0Tis1ITuLvCoCRsVQuBVF6mkLiI5Rmzh36w?= =?us-ascii?Q?wxNlA/++gvq6aznHgCfh5PkV+oHpBtm1W2UVSYT4rMBEGXIomZmjS9trhXHP?= =?us-ascii?Q?SWgv88u2UnE+bd5zbEwtdzz+P1twKg4F+mCgiIWoNEJNU6Nn1bwmph35ayFj?= =?us-ascii?Q?bLpMnPpaHiLxd9LLuTRKDo3HnNHh2+hfuNfKOwCQ1qDluBQ3s9EFQYmfiCH8?= =?us-ascii?Q?q/agZ4tBOYvmzCzOlhVy63WZK1BcGF+azJlGNy8DTrN4mMZ33xYem3wDng/E?= =?us-ascii?Q?VLxgiYi2HS7PlYmQDRo44VkbTtfL9Uo6tMqRvanrhbStwRigiZ6tS0ZSEJo2?= =?us-ascii?Q?UM3nADIWb1JR5eoq2paYyjetDR8I1BE43hkI7/MstENMyvplcFGY96rYc23J?= =?us-ascii?Q?hkzXats4urjaennIUnmhWCUkwJe6cQFucVCaIRXjla14V145bkV8fqLl/AVo?= =?us-ascii?Q?8m8Hd4TdLrDWpjincsb0BfS/OOswFgPefEGvFb1yswsaJGDrc2H7otEW4XpY?= =?us-ascii?Q?pvDBxvDtqZtuhclAiwNxUmmee8WEirj60sUwDdodhRd8Gt8C03HfIUqF8Uqd?= =?us-ascii?Q?uOLmGAwAmLEQcxJRaG0nj/v6eljwuSE3SgTmG9tRjrERGVLK4FlwZgSscn/C?= =?us-ascii?Q?cLznKsQw/3qX16KHypyWJLAkfR8G/Trgc2QIY6Hslkt3OETKmybWIVz83C4J?= =?us-ascii?Q?FHzlZmgxKUUzXNuLjUcIrMIxPCdyXDLTRuNhn2Njm2rTARHy9UaN/Vi2cNa1?= =?us-ascii?Q?WbyfBp0WiQ9PuV+tRDsvgFxCTbCcuVUyUlXg5jlbw5CkxAVgAi28oo2yporQ?= =?us-ascii?Q?ahoPup19sz842AstZ96jyHyI17I+9Oa8+LnVfB5GlI9aibQs53DFjiE1bET5?= =?us-ascii?Q?bwLzkjPPO14T4jtp41JD+AyUA08AA85fgoo3DRSqw4506zzWMWKV3O3HPO0l?= =?us-ascii?Q?6HU4h1Vl0SoB46DooZm7LCO+O8ykSEQCYIECaiVKhcAZiopceE1/AIt8o52N?= =?us-ascii?Q?wvMMuV6DsPdSVBrZsj+I5mjOTjunz0JegP8Cg5hWbigUTpqb8HulJnMt/te9?= =?us-ascii?Q?FIZtr/10rq0SjoimWRo3Fb5uDPuj3UiKNpJyoxj2k3Bb2hxW1FflE0OJaNlU?= =?us-ascii?Q?LwFqyXUARCakw3CvNlLTEofmoPgCrJBpjjVvPHvUCqL6?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8dbeabd-d78f-4330-1dc2-08dab5b64148 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 11:52:41.0110 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QWzd3gYvmr0g4JOBv8MI94Sa/6Vp9Hp8nl5uecSDkV2VGBQ2kjLNgpSVx4iLhG96vHF3YDvVPaGlIXe1s9Mskw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5443 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Ard Biesheuv= el Sent: Monday, October 24, 2022 2:17 PM To: devel@edk2.groups.io Cc: quic_llindhol@quicinc.com; Gao, Liming ; Feng= , Bob C ; rebecca@bsdio.com; Ard Biesheuvel Subject: [edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COM= MAND Commit ("2355f0c09c52 BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile") fixed a latent issue in the BaseTools/Tests Makefile, b= ut inadvertently broke the BaseTools build for cases where PYTHON_COMMAND i= s not set. As it turns out, running 'command' without a command argument ma= kes the invocation succeed, causing the empty variable to be evaluated and = called later. Let's put double quotes around PYTHON_COMMAND in the invocation of 'command= ' and force it to fail when PYTHON_COMMAND is not set. Signed-off-by: Ard Biesheuvel --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile inde= x caa4d26c9ba6..20b387864f74 100644 --- a/BaseTools/Tests/GNUmakefile +++ b/BaseTools/Tests/GNUmakefile @@ -8,7 +8,7 @@ all: test test:- @if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then $= {PYTHON_COMMAND} RunTests.py; else python RunTests.py; fi+ @if command -v "= ${PYTHON_COMMAND}" >/dev/null 2>&1; then ${PYTHON_COMMAND} RunTests.py; els= e python RunTests.py; fi clean: find . -name '*.pyc' -exec rm '{}' ';'--= =20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95492): https://edk2.groups.io/g/devel/message/95492 Mute This Topic: https://groups.io/mt/94528814/1768742 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D