From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.19930.1657702328931692618 for ; Wed, 13 Jul 2022 01:52:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=INNqYCSi; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657702328; x=1689238328; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZZratyKwryLz4voiFN6FC9WkYDdCAXAoh0woY+KMm/8=; b=INNqYCSizlRtLs7KC1c5Z0u4wTEsVNFPRDfK8EhEl0BztrsZUUj3HPhk nIbo8h1zfJcnZQ9sB/ThClpDcOjBL3LaV9lC93VzbAefoRIWrEXndr4eE kW3HMrA9pMNxyUA2873qSnGCrz7+e50rwI1ZARhP1Y6BxdTEFPPOHgffs pPkIt3jX8KNoBkFhNPuCkMMkPugYnIic/FthlkF5SrRq4TdiUiN2IurCM MsKJYc8uKuQcX1AtYl7+wCc7d84V8sqAKgQMVBlZ+QnoahRtAUswL7YBm 8+b8gMLOmtt9kv5P3QWhJwXU81BBdWX41xavRR+Jk6MIp1/MjbHAo69je w==; X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="286289637" X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="286289637" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 01:52:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="663277834" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 13 Jul 2022 01:52:08 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Jul 2022 01:52:07 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Jul 2022 01:52:07 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Jul 2022 01:52:07 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Jul 2022 01:52:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DdxypvKE7XawqsPUsUErW3j/AOpOJch5NdCuf3PmFkUot6wAC6ocnoTJYDOY79wpoi2Xu1+TYzcc3eBsRNiCD/uUpdJ6FMcs5JtsgJoMEugT9ZqKRa+h2Ag5wv8+P0/Q9859IH2kxQTEr8hC7yDdBxkWDN3itc9DGjkpRsYaEoLeTRTyVNIaTNwjjCXL9k9u5E8jfP/l2KJhpsCsBcMW4/XLWAacizjZ6JNokjeutWMK84gUCCDzIHQgry9Qd02+s2vTAoY0q5NNEa2pd4HtwdKxC15Bjs8Lit4j98xZjwE5tlr2XyC4opIzY1gfa/K9NlEMQfSm4OAEDXivSFD1fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A803q1yUgT44FftQWVEAy11ImFEtZrgsBvxlTsPHMbA=; b=bhF+zw6vtQoLx+8Np9+Km+kPnCPB5xCtlQET6w1Zfjgp3Is+6zDF4iYinbESytfqZ5lerB1ujfdDxcCp7/QTKSP2hs0A2kXysYG2/AE+gMNFtqBdeQR/Te+SOHeO47M27iHFgd1vDXI41FcgjjE2y9K6DeQqyzhmHuWcCVjZH9r4o/8vDjn78aLSvetzXHdjzTSg/sPLs+J2/XQxZiaY9I7wHy3mc+jQzes/QjvlJ8Qpvs03x2hH6KFNrn5wH2Xz8Re68uHJOsqarMVtlzqAexJ1pfNtihEy/kSuHQSI4bcldYVi9+26qoYTUIi7Uzv3iUnUjtjOsEGQ4c0xSvX/kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by SA1PR11MB5825.namprd11.prod.outlook.com (2603:10b6:806:234::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Wed, 13 Jul 2022 08:52:06 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::943:4b5a:b96b:30f8]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::943:4b5a:b96b:30f8%5]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 08:52:06 +0000 From: "Bob Feng" To: "Lin, Jason1" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Chen, Christine" , "Oram, Isaac W" , "Chaganty, Rangasai V" , "Chiang, Dakota" Subject: Re: [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0 Thread-Topic: [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value from BiosInfo would always 0x0 Thread-Index: AQHYln0/fsKOZb8zxkKllTrob5Tmwq17/pFA Date: Wed, 13 Jul 2022 08:52:05 +0000 Message-ID: References: <20220713055556.2810-1-jason1.lin@intel.com> In-Reply-To: <20220713055556.2810-1-jason1.lin@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6bb232bc-047b-4cfe-4d2f-08da64acf67f x-ms-traffictypediagnostic: SA1PR11MB5825:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vfn3+xOt6787KrwRmjT677lARsGzkgjbol3Edij0kY9GYNTbIRsO0ZNKVAyBd9lMhWGRxqOEHwNsJX+5VvEWTyd9kF88jdwvldONy53JkevEkd8wlOJHS5wFIX5Xe2odEz3bRqBBXnW2hqzMkAiMSVuZZjMXN2e2sL6Exsi73HWRp7PpMsWHPtazj47CqrHvI4Eab0zrEXpwmAKTByuwp1yN69cbNN4rHlg2kpJhnI0Dc/KFQdCE5Gy7wnkjTU5bJmKOncVQ6SFINtgelpttzNMyla7EpBhAO6ArrlQRa0GR5E3YixwOZQOVkFePNXEvMWV0D9Q6fP4j3cy4ferGricysJSV23D9chE9SJXczLMOMeE3JuEwtCxKblKJqNxg7h75Zr6x3fXG5KGTBwKSpSNXMoxNo0aVn9liFGaidcwI8mX9Bma2OikMQlXNAJZrwM8T1/EncxBUyG/ryGj0NPiEspFHDOKDPvfgzQ2+0U/CnoIp2Vv3vMjwCAU4xWFgSzggqXCS7tP7nj7lk1cmuo3wDCW6p/Bcn+jijiA+d4dK4I+9HOKbjhQP3Boz34xV1tZ+d8pvwlm432M8ezVQd8bYM582rvsNO4dbAAv2dnGhw87J/tG+QpjdUKhD+m0rReoecsc2Yjely/D7ko+YE9falLO5jo79Rzl3VDXpitIwX8YmYWHP0jgxLGkUz0FHR0rK33tCRPLF6kv2alMT7cpdPuH8bDzDJyCC87Ao0gwUkh2AzeYU8Nlx8Nk2JdtvgXGixRKQR1zIFjeUmTXGMAQzTJwes3HQek9/QW92LfC+OApTt6Otdzb3nKo5NZcnXTlHgvQbKtk7EZ4yXQFCGQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(366004)(346002)(396003)(136003)(9686003)(107886003)(53546011)(38070700005)(33656002)(26005)(186003)(6506007)(82960400001)(7696005)(122000001)(86362001)(38100700002)(55016003)(83380400001)(966005)(66946007)(8936002)(52536014)(316002)(110136005)(5660300002)(54906003)(4326008)(66556008)(66476007)(64756008)(478600001)(66446008)(71200400001)(8676002)(41300700001)(2906002)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n5TDa1Hp3N1+gMwRG3JXXL9Xx/gJWwUey+QXKKM4qIQ34y+IN8CkBAH9WpX2?= =?us-ascii?Q?o4gKgfOpmcmu+EY40JIKp7JQhNVSjl55QQT5he3xCFK9kNFnj1noMnrNAeSD?= =?us-ascii?Q?Yhu3ab4ZHo6W7hAJ8+LqQiMlIM3SteE9aiDkDcYPzaxTjQYxIQa8pdPxsp42?= =?us-ascii?Q?UDDq5WYZ7IJ/jQb+xqNZbgt/cUIUuGlZ2hRiqO6LoJtLSClZ1ZB0hf5X0OIK?= =?us-ascii?Q?1eAcKDde/aWWQhocacjeaeiYMdmNm1v0VGbe+SxXIbYiDBSz/fRS08YFBL2/?= =?us-ascii?Q?KFZf8Pc4xWCbbAZJE4LUA28Wm1PPvacj/iJLamKKfloITR8I5pNK3fYNAyT7?= =?us-ascii?Q?ODG9gE+9YXKv3pIAo3a3s2iPvFhIjSjm4IqzhV6HcGM1eWQn+wyha9Jzc1CL?= =?us-ascii?Q?gOZlh8qVTBKcYB7h2hSAh4viLaqG99qSwcPU4gwiQuhqDxcqHWiquTZYHdLk?= =?us-ascii?Q?7WYpKjrKFjbiPYDGDopDqYyriUI2Qa6cn9vkPGRsymshRMfJG7zoXdC7Nk7U?= =?us-ascii?Q?0qSf/6NjaUp7PZPGCZtU1t455fh5FhOh804TP0SDWRyfTPXHwv7JU+TCQ1Lu?= =?us-ascii?Q?opc+1avOdqyao01o3WWvAqikRZiLTJEBcSZzZGzmk6iV4tKEtMBZtZWIJcsR?= =?us-ascii?Q?FIurrh2btPTFYX32ihioc0szGzzn/CMu8OmHvbm9JVzl13ElMic6fzQ9EhBx?= =?us-ascii?Q?yj0y5NZWVNi9GUcCuaQjl42Xj1PJ1lb4dszeJmwmXxdS3wwQ2TxH/KvO59r9?= =?us-ascii?Q?NKgYI6htjIOF9xivduivVEr6dQJA3yQOOSLRbcEIKBBkzEZDdV8VhesB8Yj3?= =?us-ascii?Q?jUx25b4ogdkrDscIM9kv7x0+4iQXg7lcK7wYzcF0s4gSIz/kb2VEVa1sqC/U?= =?us-ascii?Q?CRFAtXgXZO+DEQL85/6BNYBucP6dDyC1/50xDih8/IOwpiS5QFszVVmWCGWT?= =?us-ascii?Q?i3yS4Y8E8UUHAJGOrBFOKnubtZAYMfPnMNceLvhOiUGl/ppQkqWDlI2xNbbl?= =?us-ascii?Q?wFtwyYnu0IqnKlUaMRzCBmySahLkb1JDy/3NxyKp5uyMKB1ARyVd4pMufscQ?= =?us-ascii?Q?PJXXxWLJmV5AegQPQUqSbz9ZI+Xhw5yLKI6h9ir7eGXBAANN24W4IpCu096W?= =?us-ascii?Q?+pB6akP4oApr3EDv1mYJVIXWlMBgCAq1ToyPI1YU/F8eY5x16EyCRmhmRD1S?= =?us-ascii?Q?c3VCnKaixoh0V9t7JbwtfKhJfMr272tueDjObXcpLaX0j9rltXd6bsn6M81k?= =?us-ascii?Q?ZnKir0iiyZGjnGZJjFNenUOOydxHBZIU5CvGSBzJpBfuFA965T2Xi7weFmyP?= =?us-ascii?Q?UH640Ynmuj4LkLo/XL/id2WE04WYVQOhNRlcHqxSv1XRr5XvqQuDLzydwhRI?= =?us-ascii?Q?4S8i7LOqZTnOGSVoI6gncW+TTEC6h1AhABloOzcbD3YKnd4RR0+fvL2sdYaq?= =?us-ascii?Q?Ih1VCYeq7aBHz2qWQ6/aXab7iFbB2Wj6VZHhBb4gfFs5rjWmuDspHVdsAbQB?= =?us-ascii?Q?qrMMKsO2MgUkCZLf9STI2Q/K5XuI1zKFqz79vmYPh/BJNoAi9F5bGre1V4Kf?= =?us-ascii?Q?VZMSnrI4QCk+0W6dg2Y9mp5hrYceX32TGweTbZed?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bb232bc-047b-4cfe-4d2f-08da64acf67f X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 08:52:05.8724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2d4r+Uwhjy+HN/4vlvrtVz8CAKDQQbjkmV7fhFXrmmJJI3DqNkOKpDy1fHy/wNaZ2gCUPl2dLjeLtcGi379QLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5825 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Lin, Jason1 =20 Sent: Wednesday, July 13, 2022 1:56 PM To: devel@edk2.groups.io Cc: Lin, Jason1 ; Feng, Bob C ;= Gao, Liming ; Chen, Christine ; Oram, Isaac W ; Chaganty, Rangasai V ; Chiang, Dakota Subject: [PATCH v1] Silicon/Intel/FitGen: Fix Type 2 entry version value fr= om BiosInfo would always 0x0 From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3988 With the change #3958 using the incorrect variable to store the S-ACM entry= version. That would cause the value always 0x0. gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Version variable should be corrected to gFitTableContext.StartupAcmVersion[gFitTableContext.StartupAcmNumber]. Signed-off-by: Jason1 Lin Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Isaac W Oram Cc: Rangasai V Chaganty Cc: Dakota Chiang --- Silicon/Intel/Tools/FitGen/FitGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitG= en/FitGen.c index 577ce48b10..21dfcf1ebb 100644 --- a/Silicon/Intel/Tools/FitGen/FitGen.c +++ b/Silicon/Intel/Tools/FitGen/FitGen.c @@ -1182,7 +1182,7 @@ Returns: gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].T= ype =3D FIT_TABLE_TYPE_STARTUP_ACM; gFitTableContext.StartupAc= m[gFitTableContext.StartupAcmNumber].Address =3D (UINT32)BiosInfoStruct[Bio= sInfoIndex].Address; gFitTableContext.StartupAcm[gFitTableContext= .StartupAcmNumber].Size =3D (UINT32)BiosInfoStruct[BiosInfoIndex].Size;-= gFitTableContext.StartupAcm[gFitTableContext.StartupAcmNumber].Ve= rsion =3D BiosInfoStruct[BiosInfoIndex].Version;+ gFitTableContext= .StartupAcmVersion[gFitTableContext.StartupAcmNumber] =3D BiosInfoStruct[B= iosInfoIndex].Version; gFitTableContext.StartupAcmNumber ++; = gFitTableContext.FitEntryNumber ++; break;--=20 2.37.0.windows.1