From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web08.5999.1666442884010826790 for ; Sat, 22 Oct 2022 05:48:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Yqoc+j1Y; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666442884; x=1697978884; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ioXm1YEpOSyXZ7JKbW2b+1+P8+pNEC0AqJumjsk6/5k=; b=Yqoc+j1YHfVgecEUB7ENav8iguHifYH3BH6EUMLU2HEPipJxso2CyyP2 YLhRwOz+306cFUSLmC0tVkR3hzVa4uyd3u7uImlXCWp8tmFasguAN7Xgc vQLyGezN5xEFK0NtBIm2/A8Nn9kJd2DTtkirrMsO3W4L9WFrZNApIEaJd l80EVdTvNufMZTVTaZ3RN1Qh/hzdeagnQNjYozNwPdyceZ6v3t8nUVHy8 ksMYGBvnOnRamBtIEKxsRewDZF5x9nr3iC1RSyQcrjWNtu06nwTCupD2x OdX2JT+iN23+oFq+KjGlpa3+g8LQTXq73o3KLHB/Ndz320t5yUhWOTuMd g==; X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="290489025" X-IronPort-AV: E=Sophos;i="5.95,205,1661842800"; d="scan'208";a="290489025" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2022 05:47:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="664061851" X-IronPort-AV: E=Sophos;i="5.95,205,1661842800"; d="scan'208";a="664061851" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 22 Oct 2022 05:47:54 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 05:47:54 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 05:47:51 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sat, 22 Oct 2022 05:47:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sat, 22 Oct 2022 05:47:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAlrG1P+aqWlbZ0t3FUy//F1ihNV5NKTWmsBJZ68lJJjCA/UfuHNiEpFx4lxxKjXnWizKuSXRJY0VPKG6LAkg5MiyXBTTrIhln+MoweDQGxzGaMUmx02o8+rd4vzIqVpBr+Obvyg8Hi9WYep5m4usL7JDCo06+EEgncZaJfWJhTjXv/42m73+ll+m22azV8xyVQWpi8QUGLg2M6jNITNNrk1dyuYF6NjZI9ad/WGmAZpBCEugwige5nlMv95aY0cUXaHgeC5w3aj9arXAE5C7BpA4C1zCqbHda55boxKT9rjqLgZqBWSeu27i4tQ1w+KoHKTEzHDIelxlAx3R7J7Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLnqrA1EN/SPK4w3+sM3sytbxtBeAjbYRtTphd5q2cM=; b=HcZDwCy49znTh80yxTqOcyJUZI3MdiVebkcCyMvurS5BpR2+7KEwdPlHnnNW8YnBcOmVqq/ldL78tyaKONusBsPVESpAJN5bBPCqB+BdrfjsWoLm50zSlerg31h3G+dbv5vrClgnFTzdOAa10DRSV6Ce5BQxNNjI8kdNjAd4V4VVVgiSeUUCNVkeZg8Z5ENq4IeGdQsg6jvMh3rqD6f9jbRJO+Sg3YObHeRZq7rwIkoX0V6qdOKLCqkkn0INh7j63QnFj8p9qlVXRW7N2D8FW8sP9PezJ2UuG3xtmFwqxSydiK5Z6jJoPKu/r5AdKh+9rKM8o8REW5Aq2lU4WMc6+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by SA2PR11MB5130.namprd11.prod.outlook.com (2603:10b6:806:11d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Sat, 22 Oct 2022 12:47:48 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::5a9e:911b:b5fd:6503]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::5a9e:911b:b5fd:6503%5]) with mapi id 15.20.5723.033; Sat, 22 Oct 2022 12:47:48 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "lichao@loongson.cn" CC: "Gao, Liming" , "Chen, Christine" Subject: Re: [edk2-devel] [PATCH v2] BaseTools: Fixed the multiple pairs brackets issue in GenFv Thread-Topic: [edk2-devel] [PATCH v2] BaseTools: Fixed the multiple pairs brackets issue in GenFv Thread-Index: AQHY5GXi60UaP2rYY0+bGAsFl0bykK4aYBNw Date: Sat, 22 Oct 2022 12:47:48 +0000 Message-ID: References: <20221020092501.3783878-1-lichao@loongson.cn> In-Reply-To: <20221020092501.3783878-1-lichao@loongson.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|SA2PR11MB5130:EE_ x-ms-office365-filtering-correlation-id: 51de150a-547f-49d8-a979-08dab42b9ff6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Tfk2YvLiYKhItpgB40J8dSmHmZqhhlywoe/DWq6/CmiCqqhZcT46kFmx5FKRwXz5sm1JjQXE8/jknOORz1tg7ZsM53oEFghsXBVi/fU9qJoCp+jRgSye4nhWlB+vflb75K9ClNAv8NvKJUKPPzKiKpePhT/SQbFvVLrH5DoHUB9O1hQsZlkEp3BR3AQR+EL09/2hOQ54AnveHy2y0AUbuzPaQ4XJGbo9TDgzXrwFQqXjHzMJHwgsd1t8OLvsNCOIlK278i/CS5sKiF2EgzP1tLkv30KmCbIlv75KG+A1+LHgguAQEvd6gc5WBJn63XV5XvZrAvhXLJmw7T7cry1nojuLUEvQtS0Llu5hgQexfSU/gJ4xOG3YHWiq5rJpSpYMRi/1dtKyaGUoJrg+2k4Nw/6/RnYMUyW+YoKsBCCpIpAHS2Q/5cE+dLIjgrZFz/uTbxh3jnEYg0w2ybifgIGAiMlhfhzD2q3vf0iKjy0wqkjPg0weoHI42J0jp6zFihdzf3giChEfIHfReY9EY7WhLB1Rh4cUcUtqqx6cp2qIviSm3+Z09t5GQZWSlzYo43m9W5fLdEmPLlXvU3JJcoS+Y3OvWeQ+EKrGUU6Gpz1kXPFHNpepGXAtcsbZI66LrbIfzxrJ+0c+PwNVV92PpfBc9EddGvut5PM30lvvqlihJtSHN+oUJyk+2jGLUmyMj038O0w0cUAD0WC//B9BaEN59XDqAEE0IcucMBXBxe7vXxowPQsAbJNnxhcJgZh8UzQhnZtL8IldXRzo9pWXaz6DtwA0jTJyoPyC+TCH1GkULrEgGQkX35aUsRGdIieTWbl4LBDKDyByLrFTezhcxPNP+g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199015)(33656002)(83380400001)(86362001)(8936002)(82960400001)(38100700002)(122000001)(38070700005)(478600001)(41300700001)(966005)(66556008)(64756008)(6506007)(8676002)(4326008)(5660300002)(316002)(76116006)(66476007)(55016003)(54906003)(110136005)(71200400001)(66946007)(66446008)(26005)(52536014)(53546011)(186003)(9686003)(2906002)(7696005)(107886003)(66899015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Hf3mmvZair3g5Ft7f12C2kkxa67lMXsTaZU8T7atOvhh/2LFYzMnGzfR3nFH?= =?us-ascii?Q?77sfHajhI5nw5fqs90w/EwIZ6iT295cYdevDRfFK7l6868XOTu4btoXN0qjI?= =?us-ascii?Q?zJqvWF8OAxhlm16OopFKbRLn2zRFoFIynaZGlHKA0+0p/lkKF3QRqnTkrotH?= =?us-ascii?Q?C3Z4hTubpAT4HjeV2o46ACAFzIFwduymG3pmf/azIU7yXWO2IWZ10kAmlWGN?= =?us-ascii?Q?rvnWdfYemxyJImHB1Guj3mJFK/h5HUbGBzSvvgQ5Y4Zx4UF37OrVkxgG2pPg?= =?us-ascii?Q?l9pzDy9dIc/9I72eHIKgEwGYTg63mM2uoeVrXzrQca7PQwVpWn4vfqj1tPeR?= =?us-ascii?Q?IsM4jhPZM2TxhNeTsOFzCcVdu0UiH14QB6SMtUi4sUB3cZ1L+3/2zk/eKKKn?= =?us-ascii?Q?dBQF+H3bnPrMMI2PXFmEoAtv+D69UMoAgndztunKRQCPCmrTCQJ/gjzRqurU?= =?us-ascii?Q?3/sBecb7CjkLmLFsbS+AB5mNbCMI/E1B0jS1YNmsYWXQ2updNSgroJziKrnU?= =?us-ascii?Q?ei/Dzu9GQFu8fhYbqO7eonYctkuX8FcbKFINQ4Pv4vQRVDH1XODz+DCpV0KY?= =?us-ascii?Q?HgTVQEjRSezdKxK0TaFqhBHtmq59M8i6+e6pf8jqBThmGGkOhsF256Bc9otM?= =?us-ascii?Q?r3uVGpAA6c3vQq4ksWx5Jsp9PFCwl7Mv+F7fsAs52eD6UqXpzw0qvAa1DcVp?= =?us-ascii?Q?3+eRYP2IM4wqFV3rGnVOXsq6iUQBSJrLjAkb2s/HcJl7lUK2Dodq3boVAu5v?= =?us-ascii?Q?RcMp4ebkMBt6HSFdkX0TQXJqB/aDFBDxmbh+n2iZIB+Q4S1MMHJFjiE/XYY4?= =?us-ascii?Q?dYwNV0RW+9CMcqUv2qJwSTNEOJLrNRqpZ4yTYTW9/4NQTteTQtiY/v58u+St?= =?us-ascii?Q?A2LmBNTZwfi3qo76ymihDmXmZB+f5dyyWx+kMYYbgIOUT4VTkyvhC9fNAS9o?= =?us-ascii?Q?OARmYukb4nvkGQ1z7ij1f9Z5/RNbqi7zmx+LJ++Bls1JJ4NVIO8u9P44pOel?= =?us-ascii?Q?Gzs7ZDiPQCjTlmLBIdEwThrN5YavKv9GMnK9sfYNJJoPDHk1QhB9469cix7s?= =?us-ascii?Q?dkFDCsdqoGWmAeSVzeKC2r1Yn1kGbSL9uqXT97iigxzXClUTtF/R81L5WDcc?= =?us-ascii?Q?+YO42e2v2jZqFHisEpPe8hEvBrahe+QXNeLBEVA5EwwflKvf9LnxsDWbiJyD?= =?us-ascii?Q?mYc7W2x5ddsDNwozK32JBJ6YshSB2oNsEAImRNLCsdez/K0owsBe/8ubahWM?= =?us-ascii?Q?gxv2uIvLLd3EnQvuiuhnwGTlJ41mvh2oj80MX4GCBREc0j0qQm3F43sFApiG?= =?us-ascii?Q?sO4peYPI3oTylXeKvp9kDT25bf2ItHMypSrPbmoJOgyxa0F/aJGzhJrYlKue?= =?us-ascii?Q?wx4hP9qZJLwEemMFsPrzcL7mXwU1bU/mZi8c+KKMo8WPcONZr6w7b2vsonCP?= =?us-ascii?Q?pa8kvkTiLTjJV6WLTqTU3+fxYGLuBn1/HQ42I8QNW1GiHRpsWUWAvaIA2C5U?= =?us-ascii?Q?esSyrlzghkpIU9GMisLN7Qu4IK6PsMvAA9XKfle+KCdTBrjIqHYCLBp5iOr5?= =?us-ascii?Q?ajC7sRG2oDmQ1iHAd+kjbNsXXdyzAgHXKa9pymi6?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51de150a-547f-49d8-a979-08dab42b9ff6 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2022 12:47:48.6057 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BpyyV1pVWlxIpX79opKlP+0UaV/PcTTtKhgd4WZXwVsn6OoFROlMqQfHKmQV6Y1XPKMPMDlRqCXYZJWGJViPdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5130 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chao Li Sent: Thursday, October 20, 2022 5:25 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine Subject: [edk2-devel] [PATCH v2] BaseTools: Fixed the multiple pairs bracke= ts issue in GenFv If operation Werro is turned on when compiling BaseTools, the multi-bracket= s warning will be reported. This issue is comes from on of the LoongArch en= abled patche. Removed extra pairs brackets to fix it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4111 Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Chao Li --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source= /C/GenFv/GenFvInternalLib.c index 5c3d54f5f7..b5b9425003 100644 --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c @@ -3559,7 +3559,7 @@ Returns: } // Machine type is LOONGARCH64, set a flag so LoongArch64 r= eset vector processed.- if ((MachineType =3D=3D EFI_IMAGE_MACHINE_LOON= GARCH64)) {+ if (MachineType =3D=3D EFI_IMAGE_MACHINE_LOONGARCH64) { = VerboseMsg("Located LoongArch64 SEC core in child FV"); mLoo= ngArch =3D TRUE; }@@ -3721,7 +3721,7 @@ Returns: mRiscV =3D TRUE; } - if ( (ImageContext.Machine =3D=3D EFI_IM= AGE_MACHINE_LOONGARCH64) ) {+ if (ImageContext.Machine =3D=3D EFI_IMAGE_= MACHINE_LOONGARCH64) { mLoongArch =3D TRUE; } @@ -4002,7 +4002,7 = @@ Returns: mArm =3D TRUE; } - if ( (ImageContext.Machine =3D=3D EFI_IMAG= E_MACHINE_LOONGARCH64) ) {+ if (ImageContext.Machine =3D=3D EFI_IMAGE_MA= CHINE_LOONGARCH64) { mLoongArch =3D TRUE; } --=20 2.27.0 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95422): https://edk2.groups.io/g/devel/message/95422 Mute This Topic: https://groups.io/mt/94450039/1768742 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D