From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.189923.1673932646737610466 for ; Mon, 16 Jan 2023 21:17:27 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EZVJW7jv; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673932646; x=1705468646; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=VtQszfTwAeFq16s+4PaEYAdfTPcEeFNpT1RpSK9a50w=; b=EZVJW7jvCxxfzMcLQbwQ81gJ17KhmRQIkHtvbTVggkPIC6oX9Dzkqoi3 C3YQy83RbRAHY7CbdYN+OfF46ocAa5RhSAlj11Wu0exIuiSG4LIop1a3N NLbz3Q7juBl3Cu/4Rt9EGtZ0KJIysHoH3/9L22rqDRvVRWkTuu+BbnUep imP9KSyQRlHBr3Vj8VHcyG1YKy9wIwIrLeNMpQ+vQr1p4sLwjtR02uX6b NxXx09dLg32RoEABbH7gQ2FcUyEsfF9tWvO6HryUc5+51TcInG46Dl8Vf nJa0VHnFJKyeajtouCUOFHEeHcnPKL75V9uFqbRmwBy48JoVsMzXHQcSR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="325888872" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208,217";a="325888872" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 21:17:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="904516554" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208,217";a="904516554" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 16 Jan 2023 21:17:25 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 21:17:24 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 21:17:24 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 21:17:24 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 21:17:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fMFJKASGTQjdOyzTn1amvgM0ZE/EKNgJmCi7xbCHC++Q0dKq/xmlhtmXo69B5hBB8sbRc7rlbr4TAoX5jNIasY+mNclV+CsF9i1JhjudjWi6jtqP4E3lASov5/66L0AAYtyslLXK0AEKAipau6+s9iVv355ONQzlVzh+wfekSyqFDlDVfrK5JJ15gg+hWR6VW4/agVJ3CsgwwvMGyhPvmJfYVzv5KkXSF3kRAKG5q0Nfy6kqO42gsz+9n1FVtEtgyDyBjtfMSWeRGNzWvXFFivLyftQ1mejUmtF7bEPcZ7uONfYeasGfScjFstb2hG3+OfnV0+QkB41+9E0AtkGO5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ZaWWd3VcfT8MVyl6b/Fu1WWFqIqdgwNQW8VFGpfY9s=; b=VOYtyLlmeydDf530hAYHy1IzVug9HP3K+B5o726ZQ59H+OLV43Ahlv+XDMjvRYPh8IUZhghrX/SuBiXB4XbhqKL0HZfw7cU1pZ1o9hXetptjgc17rfrQ6T9dnDICqFeF69H3KrU/vu0OBM08AgJln+rD1mpO3xBlx5b4a4ItJEh7owEOPFQ/TZwdoFwJGQWvfWChYd2nwhRY688Gsfp67n07B36zQYZ+v8FyJOizyCE/EON6ACUYPeyEtnzuqeABCa21whnKaE4NLRaeooXCidwc+L/tXzdM5lL5SudhBe+/FQkvpjcdMdNg4SELhOH5Uc9GMs1crTj6hOVJUwKkag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by PH0PR11MB7470.namprd11.prod.outlook.com (2603:10b6:510:288::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Tue, 17 Jan 2023 05:17:16 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1736:fe5c:ecff:e73a]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1736:fe5c:ecff:e73a%4]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 05:17:15 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" , Jake Garver , Konstantin Aladyshev CC: "Gao, Liming" , "Chen, Christine" Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM build Thread-Topic: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM build Thread-Index: AQHZDw8bWQ1yPeP+M0ytuH8XypOPMa5sKLAAgDYbk0CAAAJiQA== Date: Tue, 17 Jan 2023 05:17:15 +0000 Message-ID: References: <20221212130924.8156-1-aladyshev22@gmail.com> <20221213162222.590-1-aladyshev22@gmail.com> <173B00341150B4F6.23170@groups.io> In-Reply-To: <173B00341150B4F6.23170@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|PH0PR11MB7470:EE_ x-ms-office365-filtering-correlation-id: 8525ad37-b9ed-4141-6e62-08daf84a1913 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KZWRFW7TSnh1rhELff3pGCBmppi+f8Tf8nRuOd8VTSUoKgXnWO0PvUHqvXgYQ5O5I18Rfsy9Q5Je1uyDP0KwZCUwPEZIsSXKhcooAR3hSa7YLkK8FKQcu/wLhiLavXpX/BGtSgQcLqfT8kCrTgzJjeqBCnoQv/3mauaMwvoUCfvYMr7dwEFgMjv9P1XSD/uGMaTB4+VsmJHXN3YkNz7D/hCAi8tFZ/535luyOnw6Etpihw0GZ3vDV9i3is71Xyzh7w03NSdllFkIJZ28lyzXU457YTkMzObAwWxKJM4ihQ6NC9J1q0whxI9bIf4m/UeJ7VDs7gDBTJQwbZkWdytaUh9i/ONLoD7V2tm/x21S7bZjfvaxxpi+CO8hHr0fNUZAxI+9HybIL3ki01sSd7aVdOwNuAjPc4MUS62JVyzBavKxgCrGroHsQ27KNv0B3afAEwonaofZ5aYjMV9dFwbTjjPOtor30HpBuMdwSLXuubVtPescKYbe/dzZ10i5DE72SZ3jQhIKGNMHhVecWF4NPaTF5zBwkeuYcXGC/flfMO1YPZsKyOLhkAGCbWYT0OxEYx6lsD0cIJ2I+SDa5u9+gOvcf9eNPD81QPUUe8eWjnzBXO8nFtbBFQA3tkwKO3m7aitjbsAXV6F5YpJaWA+sqv4UAw1QzbFRJMRMaN1brOng7+dRby0BGubIGMN2hqtUZKkb2uIP61Nj8WS1DmvrQzZaJOiUNfjjsZ5OvKrG4OHi8qiBx0NwSL3PROZbWzvIc1jT2TpEsIRfp6TAh3mYdQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199015)(38100700002)(83380400001)(166002)(122000001)(33656002)(55016003)(86362001)(478600001)(38070700005)(8936002)(5660300002)(2906002)(52536014)(8676002)(4326008)(66556008)(64756008)(66476007)(76116006)(66446008)(66946007)(41300700001)(76236004)(82960400001)(186003)(9686003)(6506007)(107886003)(26005)(53546011)(316002)(54906003)(966005)(71200400001)(110136005)(7696005)(66899015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D9ck5jERs11ZQYVn1hUq1Agb6Id5rNXO+pHdoqoW3SM+S0b2YzDhAy79euO5?= =?us-ascii?Q?9z8w3a5oNMolxeqgo6FI5t/IGjaWpU4wk+Kq6EmtYKl5GmAiQw1p9k12tIw7?= =?us-ascii?Q?tjgDGDIb3qijYsMfgE+PyIR4q41ZeEZgwKmYoWJ4YLEgyt6+w5gZDYURpXym?= =?us-ascii?Q?DR5LtOz09pKBLE8KFj341UPwCpvE4HHaLqr5HC/B192NGYGAZy+6G8/akGK4?= =?us-ascii?Q?INQTfRI16ZUvx/yW4/z8wNhGGAdZCPbMHYMiOWdC4KGbNl5rezkwoHVRwM3h?= =?us-ascii?Q?rG1dF8L7Bl61JtrA8rfV5bu7SacwJDBE8O7+5G8T0CR3hYtdqs0vJ7QArhHb?= =?us-ascii?Q?akzT0ZLcGOI1oOOMe9jWHofeee6KwQzSu/YOWZo0Kk0Ywnik1+X+Q+8GFrlM?= =?us-ascii?Q?ZBiVm2+qcxPg4sLMGgdV4NGaQ96UYxi/HsVy9dh9Cdr2jb1IU+O32RPAhlZR?= =?us-ascii?Q?fawtFu5mXWvNYKK2EreexZfqVR3o5Mv7vEqj3UjSfudZWNErwHRU+PwNtfji?= =?us-ascii?Q?XzdkNKD20FWF3zmtBrkUJO/0yNqmvG0vreiDlteXndISD8S8BiIK42cNCRt+?= =?us-ascii?Q?FYFX5JqjYGhZWvSuTtW+qN6yxZUc3oBytyNT1EfOh9Z71st5zCPz7vnSF0z7?= =?us-ascii?Q?HFDnrgCL7bFpV8zaCLTNvxb0ZKqoN0HMlZRHwwWzOcp8f+ONfySIW3cvR2Zy?= =?us-ascii?Q?KLf/b+XQ8XN02cB/AiB5jrway/pLUsQ+v8+WtGD9Vz4as0y6QSr0iOwy9VuC?= =?us-ascii?Q?Cq+dWAjVA7V8Z6qc67v2dxDSWGi3vku1nvWZgAhyTNYdh5jsMmK1kIJhJKHP?= =?us-ascii?Q?E4SQZZPpeqE5V7GM17hH+iGdamT0cTICIhCFejuTULPNep+AzAGC5Vsl24OK?= =?us-ascii?Q?61fMqrBq9VCDHBtTcFseon3NM+1O3Yh8oonGfu9G2vvcx2hHeLLiOMb9Qu+i?= =?us-ascii?Q?uUpSsAWElZjsKRJuhYzCovGg0DSAITcjIXwKb6eA0uJnu+2i9K5501zE6ohy?= =?us-ascii?Q?lRQTgYz9GAauLOmxq90ai5IhJWPzkmCKx1gTId23VZyflW2NrojVrkO+DBul?= =?us-ascii?Q?3WO9ulprSNNCCMqjAF1kc0F0Ddw8GGHNg15fnRhS5oPvHr9zqO8ikjHCkcgW?= =?us-ascii?Q?5EwpWiptdE64Re0eB4yqCIgQnuooSSV3MkHkIjtHZRxB7GgwYQgLI4Ur1BAD?= =?us-ascii?Q?nVUlClExCr6GG/eVT2SLs7K0E9T4aoUZY4pMGsJqU5Dwoj7bi+yq4+hp7JYl?= =?us-ascii?Q?7ayCreH3cdEdHqXt3QK57rEz9lWGk2tCBi7SqUL+Qtzc9coimG7AULm4UI9I?= =?us-ascii?Q?8QuwgVW6FhJbkJ0NZH1ssT/bMoFxEr4rj6YoFdd9V+d4jgKXygctaqjfN8Nh?= =?us-ascii?Q?DcAg47wbwX5fTHvLj9E69dnMXQ8iMv/pKKR3P0pMTMNGgnEZVGEn9+YPSl2B?= =?us-ascii?Q?/VvBNEMhfWZqWATKuQKXjQ9JBsP/oPrbGdPJr3JmQuUphzElNRYeuBz6VSps?= =?us-ascii?Q?SJ0E9TyCRzktk4j/bRcTasAJy0v/qM/OHGbdqvS7+5pnMMSNN86SLhd6DGqq?= =?us-ascii?Q?KNuvXlgUhMLrtR4HTrC54NIAlrl0c/9DWEWTzCt7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8525ad37-b9ed-4141-6e62-08daf84a1913 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 05:17:15.8006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SKSWgdsHNnMZp7e0tdjQV35ekUwSTriBakECYgyPCKvnIthh6JgX0tN+PrTJV7keJ4N4xS/tLM3wXcyU1+h3+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7470 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR11MB58630D2AA7F00F53DAAE0050C9C69PH7PR11MB5863namp_" --_000_PH7PR11MB58630D2AA7F00F53DAAE0050C9C69PH7PR11MB5863namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Konstantin, The patch missed "Signed-off-by:", I help you add it and open a PR https://= github.com/tianocore/edk2/pull/3909 for merge. Thanks, Bob From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Tuesday, January 17, 2023 1:05 PM To: Jake Garver ; Konstantin Aladyshev ; devel@edk2.groups.io Cc: Gao, Liming ; Chen, Christine Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM = build Reviewed-by: Bob Feng > From: Jake Garver > Sent: Wednesday, December 14, 2022 2:48 AM To: Konstantin Aladyshev >; devel@edk2.groups.io Cc: Feng, Bob C >; Gao, L= iming >; Chen, Ch= ristine > Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build Thanks, Konstantin, I approve this version. Thanks, Jake ________________________________ From: Konstantin Aladyshev > Sent: Tuesday, December 13, 2022 11:22 AM To: devel@edk2.groups.io > Cc: bob.c.feng@intel.com >; gaoliming@byosoft.com.cn >;= yuwei.chen@intel.com >; Jake Garver >; Konstantin Aladyshev > Subject: [PATCH] Fix cyclic dependency error on OptionROM build External email: Use caution opening links or attachments EDKII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID =3D <...> PCI_DEVICE_ID =3D <...> PCI_CLASS_CODE =3D <...> PCI_REVISION =3D <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files to fix the cyclic dependency. --- BaseTools/Conf/build_rule.template | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..21ccd864fa 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,7 +342,6 @@ $(OUTPUT_DIR)(+)$(MODULE_NAME).efi - $(DEBUG_DIR)(+)$(MODULE_NAME).efi $(OUTPUT_DIR)(+)$(MODULE_NAME).map -- 2.34.1 --_000_PH7PR11MB58630D2AA7F00F53DAAE0050C9C69PH7PR11MB5863namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Konstantin,

 

The patch missed “Signed-off= -by:”, I help you add it and open a PR https://github.com/= tianocore/edk2/pull/3909 for merge.

 

Thanks,

Bob

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Bob Feng
Sent: Tuesday, January 17, 2023 1:05 PM
To: Jake Garver <jake@nvidia.com>; Konstantin Aladyshev <al= adyshev22@gmail.com>; devel@edk2.groups.io
Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine &l= t;yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on Opt= ionROM build

 

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

 

From: Jake Garver <jake@nvidia.com>
Sent: Wednesday, December 14, 2022 2:48 AM
To: Konstantin Aladyshev <aladyshev22@gmail.com>; devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.fe= ng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build<= o:p>

 

Thanks, Konstantin,<= o:p>

 

I approve this version.

 

Thanks,

Jake

From: Konstantin Aladyshev <aladyshev22@gmail.com>
Sent: Tuesday, December 13, 2022 11:22 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: bob.c.feng@intel.com= <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn &l= t;gaoliming@byosoft.com.cn&= gt;; yuwei.chen@intel.com <yuwei.chen@intel.com>; Jake Garver= <jake@nvidia.com>; Konstantin= Aladyshev <aladyshev22@gmail.c= om>
Subject: [PATCH] Fix cyclic dependency error on OptionROM build

 

External email: Use c= aution opening links or attachments


EDKII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
  ...
  PCI_VENDOR_ID         &= nbsp;        =3D <...>
  PCI_DEVICE_ID         &= nbsp;        =3D <...>
  PCI_CLASS_CODE         =         =3D <...>
  PCI_REVISION         &n= bsp;         =3D <...>
```
Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698
("BaseTools/Conf: Fix Dynamic-Library-File template") it is no lo= nger
possible.
The build system fails with the error:
```
Cyclic dependency detected while generating rule for
"<...>/DEBUG/<...>.efi" file
```
Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output = files
to fix the cyclic dependency.
---
 BaseTools/Conf/build_rule.template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template
index af4819de92..21ccd864fa 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -342,7 +342,6 @@


     <OutputFile>

         $(OUTPUT_DIR)(+)$(MODULE_N= AME).efi

-        $(DEBUG_DIR)(+)$(MODULE_NAME).e= fi

         $(OUTPUT_DIR)(+)$(MODULE_N= AME).map



     <Command.MSFT, Command.INTEL, Command.CLANGPDB&= gt;

--
2.34.1

--_000_PH7PR11MB58630D2AA7F00F53DAAE0050C9C69PH7PR11MB5863namp_--