public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"pierre.gondois@arm.com" <pierre.gondois@arm.com>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH v2 02/17] BaseTools: Remove duplicated words
Date: Sat, 1 Oct 2022 15:08:11 +0000	[thread overview]
Message-ID: <PH7PR11MB586323146B2A5CFBB79BA0CAC9599@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220906082912.81795-3-Pierre.Gondois@arm.com>

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois
Sent: Tuesday, September 6, 2022 4:29 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois <pierre.gondois@arm.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [PATCH v2 02/17] BaseTools: Remove duplicated words

From: Pierre Gondois <pierre.gondois@arm.com>

In an effort to clean the documentation of the above package, remove duplicated words.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 BaseTools/Source/C/Common/FirmwareVolumeBuffer.c    | 6 +++---
 BaseTools/Source/C/DevicePath/DevicePathUtilities.c | 2 +-
 BaseTools/Source/C/GenFv/GenFv.c                    | 2 +-
 BaseTools/Source/C/VfrCompile/Pccts/antlr/mrhoist.c | 4 ++--
 BaseTools/Source/Python/Ecc/EccToolError.py         | 2 +-
 BaseTools/Source/Python/build/build.py              | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/BaseTools/Source/C/Common/FirmwareVolumeBuffer.c b/BaseTools/Source/C/Common/FirmwareVolumeBuffer.c
index 70741c8afcb5..ace26eb71c6b 100644
--- a/BaseTools/Source/C/Common/FirmwareVolumeBuffer.c
+++ b/BaseTools/Source/C/Common/FirmwareVolumeBuffer.c
@@ -91,7 +91,7 @@ Routine Description:
 
 Arguments:
 
-  SourceFv - Address of the Fv in memory, this firmware volume volume will
+  SourceFv - Address of the Fv in memory, this firmware volume will
              be modified, if SourceFfsFile exists
   SourceFfsFile - Input FFS file to replace
 
@@ -141,7 +141,7 @@ Routine Description:
 
 Arguments:
 
-  SourceFv - Address of the Fv in memory, this firmware volume volume will
+  SourceFv - Address of the Fv in memory, this firmware volume will
              be modified, if SourceFfsFile exists
   SourceFfsFile - Input FFS file to replace
 
@@ -285,7 +285,7 @@ Routine Description:
 
 Arguments:
 
-  SourceFv - Address of the Fv in memory, this firmware volume volume will
+  SourceFv - Address of the Fv in memory, this firmware volume will
              be modified, if SourceFfsFile exists
   SourceFfsFile - Input FFS file to replace
 
diff --git a/BaseTools/Source/C/DevicePath/DevicePathUtilities.c b/BaseTools/Source/C/DevicePath/DevicePathUtilities.c
index 2ffefa8ceeef..49078aac8caf 100644
--- a/BaseTools/Source/C/DevicePath/DevicePathUtilities.c
+++ b/BaseTools/Source/C/DevicePath/DevicePathUtilities.c
@@ -37,7 +37,7 @@ CONST EFI_DEVICE_PATH_PROTOCOL  mUefiDevicePathLibEndDevicePath = {
   @retval TRUE        DevicePath is valid.
   @retval FALSE       DevicePath is NULL.
   @retval FALSE       Maxsize is less than sizeof(EFI_DEVICE_PATH_PROTOCOL).
-  @retval FALSE       The length of any node node in the DevicePath is less
+  @retval FALSE       The length of any node in the DevicePath is less
                       than sizeof (EFI_DEVICE_PATH_PROTOCOL).
   @retval FALSE       If MaxSize is not zero, the size of the DevicePath
                       exceeds MaxSize.
diff --git a/BaseTools/Source/C/GenFv/GenFv.c b/BaseTools/Source/C/GenFv/GenFv.c
index 43cc5cd3fe82..a742d55e5270 100644
--- a/BaseTools/Source/C/GenFv/GenFv.c
+++ b/BaseTools/Source/C/GenFv/GenFv.c
@@ -299,7 +299,7 @@ Returns:
         return STATUS_ERROR;
       }
       if (TempNumber == 0) {
-        Error (NULL, 0, 1003, "Invalid option value", "Fv block size can't be be set to zero");
+        Error (NULL, 0, 1003, "Invalid option value", "Fv block size 
+ can't be set to zero");
         return STATUS_ERROR;
       }
       mFvDataInfo.FvBlocks[0].Length = (UINT32) TempNumber; diff --git a/BaseTools/Source/C/VfrCompile/Pccts/antlr/mrhoist.c b/BaseTools/Source/C/VfrCompile/Pccts/antlr/mrhoist.c
index b57f5ded846c..bf3dd18eaf6f 100644
--- a/BaseTools/Source/C/VfrCompile/Pccts/antlr/mrhoist.c
+++ b/BaseTools/Source/C/VfrCompile/Pccts/antlr/mrhoist.c
@@ -714,7 +714,7 @@ Tree *MR_compute_pred_tree_ctxXX(p)
     if (p == NULL) return NULL;
 
 /* this appears strange: why do we OR the context
-   of and AND predicate ?  It is because of the way
+   of an AND predicate ?  It is because of the way
    that predicates are evaluated: if the context is
    wrong then it's the same as if the predicate was
    true.  That means that even when one leg of an @@ -1531,7 +1531,7 @@ Predicate * MR_find_in_aSubBlk(alt)
  *      1.  if lookahead for alt i is contained in the lookahead for any
  *          alt j then ignore semantic predicate of alt i
  *      2.  if lookahead for alt i is not contained in the lookahead for
- *          any alt j then add add predicate i to the OR list to be hoisted
+ *          any alt j then add predicate i to the OR list to be hoisted
  *      3.  if lookahead for alt i overlaps the lookahead for some alt j then
  *          add a dummy semantic predicate for alt j
  *
diff --git a/BaseTools/Source/Python/Ecc/EccToolError.py b/BaseTools/Source/Python/Ecc/EccToolError.py
index d97bf7948ce8..2ff36c8329cc 100644
--- a/BaseTools/Source/Python/Ecc/EccToolError.py
+++ b/BaseTools/Source/Python/Ecc/EccToolError.py
@@ -186,7 +186,7 @@ gEccErrorMessage = {
     ERROR_META_DATA_FILE_CHECK_BINARY_INF_IN_FDF : "An INF file is specified in the FDF file, but not in the DSC file, therefore the INF file must be for a Binary module only",
     ERROR_META_DATA_FILE_CHECK_PCD_DUPLICATE : "Duplicate PCDs found",
     ERROR_META_DATA_FILE_CHECK_PCD_FLASH : "PCD settings in the FDF file should only be related to flash",
-    ERROR_META_DATA_FILE_CHECK_PCD_NO_USE : "There should be no PCDs declared in INF files that are not specified in in either a DSC or FDF file",
+    ERROR_META_DATA_FILE_CHECK_PCD_NO_USE : "There should be no PCDs 
+ declared in INF files that are not specified in either a DSC or FDF 
+ file",
     ERROR_META_DATA_FILE_CHECK_DUPLICATE_GUID : "Duplicate GUID found",
     ERROR_META_DATA_FILE_CHECK_DUPLICATE_PROTOCOL : "Duplicate PROTOCOL found",
     ERROR_META_DATA_FILE_CHECK_DUPLICATE_PPI : "Duplicate PPI found", diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 07187c03618a..51fb1f433eb7 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -205,7 +205,7 @@ class MakeSubProc(Popen):
 #
 # This method will call subprocess.Popen to execute an external program with  # given options in specified directory. Because of the dead-lock issue during -# redirecting output of the external program, threads are used to to do the
+# redirecting output of the external program, threads are used to do 
+the
 # redirection work.
 #
 # @param  Command               A list or string containing the call of the program
--
2.25.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93193): https://edk2.groups.io/g/devel/message/93193
Mute This Topic: https://groups.io/mt/93496599/1768742
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com]
-=-=-=-=-=-=



  reply	other threads:[~2022-10-01 15:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06  8:28 [PATCH v2 00/17] Remove duplicated words PierreGondois
2022-09-06  8:28 ` [PATCH v2 01/17] .pytool: " PierreGondois
2022-09-06  8:28 ` [PATCH v2 02/17] BaseTools: " PierreGondois
2022-10-01 15:08   ` Bob Feng [this message]
2022-10-03  7:59     ` [edk2-devel] " PierreGondois
2022-10-08  2:22       ` 回复: " gaoliming
     [not found]   ` <1719FA81E323AB08.30932@groups.io>
2022-10-02  3:25     ` Bob Feng
2022-09-06  8:28 ` [PATCH v2 03/17] CryptoPkg: " PierreGondois
2022-09-06  8:28 ` [PATCH v2 04/17] DynamicTablesPkg: " PierreGondois
2022-12-13 14:37   ` Sami Mujawar
2022-09-06  8:29 ` [PATCH v2 05/17] EmulatorPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 06/17] FatPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 07/17] MdeModulePkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 08/17] MdePkg: " PierreGondois
2022-09-06 18:50   ` Michael D Kinney
2022-09-06  8:29 ` [PATCH v2 09/17] NetworkPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 10/17] PcAtChipsetPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 11/17] RedfishPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 12/17] SecurityPkg: " PierreGondois
2022-09-06  8:37   ` Yao, Jiewen
2022-09-06  8:29 ` [PATCH v2 13/17] ShellPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 14/17] SourceLevelDebugPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 15/17] UefiCpuPkg: " PierreGondois
2022-09-06  8:29 ` [PATCH v2 16/17] UefiPayloadPkg: " PierreGondois
2022-09-12  4:26   ` [edk2-devel] " Guo, Gua
2022-09-06  8:29 ` [PATCH v2 17/17] UnitTestFrameworkPkg: " PierreGondois
2022-09-06 18:47   ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB586323146B2A5CFBB79BA0CAC9599@PH7PR11MB5863.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox