From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F385C941263 for ; Tue, 29 Aug 2023 08:45:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sbhkZVdDyA+K/Kf5Rckt1PSPZRPnhNHQAphf3Wu2Vcg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693298726; v=1; b=vbq10CqYq6uMjbtei+ph4FfmX95uQpWOLgNKlISXEcraFAmVN6Yng9NrJPlybu2y+aqeFdB1 Ib97qqgQ5OYJ2C3HKOvtnmCu6lHw3CCGw4ufZF/7RAHgfVyjFbzZEGGtll/4vXcg3nm5JvOlQ3q XloV/RGAZz3ciMofLfsMEWl0= X-Received: by 127.0.0.2 with SMTP id 0HLfYY7687511xfAd8gEMFhT; Tue, 29 Aug 2023 01:45:26 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.13090.1693298725769958500 for ; Tue, 29 Aug 2023 01:45:26 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="441662345" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="441662345" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 01:45:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="741734454" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="741734454" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 29 Aug 2023 01:45:24 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 29 Aug 2023 01:45:24 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 29 Aug 2023 01:45:23 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 29 Aug 2023 01:45:23 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 29 Aug 2023 01:45:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nF5UKql72S0BYSUmRapBY9XZB4xsTdRwGkDXBJCeKukD/uSnxOlbAnT5dxRtjTnZBh5FET07K0tl83CbepmxKwcw5re5feAmVpag1tkP02eW/wWejubMMFCRqC32kvOQAU7ngRE5D7KFwnbgmCZHGpAfCiwCFd72xrQe9DkFDH4KtyZxthWuakk6w7t9hnqYkQ6tEMSRW2h89EeG72pMEbfqZklYH3l8kvVlHu52hBBVCFl80RgMx4Xtemtq+dPFti5o6uwoD12dS+sLjAS2uSznME7Q3HS1bYTTsDyRys8M9quKaWyiwsaFsYMZH8liDgFDbrp3KPSjWwGrZWLZzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zT299iNTvmRzAg0mBEDwtNiqqwrc7LKuONagnQUyhC8=; b=nXpWMaI2xbfQhmyvXr7AI4uQbN7g2VLMgSxt9+oV+phJ1VM++KQVWU0ezvFOjGSpcjlT01Cobie67/w44wStyP0fLJp1ZteEGl6XxUczkKdKHS3SYf5CxHN5dVO4Na2J8Jo4XsN76hfyoE6cVkjrCO25atIcdxV6jjKDjheWgE03pg4pey1nwYhZs5O2V3rB7b/2ADJo8nW8kHiabyflqG1Hvl+6RI+UnogMGq7xPZVCNCkIcSlfuh9ZPMNLXkwMikcKBNLpQnw7ZPyf2ygxiycAQUvuIMKR/lLJAjhbFA9j0E//kt9VIQPLz30OL/Iyz52oOOPOOzsrrSPUH6Jewg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by BL1PR11MB5462.namprd11.prod.outlook.com (2603:10b6:208:31e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35; Tue, 29 Aug 2023 08:45:20 +0000 X-Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::ec:877e:9aea:7dab]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::ec:877e:9aea:7dab%5]) with mapi id 15.20.6699.035; Tue, 29 Aug 2023 08:45:20 +0000 From: "Bob Feng" To: "Srinivasan, ManickamX" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Chen, Christine" , "T V, Krishnamoorthy" Subject: Re: [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Topic: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Index: AQHZ1ZOluudmz2x8jkSduH5Ncwc0f7AA/utA Date: Tue, 29 Aug 2023 08:45:20 +0000 Message-ID: References: <20230823072919.23372-1-manickamx.srinivasan@intel.com> In-Reply-To: <20230823072919.23372-1-manickamx.srinivasan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|BL1PR11MB5462:EE_ x-ms-office365-filtering-correlation-id: fdb460e2-ff81-4050-df5d-08dba86c4736 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: X/C0GXASo9nDfyWfwEGEtvHBkRNaobUCpKUXjMrymlTEFrrNUI3sqPcR2rQzV6hu7bsYURJgYY0CiLyA6nB5MksIF4tMv8ch//bNggRIG+glYFsIClK6s7kBQ+Mc6la/qDqzcP0KV+CYnxY+4DHWoZUXo30gahXREXl47nUFTs9wDb4OL7CyyPMnf4dJcJfOKmu3xArq/fP6z7VX1T4+0Fd6lygGhCOZIouErSbMh7tFVQltmddmFnF2gKMNqGmWb4UVX1UMLc4fqdz0vY9p1fzxINkFftEAsZQIXcczRwCOYFiYZL8zTLaW2P1wSPYzD30NCBy18i6RMmfMC0dRGZpVRfEAwsDxlZ3Jmh2SQ+QfgScPdYxA0vxCGOVD4HMWLokZB/g6v1gR1GA/+ZdhJbLO+jOyVszW0TuHf+ZCC5+labz+FvkPCrsY9iCLBsm2gk5abwn0X6RunOhLwZ+EhTY8oXAblcZmz017GmI0mUjFg2Y5XCsymoYT1EQVozq15cfw+hNx7XLHq4C6hkhaVjk+drlDlDbP3vNbGB+1vFHWsaybQVmd4A1SNSn8ReKBAdJDSIOYG6ZzWsYyQhzktar717T1pGbpOP6NWURYsY2OZtO2eH0HIJbza3OzmAd5KWG/iRz+tq43GvDkIUjINw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3JvKr0toze8fOgE27/vt53DiC+SaErP4rXpgQcIE90RULvaiOaJjxvYEntVs?= =?us-ascii?Q?Uez01tV2OW+6x/Kmj3S2wupmV0nNQcCKklfDqwqsYdhe5iRGCduOG+CjaCaP?= =?us-ascii?Q?BHvyo5WJkQQ8kMF+Bjb5+h3wusInz2wrpJsIVKls64KfCiCwE8c/MqVO5dok?= =?us-ascii?Q?nKiq3YGjrWlAReS/E7xQw4CkPwy8C6cOBOOY4iBCekdAwHzZj1S+PZ7e74qU?= =?us-ascii?Q?tuEcHKDE8nQKaaBuASz4F1VrvUFpgZ9ckzGqctTnWYGPR+qXt5UI6UEqlVfl?= =?us-ascii?Q?J6F8NYZY5C2zlvEhgWy8Xl6VanFh7wdMRsX8CAd+9dqKpzc6O2VoBjmqI3co?= =?us-ascii?Q?kTfSktzwWoa81byBE30oZXuUMNX1rOD4AYqSNMNs4enlz0Wh9OYl7lgmeZ3p?= =?us-ascii?Q?6NWvGamDSgCd8QeTjAkti2/CsU8erNxuvgZrj2CwX2oUxEUdXpUZiVEGzBSE?= =?us-ascii?Q?jNZCe4OtuN7UR9H1hiGFawYmDqHJDHs7JiQgpWZwOToVNgKa0iyK/ktKGMxo?= =?us-ascii?Q?Zyeh8LzE8WXXz/4UVqg7ubwdmclse3qcc40SCAMr4sjdQdE/Vv9cN/vgkCff?= =?us-ascii?Q?beRn/KJw0OKC7IeNbX/GYVTp0InoPLbtItNsyPtM5ONpUVQsb5+k1EtY15/K?= =?us-ascii?Q?eee+pO7Tswondg5UUxjAObjNrUYozV1yy0HYsNrvORBN68IM0aa7H0HkJ/0f?= =?us-ascii?Q?/Ze0PXQg8Nc1teI8FpExnwfX0PkykmjLimLQc6JTAOMpg8NaaeeIHf0BBZ6Y?= =?us-ascii?Q?fXvG8+JIBNLuiQqVmzv66gb7UCeTR2OyRph8KNM35XVQtxpgsiZrJuLrZF1A?= =?us-ascii?Q?x+LSm4K0B6mTyvq1B6OXA1YfmeBpsrm3E5L3Wm+NSFfrGp5n7DtMvQo0hFY1?= =?us-ascii?Q?O/zLsJXmzMaaN/BEpcL714TPEZssDpywwQ9x0GIdU6f5iAKhVXsbZN0pTeIn?= =?us-ascii?Q?wwg3F6ZJtCrNIBz1GREbuyUOLPxgzj+xSgloKQ5Kn/XSMMrOMtbdIO0f0GL5?= =?us-ascii?Q?HdHNtzacc6GFdo8BsBD+ejdsDkNHdra+JaIhSVkRDqoTtQMN87mlKPsLrfXk?= =?us-ascii?Q?1SEoDXHJIz1NUXhc/X0eVcLZqRSEnFeXPlrMBBovk81bAZ4CJ3qeJaJPocuf?= =?us-ascii?Q?nkwoO5nGbPOQaUCZm0AjE8g0bUHEeMCBLFVtKVNgVp5FHt+McHrITiAyx1l/?= =?us-ascii?Q?ClntmjnLSdUpFzJW7EbKr7TXmy8N7dWat/Zsaf6Rwh1bicsJJ6aF7tF3rToq?= =?us-ascii?Q?hgo4BzDRGEnaDwMS2ReNz+P0BAWidlcPjAGtEy4GA9PfM7QS1oIEka8BZMbj?= =?us-ascii?Q?LA35FTzR8L1SzQoLrbBBZ/m1JS5Cj2m4kGDNBZy0taGkcAWs0T9+YSlsAvZJ?= =?us-ascii?Q?FqYg+XEDdXgPHY8/MAZV0AfeGkK5LlrHQVOwJUaVvr9WOLgFcZf+vdDMd7Ce?= =?us-ascii?Q?9KPIdBLF/q5/Ij/aTVbwwfvFzP5qWDqQGaZl1aLRMCr0cETx4PLYlmjVjJod?= =?us-ascii?Q?jJ08rRZ2Io0tWdNzLyhIgVDBeJrdQUD4etyLg+cQL675pI7/maKeRlIw8g?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdb460e2-ff81-4050-df5d-08dba86c4736 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2023 08:45:20.7180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HyDsTkXH1N35fKNpB8+Gp10RaoZsh0AuIOlR4Z7DbQDVHF81vkf0d+JZpHhHrqcEUWRyMTrQS/BcLwaA7r9nRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5462 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bob.c.feng@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: by97A5odqGm9tSmJC6Un30Tvx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vbq10CqY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Bob Feng =20 -----Original Message----- From: Srinivasan, ManickamX =20 Sent: Wednesday, August 23, 2023 3:29 PM To: devel@edk2.groups.io Cc: Srinivasan, ManickamX ; Feng, Bob C ; Gao, Liming ; Chen, Christin= e ; T V, Krishnamoorthy Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE supp= ort The length of the Board ID is being updated based on the BOARD_ID string. I= f the PCH_TYPE is empty space/single quotes(''), removing the empty space/s= ingle quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag= strings. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: T V Krishnamoorthy Signed-off-by: ManickamX Srinivasan --- Platform/Intel/Tools/GenBiosId/GenBiosId.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/T= ools/GenBiosId/GenBiosId.py index f823fdcad..fa3689867 100644 --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py @@ -142,7 +142,13 @@ def ParserInputFile(InputDict, NoTimestamp): EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=3D_ConfigItem= Invalid % Item) _ConfigItem[Item]['Value'] =3D InputDict[Item] if len(_ConfigItem[Item]['Value']) !=3D _ConfigItem[Item]['Length'= ]: - EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=3D_ConfigLenI= nvalid % Item) + # The length of the Board ID is being updated based on the BOA= RD_ID string + #If the PCH_TYPE is empty space/single quotes(''), removing th= e empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT= and BUILD flag strings + if(_ConfigItem["BOARD_ID"]['Value'][3:5] =3D=3D "\'\'"): + _ConfigItem["BOARD_ID"]['Value']=3D_ConfigItem["BOARD_ID"]= ['Value'][0:3]+_ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID= "]['Value'])] + _ConfigItem["BOARD_ID"]['Length']=3Dlen(_ConfigItem["BOARD= _ID"]['Value']) + else: + EdkLogger("GenBiosId", FORMAT_INVALID,=20 + ExtraData=3D_ConfigLenInvalid % Item) for Item in _ConfigItem: if not _ConfigItem[Item]['Value']: EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, ExtraData=3D"Item= %s is missing" % Item) -- 2.30.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108085): https://edk2.groups.io/g/devel/message/108085 Mute This Topic: https://groups.io/mt/100916084/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-