From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.202986.1672310813018560065 for ; Thu, 29 Dec 2022 02:46:53 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=c9a/FPYE; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672310813; x=1703846813; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4llE+UDExfazcxyxdUaBwwypglhVO1eJmEWxdUBvWnw=; b=c9a/FPYEOxGLFPrLPWHGmrWxwqmfl5eQW/wm8RXuvHZ32D79h50yffgh JreaZSbLSrBG20SuAOD/PE+AkutcFyboCWxt/9YOi/YMmtXL/Vr8gCBQv n+pUDydDovXmRmzW95ihPrAkjLKjWxWsoGii+8I9uJIjqum1yWTYQc0ee 43kGq6P3dZ+AFKV5OClA7qBNHwOj2Dyt6yJUAP0cAvEoIbAEiumu/DMs/ h75z8bniQU/hG5qrrcPWrX+rhPnKpWHDIkjGOljLSfjGVfHchmgq0KN/q F9NbVkg31Og4r0MULTS1LcD0xlgFviazQlmT+j23ZuqG05Y2n8bqrVa0f w==; X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="407285898" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="407285898" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2022 02:46:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="795939168" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="795939168" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 29 Dec 2022 02:46:51 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 29 Dec 2022 02:46:50 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 29 Dec 2022 02:46:50 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 29 Dec 2022 02:46:50 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 29 Dec 2022 02:46:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rrip5lDuILBmxlZskrLY736T3vdCJiVk6srvEy77b6x6/oQ+WSVu/z/MG7Qv60pj8X/+Fkzk0TlO7AaKCDAo8qACeQschp7LpUPppH9KvsyljgVmaYm61Fw8FiCIX4B0d8wjdhBxCnxG8EXNspKLbmkXiqNPMc6nt5jmNPSU4Ui8OcCbThSQEEv1/QpS3tyhN6QeaSsLItrrOE7SQ8i03EQFN9r/NAwj5sY9CZBsQsjfsasMxXDmAy+OX4hB+W+BCxURayWSUe8d0+S2ljTGAD8iPB1S1ZkgICwmBXrihiq2DzWjkp7OUb5GPkij4G1Ofe/Gb/r9Gyq4vL9VtzXsaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M7fKbLPscaroNE5cdeoIxTwcj1Wdi60Ky3QPozUJ1R4=; b=N0j7f7GqV85SWbh91jAi2AHT3vacRnwokYZYeu3D+IT/CCWJ3oBd/PMglC6C5QewHldcJSC5UD59Z6saia0KRxkVMZHFgYcO9riyHn2Ax+mlqp7C0zIwuC+GZ2q3od7TAEEBAM79+BIxvNo97L0bXP4jkaG7VYNsI3pGlRahkMlRZj6sSoI7irlIDDB5KTZlaNpbBKE/kJWGLCkw+EilYg0c7ALs8qiwzRUty5fnTQ2FGFmkP8FXT5HYUIrtRPXVtUmYODI+9SFXl/EUexbVFg0ajpUheUzRUoV0cIL/cxoeeHBFzFF+790uzhf0Lf0o4Lg7+AKnnZZv39f5avpZeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by DS0PR11MB7577.namprd11.prod.outlook.com (2603:10b6:8:142::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 10:46:47 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1251:f989:b162:4186]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1251:f989:b162:4186%3]) with mapi id 15.20.5944.012; Thu, 29 Dec 2022 10:46:47 +0000 From: "Bob Feng" To: Jake Garver , "devel@edk2.groups.io" CC: "jbrasen@nvidia.com" , "ashishsingha@nvidia.com" , "Gao, Liming" , "Chen, Christine" Subject: Re: [PATCH] BaseTools: Use BUILD_CC when checking gcc version in DevicePath Thread-Topic: [PATCH] BaseTools: Use BUILD_CC when checking gcc version in DevicePath Thread-Index: AQHZFHUo+zYCXNB7YUuly6CdoE3NDa6EvKVg Date: Thu, 29 Dec 2022 10:46:47 +0000 Message-ID: References: <268c8606bfb6b210c932c7c8978469efaab1c2ac.1671541950.git.jake@nvidia.com> In-Reply-To: <268c8606bfb6b210c932c7c8978469efaab1c2ac.1671541950.git.jake@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|DS0PR11MB7577:EE_ x-ms-office365-filtering-correlation-id: b5b9ef81-ab96-4195-2d72-08dae989fbeb x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pGBIz1YzoQTAlQLhlMbmbCCUdCNmvo4Tp5fipdx+anMTSYgLoEb+FmEGbqwznSViygfTRxwecW17mmLFDByFqcMXc6aGI6IHiXUb+m2A5wpC9MKluAKEf/71MeYsAzRZhSb5opeudIHxNKdxByBYoX1333Kag+u51p3ulMx83UCK9fEfPV4Q0BNqfIxWJLzkTZ7p0kUgWHbM5W3g+41JfwZ8ZPzFiuxV9sqj4nStMJXHBPzE1wG/YVkUzAWi/K8lqGMDQ3glYamUm1vZlzGna2oYC1OHn3vsbr3DE5hMX+dYtFjbrmqY3OijI5h5H6hP38ZQ3ipGALi6qEHOaWBwY132wuG8NdAZFIihej6HZc1Jlhck/rbInvPQBdhZHfGAn3mdFcSHyA8Bd1Qe6mQoQVuEYMcACEL9yDWw43SE+l4fWPlblSRoW1ZTfcda8xkWt8pmRm98MW9WFlECpB0YIzwqWI2d3aWwfwiRyhEl6qCEEG3MGKyUR9iuv+7pJf9NZ9Nf2opUMvRzp9X7s5V9GNtbAFEjufNMQxG7rJqFRlWR/vfVYIU92en/SZBesIgzAoTAx8XLPp6OsJH/AQqIuW2OUiNSgilh2jBO+GjIqlZ/Dqv5pCiepCKD+508/eZAlvdNACHXJv3ikUUFC4RfTWPTOA6+nOs6ev+Ah7Sfa+W6fO1KrE74Dyy9HdXAiSY6fNxhxj0iWs1AateOB6tc+g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199015)(6506007)(7696005)(53546011)(186003)(107886003)(478600001)(83380400001)(71200400001)(2906002)(54906003)(316002)(110136005)(86362001)(5660300002)(33656002)(38100700002)(26005)(122000001)(38070700005)(41300700001)(55016003)(9686003)(52536014)(8936002)(8676002)(66476007)(82960400001)(66946007)(76116006)(66556008)(4326008)(64756008)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UXA22IcwBxEawsODnn6nADzIDeoTkVRk3LvNyRkk4fCrtdp2xzTpp6XZuSyl?= =?us-ascii?Q?rViGIKkA9oHC9J2dHaTvxXalkGl9Xj9sCRj9fcd86bHSUKd/42F393Cg/pl0?= =?us-ascii?Q?WbUpLsxXGa1wjdX0IT+xGPhWstezwdj700rebzvdGw1yTTeHZDU2JUFPngkh?= =?us-ascii?Q?9VOQe4q43OxyVzwIrNGAMt1AROQMNaSVU3So14rDoR80oxC9eLVW+oF096+z?= =?us-ascii?Q?TMS0xrKtRmow1RguK0YotK/5RV5oKLjXztT4+tc6KC0Nhz+dB1IJ2qM+yA/r?= =?us-ascii?Q?yngkyXvs61EBaBN5Q+P7mAZX5QqEXRmZRLqbaqm7eNrmzZBdBTxltZtMJz17?= =?us-ascii?Q?P0UGjeQt5nICZa+aFSYJcYAdz960fjAQ4CtyHsZBoEeTPjk5/DAgm4vR2Bc5?= =?us-ascii?Q?i2w70eo2tR6hPGgcJZtBxfPUQmuDG6BXGLkcROON+nspQ2X2vLBat4GtAiNe?= =?us-ascii?Q?CnYDxHt0YWv4VbARPTmj+NJhmHMrBajSP4e3lWX8hrCg5EkZ5XdBb/yrDLfa?= =?us-ascii?Q?8i3ei6nYhvRWj0VKvaNiS4GZ6XIx/JJfLhbW7lb/Kfq7zALsM1E8krr6g2HU?= =?us-ascii?Q?mfOJyEuhYzishFZ/ht5So6XIgzGAU6LrT6uhO64IxjbQoBloUkz899tk1VgV?= =?us-ascii?Q?Ch+GRHRJR5hCCkT7Tp5N4Kb7dPjfl01jXnUL7AF4Mo86ArCwTrtcmx9KON+O?= =?us-ascii?Q?KtoMJhQ6uQkyityqSqxo/lMWz5AugNAioRMKM+GZgLDv/oZGWbC0/SlNSTTY?= =?us-ascii?Q?iYPZP76E7wAEkUwddZwatBWzJr0ZmszkipTEQa6rVEO2Gics8nkovSPwYpMk?= =?us-ascii?Q?EAv+g4VaaeXhs86wJX0nctgOBoVzAuuXejfes5pLEfjpA2vJP/HRhdkY/KwB?= =?us-ascii?Q?HohX5NzKTFnxVtp6SGj0JMFO2aHeS5g/3FttsJtgH9Me1SaGax3OVTFgMARH?= =?us-ascii?Q?+Up0tuCgtUOLk/3/dBKjf05imQXCOcyi69qhWCSuMTy++mGcTyimn+4Nm5Ce?= =?us-ascii?Q?U83qTygzdhXwelHqHI+h9469fzwTV/L84ASaIofqr0ppLzB6f+DTdFEVa1gO?= =?us-ascii?Q?fnqxCkY4LW3zKJdji88F7a88PPbOn3nS9GjIIKNdBBV+8Dj7KhTJ7tP61njo?= =?us-ascii?Q?dVsW1MTVroL68ll7Lr55FHyZ/hIE65IBCtiJuMW+xoY4dyNDnIHXCHxTUNCY?= =?us-ascii?Q?bdsuyT1dH05hZnIO4O8HIl0iTYehMy4D3O0Zt46d7INa8MOUv9wsUcG35N0/?= =?us-ascii?Q?ZL0++26686Z7dvUn5HZMpW6BjgywuWqO7exHc1BWuS+VOKQrvCdf8lRIrpLf?= =?us-ascii?Q?h5i6YMv3vNiose13lobvaCZxDHJZkCbKfwT6RKouP7wtjfBYqA6Mz3OnOCxV?= =?us-ascii?Q?RoYp5wKh4tHHCCQLb3QuWIZRu6kcWG/mnSEyk2HZLJV1dM1RD6GjyvAZvTT0?= =?us-ascii?Q?undAwsJcn4Jny4LUNAdfxf3o94JD+yIgZ1Llh++a9ILWGuQvkB2xBIzdWVMF?= =?us-ascii?Q?QXWjW3qnpAewfxvkdj2YJRMtOedoBkysIwcJchP2gay9qSsIIQHU5heC/uH+?= =?us-ascii?Q?6eI9gB1U5YlyzMlIP78WxlvSA88JODXUM3PrbC8q?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5b9ef81-ab96-4195-2d72-08dae989fbeb X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2022 10:46:47.2163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xfVVk2ZNmF+gpj5hNrXd6n3Kc+0/Mu4ryCxX4QAYlsuWBqyUURVd5jlYK3a5M/SnqHmhWdGlHC+x5qYyqYrMzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7577 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you for fixing this issue. Reviewed-by: Bob Feng -----Original Message----- From: Jake Garver =20 Sent: Tuesday, December 20, 2022 9:14 PM To: devel@edk2.groups.io Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Jake Garver Subject: [PATCH] BaseTools: Use BUILD_CC when checking gcc version in Devic= ePath When checking the version in DevicePath's Makefile, use BUILD_CC instead of= assuming "gcc". BUILD_CC is set in header.makefile and is the compiler th= at will actually be used to build DevicePath. It defaults to "gcc", but ma= y be overridden. Signed-off-by: Jake Garver --- BaseTools/Source/C/DevicePath/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C= /DevicePath/GNUmakefile index 17f213879e..13b54ead65 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -13,7 +13,7 @@ OBJECTS =3D DevicePath.o UefiDevicePathLib.o DevicePathFr= omText.o DevicePathUtili =20 include $(MAKEROOT)/Makefiles/app.makefile =20 -GCCVERSION =3D $(shell gcc -dumpversion | awk -F'.' '{print $$1}') +GCCVERSION =3D $(shell $(BUILD_CC) -dumpversion | awk -F'.' '{print=20 +$$1}') ifneq ("$(GCCVERSION)", "5") ifneq ($(CXX), llvm) ifneq ($(DARWIN),Darwin) -- 2.17.1