public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: Konstantin Aladyshev <aladyshev22@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [PATCH v2] BaseTools/VolInfo: Show encapsulation sections
Date: Mon, 25 Jul 2022 16:08:51 +0000	[thread overview]
Message-ID: <PH7PR11MB58634309A69F4FA7140B94CBC9959@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220719122917.2749-1-aladyshev22@gmail.com>

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Konstantin Aladyshev <aladyshev22@gmail.com> 
Sent: Tuesday, July 19, 2022 8:29 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Konstantin Aladyshev <aladyshev22@gmail.com>
Subject: [PATCH v2] BaseTools/VolInfo: Show encapsulation sections

Currently there is no labels for start and end of the encapsulation sections. Therefore it is not possible to see where the encapsulation section ends and another section starts.
Add labels for start and end of encapsulation sections to fix the issue.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 BaseTools/Source/C/VolInfo/VolInfo.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolInfo/VolInfo.c
index c1f81f2dcb..ce1775f7fd 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.c
+++ b/BaseTools/Source/C/VolInfo/VolInfo.c
@@ -1903,7 +1903,9 @@ Returns:
         return EFI_SECTION_ERROR;       } +      printf ("/------------ Encapsulation section start -----------------\\\n");       Status = ParseSection (UncompressedBuffer, UncompressedLength);+      printf ("\\------------ Encapsulation section end -------------------/\n");        if (CompressionType == EFI_STANDARD_COMPRESSION) {         //@@ -2022,6 +2024,7 @@ Returns:
           return EFI_SECTION_ERROR;         } +        printf ("/------------ Encapsulation section start -----------------\\\n");         Status = ParseSection (                   ToolOutputBuffer,                   ToolOutputLength@@ -2030,6 +2033,7 @@ Returns:
           Error (NULL, 0, 0003, "parse of decoded GUIDED section failed", NULL);           return EFI_SECTION_ERROR;         }+        printf ("\\------------ Encapsulation section end -------------------/\n");        //       // Check for CRC32 sections which we can handle internally if needed.@@ -2042,6 +2046,7 @@ Returns:
         //         // CRC32 guided section         //+        printf ("/------------ Encapsulation section start -----------------\\\n");         Status = ParseSection (                   SectionBuffer + DataOffset,                   BufferLength - DataOffset@@ -2050,6 +2055,7 @@ Returns:
           Error (NULL, 0, 0003, "parse of CRC32 GUIDED section failed", NULL);           return EFI_SECTION_ERROR;         }+        printf ("\\------------ Encapsulation section end -------------------/\n");       } else {         //         // We don't know how to parse it now.-- 
2.25.1


  reply	other threads:[~2022-07-25 16:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 12:29 [PATCH v2] BaseTools/VolInfo: Show encapsulation sections Konstantin Aladyshev
2022-07-25 16:08 ` Bob Feng [this message]
2022-09-21  1:06 ` 回复: " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB58634309A69F4FA7140B94CBC9959@PH7PR11MB5863.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox