From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.71944.1682394534218842352 for ; Mon, 24 Apr 2023 20:48:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XefBJ6EO; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682394534; x=1713930534; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=1ZbC5TxJSSCl+AFaOaGQyKg495xnpoAgQQ1cQSSlD7g=; b=XefBJ6EOlDg/5uz9mk1+Gjl1J1+FMKCjPjuLHJkzcK0B8uHxJvUtzq9/ 9kgnTYkG8LnAcQhyagPH083nYlBa6kEM81T53Wkcnsy9LgfFZIcNK/chQ Q9u96RUe+j0opym+6RvPPwti2ODnpibmHDOl1SujoiXAh1Z9zjIhN0CHn NCrrWfrrfhTqMD+wjSVt02nAhsGxXHLE4sTNpJ6Z/jUpceNTqVp3J039a 4r62DoScD4Vy8iGG9YvVwhEKoukl9hxVCZhUd7zT2OIJ9868af5SAhshI tR//Jq5mzBWfFamZfAb3a+EzT+GNGTgAY1KWUcwfsbVHNM+fg3b7taUbI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="409582593" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="409582593" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 20:48:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="757948315" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="757948315" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 24 Apr 2023 20:48:52 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 20:48:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 24 Apr 2023 20:48:47 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 24 Apr 2023 20:48:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUppJgPfOKdENYJIWoedlkEK88PHMWfLexI1OUmlRk3HTljjgIamWWSc8hW7/2FEWCM944Lbx5e9Hl4Zc4sGUxPGlOACxeRWVtK4s5wjx+li44/cTjnArigvUzV9bvYM/08bGfqn+6FDL5Ao/d9e4RchOnEN9G+SI67KyyWSm+xjUhgl6A+On7N35Ct1LjBKwCfn6+rwoh+iH4/KNi5rpaWlx0fn6lB6B7AtuJnojyx8O7ZapLIksiSm/UhbEv0OHAXzot+S+ku6Kspd+oWzn0dVBAqukqfrs4BFQCKQdpJGEzEDujwHeAcFp4NOifM6CmFrP++GgMyjB7/WVdBi0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ducwkl1Yb7jPMSN56V4o+Lsj4sFprab3zdPMzQ+jkwE=; b=Oca8smcXdvu5meYtpFEDIkpsu0N2WVfMsvHvVE3h8WyF/nVZBOOpUYsztXVCRSApd1WeZOEBRHNXBH8FuvugNMbVoIN7balzpFhIHknWinlUYENxaQq0t/mFQjj2bJg6wX0vy/X1x7qvcWT/ClEmK58Q26tBe8Lrw3n1fB4wgWFAggSsJJ5gTH3ToT/Bo7eSOfFnEApn5zPT6Kn2otH0ToSWOwjM+Do+uHsWWdVTHfTYy8Ysu/vvyf1JF/XgX8XS8knCN47uJ53n9NZBOAqJEb1aw0ZvJIJtEkpME3LphrQpxQj9R/TXOG1PTB8KYiupaYArl884befL+GyhSbvDtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by SN7PR11MB6970.namprd11.prod.outlook.com (2603:10b6:806:2aa::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 03:48:45 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::946b:1bfc:5b76:6868]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::946b:1bfc:5b76:6868%8]) with mapi id 15.20.6298.030; Tue, 25 Apr 2023 03:48:45 +0000 From: "Bob Feng" To: Rebecca Cran , "devel@edk2.groups.io" , "Gao, Liming" , "Chen, Christine" Subject: Re: [PATCH v2 1/1] BaseTools: Add quotes around OBJCOPY cmd in build_rule.template Thread-Topic: [PATCH v2 1/1] BaseTools: Add quotes around OBJCOPY cmd in build_rule.template Thread-Index: AQHZdrXoV0MJMPLh60qm85a+mp4T+a87ZCIQ Date: Tue, 25 Apr 2023 03:48:44 +0000 Message-ID: References: <20230424140534.1637-1-rebecca@bsdio.com> In-Reply-To: <20230424140534.1637-1-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|SN7PR11MB6970:EE_ x-ms-office365-filtering-correlation-id: 47cd4bcf-33bd-4d7f-317f-08db453ff810 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o+G/2ZPjP2X6yA3XoMldsPa2keyV4j33KogDWSnLEPokjlg+675f/tnYqGLrgkLRgqLejDxoblkaCPIXpBU38TEstke5RhBSu4lhxdyEoUN259LMfckgvbVKOCS3eNqZ39g69yCB0810OWylxz4qOOqok7tXdYMhnDsPfKXH2Bx4cGsUpi6qsH2AaDEKThSYD5rMwDbTWoMXs84nevmMK5ftxgqOJOuE1wlqvfAfkfCwuUqW18j6s+Mu5epBEEbCXuY6skXwwSvbcw5DD5RchnvcNZ4nDhKJWGgDQQmoLtdLOxSBZnUEKRzetLxkcW+6c16CXP5ki2JIxum9t27klkPL32yaEvUr5GyiX6tPcCDwMu3zO8GcrJWXWvAVtag5LStjtXfw2wQVFFw0qwQ9jDc7BG0/Xld7QFNqcB/2YfNr/Mx6tp9V+ksrs9lmmBDukFu883DewKCnfkbsiLowSAq7k8IZu60qYONcIdr8P02GRJiaL0C0yT0VZIUPlQWzozc8dSqEiSV1lapdJawzK97sipE4nhncjPiy/ujQZr3Tdl1ghapPp1pc2MYgzn/YaB+1kUhzO+AGDMf/oLQY5tm4Y0oT7Kmf0GPazj/qMJlTdm0YJPJkdplh0TlZ3+kn x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(136003)(346002)(396003)(451199021)(8676002)(8936002)(38070700005)(110136005)(478600001)(66476007)(66556008)(55016003)(64756008)(66446008)(6636002)(76116006)(66946007)(122000001)(82960400001)(316002)(41300700001)(2906002)(38100700002)(52536014)(5660300002)(86362001)(186003)(6506007)(9686003)(53546011)(33656002)(7696005)(71200400001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LlZfYnjrz7tx/nDda2xY07cSm8T6i1GJ8rm4K4y8BGL6regK12uI+aHDlbe6?= =?us-ascii?Q?6OlzOYkXjawn9LfNn3EBeD8saBgi/Mj0zJIpoMq+JYnFF3l7up3q1alaXY7Y?= =?us-ascii?Q?lgw4krOxbRiYBWptK6/SS9hntl5gYKSK4Nb1nC7eaM/+3ANN5LfPFlLWy4rV?= =?us-ascii?Q?bTCZ2v+A3W6NVwQa5Mq8cy94KQ0foq3qi2fANQRBBTRrEVHjV2s6OShgg1Jq?= =?us-ascii?Q?SzO7KZbczyfm5i59LRr1LwjOp6vA+pIQel9IqkURRog1QBvyc1/CycL1B3/Q?= =?us-ascii?Q?KfSupJU9Mr9G3e7YEEYcm1D4YsudJ4vM8CaCN2/dP1FK4JuHGhnUbu7Fs2Lr?= =?us-ascii?Q?jeykCN8dn9CjAdxr3SjteM7L6ohTEt9ech5cOpCwYZD3BzHpJ6z0A6nB2Huv?= =?us-ascii?Q?DJxJG9KivAbQuoMwGNFRD+h8D/uWnBKUkNj5As54KsbH/rKoC9A0o0a6QUli?= =?us-ascii?Q?89FOTkofbv3NblK/j6Tq1pRyzD2h35sKs/xgKKp6NJ0HVV0DEwuwxOsrEx0V?= =?us-ascii?Q?YpLNIMPHq2unnL2m0w1M61jM31g4S6/E+cqGpz0GUr6dgnkjxU30nGsTSRTE?= =?us-ascii?Q?5uYlPlGfgWCKKOVTiqzeEDNhTgp4PsGf/GIpNYxPKJwG1ldVru5wxOWP4oGy?= =?us-ascii?Q?q8mhqGJt7opQ4VXLuFM2FN7JKB+c5ZTdihG392ch4i3U8lLnHd6bYYuLLC8z?= =?us-ascii?Q?JTNGCML9Qox/7dOBJ/vZfGGRYKCjbb6pLqh9s1FouyDYzzuzRUBbBxyGUCGb?= =?us-ascii?Q?TkuVLrELl4ZxUxG3DoWSExhFP05zTNP90s6pomisULxzUoyJKq7ZkDrQx+1B?= =?us-ascii?Q?NNyIHR9VW79XbKu6txqW2jnqMjTQLGt/oQN6l5P6KJ0l5rkM6TE2fRyKtmyL?= =?us-ascii?Q?uf8DeztitZYzbubu3BEkyosMIIsN9idCcVu1SinxshV1RllW2bm3XBNT87v7?= =?us-ascii?Q?wSPJH3KWeA9OS40ZOFCKq6vSW1dSHUII/eqr4RnKis4TJJlXGJfTwTzeR4BR?= =?us-ascii?Q?1Pa8iL77L/hyzNF97CmSYhs391AuZU/T2cPlJtTY0aqRnbgIAzNTxcfjlXE+?= =?us-ascii?Q?JSWoL+dx9ewIY1WEopCOLnOY4zJScuJ9C+lDHFIvtpEewHqqQD8og0+bpXqr?= =?us-ascii?Q?WAbwY+ry2hUY1A61wo+hQVJGotBdsOv51mYDPbOug21u4dfVEk9tuZ9S8qCF?= =?us-ascii?Q?A1mppf5DiOOETZX/eJAyDIlsKFKdHCKsNK5VknsrsfsWEXJRPy5XO36I0KIi?= =?us-ascii?Q?kOz9f3f5LnJVwWXgZLn8xSxqomiA5TMBG7SFRwA8lwvxcHpfcYxwLDCt1fIC?= =?us-ascii?Q?lUbpqrYUrfhFk4MyRVGingku0nk4dYIk5VA08ksTVQ9zCxcoMt2xDraQQk8h?= =?us-ascii?Q?fiizVbvLBosQx1irA/KaulM8aLzSwBE8CyhyBHCHJa+OqCnmxNnH8TH1YAuQ?= =?us-ascii?Q?6OyH2AnzOMpJgbNlOblNcDhcGcJMTN9oc+5zgcMbQkOgydgM00/qhbIX+jou?= =?us-ascii?Q?cR96v2ATGoH79z86e55BQw0HC6KODbEPevJ++pjsKJ/9EIdGCz9gd5ckXG37?= =?us-ascii?Q?Wb4CN3Q1bApQesYTtO5i0x8Ly6f0lS/ZdpDyeQ5mrAM9ixKaPjN0MLf3+deN?= =?us-ascii?Q?1NrQYERNn971w3KC1C8SjfgUZOZNVLq6WpD9xQugJ/Ut?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47cd4bcf-33bd-4d7f-317f-08db453ff810 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2023 03:48:44.9821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HXRwdPizvP6Kno0qQFBUJoF7VUXlKXkfXUPdFjxDM03egv/vttjYr7ibCed8EK75v+qna7fZvY8UaGe5FXYKXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6970 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Rebecca Cran =20 Sent: Monday, April 24, 2023 10:06 PM To: devel@edk2.groups.io; Gao, Liming ; Feng, Bob= C ; Chen, Christine Cc: Rebecca Cran Subject: [PATCH v2 1/1] BaseTools: Add quotes around OBJCOPY cmd in build_r= ule.template Add quotes around the OBJCOPY command in build_rule.template to fix the cas= e where LLVM is installed on Windows in a path with spaces such as C:\Progr= am Files\LLVM. Signed-off-by: Rebecca Cran --- BaseTools/Conf/build_rule.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index d42e7937cc90..eb64c62060e1 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -352,12 +352,12 @@ -$(CP) $(DEBUG_DIR)(+)*.pdb $(OUTPUT_DIR)=20 $(CP) ${src} $(DEBUG_DIR)(+)$(MODULE_NAME).debug - $(OBJCOPY) $(OBJCOPY_STRIPFLAG) ${src} + "$(OBJCOPY)" $(OBJCOPY_STRIPFLAG) ${src} =20 # #The below 2 lines are only needed for UNIXGCC tool chain, which g= enerates PE image directly # - -$(OBJCOPY) $(OBJCOPY_ADDDEBUGFLAG) ${src} + -"$(OBJCOPY)" $(OBJCOPY_ADDDEBUGFLAG) ${src} -$(CP) $(DEBUG_DIR)(+)$(MODULE_NAME).debug $(BIN_DIR)(+)$(MODULE_N= AME_GUID).debug =20 "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) -- 2.40.0.windows.1