From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.5991.1663845988357202653 for ; Thu, 22 Sep 2022 04:26:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=LqzxYvSQ; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663845988; x=1695381988; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kc90BhWvmsI2DDj2BJAckrTley561ft5v0blFE4MSKE=; b=LqzxYvSQAB/9Ua/2ZyTpnx1quVHUre59kXcnuMCSa8VSGUy1vVGg55li oCoIjkKrjxR/GlsifTtsDpb+6pshEuqLcvem0x72pFHFGx2Yu9bZ+Sm/i 7YudqABs34t30fNhbs2BTyEm/8klLL5yrUEB43oHTZxqFcNkSWTn3P56+ gGVx7jlNGL6geTLBFS+JwrrDYSoX3h4WNMXcxRaPVwSAfcuObAxv7qqt7 Eg5fwraXzCiAIKY4MCNuTXlERGvZt0D8GzQsEJmtKhpv2iF2lTirNVP0F PtRTuTG0mytQ0bv2l6SVQNA+/8cnR3O5SG0lVXIlJ0ieBS75i1GP/7nEa g==; X-IronPort-AV: E=McAfee;i="6500,9779,10477"; a="364250265" X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="364250265" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 04:26:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="745346210" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 22 Sep 2022 04:26:27 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 04:26:26 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 04:26:26 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 22 Sep 2022 04:26:26 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 22 Sep 2022 04:26:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=csN0TEwnCiKouJkW+/ewuN7GS7sqnxqxHmIsowAh9+5KWnCkjd1HIrfBVbypyZijy3dnpLG07rY6KQHpiFykgC4mSc4bgo8EBxtq7XXam32PCB1dxdlVhOrC8ozlm+tA31c03WgH8PS3fMBa4ccKZRfNAfGwVJoGzL3oWfVFmbUy3s+J4237xFPlgL2DEnpm98OGHQMvPVY7JuAqkQ1OwtXIepXFJwRf4XSne+zg1rqLZBLwte9pHxPmwpwkGbiPPDitSVmW3T5jHXcMr1qdyUc0748rRsOAfBDKoQpdiH7mMgcqHAm9rT5VABAwsuDyGLB8IZkh8v1Jv9G1ncqhWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qj9HIJ/gFUOJVJ39uLqP+KLJrtwu9ln+46q4zmX1PXA=; b=n2oxwtPb7BL/t+mKDtamA5abObF4NT1l1eKYB+UbDU1p7xFWIddikyQWR4YQHZMos8etseaB9ZQf8l0IyoaP/cuKpybcEAa9sZybyK0UoztlZfaa4thQ+mvXfBPTZEQpWh/p4OM/EEom+lwYGUSGsbalk+nuH3h+8duRemXuodjWBcWKLzLC9Dr0+sXB/9vUR29cdwsyF6fGRyTxCLoNr3t+Y3ZLn0j5BpKfI7ixTQUbDJ1O72irzdPSzce9QcMK8SvSFtsRXe+9ivWibegy5/BM47eABJgId/LxhsBXQgRbSEPevY9g2JfyAYTdMQrY6uZYW0/S0WWPvafHgnzTfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by DS0PR11MB6448.namprd11.prod.outlook.com (2603:10b6:8:c3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.17; Thu, 22 Sep 2022 11:26:24 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1%9]) with mapi id 15.20.5654.018; Thu, 22 Sep 2022 11:26:24 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" , Kun Qin CC: "Gao, Liming" , "Chen, Christine" , Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long Thread-Topic: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long Thread-Index: AQHYzfsRW/rNClslyk2BeETPQhQD1K3rS/mwgAAEMUA= Date: Thu, 22 Sep 2022 11:26:24 +0000 Message-ID: References: <20220921204459.821-1-kuqin12@gmail.com> <20220921204459.821-2-kuqin12@gmail.com> <17172A4739518A26.13460@groups.io> In-Reply-To: <17172A4739518A26.13460@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|DS0PR11MB6448:EE_ x-ms-office365-filtering-correlation-id: 4486a72b-4104-414b-0c94-08da9c8d485a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EhkcUY25q3DtqYhM9jGujV5HoEEw9OHeg1UOmQp6Hpipjk7YpoHLvL5g8CXY/bT/zQ838QOi+3UdMhLOZz2tUGsC7EGvfK5echpf/xKojhlpqb9nvDz1GyQVJyHB1rqzpmp6iUuWifnr2ffyytgA61IjcBn89fbF4XgOcU8gKOqL4sK7KCXqs5seaC53TEObBs6NRxtoGmj+w/TG9UUe1DlqxCSDrUwc/o6QTkq4WAFvUqpeI9W7M/71lXnEExAS6+jbLz6nB8BwgLyHvLm1qP/zPEobGPfK4w4Kr8SH/ZlwL60emyy8AHeA2pRukUXjZY0J3Ul+VpRO7plHTNOCCbRMpU8vIeXFaIwsLZG7DaQFzl23ILMdAKi16WTbwbi2yb69BpzwkTI+FDjkIyyTG2pvKq0ZgfPfpfxVrRuOxNHmhmKsACe+wEBL+sxAFfPeYQdd3ZyXkP4F8mx1a1g2dMqWP0hm2oE6kZbeTrU9GO7lq0GaxoodHpktQpbxfNhB+suBy0epXkX2aPWH13pbpZxRUFYNp8meG/kj8pqFMvO72nwchtwhmzhcoNZGj85wxZ6AbfY58S/jG+fpSMVsSXrwWZqh0E1ttY3nfZ6fCLuu0KOk4RdQssz92jzLJ4qpnel4anPUwatZxIKiZ1uY9HzlLMqTGe+1oTB6nwrTUzLPLCkrJgI6JCh9NpyPiCVlSOUfG+42EtqpoE6Dk7Z5pWdZvOYhmyLdjJeAUvE5P0TUv8kaXBUx/oRP0gG1a9LHi5x2v8ye8Gh5RCnFwQK2PUlAzxkUS4UHCwgGRiPN+x7Nb5cUrg3zij3LBIwPE6Qz56tUDP5qltpW9peOnlPJ0w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199015)(54906003)(5660300002)(19627235002)(55016003)(2906002)(82960400001)(316002)(110136005)(76116006)(66446008)(66556008)(64756008)(66946007)(122000001)(186003)(66476007)(478600001)(8676002)(26005)(71200400001)(7696005)(53546011)(6506007)(4326008)(9686003)(41300700001)(83380400001)(966005)(33656002)(86362001)(8936002)(38070700005)(38100700002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sHhU7JcHJn1YB0w9EQf5a59sv2TTWisu0VMVK36ThRDIZKS0uUI8elfrbg0T?= =?us-ascii?Q?HFJYwUsFKuUYrq4/EbXef5YqAXLyf1RZee7HHI3rqYa3+0x9MNPxATFdPC4B?= =?us-ascii?Q?BzjLJd6Qnq+ZjGvG2HD5ZGQWdBN55ETI8yNajsEcweugCdJ4Ir+Uzw6KyQ5s?= =?us-ascii?Q?vNmdcG4LEB7OWvdgVPMZLls9MXiKQnYAuT2eVNWVRljRh8RK478VtI6pK16I?= =?us-ascii?Q?YIFMAqn41t0Opf1s98SCt2Z0bzgBQ8wE/90A4j1cOdny+lHX54T3ijqqP5Ss?= =?us-ascii?Q?umrRDJWpDBbzhS9Q0p/IXMZ2QqcgdNtARekPuFDbp/n3iBs8WXShJG1PRuaw?= =?us-ascii?Q?bsrc937uU6hHnmOvAX2UipNmNPrrktf0QVF4BU0UrPeaCv447rAsPmcYJDxb?= =?us-ascii?Q?jjcQ2LQWvNKNdUD9NoVoQj50ie6d8Zv4VTinuq0f3xSUkwGT1hI6yBy423m8?= =?us-ascii?Q?9JAz70rodFYki116DjRLITAOg3aHu/WM7BX0oCE07qQjI2uCI558wW2Y8k55?= =?us-ascii?Q?P5QjmSJIBe5QsG4y0EJZFUZM5rsyEtftvPSPkomyMiJVkLYNsjb+c0fFOpdP?= =?us-ascii?Q?s2yiCkeaa2s+E1SE80ybxqNmrpXMag0iUKSNi7rHhnBd1hMRmhjAZqJ959dB?= =?us-ascii?Q?+4RoLzVXjtABW2uT5lfhgbYyIW9Ppv+F5Pj6VLLqVH4BT0ZeOACVO4H9K69E?= =?us-ascii?Q?oj/BHlmACK5VsndFSbsvsfvjlIzU1d9jHeMIAcZ+tf+5IZMuhRDpOKkbzUxD?= =?us-ascii?Q?9EOV92RynmrgrOuz3e5O9WLaw566iao+xGiUyDI96qID9r3X2Jrh5xaH/KXh?= =?us-ascii?Q?qN9nFM7y6u4tV6kuWTo3DrJbweK6yQ3xfkyXYgqhZlp5LSvO8fTQpbYKmu4O?= =?us-ascii?Q?ilxPctzQ2xDKWihf7IbBoi0SkuRaVMU/pNyUl28JSqD07fy961ogobOgl+KR?= =?us-ascii?Q?Ou4igPeFjWCIr7D1utxsywYhh8EaJck5GZgjtfN9SNNnLCVDCqwzLpYMNpqj?= =?us-ascii?Q?3KcrOB51Tc1DsDSWXrVbhujn8Gu1Gef6WvGmzyOGrRQmi5Y/YuExee4KFJs5?= =?us-ascii?Q?OSi4lW16ZsRxwQmCvKU5zgcmVRTKDKAj3PjoPa3Yy8W+t/n138VJNlq2GkWu?= =?us-ascii?Q?B7ARKgXjzeJp57aw505nygLVOIh5y/i5sIxHu9gMQFSN2W7Y4Y77S4MCTGGg?= =?us-ascii?Q?Q04gwilgVYwF9jUMYA8yByXJfuCYi3U8vcp3f8NX/j1x4x6Sj33lYvP8kRWn?= =?us-ascii?Q?uO/ovpJGsOnm88kYvdA2rbeSp+B6sQ3zYhXJdw7A4T+bhHoC1YIiM+VG3lwQ?= =?us-ascii?Q?Y91T7uJ/lyydFmJZrAQTmc0T9S3NoPp8VXnMQ1JWeY6jzWXanEhHg5csVv2q?= =?us-ascii?Q?Junsg8TZRJuhvU6UgSPCsIcAm+FPV5/ojdj9JIh43Ud/EhXdE9Tl8li+1J1A?= =?us-ascii?Q?NXfuNY9V76rFZqFe++OuZRU93zzy0LZEy+jJtqqoT3ejwczqCe0Ir+yOSjf8?= =?us-ascii?Q?o9h1/20WXmM2/31cipwQeITPIsRBPGONFYt2kEnErWK91EP2VtenbKH7RtSw?= =?us-ascii?Q?hpCi8tiQUspq2yMZKq2aNBsJHWtpkgaE3p+c+1IH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4486a72b-4104-414b-0c94-08da9c8d485a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 11:26:24.4060 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4CPp1oD+bqr6JEK1dDm6K0F0lxEUgPrXk41yBJBLPh68EcofnfdDfxtITm+zIkcS5ZOiU5j7ZcLxJVNFqPjA0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6448 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Create PR https://github.com/tianocore/edk2/pull/3378 for merge. -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Thursday, September 22, 2022 7:11 PM To: Kun Qin ; devel@edk2.groups.io Cc: Gao, Liming ; Chen, Christine ; Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing = pipeline build due to path too long Reviewed-by: Bob Feng -----Original Message----- From: Kun Qin =20 Sent: Thursday, September 22, 2022 4:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Sean Brogan Subject: [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build du= e to path too long From: Sean Brogan Current implementation of looking up toolchain will _insert_ the findings f= rom vsvarsall.bat to existing path and potentially stuff the variable to ex= ceed the length of maximal path length accepted by Windows. This change updated the logic to use the discovered shell varialbes to repl= ace the existing path, which is desirable in the specific use case. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Co-authored-by: Sean Brogan Signed-off-by: Kun Qin --- BaseTools/Edk2ToolsBuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py inde= x 1ea8187de693..f862468ce275 100644 --- a/BaseTools/Edk2ToolsBuild.py +++ b/BaseTools/Edk2ToolsBuild.py @@ -122,7 +122,7 @@ class Edk2ToolsBuild(BaseAbstractInvocable): for key in vc_vars.keys(): logging.debug(f"Var= - {key} =3D {vc_vars[key]}") if key.lower() =3D=3D 'path':= - shell_env.insert_path(vc_vars[key])+ = shell_env.set_path(vc_vars[key]) else: = shell_env.set_shell_var(key, vc_vars[key]) --=20 2.37.1.windows.1