From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.189801.1673931910022292677 for ; Mon, 16 Jan 2023 21:05:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=d9syyQBv; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673931910; x=1705467910; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Y/qnVQ0jVWUAavNpilLB0jFD093PmZX6PtOoroUEiTg=; b=d9syyQBvLcJ8oimlVcx8Ivjc3jKbuVUQ9RYuX8YFn9GQB+4MXmaFdgJE nhKh/pTDWPOPQMldDPUz4VqI7ZxOeER0HIaxGo6SM0Bcns+0ETBkZW8y+ ovFAiZT575BYBzVhcO5F8MdmeL2o9X9fY8Vs5bN0GviOEngs3OJtnKjsa WzO31abQ00DSRZDFxPj+kgaxqDn+2St4ffQyy9XFthXSMdZl0xuAYXlD9 5+ypccJaAQZ9jA+3BtJBnrn2UPg0Q3MhC/rkoyjWzDjrpehr11KECdLlG Z0iDBLVB1UD4HAkdXnf6ZTI1uVGf9v8/ewDTcwSq49/5pA2JI/9v8gWY5 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="304299255" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208,217";a="304299255" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 21:05:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="689673984" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208,217";a="689673984" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 16 Jan 2023 21:05:08 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 21:05:08 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 21:05:08 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 21:05:08 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 21:05:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=amkZe6nLsO6uzpQpnxZvCF6xzmq25rZsMbqrhqr/70pu7hFdzYhzK92uSexTJinTxb3fwJIKzhCkJOO88k8/iXJaKm+TpxAC0CDEotup+luUE4/ir61ULdBk6LJoopaPXW9ApS/ufYtcsWeX0Xu6SwzbFfuf1mluAk7W1tMOz4EkQqvWOdLNi7g26wlLMOe/MMU9Ros3krY5/2vVdz6ojb8DntvXIrEfARDz9WuUQs1dv20auTckAiDFHlwzflrFt+LDMQCq7i9ACWUc3sicbrj4eOaViHzA68xKcecMlIfcOZbAy5aoDGmp9EgolfszQdDMJWxTqW9kNA4jQ0OM9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n50uKwVraq7If36O55W9zYdDoWImkpxsv/J42x0Oa0E=; b=EztCtaGY8U9MkfL5fZJUnX1VGhl5hSImk8N5Ddz+sQz7BN2BrNUocZNJu7K0XCJbaqyfHJNAgb34ok3zU6Onc5Pzh3el50gLp94/QrnWB/9JJK0KuxifHqVjod2zA/zUDHv11/HWffd4thVdkZ4WMoU35/pDz1g7FmE8EgM67t5MXg/V3fTLpL9LUVnnNiWxVnY5gDGjhwjdmaG160X8R20Hg4U3B0l5u3/D6cmKsON6Dooco/CBGfWcIwyFQwN+Sc3qpGpVZxCp3X9+MFnMSUqV/liWgEueqcW3KQNjGjsvqyIXmx/WJduSLc01hPLI7oa9NT30xUp2EGz6x5ppqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by CH0PR11MB5316.namprd11.prod.outlook.com (2603:10b6:610:bf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Tue, 17 Jan 2023 05:05:00 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1736:fe5c:ecff:e73a]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1736:fe5c:ecff:e73a%4]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 05:05:00 +0000 From: "Bob Feng" To: Jake Garver , Konstantin Aladyshev , "devel@edk2.groups.io" CC: "Gao, Liming" , "Chen, Christine" Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build Thread-Topic: [PATCH] Fix cyclic dependency error on OptionROM build Thread-Index: AQHZDw8bWQ1yPeP+M0ytuH8XypOPMa5sKLAAgDYbk0A= Date: Tue, 17 Jan 2023 05:04:59 +0000 Message-ID: References: <20221212130924.8156-1-aladyshev22@gmail.com> <20221213162222.590-1-aladyshev22@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|CH0PR11MB5316:EE_ x-ms-office365-filtering-correlation-id: 1375e6c7-ac7b-46f8-2362-08daf8486284 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sgJ3qwJkeUPUUPZFCkMaR9F3UuVbdjauR+Lg2e10h4X7QSWNTGP0FvYBQmiw9SIxS6E2pTcY01Zl9LRf/FCLfNpBLMd5faS60hQxrLd2Xp0ZBZE3XBIAkqqp7mPl3YfJVuPYLnFg85xov3H9taWLJh6UUUnmSk2Dzu9jrvVG9tkKBbPIo8tsF9M7dOlz+3Bn97Aa3alT4yoU6aO/au9u0VHD1Yfy7pHPFn+WqW0DPuBMoe9ozm2jxfT219+rJbChKsYm6R6KJ65/MaMayhP6xrYCQvlhhidNUgHvsHnCuEgKJYStLp35JWAN3J7N75WxIlgXArDnbEA+1N2P0o+4IGUDjdQlLtzoGeHcLy1syY4Hwo/a5EMU/CK+yPC9hbdIP+qkaKYhj3vdd5hmHPrpKgNH/pJHAWkVyS6YC91Coxu7XX3dEay8pYgUrUox/sdpN8YD/iNcIu688M6JeRX5WVWj949c/zCzdD2sIfAImMDpcWAZLcgqFTLjw9HTa88ZB3H52QzCnsaU8Bfnocp3HPOfo1BZZ6j/+voklY3k3FjZb5jR9bAcoqpA5NJQarg22h3Z6vx5XB4Ph8uvRH147FZq3sKVt8zKL9FNMxOzk70j1HdWZ00HfceZKkqt1bHkdjtj8HF1wizCAw2le1D9XGOUZcAWyg391OKyL/O0jD4CH2pYzNb9OVUPaMNAXFh52UOp/O4Nk1nw60ep1T2ScA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(346002)(136003)(376002)(366004)(451199015)(38070700005)(82960400001)(38100700002)(33656002)(55016003)(86362001)(66556008)(9686003)(66446008)(66946007)(26005)(4326008)(66476007)(64756008)(8676002)(186003)(478600001)(54906003)(76116006)(7696005)(71200400001)(110136005)(316002)(53546011)(83380400001)(122000001)(6506007)(8936002)(52536014)(41300700001)(107886003)(5660300002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jIlTF4afl+IODg4lXfeaCxnNB3XD4er/wPDFWceeK0TNkRcBqNi7N24vQ0pU?= =?us-ascii?Q?AI35kczX3SHVJPuK1xoOuQuJqercMdu7tjBpqdXazof50HPDdlBmJfw6MCee?= =?us-ascii?Q?xCaY6rb6krP9IoHT/SlrKl3bE0ukgULIY7IzUh+6X6F6GR2F8h91F5WsS//U?= =?us-ascii?Q?hmEXptwWZDyt0JO5HpKDQiZ3QkZlBMmexDoznuvZ6h6UfyWXM1sBgMKV7HEL?= =?us-ascii?Q?f2aueIA4nxHKbUfzalHNlWwPkGtNQCCfkztoJzW0uka1y76vc1aCZ0R53/qm?= =?us-ascii?Q?Xda5+bEK92paL4ZVT15KeAMJvD5xGRqdznZXLqAQbBnaOzDDYc++gsIa1IVS?= =?us-ascii?Q?ylpGP39ZAS7Ib/wMZIXFWiyzbLIcGPi32/wYMv6gBb4bi0unTQfVQCd8Vn8O?= =?us-ascii?Q?RgJuhw6Pz/hN05mjoAb9fkmETiLx+TTZ+LjEoY0vH2zzfa56UPk7LkYldYV4?= =?us-ascii?Q?XFidvq+j33//VmFijIll37/yhyIjRnqWKnQFAe473/SsMvciQqMUYvsgmSKX?= =?us-ascii?Q?myNIPcscmy+OnJ0dGbhTGmJdPn4Rj+5PieU9vyMmG5BCHwuQ/Ox+G+L6UiYD?= =?us-ascii?Q?HhiASEI3iT2iBDIf33Nop4LR4S0rs66RuokTPdMSdbe2KsO0v1Q/qFyflSg9?= =?us-ascii?Q?QX0S2ObYx4EY42S9C6Uv7Wrvco53TSwHk2hpyPZNQ/PkzthelabvmrYi3av9?= =?us-ascii?Q?3VsfVGm/53gTPahqksth9zBT/TzdzwV1DIhAxRh45KpvxTZX0UAP1EzmJBnO?= =?us-ascii?Q?sviE1njwOc+cqmjMwDvJuiJVyrKOvXo4JsDc+ZdIjS4j7x/ShASkEa/d6cMK?= =?us-ascii?Q?scL2hCa10R3VIt3XlcpXGU5YTkf17Ssajo5Qj2rFYZlmS26O6zEm7ES7qYfO?= =?us-ascii?Q?6bXvtrsHmKqZ4+bbgiWiCHVDpUv9EYp3apL3lJwU8lEQcLm1t6kFCDvPZfSJ?= =?us-ascii?Q?DBJKfryHEng0K9xP7Lh+ZRb1thKrBMCDq1qsStq82mUEdHqQRyNws7uD0x7G?= =?us-ascii?Q?Sl2dmKITAs4orfh2TI3eTCzqD+h168aCrKWArLQblCnrq1wq9dewh7fzB8YS?= =?us-ascii?Q?v2CJ3nQDAfFD8+8boObNN4hj01TGBnyczgEUG7U7uFRKTgyO2dSyZ32x/FE2?= =?us-ascii?Q?YU8IzM0PCXGxigVVX7rWfpljK+T9rCZB5Fl/ZtcJfdQnF8Y3GiEJwG9UGpcd?= =?us-ascii?Q?jAl0J6AgJxbDruwaaqhDVOp/TSrjXDGb+SV5W6eKB7mxtH5f9iVPId6dhFy7?= =?us-ascii?Q?QD5VwjZeLO3jJyxeAv7qDynhM4NNAXRo2Dt9SLwRtONdaiDLIiVoh2LYN5YG?= =?us-ascii?Q?ZGwg0qBiNCLQjRw/Dj5kTw1cZ2PQOFkE1iId6GXBMFYA6gkc/RwF6ZV8+qC1?= =?us-ascii?Q?38M1SZ2n/2N8AD1tL4J+pEfZQiWEi2BC9tBU0Tw27u8r0KcyPS/lxlBMgXbo?= =?us-ascii?Q?J2RsFP53Ew9SJN4gT+A1u4y6J4qS8OH9X+V85A79Sb8h2nMMafh0qRUZYfhg?= =?us-ascii?Q?u5vwDHTVS2ZRoDWZ6Bmfg/bd0NVbaxqdRafmaeQPn2iy35IQ9aDC46nro+sh?= =?us-ascii?Q?gXMkdMr+c/7Ohhpy7eyEdbmGR3xv4ysHvtYpGDv0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1375e6c7-ac7b-46f8-2362-08daf8486284 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 05:05:00.0038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9noJgDC2diTTDDkkKoh22W9+YBcUryBw8E6IyCLEzD0UHh+kUfm7XXZfexiAC9JWvTdyEgOBallTCFP1f8uZUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5316 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR11MB586351666B365360795D9810C9C69PH7PR11MB5863namp_" --_000_PH7PR11MB586351666B365360795D9810C9C69PH7PR11MB5863namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng From: Jake Garver Sent: Wednesday, December 14, 2022 2:48 AM To: Konstantin Aladyshev ; devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build Thanks, Konstantin, I approve this version. Thanks, Jake ________________________________ From: Konstantin Aladyshev > Sent: Tuesday, December 13, 2022 11:22 AM To: devel@edk2.groups.io > Cc: bob.c.feng@intel.com >; gaoliming@byosoft.com.cn >;= yuwei.chen@intel.com >; Jake Garver >; Konstantin Aladyshev > Subject: [PATCH] Fix cyclic dependency error on OptionROM build External email: Use caution opening links or attachments EDKII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID =3D <...> PCI_DEVICE_ID =3D <...> PCI_CLASS_CODE =3D <...> PCI_REVISION =3D <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files to fix the cyclic dependency. --- BaseTools/Conf/build_rule.template | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..21ccd864fa 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,7 +342,6 @@ $(OUTPUT_DIR)(+)$(MODULE_NAME).efi - $(DEBUG_DIR)(+)$(MODULE_NAME).efi $(OUTPUT_DIR)(+)$(MODULE_NAME).map -- 2.34.1 --_000_PH7PR11MB586351666B365360795D9810C9C69PH7PR11MB5863namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

 

From: Jake Garver <jake@nvidia.com> Sent: Wednesday, December 14, 2022 2:48 AM
To: Konstantin Aladyshev <aladyshev22@gmail.com>; devel@edk2.g= roups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaolim= ing@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build<= o:p>

 

Thanks, Konstantin,<= o:p>

 

I approve this version.

 

Thanks,

Jake

From: Konstantin Aladyshev <aladyshev22@gmail.com>
Sent: Tuesday, December 13, 2022 11:22 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: bob.c.feng@intel.com= <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn &l= t;gaoliming@byosoft.com.cn&= gt;; yuwei.chen@intel.com <yuwei.chen@intel.com>; Jake Garver= <jake@nvidia.com>; Konstantin= Aladyshev <aladyshev22@gmail.c= om>
Subject: [PATCH] Fix cyclic dependency error on OptionROM build

 

External email: Use c= aution opening links or attachments


EDKII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
  ...
  PCI_VENDOR_ID         &= nbsp;        =3D <...>
  PCI_DEVICE_ID         &= nbsp;        =3D <...>
  PCI_CLASS_CODE         =         =3D <...>
  PCI_REVISION         &n= bsp;         =3D <...>
```
Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698
("BaseTools/Conf: Fix Dynamic-Library-File template") it is no lo= nger
possible.
The build system fails with the error:
```
Cyclic dependency detected while generating rule for
"<...>/DEBUG/<...>.efi" file
```
Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output = files
to fix the cyclic dependency.
---
 BaseTools/Conf/build_rule.template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template
index af4819de92..21ccd864fa 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -342,7 +342,6 @@


     <OutputFile>

         $(OUTPUT_DIR)(+)$(MODULE_N= AME).efi

-        $(DEBUG_DIR)(+)$(MODULE_NAME).e= fi

         $(OUTPUT_DIR)(+)$(MODULE_N= AME).map



     <Command.MSFT, Command.INTEL, Command.CLANGPDB&= gt;

--
2.34.1

--_000_PH7PR11MB586351666B365360795D9810C9C69PH7PR11MB5863namp_--