From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.4180.1664678065618997702 for ; Sat, 01 Oct 2022 19:34:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=mSYPsUQy; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664678065; x=1696214065; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=esqX0NDel4EFShJHjcM7tux6bnwGokDhqTUGHsPumgc=; b=mSYPsUQywiWzUpR5VxRmbTUEBZmRJonWZIoqmTuIER+aM+bQy4z7Wu2R baKPZClRR/KNlQ4vQsdflbah29OyF5ZWWO6l0233Oeo1cP1ciZqF2/F7U YAUT4tST++gsdfpCUrj1nDpD0BA0IlQxStokhvTqXp0gL4LKv11T8SL3h zdYcdr8ZjKYnOYsHQ28uKe9nWySjBWWKgEE3QRLIHQM5irJa1B+tmmhYi a2WzadB94+KFN2FXPf7CZqvbgL0SCHIv9rkNKKNIatMd9yQbcwTocukcW qGAQG5jgyUXkyUaCICo9XN21GLMGYpt2A/lCrKIkq2E7TisSF9wa0nR3p w==; X-IronPort-AV: E=McAfee;i="6500,9779,10487"; a="364279856" X-IronPort-AV: E=Sophos;i="5.93,361,1654585200"; d="scan'208";a="364279856" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2022 19:34:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10487"; a="765539931" X-IronPort-AV: E=Sophos;i="5.93,361,1654585200"; d="scan'208";a="765539931" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 01 Oct 2022 19:34:24 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 1 Oct 2022 19:34:23 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 1 Oct 2022 19:34:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sat, 1 Oct 2022 19:34:23 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sat, 1 Oct 2022 19:34:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TZOZ05qhXx1ADnfnn4qIxCJauvECH7Fh4UL7U3apJPugqopKO6K4QRGL/I1+b4TBzXwO+sc0StIMjPtENM4PKyo4C7BfRUXk9r7JYMQewRySHFfb5NVBUFafmBiWl4JMCWf3TUgpQHBtOpDECX9QOMFXFr2SN8bHGgRvO4nbENGFd5JDPPaHrAxVmMSeNykK+J8wgbY4Y7uaB02ZFxK4tpmjUcdI0pgcgHAFJzyTewXuBMise6jxxoZSn7jBxOJ63Nxz2BE26FsoIDvTN+SXcuLUiWPYepXQdR6nbWbmvZVVSs2tuX3MsnOBKkcxbKKWbEyxrMu83c9sYwmxykELIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUTFXvgn/+l5xjz1WPYYwYUYuME15sGZlvF7AHVQRDc=; b=OhuKhGW47KNLBNam/nd1+LkWZDJ9yUNknpIT+W9uUCcbtohkAFDgftttRQuqrStAqLvd7msMfNa/2YwHW+z7T7Gqfe3ZtpviNEwXe4nghwk9gQjg4ZlEmrUT6VDRe4OQRn/3EyX37fSp9Axl6YQVh+vq1AE5YLeqRStKmA7pfe0ug1/EkzUd1lj/unc/E3wCWPPD2dhAAH0kzWqvyaQpRMxNDQnWPqSgIT6hrSb3zCx7om3ET/7MNmnUlcBQ2Y26DTavjy9cvHP+fesPuTtd/8Fo+29Tg0EuadO7O+4DkYNWsJ5BrlhBLmpzVjBaZ/6mCge758UclYLoOnvwTxgdKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by DM4PR11MB5344.namprd11.prod.outlook.com (2603:10b6:5:393::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Sun, 2 Oct 2022 02:34:14 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1%9]) with mapi id 15.20.5676.017; Sun, 2 Oct 2022 02:34:14 +0000 From: "Bob Feng" To: Rebecca Cran , "devel@edk2.groups.io" , "Gao, Liming" , "Chen, Christine" Subject: Re: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile Thread-Topic: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile Thread-Index: AQHYzHBMLkq3WVqdzkqdQKFNOw2b2a36dfUA Date: Sun, 2 Oct 2022 02:34:14 +0000 Message-ID: References: <20220919213910.51063-1-rebecca@bsdio.com> In-Reply-To: <20220919213910.51063-1-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|DM4PR11MB5344:EE_ x-ms-office365-filtering-correlation-id: 1ec875f9-a221-4d6c-37fc-08daa41e988a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hcuPx3SMjNAIGxnIa/HXg1pRptYvr6dndwuiL0+zBED+r6eoOvo+BhTvUp9Bwp16Wem46wuffsoc6B+HDBzy0ebonIJSdu75EL7SpeTGNbaOAi1qAOKuxFZJ76nxC1dnxtZjPTgojw0pZn2Vg6mvmXMtaXGARERrdf86hrQzelAKWwEczfRf7M+ihYMVh395iRroGUaSL0pwxoCq6P/7zPzksO4DGCNz7FLfUw1mDhkgrANwXKSByk98fiNH34dY86Q9dl4nDN4dwNhDHvWAUJXauiZ5PQvqgVzknds1Przo/dxrIKY2KiZRQQ4K5GMorD55tgQmrOgSGIijcbhhw/peg0B6LHzPpmhA9Kn+Z0y5UvyVW8wzQpqtPg06bSLwyt8JguCI3gPHDsaBOt/e9snoJLn65LXXYKQLcAb6jrNEIRcMRebVMUQNTt9+uoItAB4yQFZgS6Lao/ej7oaeulSSt2+5QfntDCEiRVhgEDhoUg8xD0kvmCi/JI6p6lTZynZcWkGwWNqL0/1DpAXfPjWd+9O6avYIBV3LgudVVLHWGUc8e2CpiyIA70YvTpG2G9flHpEVTaigSAmfq/vZ8bQN94AQcj5p1VWrgRWtekuejuAqHbqBTxGfrq1LBlRzmFH8aW6ZrsnGkk5u1VAA83qFyCbt1kkU0wdqGbj2dgI1XFfGnXDBCrBpHAz8USz4AYM3hNLhucYrtk8lKR1EeCNjy1FYbyIPVVazrQZmeLA+Z7U62ueSapsIcywCtUpSGG9ELJyOFjub7ZzPslhuighlyOuIC5IvlUuq/neMdt8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(396003)(136003)(366004)(451199015)(82960400001)(122000001)(66946007)(76116006)(6636002)(66556008)(66476007)(66446008)(64756008)(8676002)(41300700001)(316002)(38100700002)(110136005)(55016003)(83380400001)(53546011)(7696005)(6506007)(86362001)(71200400001)(33656002)(478600001)(186003)(26005)(9686003)(8936002)(2906002)(5660300002)(52536014)(38070700005)(228453006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mlIBNADLW7buEy6LLiJqi7rbViCOIBKT2ennhMGGy4DOzU56JZaMnoZ7kFln?= =?us-ascii?Q?XDSHkZoCcjof5RrPRW+Dak8n7Nn+28XcOb0xYBm4FFxN8sESlBSIcUt+XZMB?= =?us-ascii?Q?BdoH9mWb+4U6DYKFeNSfNouRD7DDHKKKph7sZSEXpIf7pT5t9ZBVYkkVnmsk?= =?us-ascii?Q?cMeYEajSCMH27jYBiuoDNj3GqA5c4o2NI+PW4wWbNSxOZiJsgbn69lIwQt9w?= =?us-ascii?Q?DrwYQBEBbYDVvaXHQE4DK9yCbbWSdkRkdmxJ2l0zioiPHkBCtVwrDujkxCjM?= =?us-ascii?Q?F8KKrAI+7ymspPPgxwYTSFcL+6k59MzRLMWYttwh7LFas9QILvtEif/yIYdY?= =?us-ascii?Q?x4mhn2GbjqAQCUZD2iIiKenPJYebRtBbKU3IpimDlIDFw5wVNFor8adWKBDT?= =?us-ascii?Q?3NjlvugQ5yQ2Nbwf1j79NHJ2qCUL8pdX4wUZ4bNxKi6zsfvJDe8RAPq8O78p?= =?us-ascii?Q?m3BZQwMWfXxTgtfJlpiNJs5y/At/ersqcdTIw/LiteOec6cE9wIy1BpoD1XL?= =?us-ascii?Q?yOqRHKI5zDivIbmAxxvs6Pk2NCuRsvyk6Agmug3+7WphcL3W1fn4pOSDiL7l?= =?us-ascii?Q?L93nN17/xsql7ZwQlLegsB2rnY/mM+gHWDFQa9EOVzyoi6rnd7ovYSftSTa3?= =?us-ascii?Q?+PiNJXF2g7H/RkrWD/66ISw6YxNYQyVZnQmRwsksGoreLz4Z+1MjQGEb/7Er?= =?us-ascii?Q?uoadXtPGQ7QHzVa3Hi0pPVWgqxudrTqc3oHHEgLeYP/V2N+4Aj4KAOMoRAb2?= =?us-ascii?Q?2ruGdQsHmfW581fdE+tL+zUld6nChW5bm0iQMopFZqO+RoEWYIP4+Nv38chJ?= =?us-ascii?Q?0HUrmOTq4KOyuldNSMZmgooCKKxXZFzI5UUSnKTczOVqviGuZlOEyX6tlJsU?= =?us-ascii?Q?fMwNHl70jGk3NJfWQiXRfmWhMrDG3latb2M1+5lQZV0Mwk5ig34L/P8AGzlm?= =?us-ascii?Q?az170GQRllNwNoCEsUB38V3zzVT1rZI2oP7Xs/NQa69yNJhbpzFdkSnrvq7B?= =?us-ascii?Q?OZiLjByVq0Pgt7EANtr7l1G9rc3mt1HVwV9lMvwajg6DtU0cBb68v9z4i+BO?= =?us-ascii?Q?U4OGk97srd71Q7OH/tBuvyTT9rLx+XQGdINy+c/ZXR5PXBzKztOOh43F8mCW?= =?us-ascii?Q?DMo7ySlNuS4xXET6HU57Tx6epiYPRclsVRQ1E5ehykSFmPn8v07YPUiA6Qwa?= =?us-ascii?Q?285Ur0lg8gZZvosWR1t8bHfrGyHSZBkqMK8VglwcHuULscVVPinlHmM6Wiap?= =?us-ascii?Q?EoS3OBXy3OMLw4Ek6RlGIC4ql51WnhY9Q5bnXMC2GoU9/OZDadr7nMCQN3o6?= =?us-ascii?Q?b7jU1o+CPvUaP0mHSfxV1DMNL1J7Rt0NEtXMVrhWCI7/xxCUbFIoL1fRcaMo?= =?us-ascii?Q?ujx4nZvpuxWYY2e7dytw6F55ztgcZNREnWU6y6ZTBkR5A1khMnwd5oYyTRKS?= =?us-ascii?Q?KeL4c9eFQBZiLw69VaUeku+e+dAqafgS0TeXJYocUEAXs6AFjdsLNqXJ2AJf?= =?us-ascii?Q?fa3RL88DOzmmyhNBEupp8uUYMeoDlSgXeg5eEI3fTjHjmumHEqBFQ01Bpt1l?= =?us-ascii?Q?vJX0pBak0lFKGoifCaZZ+Zb1+LcG1BeCXCqmZ5vn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ec875f9-a221-4d6c-37fc-08daa41e988a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2022 02:34:14.1047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CUiGKpOyAfY3GbRonbNNDIC5Dp9ojfwYIlOt1cfg7saJ+BTVPmo0e73ESVuKn9HLBDfMCAWg9JXLotWjowWZsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5344 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Rebecca Cran =20 Sent: Tuesday, September 20, 2022 5:39 AM To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming <= gaoliming@byosoft.com.cn>; Chen, Christine Cc: Rebecca Cran Subject: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GN= Umakefile When checking if $PYTHON_COMMAND exists, curly braces should be used instea= d of parentheses. Also, "1" causes an error on FreeBSD: it's likely supposed to be 2>&1 like = other scripts. Signed-off-by: Rebecca Cran --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile inde= x 1cb77f84b1bf..caa4d26c9ba6 100644 --- a/BaseTools/Tests/GNUmakefile +++ b/BaseTools/Tests/GNUmakefile @@ -8,7 +8,7 @@ all: test =20 test: - @if command -v $(PYTHON_COMMAND) >/dev/null 1; then $(PYTHON_COMMAND) Run= Tests.py; else python RunTests.py; fi + @if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then=20 +${PYTHON_COMMAND} RunTests.py; else python RunTests.py; fi =20 clean: find . -name '*.pyc' -exec rm '{}' ';' -- 2.37.1