From: "Bob Feng" <bob.c.feng@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [Patch] pip-requirements.txt: Update basetools version to 0.1.17
Date: Tue, 12 Apr 2022 23:59:08 +0000 [thread overview]
Message-ID: <PH7PR11MB586373AD331BD8AE30752AFFC9ED9@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB49293135766403CBF2E8F96AD2ED9@CO1PR11MB4929.namprd11.prod.outlook.com>
Thank you Mike, I created a PR https://github.com/tianocore/edk2/pull/2770.
Thanks,
Bob
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Wednesday, April 13, 2022 7:54 AM
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: RE: [Patch] pip-requirements.txt: Update basetools version to 0.1.17
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Feng, Bob C <bob.c.feng@intel.com>
> Sent: Tuesday, April 12, 2022 7:23 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Subject: [Patch] pip-requirements.txt: Update basetools version to
> 0.1.17
>
> Synced the basetools patch from edk2 repo to edk2-basetools repo.
> Update the basetools pip module version to the latest.
>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
>
> ---
> pip-requirements.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pip-requirements.txt b/pip-requirements.txt index
> f8bcd9ceb5..89f5ff1733 100644
> --- a/pip-requirements.txt
> +++ b/pip-requirements.txt
> @@ -12,7 +12,7 @@
> # https://www.python.org/dev/peps/pep-0440/#version-specifiers
>
> ##
>
>
>
> edk2-pytool-library==0.11.2
>
> edk2-pytool-extensions~=0.16.0
>
> -edk2-basetools==0.1.13
>
> +edk2-basetools==0.1.17
>
> antlr4-python3-runtime==4.7.1
>
> --
> 2.29.1.windows.1
prev parent reply other threads:[~2022-04-12 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 14:22 [Patch] pip-requirements.txt: Update basetools version to 0.1.17 Bob Feng
2022-04-12 23:53 ` Michael D Kinney
2022-04-12 23:59 ` Bob Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB586373AD331BD8AE30752AFFC9ED9@PH7PR11MB5863.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox