From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.35605.1675060979496583799 for ; Sun, 29 Jan 2023 22:43:00 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NVCcSOWd; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675060979; x=1706596979; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AKhD8ZKJ6W11nwihLD3rSZKpKXi2G8Y/+4HUumO2oWk=; b=NVCcSOWdkaZoXVN6EnF2i/mhHxrYUMU18R1hv39vSpuMDcJ+Zqq+8q9F TFWd5ZRtZX2NLfzakeCLOtV1RaLrnrwko/plNg+wZvQkSWRt0IxJaIIUf pXvBpozV1VUy/Op7wfgutjKaXR+SgSB7sJCgT427+r50E75/TbuKowp3b Hg3BM12KpyR4k53kiQ1BBeDXqslEWv8AqMr6T0BgDZXafI6IYcEUCc7Kc yARgExEPtc+e+3srepwl170Z0jzMiIhLmAbhEKFhUQcy8xqAxf3UAm7UU BH4Fc+KS5Lef3VJylG4pGoXidIGPV1jow26IlQBebTb2AHFDf9L5giJY7 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="325183997" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="325183997" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2023 22:42:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="665969669" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="665969669" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 29 Jan 2023 22:42:55 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 29 Jan 2023 22:42:55 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 29 Jan 2023 22:42:55 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 29 Jan 2023 22:42:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bNb84gypfoBnbqnqn4C54FN3ELbatEQldCl+48TH1s/tDrJxgOMs1jQJ1HA3safFnocQkNfqp0Cu9r8xfeZjunYv6L5zW7AdnJ5+BNfMtIpUUXxEXkpEqrPLoxta3DwMumJqrepXkxRFWlo8DRjfvs9qN7HKix45qVtIHxqcut50vE6BF4O4NSnpq5Ab8kc1Ojd1F7gucx0kLYZkazTIbkzCfnnNrzA2bPTRV6S7jHMHwtic7Gpx4EZX4/wDK4BcK0z/zW3DcQTkhc0hEm46779PqzrXygMYTUM6ipkxinEBVZBOFbAu1gUvqg4NqW72f1+AzxDlWTQknxvOPI0YOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nQAO3iqFIlHtDedbbeRuWoTIU5dl1IQsQGmxFoahh7Y=; b=E2h+JuDfnEkPzkMLmNcoWnUSO0SqXebIQu69I2G9WeRNm7DgIOr8MI5dQQ4oX9wOxz3vsVba0uHSVqae1FTPoQXg+9fruNf9knQqFGJRCBfngaVWM3ThfpVTzZEfTM86NUanY8vJc8hCJ7Fa9dD9BcafpYOVE5NttKUnQdxy5SR012vQ7gFvJiy7oJk5JJQjnMoWsOAnJIAwkfEYQQL16uOmNFcq27KYwoPtemZpD+bM4MUx8a6PwDGtKLdg+yByTdZA0GRT1PZNeIhcImKALrRJ9YXE7A+xBKxcno1SaKQPyro8qs6Fs//T/EsDvhr+PGohZKKGnxVDFuVjG+A8mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by CY8PR11MB7172.namprd11.prod.outlook.com (2603:10b6:930:93::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 06:42:51 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1736:fe5c:ecff:e73a]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1736:fe5c:ecff:e73a%4]) with mapi id 15.20.6043.033; Mon, 30 Jan 2023 06:42:51 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "tlaronde@polynum.com" , "Gao, Liming" CC: "Chen, Christine" Subject: Re: [edk2-devel] ??: [PATCH 1/1] BaseTools: remove useless header inclusion Thread-Topic: [edk2-devel] ??: [PATCH 1/1] BaseTools: remove useless header inclusion Thread-Index: AQHZM4VfAJWVSILAV02dw3pIAfHjfq61JawAgAFeePA= Date: Mon, 30 Jan 2023 06:42:50 +0000 Message-ID: References: <011101d93385$52b411e0$f81c35a0$@byosoft.com.cn> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|CY8PR11MB7172:EE_ x-ms-office365-filtering-correlation-id: 4816ccc0-cbfb-467d-c5be-08db028d3546 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /ChH+5tUTDGSCjG8pfYexn0m2/L3dvngKrv6EiNkxIl0IqNKAAMQCzf6io1f5gVmYjFYjWJRUQ5Pz/Zok8VPJvs7GeRNUDX14oPJFCUwJIwd4fxZExYzdQyhcaoZXDq9vSNC4N3tEfJEuNCRLckkiufwYzH8qOk4zaM1Y6dy2HjVBR0x+SQ/YSaJGcZOaHbA6cLIxkkrq0w8vuViVWdpdmo0U54q2Qrr12PcdgldVElhwAiep0Tmyc9c2Zi9GLbkde7rUq+fzL9BPuxQ4Mgb3DXcXjDmGWdoNFK0mIdZwK6/Cpc0y2w0O0CsoJmEl3j0n5w662i4H6gi4jHoNKCixLuWwKh7eGMLBVTU9j4kUXt9qhd1VFBcIxvl7VY+psQ05vznF3L9SHjKPritbvSWFeFGjnzs67ha5zzUF9AziTZj0f+F8OBAON+D+23DSLO+FRv7Oy4rmpwChNyRqu7c5+yXhlv3FFwIiP8FYRGULyy/oEMC6OU1/A79DevQ8uz9JKAJaPojtcj4mXgg+jaTc19qGuZcq10KLNC8JNrxHXr2irVFuocJzhtI42mNSoqEYKnDE2cDm+a4MMzPhR5AWcYmC1gpvUZOg0lOMLTwyl89oPWJDScSyFqxQjxsd2bmKCmpWbr3W1QK0KTUb/YnfjJOpipuQ9IXK3L3u64bfCgDfHIZegR97Gn4XYf1tUy2c7AJExHkbTLwRiaYS/cQ0j9PbmekOabl3Y+MDxk9ZdHV4GeWd10oym6Ul4LJfdy0uq8VK2s1WFo8I7vBXk/1Qg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199018)(83380400001)(107886003)(6506007)(71200400001)(7696005)(66574015)(2906002)(33656002)(38100700002)(122000001)(110136005)(82960400001)(66899018)(66446008)(66476007)(66556008)(66946007)(76116006)(64756008)(86362001)(9686003)(53546011)(26005)(186003)(966005)(478600001)(38070700005)(55016003)(41300700001)(4326008)(316002)(8676002)(5660300002)(8936002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?uHxxIY4cUfTZeODEwM8C1sTF0t9fwav0s3XvIW13FCEOABBNLTgHTvG4nc?= =?iso-8859-1?Q?MgDQqDpaS1h98uVje/ZGmCkyYZcokSy2kLNxT4HS9oeW+bB/M0wrheTKKi?= =?iso-8859-1?Q?3Pu8pieGcshW9jFcRv2mj7IYUrW5wnb/2fZmAYsFJc/9dfCWrFmzKgTARb?= =?iso-8859-1?Q?pgSa+tmtM+jYA75hWILcRRxnxWo0o8/xEpnlkfVME/Rzvy6a6MC8KWKhkY?= =?iso-8859-1?Q?+ZWpCXqvuL6ZaP6Qn/hgo95esJwKVMfx8rdsSkkQSKSv5ytIiN5ylVL+qk?= =?iso-8859-1?Q?5evsdahGiHk1cmJQV4Mjag7pCiNlgQXT1uZ+9DFBxKVJrE3W8BuiZs+8mq?= =?iso-8859-1?Q?VOxDZ1jQqaFkqz6dnH3UZ6YNhVXzVTrAquX4DDGDu/64w97tjT9UMcZ3cx?= =?iso-8859-1?Q?d+m48y7aZW9efJ4qc/n3C6Ca8FqfmTq8mqw9zBuISVaROAlTHsHJbThVKn?= =?iso-8859-1?Q?7s8Q9wP4klVb4Jfajyyg2ExDOhkfJAg/drgUGaimnFcWTfuhT+lUufS1ij?= =?iso-8859-1?Q?GqIe9JcawMedAi4uZlMwbf2UuJEQetxWEZR8EO8wahun6D0nr8WHEmzSgE?= =?iso-8859-1?Q?h3TPff+eJxnWvqfdfd8XCkSc1FkZiwNNyOapaWqnzh6yv/NQzQy5ao9vS3?= =?iso-8859-1?Q?/wb2KQpgmEwHSQrYFxdRxn+bsd0JKp/9eZecakokQh5UQEUjRmjaov91Yh?= =?iso-8859-1?Q?TgyD1iARKk48UJ7AOXMi0GSLJv+k7JrKa5QxuokKfeCZsYUbiysUSxhkow?= =?iso-8859-1?Q?wxWT8yPawC/FrWzARDgnhIuFA7EPR+jGg2+XbiSenRwW6L6DA1E9G7oKoe?= =?iso-8859-1?Q?XuMUIyfHxYNyXly3s0DOejdXl1XC/EclRFT9UiD8YdptJcP7JmpXk42QCc?= =?iso-8859-1?Q?JsuVIiNfQjakB2kpgB45KlvGwAnPXuhSJUeEs95HTMbGJ80UtgYhLt0TXL?= =?iso-8859-1?Q?yPi3+OjTbeNS5ztdH6UZHJcrjV8op+eeUY+wikAQbY6GNbXG0YTtSptIrK?= =?iso-8859-1?Q?cfLvaAjMyQXkccnm+kt8nlTHfjqJfcm/iXOl0mriZLk4JWWcWx35i8rw0W?= =?iso-8859-1?Q?k07LAGLkqBCx+D6MzEQW1/OjkALz/NWLwONAhYr7yqSjlHpVkj0ixjJPJt?= =?iso-8859-1?Q?H3D2JwBZSi/esvIqbu2YYroCypntEUCkDg2aSM59I6KGk4gSJVw6/l+SsQ?= =?iso-8859-1?Q?yRTAkaOrsMkIop5yj2nkW50APVQ80DjgGTDf5rrAPKVbESVlw0OzJ1N7KV?= =?iso-8859-1?Q?eMReC6deCzwr5Jj+dBdqOFVCSe9tI1nc9BolU6YxG9UswzZZPRDXf8WYXq?= =?iso-8859-1?Q?ryo8XPfuhDIKSzaiblyZBMTRuk7mm8ocJxTXgodVsknesLAMztevFimnP/?= =?iso-8859-1?Q?4yY1dKy/1MYlm1UUWX3VGTUOLfJ4Z/ctChBrSJnLdeKkesLRc8iInshJCU?= =?iso-8859-1?Q?iAsEPqyOD5xcH/m3SJon9QJXtRWaHCIl+0TYL8yPEqUNwaluWMqz3eCDp1?= =?iso-8859-1?Q?3Aj7+2qMkso2h6SoEnWveG5eJXkHO3MUVLGVu+sFmNIqR5vWupkfhl//TQ?= =?iso-8859-1?Q?GNaNufK8bT8oUhlW9VB2bp7xwiBkLLf5NVeIO4J1bNrEzf59Z6uUkaGeLt?= =?iso-8859-1?Q?NhEv3qNyfgEHHfTz0/nOW8ABJf00iwOUbt?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4816ccc0-cbfb-467d-c5be-08db028d3546 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 06:42:50.9907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AHWtvxd84tYHr1NYQcDqM7m0Aa3TDJHvrXeRfMk3jC5UqjhK061TDc/orOmIXLiB1CTyl6tkHD6UUNa8LRTj0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7172 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable There is no build failure on Linux. Refer to: https://github.com/tianocore/= edk2/pull/3966 Thierry, would you update the patch to remove the -luuid in GNUMakefile too= ? And trigger a edk2 CI to test it? Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of tlaronde@pol= ynum.com Sent: Sunday, January 29, 2023 5:45 PM To: devel@edk2.groups.io; Gao, Liming Cc: Feng, Bob C ; Chen, Christine Subject: Re: [edk2-devel] ??: [PATCH 1/1] BaseTools: remove useless header = inclusion Hello, Le Sun, Jan 29, 2023 at 09:59:29AM +0800, gaoliming via groups.io a =E9crit= : > With this change, does GenFv pass build on Linux environment? It should: there is absolutely nothing in GenFvInternalLib.c using uuid_* or UUID_*. Furthermore, the API exposed by FreeBSD uuid.h and util-l= inux-ng uuid/uuid.h are totally different; so this is why I wondered, from = the start, what the inclusions were achieving. If the Linux build should fail, this would be by side-effect because a head= er included via uuid.h is missing. I can not test a Linux environment: I have none. BTW, in the patch, I should have removed the -luuid in GNUMakefile too. >=20 > > -----????----- > > ???: tlaronde@polynum.com > > ????: 2023?1?26? 18:03 > > ???: devel@edk2.groups.io > > ??: Bob Feng ; Liming Gao=20 > > ; Yuwei Chen > > ??: [PATCH 1/1] BaseTools: remove useless header inclusion > >=20 > > GenFvInternalLib.c: useless inclusion and dependency on uuid.h. > >=20 > > From 6c0ba96fa11390750e102ebd277f59ef38970394 Mon Sep 17 00:00:00 > > 2001 > > From: Thierry LARONDE > > Date: Thu, 26 Jan 2023 10:49:12 +0100 > > Subject: [PATCH] Remove useless uuid.h include. > >=20 > > Signed-off-by: Thierry LARONDE > > --- > > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 ----- > > 1 file changed, 5 deletions(-) > >=20 > > diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > b/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > index 6bd59515b1..2df7182f8b 100644 > > --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > @@ -14,11 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent //=20 > > Include files // > >=20 > > -#if defined(__FreeBSD__) > > -#include > > -#elif defined(__GNUC__) > > -#include > > -#endif > > #ifdef __GNUC__ > > #include > > #endif > > -- > > 2.39.0 > >=20 > > -- > > Thierry Laronde > > http://www.kergis.com/ > > http://kertex.kergis.com/ Key fingerprint =3D 0FF7= =20 > > E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C >=20 >=20 >=20 >=20 >=20 >=20 >=20 --=20 Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint =3D 0FF7 E906= FBAF FE95 FD89 250D 52B1 AE95 6006 F40C