public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: Konstantin Aladyshev <aladyshev22@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [PATCH v2] BaseTools: Support COMPAT16 section generation
Date: Sun, 2 Oct 2022 02:13:57 +0000	[thread overview]
Message-ID: <PH7PR11MB5863BCC59FBA199D83B7A1A5C9589@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220830101957.18517-1-aladyshev22@gmail.com>

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Konstantin Aladyshev <aladyshev22@gmail.com> 
Sent: Tuesday, August 30, 2022 6:20 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Konstantin Aladyshev <aladyshev22@gmail.com>
Subject: [PATCH v2] BaseTools: Support COMPAT16 section generation

Currently COMPAT16 section type is not recognized and GenSec is called without the "-s [SectionType]" argument.
Add COMPAT16 type to the SectionType dictionary to fix the issue.

Now this syntax works correctly:
```
FILE FREEFORM = <GUID>  {
  SECTION COMPAT16 = <FILE>
}
```

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 BaseTools/Source/Python/GenFds/Section.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/GenFds/Section.py b/BaseTools/Source/Python/GenFds/Section.py
index 447828c8e5..859db7230a 100644
--- a/BaseTools/Source/Python/GenFds/Section.py
+++ b/BaseTools/Source/Python/GenFds/Section.py
@@ -28,6 +28,7 @@ class Section (SectionClassObject):
         BINARY_FILE_TYPE_PIC       : 'EFI_SECTION_PIC',         BINARY_FILE_TYPE_TE        : 'EFI_SECTION_TE',         'FV_IMAGE'  : 'EFI_SECTION_FIRMWARE_VOLUME_IMAGE',+        'COMPAT16'  : 'EFI_SECTION_COMPATIBILITY16',         BINARY_FILE_TYPE_DXE_DEPEX : 'EFI_SECTION_DXE_DEPEX',         BINARY_FILE_TYPE_PEI_DEPEX : 'EFI_SECTION_PEI_DEPEX',         'GUIDED'    : 'EFI_SECTION_GUID_DEFINED',-- 
2.25.1


      parent reply	other threads:[~2022-10-02  2:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 10:19 [PATCH v2] BaseTools: Support COMPAT16 section generation Konstantin Aladyshev
2022-08-31  1:41 ` 回复: [edk2-devel] " gaoliming
2022-08-31  7:28   ` Konstantin Aladyshev
2022-09-02  8:22     ` 回复: " gaoliming
2022-10-02  2:13 ` Bob Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB5863BCC59FBA199D83B7A1A5C9589@PH7PR11MB5863.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox