Re: [PATCH v2 0/3] BaseTools: Add support for gdb and lldb

["Bob Feng" <bob.c.feng@intel.com>]

Created the PR.
https://github.com/tianocore/edk2/pull/2758

-----Original Message-----
From: Rebecca Cran <quic_rcran@quicinc.com> 
Sent: Thursday, April 7, 2022 6:34 AM
To: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Subject: Re: [PATCH v2 0/3] BaseTools: Add support for gdb and lldb

Could I have some more reviews on this please? I'd like to get this into the tree soon.

--
Rebecca Cran

On 3/21/22 14:20, Rebecca Cran wrote:
> This patch set adds debugging support for gdb and lldb.
> It also adds generic debugging classes that use a file like object to 
> make it easy to import into any debugger that supports Python.
>
> Changes from v1 to v2:
> - Moved scripts from the root of the repo into BaseTools/Scripts.
> - Fixed typo of "RISCV" as "RISKV".
>
> Testing:
> - Tested gdb on Ubuntu and lldb on macOS for IA32 and X64.
> - Tested gdb on openSUSE for AARCH64.
>
> Rebecca Cran (3):
>    BaseTools: efi_debugging.py: Add debugger agnostic dbg Python Classes
>    BaseTools: Scripts/efi_gdb.py: Add gdb EFI commands and pretty Print
>    BaseTools: Scripts/efi_lldb.py: Add lldb EFI commands and pretty 
> Print
>
>   BaseTools/Scripts/efi_debugging.py | 2185 ++++++++++++++++++++
>   BaseTools/Scripts/efi_gdb.py       |  918 ++++++++
>   BaseTools/Scripts/efi_lldb.py      | 1044 ++++++++++
>   3 files changed, 4147 insertions(+)
>   create mode 100755 BaseTools/Scripts/efi_debugging.py
>   create mode 100755 BaseTools/Scripts/efi_gdb.py
>   create mode 100755 BaseTools/Scripts/efi_lldb.py
>