From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"ardb@kernel.org" <ardb@kernel.org>,
"rebecca@bsdio.com" <rebecca@bsdio.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Cc: "Leif Lindholm" <quic_llindhol@quicinc.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
"Marvin Häuser" <mhaeuser@posteo.de>
Subject: Re: [edk2-devel] [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support
Date: Mon, 30 Jan 2023 02:35:26 +0000 [thread overview]
Message-ID: <PH7PR11MB5863D434CCAF241EF01A11D9C9D39@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXHXFHBQoOV-rnRLU+T4RQf0RuK5woA1zBVPPf-5kK0_bQ@mail.gmail.com>
Hi Ard,
I have no objections. For the patch series,
Acked-by: Bob Feng <bob.c.feng@intel.com>
Thanks,
Bob
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
Sent: Saturday, January 28, 2023 1:00 AM
To: devel@edk2.groups.io; rebecca@bsdio.com; Gao, Liming <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Chen, Christine <yuwei.chen@intel.com>; Marvin Häuser <mhaeuser@posteo.de>
Subject: Re: [edk2-devel] [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support
On Fri, 27 Jan 2023 at 17:43, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> Personal PR: https://github.com/tianocore/edk2/pull/3958
>
> Changes from v1 to v2:
>
> Removed reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py
> Removed RealView Debugger support and references.
>
> Rebecca Cran (4):
> BaseTools: Delete Bin/{CYGWIN_NT-5.1-i686,Darwin-i386} directories
> BaseTools: Remove CYGWIN_NT-5.1-i686 ref from Scripts/PatchCheck.py
> ArmPkg: Remove RealView Debugger support
> ArmVirtPkg: Remove RealView Debugger lines from ArmVirtPkg.dsc.inc
>
Thanks for the respin.
For the series,
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Liming, Bob: unless there are any objections, I intend to merge this, including the BaseTools/ changes, beginning of next week.
Thanks,
Ard.
> ArmVirtPkg/ArmVirt.dsc.inc | 7 -
> ArmPkg/ArmPkg.dsc | 1 -
> ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf | 35 -----
> ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 5 -
> ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.c | 147 --------------------
> BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv | 5 -
> BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc | 14 --
> BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32 | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex | 14 --
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds | 14 --
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress | 17 ---
> BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource | 5 -
> BaseTools/Bin/CYGWIN_NT-5.1-i686/Split | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool | 14 --
> BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim | 14 --
> BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo | 29 ----
> BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py | 87 ------------
> BaseTools/Bin/CYGWIN_NT-5.1-i686/build | 14 --
> BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE31/CompilerIntrinsicsLib.lib | Bin 36072 -> 0 bytes
> BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE32/CompilerIntrinsicsLib.lib | Bin 36072 -> 0 bytes
>
> BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE31/CompilerIntrinsicsLib.lib | Bin 11504 -> 0 bytes BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE32/CompilerIntrinsicsLib.lib | Bin 11504 -> 0 bytes
> BaseTools/Scripts/PatchCheck.py | 1 -
> 37 files changed, 887 deletions(-)
> delete mode 100644
> ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf
> delete mode 100644
> ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.c
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress
> delete mode 100755
> BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/Split
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
> delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/build
> delete mode 100644
> BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE31/CompilerIntrinsicsLib.lib
> delete mode 100644
> BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE32/CompilerIntrinsicsLib.lib
> delete mode 100644
> BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE31/CompilerIntrinsicsLib.li
> b delete mode 100644
> BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE32/CompilerIntrinsicsLib.li
> b
>
> --
> 2.34.1
>
>
>
>
>
>
next prev parent reply other threads:[~2023-01-30 2:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 16:42 [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support Rebecca Cran
2023-01-27 16:42 ` [PATCH v2 1/4] BaseTools: Delete Bin/{CYGWIN_NT-5.1-i686,Darwin-i386} directories Rebecca Cran
2023-01-27 16:42 ` [PATCH v2 2/4] BaseTools: Remove CYGWIN_NT-5.1-i686 ref from Scripts/PatchCheck.py Rebecca Cran
2023-01-27 16:42 ` [PATCH v2 3/4] ArmPkg: Remove RealView Debugger support Rebecca Cran
2023-01-27 16:42 ` [PATCH v2 4/4] ArmVirtPkg: Remove RealView Debugger lines from ArmVirtPkg.dsc.inc Rebecca Cran
2023-01-27 16:46 ` Marvin Häuser
2023-01-27 16:59 ` [edk2-devel] [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support Ard Biesheuvel
2023-01-27 17:13 ` Michael D Kinney
2023-01-27 17:19 ` Ard Biesheuvel
2023-01-29 5:37 ` 回复: " gaoliming
2023-01-30 2:35 ` Bob Feng [this message]
2023-01-30 16:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB5863D434CCAF241EF01A11D9C9D39@PH7PR11MB5863.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox