From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6B4EAD811A7 for ; Tue, 30 Jan 2024 16:32:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SIH9GFabBeAU3tFCFBdf65VlRKR80zkocarfbpzA1mc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706632341; v=1; b=MD1jVSiWbPGTWaauYcUOx/qXw5yglpPjZTEnyAnfz3SFOCyqGNHwOCbuk4LM6s30u0A3f4x2 gC17FO8B0IdXTpqOpXv+IAq3SbASs6AOxS7kzVBFFVnQmh4pq+P+jEZTaYy2kN2YQTqTL0cIyp2 Yip7aeRrxq4JCbnJo3TH4zLE= X-Received: by 127.0.0.2 with SMTP id q75EYY7687511xZxMG3a1g9s; Tue, 30 Jan 2024 08:32:21 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mx.groups.io with SMTP id smtpd.web10.13630.1706600941846867792 for ; Mon, 29 Jan 2024 23:49:02 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10968"; a="3072869" X-IronPort-AV: E=Sophos;i="6.05,707,1701158400"; d="scan'208";a="3072869" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2024 23:49:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10968"; a="878350431" X-IronPort-AV: E=Sophos;i="6.05,707,1701158400"; d="scan'208";a="878350431" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Jan 2024 23:48:59 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 29 Jan 2024 23:48:59 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 29 Jan 2024 23:48:58 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 29 Jan 2024 23:48:58 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 29 Jan 2024 23:48:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mEulFCxd3GzI6AqDNlhMcmiPx2zeov1JPrC6SuXTvYTd00MNjqire64dTmxhiWfwtXN4bBNhW3z4Yix+NDewc0XrqXDs+JKGVJeOtAG0DTNOOOupAGsrsDlka/Fl4qfAoc9P0GS1/9fhxayE+97hCum5lxIlQtIuILl2DFUbfZSRXF9Z7DRG1DukcGdOEeqwtaghSuhcLk7DbIvp3NlZdPJi27v8f+bXwva2KmoRiyTt+/PMfvzxccCITESbDBKlAD5AKeR+BzmGF8m/MUzoNxRfZrgyMHJJkS+pjkbRyP4eJmyOHY6s3RyxtzkZRd3HLOKOJSti6g7pzOQvfSqitQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJ6OioG//26hJyRLoRW2+lYJjyxkNBzLAD/rCbZ3w9c=; b=PGWMhYqT89XDned5JYpUM8mDOf0WEbRWZASQLF8wVFhDyvTkopgTgNC5vLhD39GI6+2kyibgPzxIuZLWkbs1OHhf9ZoOCkXi6gE6liGlxLdNmZfpyxUuydI1VHSltc7uf/oBNXP+Nh36GfwYRHIRc6Z5HPLUysWHF5UuFCpXXwo73WZfDlCKFk+1UVOXBOBz5hF3NvYHnlu7iGK9kyhFjCurIFUQn8r3NlpZr2VFu8bZozTkIHdx2cveaNybU3/umFk1XawhHbHLirPamGSIcjU9hU9drAsSnXpuGnxivRY6P84MRgurCTwCXtIlFmVq3j4iCF9qSa5ZvPF3mL8Ytw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by PH7PR11MB6859.namprd11.prod.outlook.com (2603:10b6:510:1ef::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.22; Tue, 30 Jan 2024 07:48:55 +0000 X-Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::e4d6:ab6:b4c7:8830]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::e4d6:ab6:b4c7:8830%7]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 07:48:55 +0000 From: "Feng, Bob C" To: "Chan, Amy" , "Chen, Christine" , "S, Ashraf Ali" , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaN0b+mR1Xjx7/GkyMPRK/JJpEv7DPJOiAgAA5LYCAItTJQA== Date: Tue, 30 Jan 2024 07:48:55 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|PH7PR11MB6859:EE_ x-ms-office365-filtering-correlation-id: 0e9083a9-5109-46dc-7cb8-08dc2167e8d1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: lWEyFzH8EUjJtxsdfpC8i19ln2Vn8fGZ7NW+IE6HHjGaHu3PTszxDxdfbSvojhL7BVgUB/WLd0j7htSk/GMImXV+nzLtXExGgqw1uvM0GrFUSIZWtVFfLd9KhGlA7JCw1nPaFXR5kFXA3c8R23ZUHChPyNn9ZNzapAcauCQhlnVZvCPi3r/UAcTJddCziWonhPR3iZOJbN+OOZW3IHs5/ADh2WzbdR0kvrxMI7STOByhs0BVGukpt4S88yd3bkVJ2jma9yF7LH5yAFLdh8NVemckqYnYycnnJ+ZYQY5FH3dAExx4tjchOqvZTfcwOjmmynwU+81fl5708F0B6rDrg8LqtkmdzD29zRMhJwZF5UVzQvLpWQ/91IpHaNzGbVUPAUebZi7WE2qJhlXPchj+lICy5uLTR2Vu8cxCyoVOJthUZqfcz6PJKw4LcTkmsJbGrJcj4UveRGbeZ/PU+i0LM1dBs+k9yF6ZZoL0tvxkd9EIG9gak2ulE6bHVsWjIHmUtrkJ1s9D/lnPF3tgIAW0cV32wG62JzuG2FuSIWEpJz3MQ8v9Hb75RgiJMyPMz7dE8y5t3++ym6PFTxHHBhMr9uzvZqMdAvZsAUVcoU+d/UsAP5Ik5cD4KAKIM27+hMy2 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wdPAeX35i/ydtQ4P/X0QsDMpEfu//BVZFQZc/6sQm4IhFN2IksNyh7R/kshN?= =?us-ascii?Q?dk1QgDGkLLU/hblOMkoCUsb872VPkVN7lq0pj3M2kUZbNctbucQsmCD/UXMc?= =?us-ascii?Q?N2BhbqyYaj+TetNfKnbbkhJsOMMtkdB0/Nj/nln3iE4/8fBYSHBnxSjcsYki?= =?us-ascii?Q?/sXoshV5StZe2tD6TJIEh6kVBRxqLOPTrtqqXVxLFG3I4rI/x9y+eZ4MifGq?= =?us-ascii?Q?BUGtzQ3FJHzZujj5PBFHK5Ibr94ZMKwPflAu+Iej9pHjyIrXGqSAUhMY8W+b?= =?us-ascii?Q?S36xUn2zSS8QIw/HcwaUN45vX6dYSg0DOg9JNPVxMVTFtrbQE2VTzOloZYMY?= =?us-ascii?Q?7YIxnBT2tq7bsJ2rLLhdND2oCa+kfXqbg95TpFwM+PPqh/otbDjYL8WRuFUy?= =?us-ascii?Q?BBnVx2gSiOd4pjAwoxHP8QFwj91Ol1FWJjFFF1VW48G9rtEzFucevdtGSv7D?= =?us-ascii?Q?YGvtllSdSnJHLSXS9tu/VQP4MwmuHrHSSmSX2yAio7dItRVwJTnNtC8MEJ4C?= =?us-ascii?Q?W+bT99McUqp5097xaUKoIiYJJYPSeaUX+s+rDJDMOZDLOAvXWdBARC6cqEHf?= =?us-ascii?Q?qvQxx0k0GR+9PerE1BQUSaGdr7cPdisVXTcJF+15PrUNIv0pzXYODjEB2Uuu?= =?us-ascii?Q?dOh6IOEZVwr0VuQip1V8BUKdYQy5xO2EStJZInFGL7xyERXKSj2JGid2zBn0?= =?us-ascii?Q?0/NA+Ty2tUULiI3EUssIEa1c/gP5eo6GOONSw1OPXsDMRdNxIShop/91Eas+?= =?us-ascii?Q?0x/FePH4tUBgObircVIVWFKII2lDkV6Ynldl+XTajEqJ4nVbMzpi4XiqScmd?= =?us-ascii?Q?TzqIfFgujLgo5N67fmhQvVeFMcfJgkpTJ1MO6yq8PaJj1m0h56dW0jHIO3so?= =?us-ascii?Q?M+7tfSb1W+mWq8nFLZGFRLJa/Gmymo/AImdBAgRGKxYtwdHxwZDTHGkJheZk?= =?us-ascii?Q?++8rlOHVCllsFNRPYBNQQMIZ4mu0FfD2OqJgfaU5lOFilw6LLhQrofAhs5Wg?= =?us-ascii?Q?p3ieTemKtTJwFyMordTSjbUpM4Az17/aQTEBC0YC0xwOykqSd/yM3Sz1P+0T?= =?us-ascii?Q?pZFbxU9u4aZtCRHwufpZd+2nn0YzHHUz31HmbF81quffjXS5JraIvCE/4TRU?= =?us-ascii?Q?4lFS6jcGWpEwEx1MAhAqG3dfyeESv09BujJC2wghNME0WAC6af2Swk00geqr?= =?us-ascii?Q?7cleo0We7EHtLhgy8Jcb+u0LL33y7nH13JIyv/3OwL+NEkCMvmQutlmC1nLT?= =?us-ascii?Q?O8qXedh7IWTahM+G/gMK2Pdr0RyJb/UnqGQsRJAMVu6CEhvCVd2JA3nZBl3a?= =?us-ascii?Q?er/RopWO9cRzTCIBA2rIpuNKxDA0Ut98iCIc7ZrvRaOt4ygfPOPh3xTI+LFT?= =?us-ascii?Q?9OTBn5LTiJNtfbVOEcANX9RiL/rnP4SRRTbk50Km6ioR6HkrAYu2Q2GpBAHI?= =?us-ascii?Q?urBCKFIbC3KT7AEr8MnwtBMz4zEbXRnfl9mgArjZDzB5HVpd3tEseuhvXx64?= =?us-ascii?Q?zMTD3fUH8yiYGY6MwZUJBFL3idT0dPEW65BaWgrJZeL8p1XbX5A4TAPuKFuq?= =?us-ascii?Q?Gxd+30L0RI0WkNzOql/0BuwhNl+AMsuvhO+8Ccwe?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e9083a9-5109-46dc-7cb8-08dc2167e8d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2024 07:48:55.1042 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qpdPlX54tQUePi7KpswjxzNi3fA9pWiV3czqGb3X6dBSMPxOT/DiDlZQZ0UuqBA9iBO0rblmwfuqC6DPpIIeBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6859 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bob.c.feng@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Xh1rkaE3manYEcJc2qQuTcKbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MD1jVSiW; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Bob Feng -----Original Message----- From: Chan, Amy =20 Sent: Monday, January 8, 2024 11:54 AM To: Chen, Christine ; S, Ashraf Ali ; devel@edk2.groups.io Cc: Rebecca Cran ; Gao, Liming ; Feng, Bob C ; Chaganty, Rangasai V Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId = from allskuset Reviewed-by: Amy Chan > -----Original Message----- > From: Chen, Christine > Sent: Monday, January 8, 2024 8:29 AM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming=20 > ; Feng, Bob C ; Chan,=20 > Amy ; Chaganty, Rangasai V=20 > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and=20 > SkuId from allskuset >=20 > Reviewed-by: Yuwei Chen >=20 > > -----Original Message----- > > From: S, Ashraf Ali > > Sent: Monday, December 25, 2023 11:28 PM > > To: devel@edk2.groups.io > > Cc: S, Ashraf Ali ; Chen, Christine=20 > > ; Rebecca Cran ; Gao, > Liming > > ; Feng, Bob C ;=20 > > Chan, Amy ; Chaganty, Rangasai V=20 > > > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and=20 > > SkuId from allskuset > > > > Currently when the platform has many SKUs then allskuset will be=20 > > having so many duplicate. and while parsing the allskuset will take=20 > > longer time while assing Pcd.SkuInfoList. > > This patch is to eliminate those duplicate entires to reduce the=20 > > build time > > > > Cc: Yuwei Chen > > Cc: Rebecca Cran > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Amy Chan > > Cc: Sai Chaganty > > Signed-off-by: Ashraf Ali S > > --- > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > index 592d4824a4..dac81454a9 100644 > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > self._DynamicPcdList.sort() > > allskuset =3D [(SkuName, Sku.SkuId) for pcd in=20 > > self._DynamicPcdList for (SkuName, Sku) in pcd.SkuInfoList.items()] > > + # Remove duplicate sets in the list > > + allskuset =3D list(set(allskuset)) > > for pcd in self._DynamicPcdList: > > if len(pcd.SkuInfoList) =3D=3D 1: > > for (SkuName, SkuId) in allskuset: > > -- > > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114799): https://edk2.groups.io/g/devel/message/114799 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-