From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.3266.1666143984786891862 for ; Tue, 18 Oct 2022 18:46:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=kOCK730R; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666143984; x=1697679984; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qxy2I5cHCI2A8qr3G0sIRpbBovM5wJDRUI3TXVQ6b3Y=; b=kOCK730RwdFuPkYyP0TJIovSLUWbV/4ELGB8mX1hANI+XY/9W9NqgOil 9x5aNE0XHVk/KqMUIbmJ6+rRWoD9UELU5jSAn9HnhUTQNfahCOYR9zGcF qmMlvJj0CMjMQc8gEROFa/LCjwRnd5bVqWRFxoW9HrU8CjFDekXND2On5 Cdh0epmHbNF5qH5aHIl8brfjV2VpSYOfoW7Wdd1ouovMJMycPO85gB5fy SgyHMLJxgkOL6zWIDzf6+btkw4sY7IDfF+dfxkOVkNbhcKEFojU9DmNlC dDaAioIXtCVLdK+Hbwgfig5ACjzDuHPmLvcZEn0HxGt+5a+D9DzRLzkXT w==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="370500706" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208";a="370500706" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 18:46:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="804049518" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208";a="804049518" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 18 Oct 2022 18:46:24 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 18:46:23 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 18:46:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 18 Oct 2022 18:46:23 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 18 Oct 2022 18:46:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aj+o+OoGJkJA7Xf5O0tziIP0YFYwhuaDqcW89OgCRvBt9X0/MF6l0mweC+UBNv8v3khF2sqtllP4GpQtl9BDcJFOUJX+cm4NZmxEnAQbgzgAk5Ob40zfL1wpRA8+KJuxAxtPDskQzuMUIwt8Lff5Vfg0JOgjOg1bZzdSl/6G8Hu0imqGz94lG+jn7SSO/fmbpG9sR9EPw5S5HSTsVEFD6zzKuAfak/gW5fDgCXb9CFQMrb0A42EyvZrNVMqLdi+1d28yIEnPlv7Y8hRQWOMffXlAczFk9sn3u7OoVNdCznFmkK9aI5flBhYrqLv0ZDfK9iwXpu2clXmPnedilG+SEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6R8oaLt1fhfgkOodheedoKCm2eKCXsAUaknE6PaaEQc=; b=FUwvaKsbJCClWx0MwOLiX5qmRqWlaORfyBEg2sPrIGvh0EeihBWxBoGz74cR2n+KgMvEjcLrB+LpxEJD72ir+/t7s47qFsxHpAz5ViOKMRiCvOmD6oXwRHW9iVDRfABcDLHEoXmdTujoPgaRb0bETBkCyboMdwaGrlr0h2brZTGF7SFE87igYL9/fwpACgZ5Z1+X/YnLEvWHKcZpE2IlZiA0gaO204l/jhu8+xs85n91Ya7Jh2wVfEHkuuGdNwPEPy4dpTTpb5mtk+E4VoUIjDa+Q78nATpVaNG7HOUdB8OAcGpbRf8VXyZajYHqs8UFKXf0R+lU4zuquynOw/g6KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by BL1PR11MB5977.namprd11.prod.outlook.com (2603:10b6:208:384::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct 2022 01:46:20 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::5a9e:911b:b5fd:6503]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::5a9e:911b:b5fd:6503%5]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022 01:46:20 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" CC: "Gao, Liming" , "Chen, Christine" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Allow tab in Makefile Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Allow tab in Makefile Thread-Index: AQHY4RExg6zUx/sa6U2QpJhAe8YDUa4U6PtA Date: Wed, 19 Oct 2022 01:46:20 +0000 Message-ID: References: <171E6FA868D99F8D.19083@groups.io> In-Reply-To: <171E6FA868D99F8D.19083@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|BL1PR11MB5977:EE_ x-ms-office365-filtering-correlation-id: b4ffe17c-96ba-4538-8395-08dab173b8b4 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ezhK7XWyyMyP26qsTBWefirPR9uRfTGYC7uJOQfGRbAmbQg4d1FgpRL9bUi3qXAUNJcDySezMC4IBiJlOJhQtq5L3vMkK1rr6u8TUwWivTRnrVKjif1y/S6ihDaSFIuOLMrouZS3HF/xMArNDEgMmIBaFz3AzJz/PEpWwkzqBCAdRPGJYIj4qqU54ZCfNdl9GoaSnBk8BYVfry4FuWmC7pfHo5iR91E/oS/FUypsT/IQ4wMEUQIRntCJGxon5ugbANWp/Whj+oPAzqRmGjzA/daWYoXHxkbKz0gS1Z3gmMq5Yoih3T8qEqhPFjhE0Ej+31Kn4CC2k45+SQ3DEIAxRqBTCpkAxAWQS784FDE1gx8vJLzULTKX+O8ppDnGZ+nFM0kEePzkYeSasFp3YRhQtmmtH4ZQa025thJwhXC/+iRMMWM3rW3IrKFqc4IIw/TpWsDfWSZ2V2CwLEDHQqjuen0hp5id9Hf3jZA7+V8EAhIOAo9mErvzQwtsPuND7wqQXK3B1kTS4esRkiJUo0LxXtALoCTDYXYiI5f5tcZ+NwurGoebBtxAdH5WXXqij6+3hVZWtI1oTOBZcgGZr8xqZVHJO8LKGFc2v6ljGRH819lzhlJ0uRT1Z0D2whtTRiF41tY2ZgO1oXD5j6blk3HlOiK/2EyouFwt0ybJA+R0lQFt+F04P88OhVzUmE9U55ykPfjc5p0WmW+rB3yiSp8gdVWadfhS3bzKU83MJE04TMIXC7j27Vn92NTAg9w+9QFgOFOmF8/4ODaC2npBFhLQu5852MQdjnSrE81alJ2pi50TRgWW145APfe2oyf/+TJSF96qie753+E7aJiggq+DOw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(39860400002)(376002)(136003)(366004)(451199015)(66899015)(41300700001)(71200400001)(38100700002)(5660300002)(55016003)(66446008)(66476007)(64756008)(66556008)(38070700005)(8676002)(53546011)(7696005)(4326008)(82960400001)(86362001)(66946007)(83380400001)(52536014)(107886003)(478600001)(8936002)(966005)(2906002)(110136005)(122000001)(54906003)(9686003)(76116006)(33656002)(186003)(26005)(316002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?viRz9GLUCLwubFQCxqcr20W0mb1Q2O4JWklUE1AM9Va8NyrJi6g3inbO9apJ?= =?us-ascii?Q?bKXjabX6+aFfyc0QrA75jOIEGTwVlHb9SSqfnpXbn5RN+cOvFBr3DNqrndJ8?= =?us-ascii?Q?GGNgqX7URigS0QgiOb2tKi2l/p47c7mQIl3mdtK//1j+Tl6HoMW3kuCt3jqb?= =?us-ascii?Q?cei/mfC67RJ6kXdTfX7K5Ng71K3JICyJNbVw8Mdnjqbh+iJJ1igpZybDUb0V?= =?us-ascii?Q?r84eshA7Yxx+l4reoWFcbtLOnw3UV8fe9DrSim7UUBpcqE7TVnsgC0Ur6QbA?= =?us-ascii?Q?PNSl0m+TgXQaFdePGGpWWmrWyU/Am6cyCdtv4WtLyY9J9F34PJ068hN1IUWf?= =?us-ascii?Q?VVoB3cMrwGvyhorzPJNexWnc71hwfOBM8G5RZETbIXSsOHDL7RjLdtHnwpM1?= =?us-ascii?Q?p9Tvvc7qjpnEaKYKFhCXPJIlsc8kJqZmgvkQ+LY6Zi/pRE4QZcs0PuzshNwl?= =?us-ascii?Q?A5X9/SjADRqjXIelJKOm4rI6LJYdUrb/pLF3yQ3Lz0VSqjnxtOJKZf84bJip?= =?us-ascii?Q?Sav0PoMWbtjXMU+WwCjt+Q/PiXm6gN5NN0ZXl0GZnbORR1cN3q1p8bhVxx3x?= =?us-ascii?Q?VZIKvssvUiO5JTysaRKb1C1ygNfd97RncjxYUVy3SbeyGAgOohlbFk7XuEaB?= =?us-ascii?Q?LfeHxDUFfKN+d2xbiIl+2qAzGyKqhLn89SpCVToBa1wcNFWdSyhk2oH16ZGc?= =?us-ascii?Q?qEsOcxWAqgnB4G+HJVaOcZGEz3iwomxSp18zTC8J6XKrBOYituh44e9uWS94?= =?us-ascii?Q?tF8DVrIA9YDOYN2QUmUyAyRcglBWzzK3MFcnXXC/2CYWMXHZLs5uhDSuPg5r?= =?us-ascii?Q?9sO35m7CyZBNRNMDbWsVZ9tX3tyPPkTttgmC8nuccYCsHl8CPsrFlLe+4P0F?= =?us-ascii?Q?RFopohIBsJAxDV2PouFti1qp7YlBbuDLpdVub5+MuqGilVVRc5U76FKQpg8Z?= =?us-ascii?Q?O+gpsQVBkdXSYRqhXn0BLx9pS9ycnJy4RxVpPsChwOCFH9qT/orKbybLjVxM?= =?us-ascii?Q?Wly3rDhO+uKFDVFV0CMjpsliQ8tp02dq9FFenayYyNLon8XFTs9j8yPxddaJ?= =?us-ascii?Q?G6lmPrPu4Tz+EFfqolMt1TZRH/GMtPbz6rwSHC9UjO2/HkLtm5x9/U81jbGr?= =?us-ascii?Q?Oi9gev9Pap71ZXM2VrBJn3N2OKkCtzjQWIte40Fx8ELDSKsiAH4SJ8696M2S?= =?us-ascii?Q?9v5bdGCBzSVWZlIu0zJUA4LN6O1UdeK/XQ3UMRWO/KEIahwT32KXHfzZRZfk?= =?us-ascii?Q?hsAoit1cpyFVImK3Lyn+pxXqi6DzEi18ZGepz3KzdlK+JsJx8A9PUxNQLFgf?= =?us-ascii?Q?Q+kXv+Rzw6ucsMgte1IwgGIP4lbBb5MjeSuAklqKQgImuQ2CQv2gQBgwDUD0?= =?us-ascii?Q?rE4PTlqVk9v9R0U1xwsHrP4fl1mZD2qW/pSldu9kVY7Plw3sfKjMXszFikPL?= =?us-ascii?Q?kPa9JwEaik8WnSTpY3KNqV64WQawWPNcqtHv78s06JiXlPd8r200kEckALz5?= =?us-ascii?Q?rEaxjVWNTjkqziHckjp8lUoD42AttqbOaWSXU89UT4qlMRm4hSrM503WApo2?= =?us-ascii?Q?ueDOGRjfCjnuWGbqYS6Ccm7ClLiljKcXBQzgnVb0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4ffe17c-96ba-4538-8395-08dab173b8b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 01:46:20.4227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8K0Y5HiPmAMwQYvITKOndDKvssaVltxFy3NqtBQG2/NjJAWeQZghbFWqjUOal4AqY8szy+di1L3A5W3qt/l3zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5977 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Christine, Please help review this patch.=20 This patch can unblock the CI test for the change of Makefile/GNUmakefile. https://github.com/tianocore/edk2/pull/3436 Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Sunday, October 16, 2022 11:41 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine Subject: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Allow ta= b in Makefile The syntax for Makefiles requires that indented lines s tart with a tab, bu= t not a space. This change of PatchCheck.py make the patch for Makefile/GNUmakefile pass t= he PatchCheck.py. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- BaseTools/Scripts/PatchCheck.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 63e6223f8ebc..475b3a8c27d9 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,6 +383,9 @@ class GitDiffCheck: # self.force_crlf =3D False self.force_notabs =3D False + if os.path.basename(self.filename) =3D=3D 'GNUmakefile' or= \ + os.path.basename(self.filename) =3D=3D 'Makefile': + self.force_notabs =3D False elif len(line.rstrip()) !=3D 0: self.format_error("didn't find diff command") self.line_num +=3D 1 -- 2.37.0.windows.1