From: "Bob Feng" <bob.c.feng@intel.com>
To: "Srinivasan, ManickamX" <manickamx.srinivasan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"Chen, Christine" <yuwei.chen@intel.com>,
"T V, Krishnamoorthy" <krishnamoorthy.t.v@intel.com>
Subject: Re: [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support
Date: Fri, 15 Sep 2023 07:03:10 +0000 [thread overview]
Message-ID: <PH7PR11MB5863DD2C49D9837EF85B71C8C9F6A@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230913085628.22913-1-manickamx.srinivasan@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Srinivasan, ManickamX <manickamx.srinivasan@intel.com>
Sent: Wednesday, September 13, 2023 4:56 PM
To: devel@edk2.groups.io
Cc: Srinivasan, ManickamX <manickamx.srinivasan@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; T V, Krishnamoorthy <krishnamoorthy.t.v@intel.com>
Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support
The length of the Board ID is being updated based on the BOARD_ID string. If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: T V Krishnamoorthy <krishnamoorthy.t.v@intel.com>
Signed-off-by: ManickamX Srinivasan <manickamx.srinivasan@intel.com>
---
Platform/Intel/Tools/GenBiosId/GenBiosId.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
index fa3689867..54503fdfc 100644
--- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py
+++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
@@ -141,14 +141,16 @@ def ParserInputFile(InputDict, NoTimestamp):
if Item not in _ConfigItem:
EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigItemInvalid % Item)
_ConfigItem[Item]['Value'] = InputDict[Item]
- if len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length']:
+ if ((len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length'])|(_ConfigItem["BOARD_ID"]['Value'][3:4] == " ")):
# The length of the Board ID is being updated based on the BOARD_ID string
#If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings
if(_ConfigItem["BOARD_ID"]['Value'][3:5] == "\'\'"):
_ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3]+_ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID"]['Value'])]
- _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value'])
+ elif (_ConfigItem["BOARD_ID"]['Value'][3:4] == " "):
+
+ _ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3]
+ +_ConfigItem["BOARD_ID"]['Value'][4:len(_ConfigItem["BOARD_ID"]['Value
+ '])]
else:
EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigLenInvalid % Item)
+
+ _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value']
+ )
for Item in _ConfigItem:
if not _ConfigItem[Item]['Value']:
EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, ExtraData="Item %s is missing" % Item)
--
2.30.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108697): https://edk2.groups.io/g/devel/message/108697
Mute This Topic: https://groups.io/mt/101333312/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-15 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 8:56 [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support ManickamX Srinivasan
2023-09-15 7:03 ` Bob Feng [this message]
2023-09-15 12:05 ` Yuwei Chen
-- strict thread matches above, loose matches on Subject: below --
2023-08-23 7:29 ManickamX Srinivasan
2023-08-29 8:45 ` Bob Feng
2023-08-29 9:10 ` Yuwei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB5863DD2C49D9837EF85B71C8C9F6A@PH7PR11MB5863.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox