From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7BF957803CC for ; Fri, 15 Sep 2023 07:03:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ABwK5gz4TQyLBu6nH2p9C+Xe82o2RLHr5VYjwwZX07I=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694761422; v=1; b=KwelBYmyJaWzIjtA/Gu65IOoU1TVBbVcAobwMU5pp3K4jogzjft25DfaU3Mk7t/Dgaf8eam2 iIbbea5LAucJqqyBhX5oEs1LNv+p6Ia8bMd5KqJttrUvPkgq5AXj0TNobQ1OjY/T12bu0af97Gi J9PF25Lc7qgox/Mr/qjN9qpc= X-Received: by 127.0.0.2 with SMTP id JlTQYY7687511xl5FuBpZDaX; Fri, 15 Sep 2023 00:03:42 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.15504.1694761420576305645 for ; Fri, 15 Sep 2023 00:03:41 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="381905866" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="381905866" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 00:03:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="1075698319" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="1075698319" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Sep 2023 00:03:22 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 15 Sep 2023 00:03:22 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 15 Sep 2023 00:03:22 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 15 Sep 2023 00:03:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BHe3OgdznJdUEEsVJXGKl2nCuHU/KlBepX3P/aUI/5DWtyH56G+2LCjufOXI+2Z8V+6V5OAZMnZAqxS04QkrAw1N8V9dda1+xNu5o042UfssFBp1XXF4k91rFJK1lUK+RO8C43sBocg1OEZLsU3dahKYeok361X5WOeZbFwU58FMWlGLBCSlBflwPidA0QhnLpU7eSaurr9m566wyBBF4IfUDSR4sL8nUq8CiekjhM3SA6tsa3DuFEe2y4ZHERjRgg09JfamuPr67AtZtX8F58pc60OThywKNvMsWZI24XQzjtMcRMymTGfWsC3W94raMvLHjVeHQsAjwi9QWfK4ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LhlV/V4pNzPUOAPT7KMVUox3nxmUMsvcOUc8dqwBnjc=; b=NajBIq8WpX5K4pl59VDDBTa3GqPoTLUv/9J6ZR1eFfVTywWH2ZdPuw+lHnadAdcMXgDtnNndKg7hJ+mMAP3hYTOXlzd96TT1vNWe3ie5TT340Z0C0+GxbU9tbhvkWLq6XctKL7QlIH7wFD2oWioAfVL+FFO4GN3ITdjsuLKCljhgk74O8UupHAFj4mpu5GpFbPNISjx6X/79zw18u0jjpsvOtZgYl3mc7fbdnnUV3ZbDMGgRJF65mBxWqMREvWpmDwKSf28gJrDR1IuyQFO2y5Zxldkv4BthrR70GrpaTwm4mumugSCSFeS3O/jaXJGqSOK1J5EJ+HEfBU5SFoyXQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by CH3PR11MB7324.namprd11.prod.outlook.com (2603:10b6:610:14f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Fri, 15 Sep 2023 07:03:10 +0000 X-Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::ec:877e:9aea:7dab]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::ec:877e:9aea:7dab%5]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 07:03:10 +0000 From: "Bob Feng" To: "Srinivasan, ManickamX" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Chen, Christine" , "T V, Krishnamoorthy" Subject: Re: [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Topic: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Index: AQHZ5iL2SNN2wLEuKUqROhILTir7z7AbePhg Date: Fri, 15 Sep 2023 07:03:10 +0000 Message-ID: References: <20230913085628.22913-1-manickamx.srinivasan@intel.com> In-Reply-To: <20230913085628.22913-1-manickamx.srinivasan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|CH3PR11MB7324:EE_ x-ms-office365-filtering-correlation-id: 5a073da5-748a-4bb2-3cc2-08dbb5b9d254 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: D8gkK0ld41xvr9bm5XL/o9fpRk7VxCePQvcK7vJmxBFNlXLKJWYt4z4sjh/sgTWHeolnMypYP/Vvgg/R++yqL2RFa+5VT6940vXDwZHKK0uvMEWWP4lCnGPvHpD7SOnh1xzvkWsWJ1txbp6hjfVzSDxHPJVFqVDNcw93sUlN+gsourCAWHghVYcK0tAmCFBQDWOFhCXsXtyPCY6QJT8cE52n/gEEekcmlFDKpKzRVwwirUHBIqQ8YORN8K3gHZkQXM8wcYlRY08B9Uo60UT0lhfFJJ9qcK/1Tf9Aq9VNSVqOxTGJwhzROl1XbL/XUg6FuPdZkfvHdl+AsPleTrFmt0Ffuct5retHW7ozTLhD8azB/EPXJ7RcJ30s6PMXQdVieOO4cjWoNobbH1dYEPF+6XXZAly0gdtFhJL3EFPMFnm1YzvNDoK/iDacHoo3GcvO483p5B/Akf3+WVInkmExN39eORYf0hvpzZhA1oi9G42DY1dD5mopDZWsnqwZop9rBPX3jTOXMflMxvoerA/36hzNJ3cUhtNM8YSPpBBcY4ZP7s6JRNolba3EVLbzpGaKNat25UY/4Hp9chWWIzzVAsyhKkOE4UDXNrAa+coouK60Pyw6b5vwvTDTwBInh5y2J2zymiygty0Nn+mahWUEPQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OyQaRm6Sy6IfnxhoEYjACDLkNqo8F1rPeQbwE2pR5E+wb4nekBe3WpXjye1/?= =?us-ascii?Q?jIObJsN597sOIjIwsUlYQ80M8Qvo/LEkLLr6Fo2ZldzVf9h7tPFriodLx1Lv?= =?us-ascii?Q?Od0TXT0kKHBnPwPz/S3xGZ+V5+AbmTB+Xtnr3tLPZb5ndXgzb0KAzz6PxY3w?= =?us-ascii?Q?4+rGMVyBRT2JkS4rJxA5b47DHdzRZs+XsleZImh/7Ln0mbQSVMnPgVzzUiRB?= =?us-ascii?Q?CxB3w/tGfEsB9//d0oFyhk2fHDOACgux6ZJ9BHt65mu4Qx+VUyBNlsgw6rk+?= =?us-ascii?Q?35eFjJu238G3DR+xkHmx+nzX2C5Kop4XptR+CXsvBHHIa7umpAYIwL6qDfoO?= =?us-ascii?Q?mtZ9sNCqhlD6Jmk2kQ4LG7hLHmKkRvlgbh6U7AEys1VQmt8/PmOKkoIZTDIv?= =?us-ascii?Q?6cRYoeAJnewEG0dhoXJDBXlGEXa2V1YNDFZDMIjcEreQvhOINGd48LUKEB9X?= =?us-ascii?Q?xwfoXXjnX0BKZbHE8em7Khy2pf9I9WddjyXfr5cbhQO0N/7qSNEQw0w6ndCW?= =?us-ascii?Q?XWAWrHWSmbNzwL8sJapMOkV2OxewCvjoeOr0sfpQjyM4vqWh1xqe186Cxbp7?= =?us-ascii?Q?Kk8KHZBxW4IH+se+eKw7gWFrK5ai3jF79zJeYzdyZnRnkAqIVfbtB99HMs/o?= =?us-ascii?Q?pJbS2lM2PtW9GWvf1YVdFFzmJ6b1BoCMCH/C6bit60ItBYcxUh7n+osr+wX8?= =?us-ascii?Q?5yAv11jWuIhfRu2/KHZVJ11iQjoKmAsQZJDcG5VSrjUQvqi3mgL6OavaHuPN?= =?us-ascii?Q?tsSmngpS07v0grTHTllGDAvB33plM5IMloViro+Xx7Z1FTv2CLv0sNa29bL1?= =?us-ascii?Q?PrOUtGUhXJqp5PfFsRuYvlIg44VKWnGDnmxFdXtBSRtBbYeNAweNoJhxnG/g?= =?us-ascii?Q?SyCmHCh62Uck6Z4SCIDcxzPfREbr89X5CUgtmfCxBDhApftHIqKI+7GwCaNb?= =?us-ascii?Q?OG+woSlMcilO4BX9A+No09oDeoE4QecDXQSJnqkB4p+jXq2Sh0xYiyxeWNM6?= =?us-ascii?Q?dno4Ek7Q1uszb7smt1eGTDXDjBhBODFhrAPVD8CuegyXHYjCsLRnvC6iTrad?= =?us-ascii?Q?Il3ACfEDMae64jbpvxbUf5/GYrRvhiBK5P9me986RVKNl6/CJMOR+LocBeHj?= =?us-ascii?Q?ApC+TWcbH72ZeL9ZSQ0XHj2oCxUC/ort5vSsyn5KsNPH/lFnNQlKBLB3fWhq?= =?us-ascii?Q?OncHGEShxDNYMjknvDTJykqjWrPXCJzXL1wWwFnHOyXH1X7dk/DZXHKUXTrJ?= =?us-ascii?Q?x27SXuEh8FS5qEdfgBW6Q2WA/kT9I8okwfCpfdvWbFokVAZ2wagDgK4p9L2C?= =?us-ascii?Q?LokQY9q1FUPvmqcbqDhGltrKUYlwLASzurQvJSpZiySE6wJ5kqzG4j4fGI4n?= =?us-ascii?Q?us41F+fpbYMBrRA2rX8prJ2wj6ytyvBTuY+tpNppohETi5JMD05vMyOg9UCh?= =?us-ascii?Q?uzvlWA3W40uA+f/oDWO9ivk7KbVFC8Azgi7OjVpEtdAhp2qgUFaAhie+qjr/?= =?us-ascii?Q?OCpHiwxT8XQT2dgTHmL4wenjMhosZpwqYSGOSZzUoCUIuiuC7v+mKFAjL1jb?= =?us-ascii?Q?515C1LdU/QIq0yMxG9EOSGsKbii5mFuGlI9IPphl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a073da5-748a-4bb2-3cc2-08dbb5b9d254 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2023 07:03:10.5205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KQcPjtRRuh+n30Pi4xhYVAAhqqILMTSFmmPNTa6sMftSTuQLwJO4obLmcrLxw6jiGkx32mxgrcOnQgEkhYD4Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7324 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bob.c.feng@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ekhGNrL2V68GpVK6eAMcSsd8x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KwelBYmy; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Bob Feng -----Original Message----- From: Srinivasan, ManickamX =20 Sent: Wednesday, September 13, 2023 4:56 PM To: devel@edk2.groups.io Cc: Srinivasan, ManickamX ; Feng, Bob C ; Gao, Liming ; Chen, Christin= e ; T V, Krishnamoorthy Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE supp= ort The length of the Board ID is being updated based on the BOARD_ID string. I= f the PCH_TYPE is empty space/single quotes(''), removing the empty space/s= ingle quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag= strings. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: T V Krishnamoorthy Signed-off-by: ManickamX Srinivasan --- Platform/Intel/Tools/GenBiosId/GenBiosId.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/T= ools/GenBiosId/GenBiosId.py index fa3689867..54503fdfc 100644 --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py @@ -141,14 +141,16 @@ def ParserInputFile(InputDict, NoTimestamp): if Item not in _ConfigItem: EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=3D_ConfigItem= Invalid % Item) _ConfigItem[Item]['Value'] =3D InputDict[Item] - if len(_ConfigItem[Item]['Value']) !=3D _ConfigItem[Item]['Length'= ]: + if ((len(_ConfigItem[Item]['Value']) !=3D _ConfigItem[Item]['Lengt= h'])|(_ConfigItem["BOARD_ID"]['Value'][3:4] =3D=3D " ")): # The length of the Board ID is being updated based on the BOA= RD_ID string #If the PCH_TYPE is empty space/single quotes(''), removing th= e empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT= and BUILD flag strings if(_ConfigItem["BOARD_ID"]['Value'][3:5] =3D=3D "\'\'"): _ConfigItem["BOARD_ID"]['Value']=3D_ConfigItem["BOARD_ID"]= ['Value'][0:3]+_ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID= "]['Value'])] - _ConfigItem["BOARD_ID"]['Length']=3Dlen(_ConfigItem["BOARD= _ID"]['Value']) + elif (_ConfigItem["BOARD_ID"]['Value'][3:4] =3D=3D " "): + =20 + _ConfigItem["BOARD_ID"]['Value']=3D_ConfigItem["BOARD_ID"]['Value'][0:3] + +_ConfigItem["BOARD_ID"]['Value'][4:len(_ConfigItem["BOARD_ID"]['Value + '])] else: EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=3D_Config= LenInvalid % Item) + =20 + _ConfigItem["BOARD_ID"]['Length']=3Dlen(_ConfigItem["BOARD_ID"]['Value'] + ) for Item in _ConfigItem: if not _ConfigItem[Item]['Value']: EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, ExtraData=3D"Item= %s is missing" % Item) -- 2.30.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108697): https://edk2.groups.io/g/devel/message/108697 Mute This Topic: https://groups.io/mt/101333312/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-