From: "Bob Feng" <bob.c.feng@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
Pedro Falcato <pedro.falcato@gmail.com>,
"Chen, Christine" <yuwei.chen@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Pawel Polawski <ppolawsk@redhat.com>,
Oliver Steffen <osteffen@redhat.com>,
Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v3 0/3] BaseTools: fix gcc workaround
Date: Sat, 9 Apr 2022 03:53:48 +0000 [thread overview]
Message-ID: <PH7PR11MB5863E4B2E714E05D9DECB139C9E89@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220407101225.d2m2i4h2dsacaw57@sirius.home.kraxel.org>
Hi Gerd,
Your patches are great but I think we can't take them because of the incompatible license.
I think the new Toolchain definition, like GCC12, can not resolve this issue because Toolchain is not used for building BaseTools.
So I'd prefer the second option of using 'gcc -dumpversion'.
And also we have the task to convert the tools implemented by C to python implementation. After we have done that, there will be no BaseTools build issue.
https://github.com/tianocore/edk2-staging/tree/PyBaseTools
@Gao, Liming @Chen, Christine
Could you review the corresponding patch?
Thanks,
Bob
-----Original Message-----
From: Gerd Hoffmann <kraxel@redhat.com>
Sent: Thursday, April 7, 2022 6:12 PM
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Chen, Christine <yuwei.chen@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Pawel Polawski <ppolawsk@redhat.com>; Feng, Bob C <bob.c.feng@intel.com>; Oliver Steffen <osteffen@redhat.com>; Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v3 0/3] BaseTools: fix gcc workaround
On Mon, Apr 04, 2022 at 04:18:56PM +0100, Pedro Falcato wrote:
> Hi Gerd,
>
> These patches are a great idea but I don't know if we can take GPLv2
> code like that. Are they even mergeable into the main edk2 repo (as
> it's not compatible with BSD-2-clause)?
It's build system, doesn't end up being linked into firmware code, so not sure license compatibility is actually a problem here.
In any case I strongly prefer to fix that in some automatic way which does *not* require a new GCC12 tool chain definition.
So, any comments how to move forward with this?
Can we take the series as-is?
If not, other suggestions?
Second-best idea I've seen on the list is using 'gcc -dumpversion'.
Is it an option to just raise the minimum required gcc version to something newer? gcc5 was released almost 7 years ago ...
take care,
Gerd
prev parent reply other threads:[~2022-04-09 3:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 9:32 [PATCH v3 0/3] BaseTools: fix gcc workaround Gerd Hoffmann
2022-04-04 9:32 ` [PATCH v3 1/3] BaseTools: import compiler check macros from linux kernel Gerd Hoffmann
2022-04-04 9:32 ` [PATCH v3 2/3] BaseTools: adapt comniler checks mmacros for edk2 Gerd Hoffmann
2022-04-04 9:32 ` [PATCH v3 3/3] BaseTools: fix gcc workaround Gerd Hoffmann
2022-04-04 15:18 ` [edk2-devel] [PATCH v3 0/3] " Pedro Falcato
2022-04-07 10:12 ` Gerd Hoffmann
2022-04-09 3:53 ` Bob Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB5863E4B2E714E05D9DECB139C9E89@PH7PR11MB5863.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox