From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.6984.1664637354375667140 for ; Sat, 01 Oct 2022 08:15:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GJCGK/kl; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664637354; x=1696173354; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5GidXsfSQhiQECoGHLb6aGxe4cpfdVzXEntXFFyNx74=; b=GJCGK/kl0P/PB0KB7Xhs/K0ujf1uR5500+iIFLpDE3gw/TCQArTygB2s ETrMQePk+R0OL4YBQDaL4Ga4Pc5joU3L9T0PSBQa8xbqIP2/CBXXKtoeA KsnIvgM8k80mOuLODxsF0vdhL38stvI2xwxOYJm9LZ8oruJbjn32k5JXO /J+t7FMPjmhXI52qNjTqOIUOzHOoTrR+8DmsgA1/XjIiKdaQGDU12mirH v4WnBWqEvT76oi5sUe/ouVNi2XvcljW6knO6/54sQN19c5zbmbhJ8myC0 uqP8nxl1ZjoL+OU5FOigUYHL2AsIT5dBHPZok9VZCfOZ8Sc+EPe+43LZt A==; X-IronPort-AV: E=McAfee;i="6500,9779,10487"; a="366438064" X-IronPort-AV: E=Sophos;i="5.93,361,1654585200"; d="scan'208";a="366438064" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2022 08:15:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10487"; a="748547942" X-IronPort-AV: E=Sophos;i="5.93,361,1654585200"; d="scan'208";a="748547942" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 01 Oct 2022 08:15:53 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 1 Oct 2022 08:15:53 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 1 Oct 2022 08:15:52 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sat, 1 Oct 2022 08:15:52 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sat, 1 Oct 2022 08:15:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GF4PbPbIOuujSjWprDm5aHGlpiSCirpM0U1fAv6z5IyOyTPyZSwJvYctdUDv1y9eXQebV40vRTZxC0I0V5qEHxcxDyDVrSNsCUUsrDVL06VX35cgukJ53Vm98vivPYenRyEtw/4lQJuM7P4K7Fs9ZmRfn31mXIB3Psv67BdfcsUjy2tzj0RDLti815hXbAoHdidBA3ydGAwxHEokWYowjNE9iib8jNKVWin8ETZNWeqNr/uGtRE60NKn1atpILy0yjyccO/joWwNF0uOE7nSLJj4HCKi/xNuN5iGNs8joZNklmVQcJEtmfWhrYkCNW+0gL5/1skV+WSnvk1+TLheBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JHuEvDlfl9y31OP8TXMjALN5qoDtkMPAb6zwDNYX/+o=; b=nhW5a10cs+fPK6ZUavEYoD4aEM+lrw3tPG3l+aJBb6m/d1RWSmAIn8cO9RWKO0As8qAkG/iJlt14W/vOBEdvQAY6KfE13ZXhtbOA52IMhL6yZ3zZCY3PDe9mMt1PhxdfqAWm3WnEqXC4304oEK7Ed6p19Cd6O3NuH74zxEwpvNmhm60O0YZyuHMdP+hmiOepyi1WHFxHj1xn9ruHr6P1OEilIDBGEckq0wbaFrqAdtaDjEvnPmV4yci63uAT+gB+0NVUO4t7mBTawbB/D9kgdFcDX6rSSpIU0MJAKWlhvxptrsMFhkK70RKnyK6znT2+MKfon28ImnTs6O2zlmTZDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by MW3PR11MB4714.namprd11.prod.outlook.com (2603:10b6:303:5d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Sat, 1 Oct 2022 15:15:50 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1%9]) with mapi id 15.20.5676.017; Sat, 1 Oct 2022 15:15:50 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "aladyshev22@gmail.com" CC: "Gao, Liming" , "Chen, Christine" Subject: Re: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing Thread-Topic: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing Thread-Index: AQHYvFlbKxoDLPe6dEeXHi+vDuL9Jq352JTg Date: Sat, 1 Oct 2022 15:15:50 +0000 Message-ID: References: <20220830101445.18110-1-aladyshev22@gmail.com> In-Reply-To: <20220830101445.18110-1-aladyshev22@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|MW3PR11MB4714:EE_ x-ms-office365-filtering-correlation-id: 824fb2fe-0dfb-49a6-1dda-08daa3bfd361 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RZRAfavX6eKdUyiJqM+OCoE7VNvQSDRqNRLuxyJQTKsk6/VMoYhoJeiZY8BbWICqRbY4RojAy57XbSXaRSw6LHYXjSVH6nVBLJKWXB7VETm//TzgmpjdguIi5vraqVQ5DIHTQTKlrrNAzE6fEdWBGHVSwRKllCGUwQBBcuUVPx8UJWHzEYYNRL2lnw/M6nogYJfrQ5dltJyt3iAt34g2IamBJgKtihx66bNOZk0+AytL5QePwMuJ1JIcIHcmJ9v9J6wHqj9S5wJrPfjmsqh4fUvlVwEwToUjyE3Im5+eTMpMrqFznlnlkVsCWyTqTE20hHe0vtgN7pd1Nb/1ua9uXTLkPIWc2P6Pj6/NdQKza4+hPUP6JMgpfXyaKxbjn4YZcntilRDjLN6LaUrPDHhr/EFlQWtjZv/7t0hu9BvLC1xV/04dLv3+wvspJC9gZbaDi5NvWD1fbqOvXYDKzqTBfqLVuRLjM9X44i/iqPJMHjxnK+Sfu+pMsdJm+yVviZbINUmvLxHO90yYZ2MowPxTX2eITlPwP+PnAEkFwHvE0gRQOxeFjLbiztwxCFc0i2ykfk2Pc2qJg5oluh14lbU43pgB712pjG7+6x9Va9Aihrn1/pLPzoHtxca17c9RxedL0XhQdBhZlTA5JW6BBMeT0FFYiogkTUG9FiAOggHz6D3WZqjV7oF2wX2sSGnqTAMjkAoGdEWGn98OxyJzrVxGCNP6w+i/qM9l4D3yaDAImvyTOeq9UdS6Alr8S/RHpoiWpXYf7zq+wjwDnSe4eu0AjNEwtbDqhxUwnixymPMd+kKUpO7BkA6jh++jjtQa/E2Vyi7q5/bqSJdZD2eOFF0DqA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(376002)(39860400002)(396003)(136003)(451199015)(38100700002)(122000001)(82960400001)(38070700005)(86362001)(55016003)(33656002)(7696005)(6506007)(41300700001)(53546011)(64756008)(66946007)(76116006)(4326008)(107886003)(66476007)(66556008)(66446008)(5660300002)(52536014)(8936002)(9686003)(26005)(110136005)(71200400001)(8676002)(966005)(478600001)(316002)(54906003)(2906002)(186003)(83380400001)(66899015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uKWMAloxGq90/SU/YRqZyV1U2l5PJQGXv1xW5rTZzX3TNz7SoqzLV/Y26zb5?= =?us-ascii?Q?yLyAbNFyLiaNT+E1o3HgQ3Iax3pr/IlRahGOxrmyxBpJ0GmFwDH1xXWneBOI?= =?us-ascii?Q?n/vEXtjwweooEmG11dP/K6s80lnxIFoU5FLquUI0WySgZ0biXy8xCglm0TgT?= =?us-ascii?Q?LGUZS3iHxxlw0VR/YLtMy2zAmVWhQBFU+k/WeZaZPiVGVwWlNIXcIWEc81Nh?= =?us-ascii?Q?dfiJmObw6GDjmDyylHhlR+FFXZ2uioALFRKZjojsx8gnxoJh5uHKKW075O6+?= =?us-ascii?Q?PhyBPNeLL5rM5K/OYAl8K4cswWxAS/xPk2BLjyBoIcZShiPKNHe66sh4AfkT?= =?us-ascii?Q?ecRKf8QbXsh7OhmD5NOlQX0w7pjzufaEBpCX05QbwmvwE0uvAeVr4H727sXb?= =?us-ascii?Q?2/Ey/Um91bbBi+6TTmhiRB9NePB1EAyCzOiesMhZh1L9uH7/ankDhVV02hvA?= =?us-ascii?Q?Mu6DO2DmE24p7LEJSST7kpZZNdiAjugfj7Yw3XHTuAAiRPn0rj14XG/hf2Ez?= =?us-ascii?Q?RYZnQxb4cWYQFKdmMlEz/ArTsPNAa8DE4Svq0sygjiilnSYnspYulrOZx0yt?= =?us-ascii?Q?YnDhGxN+e8CVE1wLw8qD30N/PP8GFpHv4oNGpYvulgpesoHnmXxKoK5uJjad?= =?us-ascii?Q?8KqgQQBawfoK5lWaET8V1c2VhM9CfcQguLIuZtU+OytPXud9hUDcacXr9a09?= =?us-ascii?Q?4P//NtYk9uWb8ek/3dwS/qPrc+EDry83R+5h+m3nIr5n1HI8xU+da6rY3+sP?= =?us-ascii?Q?p1qhJsWiCzbJpqplhTEqCM2pyi1HTm1gCYsQ9Ie05GLy/C7iekCAxbfh0wGm?= =?us-ascii?Q?6emqAEXYINhBo6eLgREEwl4WcvWYIMqIehJDVwZwQpcP3tccw7N3XDnWH5J8?= =?us-ascii?Q?xPoPZYyQGuaTzlOiL/vhREMdjzgmowVSB1Blbuuekx7x6CmFzAMQZsip7qdf?= =?us-ascii?Q?0jUio7Jd55BN9iL8NVwlIh14sTLpuIAVUCSWtRCpvXdhKh98wJfMlEuoUkmh?= =?us-ascii?Q?huzuPHNxCj6NUhq9s07KYkBbf+pmvjGkGTBYW11JudrbHjCcKESyt9PbHwv7?= =?us-ascii?Q?1DWsrYb8W5vYUNnq5uXo+opdCzP0nCQWkesKEk16Onz7jFH3q6Dwwxj5pVW8?= =?us-ascii?Q?niHGQGKQ6fhYGP9Oq33aqouhod40Q1oXAg9+XQyr0ps/m5huKanRw4F2vfrP?= =?us-ascii?Q?2WXWgcxCPvLjERjjbgsdcoETgHsq4Vo2IQuBxIGvj9DuqOf2rqdl/0UzpUgp?= =?us-ascii?Q?EnbweD3OJY18f1141i8bZymTcdD2pUJ2A5nw/fexKMyDwzWC03zOs3UzZjvc?= =?us-ascii?Q?6vK8t03reDiawRGU6QhE6WHPrmYMMM3RWMpOx8aimHQC9hriaWMKkGeEpf0k?= =?us-ascii?Q?ExzXNcZ+J+LgcDO2A1mp3xYyY+gSIyS/6zHjpfikrsVfIos2AOEd6zgt9JNy?= =?us-ascii?Q?8IJyBcSj9r1UA6m9MBwoRsAspzFvUjpU4ydnzPKivjQ+DFh9Ee78PtSTl68T?= =?us-ascii?Q?hb3M42OeyoFQkdOJVdBKE6Otgieze1NHKbaDee2DFWycZ/UZeDv88b0qCfcI?= =?us-ascii?Q?jTz8NtQqbQ8dfOh0f5SOayMfcO5w/fHg8a+sahom?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 824fb2fe-0dfb-49a6-1dda-08daa3bfd361 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2022 15:15:50.6160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zG1/zuLs//+6UQjpYYQOwU6dWb5EjY7Qhij2eGX1yOW05BWQ4M59ovCDNw5Q853fruTyQKhGb20ZDI4QPh5Gag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4714 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Konstantin A= ladyshev Sent: Tuesday, August 30, 2022 6:15 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_D= EFINED parsing Currently 'PutFileImage' function is called with arguments that are not adv= anced on each section parsing. This would lead to an error if EFI_SECTION_G= UID_DEFINED is not the first in a file. The same mistake is present in the parsing of CRC32 guided section case. Use correct arguments to fix the issue. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolI= nfo/VolInfo.c index 135924e028..b5760d185e 100644 --- a/BaseTools/Source/C/VolInfo/VolInfo.c +++ b/BaseTools/Source/C/VolInfo/VolInfo.c @@ -2012,8 +2012,8 @@ Returns: Status =3D PutFileImage ( ToolInputFile,- = (CHAR8*) SectionBuffer + DataOffset,- BufferLength - Da= taOffset+ (CHAR8*)Ptr + DataOffset,+ SectionLength - = DataOffset ); system (SystemCommand);@@ -2058,8 +2058,= 8 @@ Returns: // printf ("/------------ Encapsulation section start ----= -------------\\\n"); Status =3D ParseSection (- Se= ctionBuffer + DataOffset,- BufferLength - DataOffset+ = Ptr + DataOffset,+ SectionLength - DataOffset= ); if (EFI_ERROR (Status)) { Error (NU= LL, 0, 0003, "parse of CRC32 GUIDED section failed", NULL);--=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92968): https://edk2.groups.io/g/devel/message/92968 Mute This Topic: https://groups.io/mt/93345656/1768742 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D