public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: Konstantin Aladyshev <aladyshev22@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [PATCH] BaseTools/VolInfo: Show FV section boundaries
Date: Thu, 4 Aug 2022 15:30:51 +0000	[thread overview]
Message-ID: <PH7PR11MB5863E94A08BF503790A73AE8C99F9@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220719154552.12790-1-aladyshev22@gmail.com>

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Konstantin Aladyshev <aladyshev22@gmail.com> 
Sent: Tuesday, July 19, 2022 11:46 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Konstantin Aladyshev <aladyshev22@gmail.com>
Subject: [PATCH] BaseTools/VolInfo: Show FV section boundaries

Currently there is no labels for start and end of the EFI_SECTION_FIRMWARE_VOLUME_IMAGE type section. Therefore it is not possible to see where the FV section ends and another section starts.
Add labels for start and end of the FV sections to fix the issue.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 BaseTools/Source/C/VolInfo/VolInfo.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolInfo/VolInfo.c
index 47a8f80f46..a78a7e7976 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.c
+++ b/BaseTools/Source/C/VolInfo/VolInfo.c
@@ -1796,11 +1796,13 @@ Returns:
       break;      case EFI_SECTION_FIRMWARE_VOLUME_IMAGE:+      printf ("/------------ Firmware Volume section start ---------------\\\n");       Status = PrintFvInfo (Ptr + SectionHeaderLen, TRUE);       if (EFI_ERROR (Status)) {         Error (NULL, 0, 0003, "printing of FV section contents failed", NULL);         return EFI_SECTION_ERROR;       }+      printf ("\\------------ Firmware Volume section end -----------------/\n");       break;      case EFI_SECTION_COMPATIBILITY16:-- 
2.25.1


      reply	other threads:[~2022-08-04 15:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 15:45 [PATCH] BaseTools/VolInfo: Show FV section boundaries Konstantin Aladyshev
2022-08-04 15:30 ` Bob Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB5863E94A08BF503790A73AE8C99F9@PH7PR11MB5863.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox