From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.2404.1664591491436401758 for ; Fri, 30 Sep 2022 19:31:31 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=dcwtxPF9; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664591491; x=1696127491; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=F3GxvBD8YovkvvLd/8g4LtS+LYxGsgAHAZxpGLsdlcQ=; b=dcwtxPF9HDXAPTbSMahUuG9Os7LlfPJVq0E35B/qnqGAH58eo8E+nQOi M7/rnVgoTtfenDepiniy1R9ztvgKPr9mzlmtutR/eOzP5uNrOfFDEgejE l+lpXFqd5jkOAjztb8MjKLruALRjKXamtaSlWvdWI6xzpGrFcAFp113eo 1YAIcsfnmTKbptqBh1hoMRjNtzXO6u1X2g/6Jm4Sdwx9+6Bimx4pW5SC6 4j2felq/UHmPGbNvpqdqcw4kkvfw8UXGIOiTrH6pVAH+hwjmbKbuPKCjy wIiMgaamCjELzPKbcAoh0gXY3luEiBVlhSoG63+tM59vWUhb9vKfZUrmJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10486"; a="301047499" X-IronPort-AV: E=Sophos;i="5.93,359,1654585200"; d="scan'208";a="301047499" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2022 19:31:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10486"; a="656158794" X-IronPort-AV: E=Sophos;i="5.93,359,1654585200"; d="scan'208";a="656158794" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 30 Sep 2022 19:31:30 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 30 Sep 2022 19:31:29 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 30 Sep 2022 19:31:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 30 Sep 2022 19:31:29 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 30 Sep 2022 19:31:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdgFuPIlu5gD5Kl5GFxBiPjOiPulnsSmOcwthV3wkljPaf9vXjGS/syzsBuq3S4EBjM09brDBfqbXoFK1DpRsbETYDC29dKYv62e7JE40LKRQtx7y8BPR0HMkX24GjwQsBisBH2UlYtd3Qz/ZMhixK7UER8PeRD4JlPpb2A3DXNCXORVNxgn/r/GW0nEb3dXQy8nMZzZrwaoR+1FgGpSFpZ6Z6JWLRCncmHrDQLKR9Q1k548cN0Wg2y0KIprh/116VYyncp0h2SlMRxDqooG6/ORD/uXmYxfWcJZw50McDQJmJi2kpD/PHaqEzKqk3iKGrODumHKJsj1/IjlIfCj+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=67BZCo5xfQMFyESSvTTbsuq70mn1EEw5ArHvHQZHpzo=; b=OW5FFh3N0AOFirsuAONh6zmBujG571UHrKGGE9htMn08TylKC08VeBHEVfWgZrN+VrUCUoCEpY6gVbTa+ydDuFqNC7ldSGXGvKd9+uMVeQiyl/kIbl7zhwVH7KpQNnPGWb0kiWorawXlvVkQgAel46Tgquawnny7xn7qvjv+d//4Hvh8smPUFfaMlybA1zqnq8nHRJjqalYjGOfuz9Em7tBTSqPsaGVo5PzL5XuqboTnFIlkqanvZ3k5NtLRczx+wF2B6qhLcbmtXcvWil0Wd1hI7uQYt3aIlJBxu51J1R8/xBkWqQS8/Y/C40mpN+7eNHUwPrk7ePmHPVsWbYgCmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by SA2PR11MB5068.namprd11.prod.outlook.com (2603:10b6:806:116::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Sat, 1 Oct 2022 02:31:27 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::b6b:85ec:5ee0:d1%9]) with mapi id 15.20.5676.017; Sat, 1 Oct 2022 02:31:27 +0000 From: "Bob Feng" To: Konstantin Aladyshev , "devel@edk2.groups.io" CC: "Gao, Liming" , "Chen, Christine" Subject: Re: [PATCH] BaseTools: Correct BPDG tool error prints Thread-Topic: [PATCH] BaseTools: Correct BPDG tool error prints Thread-Index: AQHYwQifDd21bTDrc0KriGH1mxY4wa349e5g Date: Sat, 1 Oct 2022 02:31:27 +0000 Message-ID: References: <20220905091923.23957-1-aladyshev22@gmail.com> In-Reply-To: <20220905091923.23957-1-aladyshev22@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|SA2PR11MB5068:EE_ x-ms-office365-filtering-correlation-id: b7443a83-1362-4c95-f5a4-08daa3550aa8 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 75clj+ucg8jwtUQ9PC/1mSwiLiVzJ6fSsYJtjlf0YXJSWJbzyXWeYPfDxg+UdFKZ9R0toY5B3R+mrjAdgjuo/8fvnuDw0Bnm+LPB8xBtzujWFwxxg48PtScn35XxWu6g7VZHWt5YTdwoia85c2eihRxbdCVh55jnRzhUXm1POZrNvp1pXyhQHIUR8VenMMUpUU98zp9/0XINmvotus0bz6GzqJ6VSuNkJaUnOtawr//EFyQpsB4LYOJf820Mjs8rSfIF6vhQjD/zZUkZ2/Lg7ovdp1dpdLqb/8nlUnv6F8F6exUBtVYRFs7FfHIRPG1M7KdeATQUMBnxFsnHcj818ilzFL9SIZCICEcrdgQruIWtwOUI805H48iRDQVIPsbjwcALLdNqac8hFFzk9N3cBTuD26Ix8r7osdjdPoB95cO0atyum5L69nv/+efei7x8vbc1y/yXgF9JaguNGtAzdXl7l8guNnhiZGDTAPbe7Rjk1iEHZg2Ssjb6YzVj6ZGjJTdFj7oItjTAae02+HLYBUemOiRq82AH3RqaJ0iSOSeOu88QOXSNw7nodOMGGGiwT1jRLAWBv2tYe+54dRDdJuRSKrkhu7oksNVsT7NVs/iHmKoUcDjTgQNLhF6VJsIsWqYbwrTD4j7NSGVOIpLmkYIXL1ODzQZCW2akjVMdObHbkCSAJ3VxvIn8fAqq3vy2sgRvpzatuvVjjMnZziR338SM5iB+DIkV8ecfXyOo2dpc17gAymWLVCsoncnGoHhhjcCqqFYnZUEz+eB/MR0axA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(376002)(39860400002)(136003)(451199015)(122000001)(26005)(38100700002)(41300700001)(316002)(9686003)(83380400001)(8936002)(55016003)(5660300002)(86362001)(33656002)(478600001)(52536014)(107886003)(53546011)(110136005)(71200400001)(82960400001)(2906002)(76116006)(7696005)(6506007)(66476007)(4326008)(64756008)(66446008)(66556008)(54906003)(186003)(38070700005)(66946007)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eywSwEhqGai4zVzSz02hLRiBCzfJw35TpdEree4k2L1Eh0W90aR+SEc6rl4X?= =?us-ascii?Q?PhCMgFNy3IGVnjjSpupqp4h0pX1nlExRV535Km2ZjOhkutxRrE1q8Qi6o4Mh?= =?us-ascii?Q?yMQN2uAVVAWBT0Vrgotv7tEmwnU0BltXgaJfLOMbEUvMl8T/jFuvqwirGbBT?= =?us-ascii?Q?OYd9uQuq0H08mUU06FebsZmRksWUSvh+A+AiIoMu+IsSYG8PIoWwtaDzHkdc?= =?us-ascii?Q?6+G5QOmEDM6fzjVRslMTAOXPqPwMvBRG1s+iTg0dGVkBjnuNwHv2u+6+pwxh?= =?us-ascii?Q?tTrCeeq4SVL87Y/DTWUxdLHl8y97/ZmVEhR+yUfOZXYqt1fghFAnKeSDu7c1?= =?us-ascii?Q?RT8sTHge2WWolZtWGEP5t/e6vY+M2Ji0wRyl51qaPbNE171jh1BQSVxBNM7R?= =?us-ascii?Q?iu4uAtUdMC8hkPOrPzO957TN8TrsE7aPJEXrUyX9h3/O6ciXHNtDfGq8XJh4?= =?us-ascii?Q?9e5HE+pZIzqEsqcb6x0qQANdTPnldQG5AaZTcaYA7/xxn5U64RGivasUXqCL?= =?us-ascii?Q?/qKTw3f+T0y5UM+79dcBlaepunWrp/sI4Dd7XryHW1a0+dWRtSCLh/4h1Iiv?= =?us-ascii?Q?9kR7/yYUo80eu1Bbm1rNeI2/M9hokQw/NRcxOV93ACtB5h2cLsoXSzIPOPzt?= =?us-ascii?Q?gQu+nSFckmmA9ky4KOTqAcjiDMwbB2mpEqYcAjZOwsQtxgvV8yJ3WlQXH0u/?= =?us-ascii?Q?dbtS9VPg83/7I74zchBvSj88V2vs3zQJYuEnmpI+0EXx2nKfpa6/FBSwzrZm?= =?us-ascii?Q?tWEEqf5lsTMb9L3U7gfrpqkdbP2K8FDaL03/Y1+jte35K5LSKy0QUwUreoJE?= =?us-ascii?Q?9E/gltwB7lrisJP3S+8pW22GJG242QHfKamRcmqtiPf2TNOOQLdniWTwrkQs?= =?us-ascii?Q?9Q5XIAgWI9JNFSfxakt44KS3cSv4CIFOfywTFRw3XBfnweqSF8+RX4DctB1g?= =?us-ascii?Q?D1SfTQWCK38umabTv6AMI7S0KoYhj02la597yySEviCrzOoQJCOiyISDJsJG?= =?us-ascii?Q?93lg5xy7AV9wqA9KB5G+IWPTKdayIhAn3Bn9h0IIe+BrjrMaOVM1QUEHKPUH?= =?us-ascii?Q?PHw7iJY7yv/i8kI1eoUQnxvJ7PS+XPHZez9aPT/NopXxcrkjYCYau3w7X1i+?= =?us-ascii?Q?P/lVi6dNdjPwxJE0JVfKBtjMqgXAgPlbN0BF7ZTPHdIMXETnPhAgLjJgIrQz?= =?us-ascii?Q?4aNml1V6hmSeNDdal6Fz/SCx3uipS3EdPj8gcStc19s4DMHX+PmdqbXgHLIc?= =?us-ascii?Q?OnuxT/+Bwq+WvDoWCbv8QeLQmUMdySLVJ1655APq6crVhlT0OFNZqZxIUFUD?= =?us-ascii?Q?Ylqjf/WfNC3Jwb4qm+3gFtLZkRdS4YWbN50MNrvaIpeRVtv9bqpAP5AkiSYt?= =?us-ascii?Q?+DVP6T90sJuQ1L//rFlUdrnLBlVQzdvSLAP9oRh/7WX70ObXlvOksK+uhw9f?= =?us-ascii?Q?NBCUW8hO6zuLF305Nj4Y4r+ooPxUJHOQ8dqTtC4P7x2GTUMMsAYDhSl+sNoZ?= =?us-ascii?Q?ukYRFSHWIxoI6iYpzGAgXqWQSjL+RH5ObaGWYUsKGEO8w8PRAlWr3o9DZlAU?= =?us-ascii?Q?zmq9ARbGsKbZFO7QYDzrA5skCCDiC7XooJA6FJgs?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7443a83-1362-4c95-f5a4-08daa3550aa8 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2022 02:31:27.2427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xA8eoTqCFzGrCz9KSMxgi5+hbuKM3X2ZTQIBSmXoU0SYHZBmuLWdbOPjAfU7wDMYMgTA02W8gZyYAPE2bOFazQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5068 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Konstantin Aladyshev =20 Sent: Monday, September 5, 2022 5:19 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [PATCH] BaseTools: Correct BPDG tool error prints Popen communication returns bytestrings. It is necessary to perform decode = on these strings before passing them to the EdkLogger that works with ordin= ary strings. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/Python/Common/VpdInfoFile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/Common/VpdInfoFile.py b/BaseTools/Sour= ce/Python/Common/VpdInfoFile.py index 4249b9f899..1e0c3dfe76 100644 --- a/BaseTools/Source/Python/Common/VpdInfoFile.py +++ b/BaseTools/Source/Python/Common/VpdInfoFile.py @@ -248,8 +248,8 @@ def CallExtenalBPDGTool(ToolPath, VpdFileName): PopenObject.wait() if PopenObject.returncode !=3D 0:- = EdkLogger.debug(EdkLogger.DEBUG_1, "Fail to call BPDG tool", str(error))+ = EdkLogger.debug(EdkLogger.DEBUG_1, "Fail to call BPDG tool", str(erro= r.decode())) EdkLogger.error("BPDG", BuildToolError.COMMAND_FAILURE= , "Fail to execute BPDG tool with exit code: %d, the error message is: \n %= s" % \- (PopenObject.returncode, str(error)))+ = (PopenObject.returncode, str(error.decode()))) = return PopenObject.returncode--=20 2.25.1