From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.2146.1650945183103978499 for ; Mon, 25 Apr 2022 20:53:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=l4+RMZBY; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650945183; x=1682481183; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=/4THwl/3dqSEqw3KyNk/rRUyWLSY2uno6ExeZlBkAEk=; b=l4+RMZBYlio0KNQclhosC/IeDCLtL6XRAS4WAQIOPenvxr2zv88XmohX BSfKM2u8IGOuYd0yultu0gY2bm/3qpRWGm3jqLNUbZQwbUSlxS8zazRju Ve1k1gpD55nImckfI5+kLmeOCcmGjq/rx9IzJV/aqAhle/Y2Nd8CC8m2n 9eKqrO85yaH1XyR2i9ttafl5OsieghDmePTc46Qm+17ok8R2GXDsp91ul tzeCcVONxb3kcpPpu1sH2yAlwb/WI6nPJ7jaLujT03Bs2PrDnL4M0eYXi 0ZEBvFzKVLSXVd3jgc1Bst4Q5v4KXgim4K3jRu/uQuFxKTXCE05eafs5E Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="264287214" X-IronPort-AV: E=Sophos;i="5.90,290,1643702400"; d="scan'208";a="264287214" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 20:53:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,290,1643702400"; d="scan'208";a="873699582" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga005.fm.intel.com with ESMTP; 25 Apr 2022 20:52:46 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 25 Apr 2022 20:52:46 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 25 Apr 2022 20:52:46 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 25 Apr 2022 20:52:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7N2IEzOHyJqJ3Ad0CmpkwCXgrX7DvkeLtRgzQOU5P39G4+aL5Fg0AfOoPDwyWlGZ8Ki5bFP5pROnZBMn9+h5F7C2iWO50bVUXNCScCTY8AvK/ytzkBNzAPHWhWg4jYkoOytMYfIS14wf60aK2BbuPyLX6vbS+5v8q6F9TCp2Vput7dVuAcXyHX75nC7wPmiDfVf6M21DemmGmHSJp9WnlLohefHMVSkaUnhZzH9yiZjhFBMAhcmm8vyOz7gLA55alf5CK/olzfac64Wb2fBEjfubIfoj/FLhZfp3fJh2xcg0hkWC1+XY1prZ2RarEcVEMSrY+EWvjr1F7U9s7aymQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kIzDakAS320J1lcBHzt/GkgkqoP702QsYPcITyaMIDY=; b=S0eogrBzQl0hdTVn+eRShd0u54jO23yFly+NzjECCOFi+DDTvbc2+VWkeB9v1zP8kPrxvwwjiQs5O5956Bd7hEwVwv8S8bTvpJ4Div7tOh/g9FGIBhAnq1LbBdHiaTCOEk2tbtleKIydhGQIb80uWqneY6RZt/JIQsoKv2q2vA4yBvfauFMSJ8TeXTgI56qdOexmJ1qDkzrjCxRmx/KDQeeUjvcJaJ4DNaU+vwXQxiURP0uI2yWAGN2JJEulYXGcSrjuS7GFenkwH2xp26ff03pxcebWwIaWU+r1Tm1/LSVEsgoQFudyh4rsdfrW3xt31RdfC2n/0bGJMZrTh9lnKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by DM6PR11MB3657.namprd11.prod.outlook.com (2603:10b6:5:143::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr 2022 03:52:44 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::bdfa:2a87:8b69:fb8c]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::bdfa:2a87:8b69:fb8c%8]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022 03:52:44 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "jake@nvidia.com" , "jbrasen@nvidia.com" , "ashishsingha@nvidia.com" Subject: Re: [edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template Thread-Topic: [edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template Thread-Index: AQHYSqGQHOx32KnlL0qbBTSQ+ECayK0BrLBw Date: Tue, 26 Apr 2022 03:52:44 +0000 Message-ID: References: <9c8bfad0f021bea4831b7d707f9e851afb0d7ad0.1649351002.git.jake@nvidia.com> In-Reply-To: <9c8bfad0f021bea4831b7d707f9e851afb0d7ad0.1649351002.git.jake@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 443c1482-4d14-44f3-64b5-08da27383886 x-ms-traffictypediagnostic: DM6PR11MB3657:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dFQ8yjcC0rwktnfYAd2QPYNUzv7+VuFI6nzNn/GBMltELgeYPx5FsxPgjwGO0QVAmbl1d4MgvH68rgcCeNjHJsje5EO6Z8GtH6FUmKClCMIYewVte9py+GJp4ojaXOGrc5KOUJUGvyX6kzdIc89b+x1ZOyJ+eHXXyCXYxycgQGK7engXkrEqgEtiT5CyZ3hv89XEKIenZfmpMRR75R0kRFBimv3YfrugLJFcE68YURPIm3y1cW3EjTNgBttiBewIE0e8M9YN5UvAFIyDVc68ZxZv63vOQZ+qT8tvMKlcZe81r5HfDkPZx8G/BFbaiv56zOciHal9jWb8DJhIiAgCxwCFirOIUzoVXdbjIrb1jfC00vqo6TKm9woRmdqA3rXNWRyWc4nqyL/Uniph2DFy72xZo1q8Xi0q2e+zNwnEyIgtAOlVnIKkwTn3hm6qBCz1hahUwap6CPq3+7Qz665hmsw2NXEP1ZYtsMiKNFe7E6ruel+//h+bRzSeZetq13UuEdlhTU3mhXkbZoJIm42LxppVF5PY31uViSCGIRfZ+B9g3MkQJpQxiEwgJWqf4YvIOUlcYEAPbGsVKmNcFOkWPcJsW23q9bytwj4Qm5/86QsmAUcrXIh/h2Usj3ORRSA1VoYRu0KMi2ij59RrS6YHZI51q9qIsMkUVcykX9DPBNLXTyrcqyt5UYFauypt0AB3eWOUC+30iDHNKF7uzIvlxs2oB1GlAyxzGI8kOvgpAEHq8BZ6ublLmgeV7ciINgWALlYVjcnUQeFPQeBUtLD8u4usPJ4PkeDvERHviyAn0lBDMuw+e/5q2oOMoku3Drm0xi6rqjQcxHLMLLyI8maDkw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(64756008)(76116006)(66946007)(9686003)(8676002)(66556008)(66476007)(82960400001)(7696005)(26005)(66446008)(966005)(316002)(6506007)(508600001)(53546011)(122000001)(110136005)(86362001)(186003)(83380400001)(38070700005)(38100700002)(2906002)(33656002)(55016003)(8936002)(52536014)(5660300002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7mMG96I3mlcPiICKToGLOuhiVuPuOdG+MUnRxo+1fxBAYPKn9JqbXu8AKoZH?= =?us-ascii?Q?RnB2sstQLoxFV/X+QrMu7Lg/30QeWTj4q0G+3sOFaS3K7HVH3IjCp5uZuOUV?= =?us-ascii?Q?maoR7Tkk5CADpfd/jEIlJiUbwRCTsrwPWpLKMsGuioH1gmGxpeOOasVhJZdi?= =?us-ascii?Q?BQAYeJEtS1vMEt/0pkHFGe9cGldpjVUQFxx0rvZKsPLHndCG3TDYITZsLcC2?= =?us-ascii?Q?MrfDoD9+0M8PYpTPFXnneodF6QJTpsmkGeopQ6r+SCXOns1upu8K9Pa3LiR/?= =?us-ascii?Q?N+YPtYfY/GhS3dqX9fbsrHz29CiZ8MHKseRlTQA4ZW2TmC2YngxI1aqawOtL?= =?us-ascii?Q?J9+N2z8cz+1Vq0Tmsgr3113LwsCa/87ST4v9zrnzCEBkECqMyjxhri6oi89Y?= =?us-ascii?Q?ZOAmvC0jUmH2DZnz/jEFAY5J85lEdGLR1xmuGaCgSDuX7jzcivrCN4awhA7Y?= =?us-ascii?Q?ucKZhe2Ju1ZmNqCOrENT+jXhtg86+JCFK/7QiV6r4RLhdUsThIus2/HkT1Nf?= =?us-ascii?Q?5Y+sqDlxrmAU1A7pbY1Kg/Fv/Dlm1Q4K9sUSkzBQFahT6JKLSobTxGzDxRbI?= =?us-ascii?Q?sdLAKzoGK+Yx/nvQX/eIXC3fS7iViKf7V6AcBm5Tp+0xiwvYqN0H8qxRAuec?= =?us-ascii?Q?OHtt743YHIjFjCYW3ANTQ0n70ZiQ+eN325o/Ewf46FM3rZk4pK5d7diN2/h9?= =?us-ascii?Q?YPcVTz8aBwb1dPK3rLIpKZ+A9p0gbz0N0Z7g0MU/0tLgMSdeD0r7tT3QWDqs?= =?us-ascii?Q?E7/FeKnMwA2DiqQ/8Dxxsk7x9ABNbcJkMv24G3Ve10WsMDBIJGp11NiZqXuD?= =?us-ascii?Q?Nh1WbQ6zZOKDzh92PvEWFT51Du9Z4IgUOtMAxj539rCtRgI2hGFG/vok+i1M?= =?us-ascii?Q?UOssr09phARjJj6wLBTBjbErv+zc0QM2Ze4GxGihrmDXIrOh2YWLVkAvNIWM?= =?us-ascii?Q?xSX78sgqsRpiVdH79kPtF3ntHEN53VDCOFDWRC1JctFVpxJn0vdqrhVpOiCT?= =?us-ascii?Q?SvmHdaDDQ0Il1VZznTmeAzwkJwdXtjwhFn4DFwOb4CMOPjers/Nz6oqqElBI?= =?us-ascii?Q?5KtteF3lI16ybFEqG2TSRfdrFg2f7nesAWvZckJFHP8B/AV8++D1Lkt349J/?= =?us-ascii?Q?R+ytt474fb+vR2VceipkwTY0qxMFxcnn7n+sWuLMu09oTEO+JTulu62G1Z7Q?= =?us-ascii?Q?f0FJarMJ6ItonxZMmAdTKNWP9wyqLNNi2T2NYlIxYy4MOJEceV4NT5fN8iT7?= =?us-ascii?Q?WC2Qjj4q9RhrHjLD4My3jDvaJRjuFtdjsZ1eAyqZF++ogwwubsIWY9a9TiPG?= =?us-ascii?Q?JgLfd1O4GU/hIY2EAgEp0H5dbKx3cCbPOLa6etzguIMXxTMRbSUJd6P5d+IC?= =?us-ascii?Q?L1Ho37Sn3Zvd5l+pPRAFAYKVn4oimuvpLCiAyuTlyANfNLFGxPjpoqpjbhpR?= =?us-ascii?Q?WFXRslNX2yEg5XDBpXLXyBUwMKCZI00xKhL5hZFiHrgGbWDB4GN2cdH1SIjl?= =?us-ascii?Q?a3KWbI/AHpOvg55eOIVxU3x7CJXOt34mJDvmlzqzysoGvawXtntfaSp8ihV4?= =?us-ascii?Q?6rUYT+i9T55gtxrAshhY+yt7AloVMWiCl9VN3aiUjOVkxNrrCjPh+1SnlcqR?= =?us-ascii?Q?T5b76W0My8ChKr34jHuc29s+zx3oniDcq5pFAsFOqTG9nDQPt3onuqnYYPfg?= =?us-ascii?Q?EqTo6bD56FzU/1BtqT1R6JbyILcOr0Xmf4YvvNvNlfyzeae5BR+YeMmXg3LO?= =?us-ascii?Q?sEQpxttksQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 443c1482-4d14-44f3-64b5-08da27383886 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 03:52:44.6017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8VnaPyPLPvImty+eF9cKdU0475sY57aWD3ViajewRBO0RZ7d3/pLTf6WXS9tLTPHQaQdNcCXA1Pk/EiE/GkESA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3657 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch looks good to me. Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Jake Garver = via groups.io Sent: Friday, April 8, 2022 1:04 AM To: devel@edk2.groups.io; jbrasen@nvidia.com; ashishsingha@nvidia.com Cc: Jake Garver Subject: [edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File temp= late In the Dynamic-Library-File template, add missing output file declarations.= These files are generated by the template and other rules explicitly depe= nd on them. This change resolves missing dependency issues we encountered while running= a recursive make with job control. Signed-off-by: Jake Garver --- BaseTools/Conf/build_rule.template | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index f401182344..4356623512 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -366,6 +366,8 @@ =20 $(OUTPUT_DIR)(+)$(MODULE_NAME).efi + $(DEBUG_DIR)(+)$(MODULE_NAME).efi + $(OUTPUT_DIR)(+)$(MODULE_NAME).map =20 "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) -- 2.17.1