[PATCH] BaseTools/Conf: Fix Dynamic-Library-File template

[PATCH] BaseTools/Conf: Fix Dynamic-Library-File template

[Jake Garver]

In the Dynamic-Library-File template, add missing output file
declarations.  These files are generated by the template and other rules
explicitly depend on them.

This change resolves missing dependency issues we encountered while
running a recursive make with job control.

Signed-off-by: Jake Garver <jake@nvidia.com>
---
 BaseTools/Conf/build_rule.template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index f401182344..4356623512 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -366,6 +366,8 @@
 
     <OutputFile>
         $(OUTPUT_DIR)(+)$(MODULE_NAME).efi
+        $(DEBUG_DIR)(+)$(MODULE_NAME).efi
+        $(OUTPUT_DIR)(+)$(MODULE_NAME).map
 
     <Command.MSFT, Command.INTEL, Command.RVCT, Command.CLANGPDB>
         "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS)
-- 
2.17.1

Re: [edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template

[Bob Feng]

This patch looks good to me.

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jake Garver via groups.io
Sent: Friday, April 8, 2022 1:04 AM
To: devel@edk2.groups.io; jbrasen@nvidia.com; ashishsingha@nvidia.com
Cc: Jake Garver <jake@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template

In the Dynamic-Library-File template, add missing output file declarations.  These files are generated by the template and other rules explicitly depend on them.

This change resolves missing dependency issues we encountered while running a recursive make with job control.

Signed-off-by: Jake Garver <jake@nvidia.com>
---
 BaseTools/Conf/build_rule.template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index f401182344..4356623512 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -366,6 +366,8 @@
 
     <OutputFile>
         $(OUTPUT_DIR)(+)$(MODULE_NAME).efi
+        $(DEBUG_DIR)(+)$(MODULE_NAME).efi
+        $(OUTPUT_DIR)(+)$(MODULE_NAME).map
 
     <Command.MSFT, Command.INTEL, Command.RVCT, Command.CLANGPDB>
         "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS)
--
2.17.1