From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.202936.1672310463074019415 for ; Thu, 29 Dec 2022 02:41:03 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WTe16i1O; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672310463; x=1703846463; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Oo1hMAWyAE/KxodlJk6wapMGhA4N22UbS8sPgSXfDjA=; b=WTe16i1ONi4myRoXMGPVWGiPxsAoAqkUxw5bndR1RVLtb49Fcd9Vcy69 ZyEJrYlBgKctO2dlqfT3mzT+DKh89sn01WZTS+lYXzDxtnJNKgjmcdnYT ewBtz1nENmnzuCX5JAURrvow5oeM+mYtxEx3ATMfwsllrdy5vFPs9k/PV KfC/yWExLxe5l03/rpEmxK5yaarLWsCEBBIU7U6f5QqAP6FgIBYEAY553 tKhL/8SNT44A30RS0MyhwNtxL2yW9VmHiU5YtwiXqtgytAaMUWBXiOEEs 4SRRWeAdJ+8REDnwV/keAil78GDWttu84bgi0cCYmQn+hPGOFtMTNMW8H Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="323004500" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="323004500" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2022 02:41:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="646977247" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="646977247" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 29 Dec 2022 02:41:02 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 29 Dec 2022 02:41:01 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 29 Dec 2022 02:41:01 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 29 Dec 2022 02:41:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxthMXHBZUsjLSx9BHbMfdJXFLnC7eOlxQQjJfTW9fIjiXfC9rAxqbxMJJCUmMFfEe355+n04TWrzkQAcTQI8mLl6wVbw5+4BeFDD4nFLHn3csfCGNeno1QWV4O8ifMbaaz7dwuqkY/f1hAhSqObOlxqDZQTuVSbhL7S9QsV5f9/AAK6fTSVNStyp026MbqibItFrWKJIEqx1Gk04cfZB2qp0pHye1VD/i34PEDcxvKS70nRwHWcAD1VnpV5keuJCaMTKWwf0b7Y/h17t5x3U0gq/hPQ+mEeuDPtoByXWu0/faeKVnBKWNBFt2lFoKLFUMTGFbzZDWA0RmEN34538A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7DhpvFanjj+sXgEG6S9djwz+lKaNLeV0f1il7wwubc=; b=gIO4Y92Xddbf0+GNfvXdpNjxNQ/T55k0FMDeghDwJuthJHR5vaCnHt8Cyaj4o0e//b8P0gAwwqTKyORvhLp7AJFeylTml9o/YG87FJ89+t+OOYdxDcoch2IkhSaDqPcbYTQtMFMTeQtSZROyJbjxUwGxVZS+0aQiSpPHajF3Ww7vHs6b/zMIHtxVOJ+/16BdpwvdkhO3ngyjpRMg1wTxShIb1eAPwIqSRTBcrqtBr3+sK8u9R/RXflAur8U53I/6wtYj/iSKxKmLzUpRHD2nO5GgXJkkHdte+60xPbJC25+wzYyhymkRyt5yvih7GubA0oQXtEKEYkV54OyP/JHsVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by LV2PR11MB5975.namprd11.prod.outlook.com (2603:10b6:408:17d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 10:40:58 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1251:f989:b162:4186]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::1251:f989:b162:4186%3]) with mapi id 15.20.5944.012; Thu, 29 Dec 2022 10:40:58 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "jake@nvidia.com" , "jbrasen@nvidia.com" , "ashishsingha@nvidia.com" Subject: Re: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets Thread-Topic: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets Thread-Index: AQHZCyFn4aBQY3rKhkSC8aOLebPc1K6Ezaig Date: Thu, 29 Dec 2022 10:40:58 +0000 Message-ID: References: <2afe0ee929bbe7983216912b20a933405c67e1f8.1670516469.git.jake@nvidia.com> In-Reply-To: <2afe0ee929bbe7983216912b20a933405c67e1f8.1670516469.git.jake@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5863:EE_|LV2PR11MB5975:EE_ x-ms-office365-filtering-correlation-id: 43a69a5a-3813-4c05-b0ee-08dae9892c05 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jPGbRWzRbgvobiKnzA1Ac9uwL83qK4sYKvk9hii+R4WEQpZh5C466t1zANzbfInbCuO/u6AKlb6Vps22S287D1zkrSt3XrJdlnsDw/ORvHKnJvUymoSyhZpTQhjqskpHj+eMVXfPnkl2HCNKCJ5ChN5Rn2Hv9+mB18pnAA2HmQCp77/wjkL6SB3h7h3fOCTstKn3N+w1hl+qR8+PyeBLnbsVBJTCVRJXKGgkFaO4EsttPzcgV3cxUsfCBWKTRNw6aIrPXxuNeLRmbL0npQbJdiWO2MQC8fmj8BtFnvOsTjKmNIvssU/Tvvp6ZWPxmUOfqC0/wcHCBzLwg8Ihk5zfc5bEiLhnBTVB1PYqjg6zfVxAQd934iK2LGrKmRC1rojHmMon+3u19kapkAwY0H83tiDf6PC9tuPtW58mmoBOXDlRWid0Q2DRQyywVrH+N09WJBeZV7RKWhcHPaia19J2T17IMYFbNKQZKc16S/exNKSRr1dn1Y0zgoH6NQ7eCTP/SxMHYMhfoBOLTlMNhC4+PTbHo6ObCj1aNguc/PwqX56FZ6AOtqFQ08/3TeeXqRkVhW6+yfclJV/5g+bMiTWcBVD0/EjuNKR6Sek1ig+tWjH293U0tdWCHGxPPwCHdLxRpLyyaQqWskvRLvMwYbbzjl3p0V8wQiBD50neHkhd1KBgRI1Fp6gFQJ59v8HZojpV1q8AuA8jz02z4Q0tJNxfKRSkcvJRTbbBtjLOVeXULxKaCC2D2jkqEquur9j7PGu8txkqwKFFCODRSsYEqzk2Pg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(66899015)(82960400001)(76116006)(2906002)(66946007)(66556008)(66476007)(64756008)(66446008)(8676002)(38070700005)(5660300002)(33656002)(38100700002)(122000001)(86362001)(83380400001)(52536014)(316002)(71200400001)(478600001)(110136005)(966005)(55016003)(41300700001)(8936002)(53546011)(7696005)(6506007)(9686003)(186003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SOlkYrYgtLEVTlgeu3cNVChZRC+ie1Vvp3fvtFAecruFQ79dN7M2dvU1S8pl?= =?us-ascii?Q?Hbx5VQCygfyaoitaVvQKBoHwoE8/GKwtqG6eyhwg82RcaMBlSdP4zsiUs1BQ?= =?us-ascii?Q?7+TOvIxh76QcBnplOjtZgSd83tklwfHI3WW4yStSNC3raxaasLMxqzxpRscQ?= =?us-ascii?Q?1BtDPSoMZgQVrbRe7REucDmyc09OpVZinNQvyYOiCoKtYbpE5Qka2B5lMWYK?= =?us-ascii?Q?PlfkSTHmzuufpYuK25011XR2I/++MOLKdcdLASbHrZWhSroC2sdVuE2JEU7a?= =?us-ascii?Q?gTpeA8xRxdVpmreb081Irjl5+LkRqvzCb/mDGtDv/XYv27nDwE5QUj0RaBKc?= =?us-ascii?Q?oOit51AGDhDf/5QE0qKcTUEqEV7bVkSKu2d3TkGWi71TVIlZkclhfdjvod88?= =?us-ascii?Q?UglYHNixuEio8JU7Q3PmphYkbeO+AIBo03QBJ/OhP5ALOk9HFPUMBe+A4TMA?= =?us-ascii?Q?MyuScf+vfGKJvYiSDuuFOdLnyucylkZk+UaGbnw613SoGZKUHyHWBQk26f7T?= =?us-ascii?Q?qkBOl7TN9ZpW+6w4YiARsYvCcRkfmVMaXw0CuBjpZ+WEpbak2YzE8mdhkisI?= =?us-ascii?Q?Cyj4wPl3nnhE4uoRnLkSOCHwhh3fZnVUYA9iE0ws9umn8tgP/wjltuZnW9Sh?= =?us-ascii?Q?cOPVoz14NuOxzW5nXPbW/ZdiKYV7uyvrPAg8IAUu//p4uTKbBREjs8sqgsle?= =?us-ascii?Q?Q0Z9AI5LeI36XCdnT1j/wctL7No0f+Qp/TGxUg02r7WrvRykF/ZAjiMeBKB8?= =?us-ascii?Q?BvugbbiHrt6dbmvtfDdjLCV3Um3XNOp8fqqDProNU4vlXIUUYAeq6uEzhxf3?= =?us-ascii?Q?oo6QTmbVN70RgKa6NE49nzQVm902p3GchosIa34tW+m6OT5WoiMO1FhHUCPC?= =?us-ascii?Q?UBX+QQ4lLorE6Qqv/MM3koz+RehVy00MrXrV6prpgATL7TcMaW36u4QjjjuT?= =?us-ascii?Q?VMHSJIqk4qtHZl+VjM56VrT9ZO5rFB//eQIhh2SYExzPfoTSlIfxN8xJiL2m?= =?us-ascii?Q?QQtsPKLwfxMk3sbJcSd2E2BSMRICbgjtZuS+GW0swcKZX5PGrksi+TuG5EUn?= =?us-ascii?Q?6TanRAQ2RmHsBqcJjUO8fOQcx9hNsRDqfl1liV/eUzAb9DEzFlqUL20MOvaW?= =?us-ascii?Q?GBzEr+DLay1ze+Oqvn3QLW5N6PTT7oRPuq3nEFGeadIntKMzsq63gEfPSE6z?= =?us-ascii?Q?nkoUPl/XxpGUjwBTjKt+DLEKa1yHpHPs+ZGWaFkPANjBgEcq9ihBoA6MkOrw?= =?us-ascii?Q?AEMJaMNUtSKzM9dpizAKCjb/YZs58hyyUPYzjEruzp3Nwr2gqKZZXnz8sae/?= =?us-ascii?Q?fA7aMf7XU8Rykswcu2ytBlGdbZuh7TM6eeGzRbPpJbMHP/czJ4VXyUFPfH96?= =?us-ascii?Q?MhQitGtrRWeKluQFi94g2tN13m5emcgANRniQqRmbSCN978ZoKhpudjCnMS+?= =?us-ascii?Q?AIYCSSICFk3FcJRh8OisvXy13jXA7gmOhphmjV0zoNb/zVn6UgqXyB53CE3c?= =?us-ascii?Q?MtNImzD+IYw46M4LRZUgIMR/sK0tp8a56lDX3Ydz3LMuktzG/dN6QKENGlA3?= =?us-ascii?Q?be7Dz8BMLE34oFZMfrPAaBj/seEO9dfBVkUBLhN9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43a69a5a-3813-4c05-b0ee-08dae9892c05 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2022 10:40:58.4395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zwl89W5D2pJZseF8TCygcCY/YdB1LjjDZR/cLsDRzplxVCw2uEMVSvmLIsGFP5HrlhvX8T06sQgGfD5bjuMF7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5975 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch is good to me. Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Jake Garver = via groups.io Sent: Friday, December 9, 2022 12:22 AM To: devel@edk2.groups.io; jbrasen@nvidia.com; ashishsingha@nvidia.com Cc: Jake Garver Subject: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets Prior to this change, deps were not generated for Arm and AARCH64 libraries= when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That resulted in bad in= cremental builds. Signed-off-by: Jake Garver Reviewed-by: Jeff Brasen --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..ec83638144 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -145,7 +145,7 @@ $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj =20 - "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src} + "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst}=20 + $(INC) ${src} =20 [C-Header-File] -- 2.17.1