From: "Bob Feng" <bob.c.feng@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [Patch 6/7] BaseTools/Plugin/HostBaseUnitTestRunner: Enable gtest xml output
Date: Fri, 4 Nov 2022 13:30:23 +0000 [thread overview]
Message-ID: <PH7PR11MB5863FDDC5CC654AD8E35C48CC93B9@PH7PR11MB5863.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221104033056.1259-7-michael.d.kinney@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Friday, November 4, 2022 11:31 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [Patch 6/7] BaseTools/Plugin/HostBaseUnitTestRunner: Enable gtest xml output
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Set environment variable GTEST_OUTPUT to specify the output format of XML and the output file name. Both CMOCKA_XML_FILE and GTEST_OUTPUT are set for each host based unit test to support both cmocka unit tests and gtest unit tests.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
index c1eeaf26251e..a8220aacd396 100644
--- a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
+++ b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.p
+++ y
@@ -85,9 +85,12 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin):
raise NotImplementedError("Unsupported Operating System")
for test in testList:
- # Configure output name.
+ # Configure output name if test uses cmocka.
shell_env.set_shell_var(
- 'CMOCKA_XML_FILE', test + ".%g." + arch + ".result.xml")
+ 'CMOCKA_XML_FILE', test + ".CMOCKA.%g." + arch + ".result.xml")
+ # Configure output name if test uses gtest.
+ shell_env.set_shell_var(
+ 'GTEST_OUTPUT', "xml:" + test + ".GTEST." + arch +
+ ".result.xml")
# Run the test.
ret = RunCmd('"' + test + '"', "", workingdir=cp)
--
2.37.1.windows.1
next prev parent reply other threads:[~2022-11-04 13:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 3:30 [Patch 0/7] Add GoogleTest to UnitTestFrameworkPkg Michael D Kinney
2022-11-04 3:30 ` [Patch 1/7] MdePkg/Include: Update Base.h to improve C++ compatibility Michael D Kinney
2022-11-04 3:30 ` [Patch 2/7] MdePkg/Include/Library: Undefine _ASSERT() if already defined Michael D Kinney
2022-11-04 3:30 ` [Patch 3/7] UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib Michael D Kinney
2022-11-04 14:44 ` [edk2-devel] " Michael Kubacki
2022-11-04 16:32 ` Michael D Kinney
2022-11-04 3:30 ` [Patch 4/7] UnitTestFrameworkPkg/Library/CmockaLib: Enable symbol files Michael D Kinney
2022-11-04 14:45 ` [edk2-devel] " Michael Kubacki
2022-11-04 3:30 ` [Patch 5/7] .pytool: Add googletest submodule to CISettings.py Michael D Kinney
2022-11-04 14:46 ` [edk2-devel] " Michael Kubacki
2022-11-04 3:30 ` [Patch 6/7] BaseTools/Plugin/HostBaseUnitTestRunner: Enable gtest xml output Michael D Kinney
2022-11-04 13:30 ` Bob Feng [this message]
2022-11-04 3:30 ` [Patch 7/7] MdePkg/Test: Add port of BaseSafeIntLib unit tests to GoogleTest Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB5863FDDC5CC654AD8E35C48CC93B9@PH7PR11MB5863.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox