Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message

["Bob Feng" <bob.c.feng@intel.com>]

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Chen, Christine <yuwei.chen@intel.com> 
Sent: Friday, June 24, 2022 9:25 AM
To: devel@edk2.groups.io; quic_rcran@quicinc.com; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message

Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca 
> Cran
> Sent: Monday, June 20, 2022 6:07 AM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Gao, 
> Liming <gaoliming@byosoft.com.cn>; Chen, Christine 
> <yuwei.chen@intel.com>
> Cc: Rebecca Cran <quic_rcran@quicinc.com>
> Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc 
> error message
> 
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
>  BaseTools/Source/Python/Ecc/c.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Ecc/c.py
> b/BaseTools/Source/Python/Ecc/c.py
> index 4a82e5e76003..61ad084fcc5b 100644
> --- a/BaseTools/Source/Python/Ecc/c.py
> +++ b/BaseTools/Source/Python/Ecc/c.py
> @@ -2612,8 +2612,8 @@ def
> CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier,
> FuncHeader, Fu
> 
> 
>              if Tag.find(ParamName) == -1 and ParamName != 'VOID' and 
> ParamName != 'void':
> -                ErrorMsgList.append('Line %d : in Comment, <%s> does NOT
> consistent with parameter name %s ' % (CommentStartLine, 
> (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> -                PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> does NOT consistent with parameter name %s ' % 
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', 
> '').replace('\r', ''), ParamName), TableName, CommentId)
> +                ErrorMsgList.append('Line %d : in Comment, <%s> is 
> + NOT
> consistent with parameter name %s ' % (CommentStartLine, 
> (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', 
> '').replace('\r', ''), ParamName))
> +                PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 
> + 'in
> Comment, <%s> is NOT consistent with parameter name %s ' % 
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', 
> '').replace('\r', ''), ParamName), TableName, CommentId)
>              Index += 1
> 
>          if Index < ParamNumber:
> --
> 2.35.3
> 
> 
> 
> 
>