From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.36227.1656290317747601696 for ; Sun, 26 Jun 2022 17:38:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=BMrq3MjR; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: bob.c.feng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656290317; x=1687826317; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=XIsJs80Dfz0yyi00n0jWqFfZ1PLfpRkNOJran+4GY8k=; b=BMrq3MjRxxITFEw5jrQ3Z4UAn/fQ5ANHPAm3bSKmKE/FBu8vwAD826RJ pSl6n9NIMTlkMYRzpZiptPB3VwGMxB6tMOoApVwfshUiBJhW0CPXI9i/b U0Mtp+Qy0tFcT+mlG1h2kf1t2UFXGx9q6zL7QKwnuZM9KtbYI6Nd3x3ZE dA0UTHPdtuLF7Pb1Fdr79cR52SjoJFBs4L7EKJACT443ER8pEFEDFAPgz dyzMekA/gGx/hzUrgcAh15oPgBklUzPNmezY1EFmuibP3gSuJNxP60pTp 6SLBlwYpsbx9JcAsW0QvYSzkyfjXAv/SIwZXY/Q09W1GS07N4gGP3EIqp Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10390"; a="264369588" X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="264369588" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2022 17:38:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,225,1650956400"; d="scan'208";a="679346313" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jun 2022 17:38:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 26 Jun 2022 17:38:36 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 26 Jun 2022 17:38:36 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 26 Jun 2022 17:38:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TMLtybsWbbJLMkkTqeOlmzUzhu83GJWa8wtXQsBr89cx/fVUcwPUDN7hc8GCsL1DrFK6zw67NC+/9G3dXdBhRMfF8igHsFPjrzPbLxRb7XG6jofpdryemcdL3R5E8CrDBQf6OdJPfNo3YgormYhSsGN54eDsg1AzbyRmSuBSxeLAjmjnCJ8pBhZ691EeLW+BOe95jJZ/OY0ivIHsyubLii6mi0F+IfBDS/LpmLDk1F0awerhp1bz2xJ1ueM6CqMxfYpwMeRNycAZgB568NB4MhfUpwyJFYKXcHfUHjt4uVT1Jg+mYq0FLHzHzUseQnjnWdDGWYDHm1VvbWXgIYjGIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EiNW/zhGXyIiXJCHb4W9B3xqSCLFurj9yCyDTO3rtV4=; b=ArH5u33AY/r/1B67z2/MQ91VzCGTG5GWZ+QY5uNA3gGV1pjKgemvIxY4R4CNFP3H1Lmx4xSRquFlgpvokdDr7F4cqQmLF38lMuBA32iSFQe8pGMw//l2U/a2QpiqqZLNJWa/TY0F27HHr2zEzBlXmtOt5yxblPIiq3L+FqUuOBrU4qsp6t/GBowGWbkT0JwDa6mowBXDpecC9X28ZhTdva2CN0vFBDNgIYdQ0ypeFtL8WBquH0gOYWa9/Aa7CDdz7q2DyRquG/5MVp+9N+hkZisaTcrJIZCxpNxxPqIbh8zXHO6UeICyU0V+fIjB5c0yw+jflwh9O5AuSKrrTQNdyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5863.namprd11.prod.outlook.com (2603:10b6:510:135::11) by BN6PR11MB1380.namprd11.prod.outlook.com (2603:10b6:404:3c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Mon, 27 Jun 2022 00:38:33 +0000 Received: from PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::943:4b5a:b96b:30f8]) by PH7PR11MB5863.namprd11.prod.outlook.com ([fe80::943:4b5a:b96b:30f8%5]) with mapi id 15.20.5373.018; Mon, 27 Jun 2022 00:38:33 +0000 From: "Bob Feng" To: "Chen, Christine" , "devel@edk2.groups.io" , "quic_rcran@quicinc.com" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message Thread-Index: AQHYhCkgTD5oGW9Qh06ZzgSW4hPWMK1dyhmAgASp79A= Date: Mon, 27 Jun 2022 00:38:33 +0000 Message-ID: References: <20220619220709.9665-1-quic_rcran@quicinc.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ffc8d806-59b1-4d6a-6f62-08da57d55d5d x-ms-traffictypediagnostic: BN6PR11MB1380:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DaOzrRV7a8HiYG9swtHt6hzXQLJmjSf4/UJuK4OelXFzLn4wVBfvSlOk1OE4tT7JBBn+ou5WnZxrA959n2a2n+7kA4Kdc+4jeSw8XVtZl5RMwS7ij41c1Oh/FtWmXpNrRUSNRiglI4QBFewuafSLAQ2o39yo0jnpuxX866TRDEet7+33a1vbYJrPJo9LZHgNryr3UbpnFrjEEotw0GRu8ORL/z9E8lCRuxsz7C8WW/OQCU9254J3GK9kRcM891Q1nkQRgq0u9/aUsMn4ZDaKFWQ6XA+oDbp0CUwpFXA9d9vs+2u3DUTOJcgIlA5K+4luFl56hzeeQh31mjsh/8ZJbjKH5u4ScT/yF7ia+phIfFD8mcPGXqWyMf2f3c4fkYMky0FfrlQbQl2YPem4U/mLoaP99piOzjtw7mq0aq3fpGcH3T12jKAXx1t8nFR3vKR9jQPdWkVp1btrhysfq19dYdSw01/2nMLwjQ9RosvgrKq+2idm41TLz+Yb+QyN5ARqjNgpe44rKJyUm2FeYWyEu6mY26i6sAlSCTnRJXZ/sIRjM/hwpcsUKqV7X8ynhDrYehWvcxdhJ9HlfxtdkDxHLe4Bp0YcX49pmD0dnv3mQ4dHmL05jXr4GfK4MfiFFLUgnns+rAFzvfchkfSfmsf5KNg8Qu74jUL6knWNIWuBnTu0ELlWxSaY4kfpZRLJYpv/oqR+xscIfigBKDe54dNKf3uBO/0DGjvJ1F4GAnrwjJFTCQn4lK+QuveUOgHr7pbvgBVwhdi3mT3GskmULnqObHVcXdJx3Ri5O68xJT/koXOZUv/0XvKSL7gbwyiW7qvcacE3sYFYXcqiyx8X0lnqtw8QKpy88tZy7dpB/m2FhAeWffg4Ccz3hoxNG3XstyQy x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB5863.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(346002)(376002)(136003)(316002)(186003)(66446008)(64756008)(86362001)(66556008)(26005)(9686003)(6506007)(53546011)(41300700001)(7696005)(38100700002)(38070700005)(122000001)(82960400001)(5660300002)(33656002)(15650500001)(52536014)(478600001)(8936002)(83380400001)(110136005)(2906002)(71200400001)(55016003)(76116006)(66476007)(8676002)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xMKi6iFGqqrMgYPGhSZb31P/gM5ik3EYv9GMjkaDykYFGUJa1AhvHUlt/Hfd?= =?us-ascii?Q?NvZGURNMtjXy9zt/ubougZrU99CG7SMMlQi/7VKpttuf10FTSPoOGCLeuywv?= =?us-ascii?Q?chduMwxXKPqnSA+S4rbEOqCIjcmBaAdWhiZ9FKp+PRehctGEZIM1mrdF7Nhg?= =?us-ascii?Q?u45HKQLWqe94x2kB0GlRTIa4XpcSKkDRtXeJLE7f0KhMCvaFHz1TWJW+gEmh?= =?us-ascii?Q?LOMpHfLa2EN6DtcQNL4mepAn/PdeoCfKkNg9rEe9EiEseiH5ASbDsNO/97cB?= =?us-ascii?Q?YeFT2FugDDHTiT2tOu+Omh1NCuhyq4tX7LGl9Lx5ESAsDcwKAhlwO2R7+cIp?= =?us-ascii?Q?h/8sATqohf+1hi+y+XLN4YTlUxpXWTGLR085pQMaTtEZQDDsiD4q0HOsAplJ?= =?us-ascii?Q?QZ1Xjpa50D8bcsaviEJWGbETcOvS/27qV4PXdrOggaPAFLrJn8OlFVBivf9Z?= =?us-ascii?Q?QGsZ4XNikE/6pCSs4ymbjJiUmXg10UHdfPboBt3KriVVwSVbp1N+aaN9tpzt?= =?us-ascii?Q?VmIkKihhnQMWWvBTXSE2mkfmy5nrFrUsQf7WH3YYEH2b9THL+mgHTeVzxVz+?= =?us-ascii?Q?7YCGy25SM6IFUFTHvuxtvgyUt7PhA5sFi+mnsTA/D1oMbm1caumQyjhbqY2s?= =?us-ascii?Q?avfhF4FCGJIBLz8NSrLdqvrHFjVz9Dd9lmCW8VdgU0+Vcw0jCIZsQAr0cfmW?= =?us-ascii?Q?e+txtwp810ortJqLEGI2HWPc0Jzjywe6qPuGmRPOwqnIrKgBtog+vFJZsvVn?= =?us-ascii?Q?KsmC3OAiYM0OMeczTUY1xd22Y37HqmXcC2p0lB5FKO2l617jD2quCjmXrMiN?= =?us-ascii?Q?7oNyxpylpM4tbfI89NghQGniwpPjLzxIBtCcFfsjccGG3U5jYOikP+neRm7p?= =?us-ascii?Q?kG4LjvXvcNt0SaSG2DSocrU97Qli7m7Wm2H4DNxlnjOuqN3IPxsAFKXeF52X?= =?us-ascii?Q?kDJUAmHEnlgCx6XLDG79rquy5LYOs5lG8p8lZ3TXt7RVg4yQGX7T1IP3VyYj?= =?us-ascii?Q?Yz58qDX5A42kXNIWZ7NLs+ilkS1qAAGko9v9rfo6xry8gH6oqvMLZXm6VhiM?= =?us-ascii?Q?2sdkY1MEmfOdFpifTr2hcqlQ+kjWX2zTRft5RryZSnyo+buY+4Vhcng4Lp+H?= =?us-ascii?Q?ewLxFeRDetaa/D5lz5n76ufFPD1T0X/K5uzfztCbFFP2qBMeeBYYeRO7IvHy?= =?us-ascii?Q?aNnOhri3Zh0VWcmuTY5fMKlLIgDY7ehk0lHTw63Da138kExJf+C+QCHeHBt3?= =?us-ascii?Q?AynfVsNz6sT+5O1NkRyDuLJyxBpfhSd3bUnD550VPWhg2iB1wuTveNuJlSHi?= =?us-ascii?Q?lA/bk6ID/29KtzGRABLOHmmT3TAvhMmZWR7zmUuBqFkL6S1K6J/VB3xEvDP3?= =?us-ascii?Q?qZfYIh19jbcLJ5f4RRr4UY6XUOQJNP6fsUCsNjVp96Bhs+74Gk0Mngbw4Uaw?= =?us-ascii?Q?dC/PyXGtsTUzb4VcC2B1ilOzI7brS7fmFsx/EUdM/0wAaXFeVEIEuV/lvhcN?= =?us-ascii?Q?WJ+YozevqwRwXUe+6JV49cfDWM3eyD23QHy0FerMZhLmADS6vp5tAGyOI/hL?= =?us-ascii?Q?/J3pqDtECbTlSo+424bNOVZM/pvyONuEzm/FuJ4v?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5863.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffc8d806-59b1-4d6a-6f62-08da57d55d5d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2022 00:38:33.1932 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IrSC2Om57nXv8TjK+ebV7ZKAF6p+h5qn4u2TDhMY3iVax9m3cjg/XmCcrymoCmw4McZ0uiTO90Kze/xJ11h/vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1380 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Chen, Christine =20 Sent: Friday, June 24, 2022 9:25 AM To: devel@edk2.groups.io; quic_rcran@quicinc.com; Feng, Bob C ; Gao, Liming Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc err= or message Reviewed-by: Yuwei Chen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Rebecca=20 > Cran > Sent: Monday, June 20, 2022 6:07 AM > To: devel@edk2.groups.io; Feng, Bob C ; Gao,=20 > Liming ; Chen, Christine=20 > > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc=20 > error message >=20 > Signed-off-by: Rebecca Cran > --- > BaseTools/Source/Python/Ecc/c.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/Ecc/c.py > b/BaseTools/Source/Python/Ecc/c.py > index 4a82e5e76003..61ad084fcc5b 100644 > --- a/BaseTools/Source/Python/Ecc/c.py > +++ b/BaseTools/Source/Python/Ecc/c.py > @@ -2612,8 +2612,8 @@ def > CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier, > FuncHeader, Fu >=20 >=20 > if Tag.find(ParamName) =3D=3D -1 and ParamName !=3D 'VOID' a= nd=20 > ParamName !=3D 'void': > - ErrorMsgList.append('Line %d : in Comment, <%s> does NOT > consistent with parameter name %s ' % (CommentStartLine,=20 > (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', '= '), ParamName)) > - PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in > Comment, <%s> does NOT consistent with parameter name %s ' %=20 > ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n',=20 > '').replace('\r', ''), ParamName), TableName, CommentId) > + ErrorMsgList.append('Line %d : in Comment, <%s> is=20 > + NOT > consistent with parameter name %s ' % (CommentStartLine,=20 > (TagPartList[0] + ' ' + TagPartList[1]).replace('\n',=20 > '').replace('\r', ''), ParamName)) > + PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER,=20 > + 'in > Comment, <%s> is NOT consistent with parameter name %s ' %=20 > ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n',=20 > '').replace('\r', ''), ParamName), TableName, CommentId) > Index +=3D 1 >=20 > if Index < ParamNumber: > -- > 2.35.3 >=20 >=20 >=20 >=20 >=20