* [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message
@ 2022-06-19 22:07 Rebecca Cran
2022-06-24 1:24 ` [edk2-devel] " Yuwei Chen
0 siblings, 1 reply; 3+ messages in thread
From: Rebecca Cran @ 2022-06-19 22:07 UTC (permalink / raw)
To: devel, Bob Feng, Liming Gao, Yuwei Chen; +Cc: Rebecca Cran
Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
---
BaseTools/Source/Python/Ecc/c.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/Ecc/c.py b/BaseTools/Source/Python/Ecc/c.py
index 4a82e5e76003..61ad084fcc5b 100644
--- a/BaseTools/Source/Python/Ecc/c.py
+++ b/BaseTools/Source/Python/Ecc/c.py
@@ -2612,8 +2612,8 @@ def CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier, FuncHeader, Fu
if Tag.find(ParamName) == -1 and ParamName != 'VOID' and ParamName != 'void':
- ErrorMsgList.append('Line %d : in Comment, <%s> does NOT consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
- PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in Comment, <%s> does NOT consistent with parameter name %s ' % ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName), TableName, CommentId)
+ ErrorMsgList.append('Line %d : in Comment, <%s> is NOT consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
+ PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in Comment, <%s> is NOT consistent with parameter name %s ' % ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName), TableName, CommentId)
Index += 1
if Index < ParamNumber:
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message
2022-06-19 22:07 [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message Rebecca Cran
@ 2022-06-24 1:24 ` Yuwei Chen
2022-06-27 0:38 ` Bob Feng
0 siblings, 1 reply; 3+ messages in thread
From: Yuwei Chen @ 2022-06-24 1:24 UTC (permalink / raw)
To: devel@edk2.groups.io, quic_rcran@quicinc.com, Feng, Bob C,
Gao, Liming
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Monday, June 20, 2022 6:07 AM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
> Cc: Rebecca Cran <quic_rcran@quicinc.com>
> Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error
> message
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
> BaseTools/Source/Python/Ecc/c.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Ecc/c.py
> b/BaseTools/Source/Python/Ecc/c.py
> index 4a82e5e76003..61ad084fcc5b 100644
> --- a/BaseTools/Source/Python/Ecc/c.py
> +++ b/BaseTools/Source/Python/Ecc/c.py
> @@ -2612,8 +2612,8 @@ def
> CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier,
> FuncHeader, Fu
>
>
> if Tag.find(ParamName) == -1 and ParamName != 'VOID' and
> ParamName != 'void':
> - ErrorMsgList.append('Line %d : in Comment, <%s> does NOT
> consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
> ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> - PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> does NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
> ParamName), TableName, CommentId)
> + ErrorMsgList.append('Line %d : in Comment, <%s> is NOT
> consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
> ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> + PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> is NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
> ParamName), TableName, CommentId)
> Index += 1
>
> if Index < ParamNumber:
> --
> 2.35.3
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message
2022-06-24 1:24 ` [edk2-devel] " Yuwei Chen
@ 2022-06-27 0:38 ` Bob Feng
0 siblings, 0 replies; 3+ messages in thread
From: Bob Feng @ 2022-06-27 0:38 UTC (permalink / raw)
To: Chen, Christine, devel@edk2.groups.io, quic_rcran@quicinc.com,
Gao, Liming
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Chen, Christine <yuwei.chen@intel.com>
Sent: Friday, June 24, 2022 9:25 AM
To: devel@edk2.groups.io; quic_rcran@quicinc.com; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Monday, June 20, 2022 6:07 AM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Gao,
> Liming <gaoliming@byosoft.com.cn>; Chen, Christine
> <yuwei.chen@intel.com>
> Cc: Rebecca Cran <quic_rcran@quicinc.com>
> Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc
> error message
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
> BaseTools/Source/Python/Ecc/c.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Ecc/c.py
> b/BaseTools/Source/Python/Ecc/c.py
> index 4a82e5e76003..61ad084fcc5b 100644
> --- a/BaseTools/Source/Python/Ecc/c.py
> +++ b/BaseTools/Source/Python/Ecc/c.py
> @@ -2612,8 +2612,8 @@ def
> CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier,
> FuncHeader, Fu
>
>
> if Tag.find(ParamName) == -1 and ParamName != 'VOID' and
> ParamName != 'void':
> - ErrorMsgList.append('Line %d : in Comment, <%s> does NOT
> consistent with parameter name %s ' % (CommentStartLine,
> (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> - PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> does NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n',
> '').replace('\r', ''), ParamName), TableName, CommentId)
> + ErrorMsgList.append('Line %d : in Comment, <%s> is
> + NOT
> consistent with parameter name %s ' % (CommentStartLine,
> (TagPartList[0] + ' ' + TagPartList[1]).replace('\n',
> '').replace('\r', ''), ParamName))
> + PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER,
> + 'in
> Comment, <%s> is NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n',
> '').replace('\r', ''), ParamName), TableName, CommentId)
> Index += 1
>
> if Index < ParamNumber:
> --
> 2.35.3
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-27 0:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-19 22:07 [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message Rebecca Cran
2022-06-24 1:24 ` [edk2-devel] " Yuwei Chen
2022-06-27 0:38 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox