From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3CD477803DE for ; Tue, 5 Sep 2023 08:38:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cmtnQcenXUGzoPUFERbwVatul8QegVJKG9mt3mXoels=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693903106; v=1; b=nfm4OfRKvgYXO3513Xd9CeyzfDm9sOpGq2rdM6BAfUZKp4IFK5hNvegRQUezX+ilctty5oJ3 EcF7pb5n+d8D0qzX2Mib0SsCerEWAKsos9UKbRU2zxkNOp+tpADxDvvtSrS3s/+/TQy0HBS5+/O u3ngpRGL9oIhdESUYNMt5SrQ= X-Received: by 127.0.0.2 with SMTP id wpDmYY7687511x3TO8qfmoQA; Tue, 05 Sep 2023 01:38:26 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.16851.1693903105879145406 for ; Tue, 05 Sep 2023 01:38:26 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="379461364" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="379461364" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2023 01:38:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="1071890493" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="1071890493" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Sep 2023 01:38:24 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 5 Sep 2023 01:38:24 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 5 Sep 2023 01:38:23 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 5 Sep 2023 01:38:23 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 5 Sep 2023 01:38:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrJJ3yXMyHfyJ+8nB9Yw2nErlBriD4SdLNiaeZqn3hhIYrHMM66LZ5nwL70lojNt64ua/fC63d0wJ4Dck3UdsL9WhJeeqhCjvewMk9XTt1TY58RF07Ck+vWR9pWupFrj5mI8ACm14ROkhG7jx+GZ9PNtK0ElRJUQ6u0xkz03B/zu98AZi5P7isqpf7ymKT2OwVvOLK4Fw5VFaAWv5g7+ykpTYGx91HUoGevW/GtlXn6kPJRTDjupIPqID5qUZHU6o8KDz9AWFBNF0KzWsMSO3n1y+ws9Yi9AJwTwoOL2qdEOkOdS1qx5e1gOeItzo2FrCkRlTjLjN52F/50zRP6kGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M8YpcCFtXNVjKwrgtfYscYRh/6XTMcbJBDuN7hGi2do=; b=dItj2yizqVtC77t6M+VQNoGnVzcuUY4CovnCd8mVGNWwSW8kv4ZEiIMz3OK1yRx73Rg7inAKlRaI9dVelyj4gDABn+aFoZzR04egFQqBlfjq2Nk0oESYQq7Gbs6WeTdNm8VYGDSvhV0G6loE5IJwsibrM5KNZS/dACuAlUaLMLviJnDRxHUtV1QwuraY9GmtUf5tQt4TDZuWBL1fZqgX3hYj4GpKRlV/AV95l5pxdfk1w5anstbG3jJhWQw7kIdrEQuajWYHN7zRf5aDrbS3QOulJxeMLM7Yy9/Op7kHTsSFDlq4i3uOKYhU7u5WyKx5LEmsxtL4aXmEbglmIOXlXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5888.namprd11.prod.outlook.com (2603:10b6:510:137::11) by DM8PR11MB5640.namprd11.prod.outlook.com (2603:10b6:8:3f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Tue, 5 Sep 2023 08:38:22 +0000 X-Received: from PH7PR11MB5888.namprd11.prod.outlook.com ([fe80::1025:f73:7f80:2d9c]) by PH7PR11MB5888.namprd11.prod.outlook.com ([fe80::1025:f73:7f80:2d9c%3]) with mapi id 15.20.6745.030; Tue, 5 Sep 2023 08:38:22 +0000 From: "Linus Liu" To: "devel@edk2.groups.io" , "Liu, Linus" CC: "Zhang, Qi1" , "Kumar, Rahul R" , "Yao, Jiewen" , "Chen, Tina" , "Chen, Xiao X" Subject: Re: [edk2-devel] [PATCH v1] Pyrite support - Secure erase is only available if encryption is supported. Thread-Topic: [edk2-devel] [PATCH v1] Pyrite support - Secure erase is only available if encryption is supported. Thread-Index: AQHZ36ihnBwqSJ1OEUGomy311keACrAL6SAQ Date: Tue, 5 Sep 2023 08:38:22 +0000 Message-ID: References: <1781A5556E472CC8.20961@groups.io> In-Reply-To: <1781A5556E472CC8.20961@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5888:EE_|DM8PR11MB5640:EE_ x-ms-office365-filtering-correlation-id: a26e47ca-f463-4da3-7a13-08dbadeb768e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Jo6a8Qzoc5Iicp5hY7o390MqyQn6pFYPCM9bp89KeF9xiKhnCB0w9tZZqxlc+ENp9VsguHl0qJW7zqRV1tTbdu6uYaDFkeZvqo3uxLdhN81pxN7zpQ5GBHJK4qGon/zYSpIGUv4fs7WCk1Q+w+OC4Q8bzit5tmZSATAoA3hb2PxPMRe7TKRCB7LGtQxF2eX8PObU6fcwC50Gn4ose5ojy6TMnJ8zPtmBhCzyvzFAsA2ix3tLBHbq+T3C9tjX9xQUHYiXrbkFwkw2tmBEnbn037XhzA10GkNEbdaPLi+R2XGCCij5EW7H2FMyOCutoHvmTMD6Ox9kD/klRWOuiPx7MID6MK9H+o82NSOVuLTsCaIXOoaNguTWiKc2xKmRoNMPbp7ODKS18iBCF5TkQlRa5F7wCdg6sWCeNkHM+2yqyOIH/WokFofUe5LjaaFD+/aGne1sN99onSwuvUq+J82clJlYRcOXErAq4Nkw/BRZB6jAez6ULvFZRqCaH3t44EGGeVVqP5NiUVQ1LTuQC2RrMtpguUqpigafXVmZJqsd2Ls+csiuZglFiXkTOBeX9/69L6nABHVQVRJ1JmlIvz01dwdCIrojmCJ4ziAZhsnV0cyfnYzVxKjEuO2Kank5ZN6nxlLBrZFc71k1BgLbkzYVsw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+pmstcBpy1lAeG1NZ0XNtYDRKF4jbNbuagXYdNjcj/G5dsFe/7zY7N4D29qS?= =?us-ascii?Q?LDv7NMjwEoSHWD77DPLQSxK21Z+pPRs7ECi8MtpxDblUWp9bICgB3k70F4fU?= =?us-ascii?Q?kFLeurwqrAbvHDAfoONjc5Snk28byQApTKi5lihHbnvHN4ccanpd8w+oq9DH?= =?us-ascii?Q?G7v14li2xQCEUC6LCSjVO6Y76Y6UB4K5Pe3mEj1NtSELEZLJ5Eb/BtfXX7lx?= =?us-ascii?Q?NMjMeO8PbVsn48uOpHJw8PZcAoL84SXVN/1eGWyzAFGRFM5bTjREJuP3f4GH?= =?us-ascii?Q?PAZ8ZhLQfUbQd1yRbkkZ1bHTWuAnvByc9IoNRLfEdPstkimRQXn5ySqvDPES?= =?us-ascii?Q?RuSnb7gTqAfDN+qp9bAOryAZazSfZHMXXBwNGRr1ZAVAYd0w6PFnVnP7wzTt?= =?us-ascii?Q?x5T4D8z0RttNJ2lDY+OgmVZ2RoAYfuFhxavqq1bV0PLALUG2Ob2QrwzOYLON?= =?us-ascii?Q?3I/dLqGPadnsJwNaPXFXU6dQjQsuc8R2vA2cuCyDNgnwVooJ1zHOvp8vhk2X?= =?us-ascii?Q?0IFVrWl/EuWJ1b0oMfRY4hhmph3Rx16qOJfDeAg/x6HQIvVMDCAKtXxsHgsc?= =?us-ascii?Q?SsUTRFTGvNk7t7zyTnmrU6+fy7MfqnlyU2zOdYsPehk42AgoVJTtvUEyoTMW?= =?us-ascii?Q?qui+Hl4BlKUBCuGiRL75zXVq7STc9uBvjs09K47O9b0I/9lTxXeLRsTXJvZh?= =?us-ascii?Q?WM87n6/12/kRlYTfL7JtjLKT04Y8s8Cso/xA+F7Atfg9058kEtM6Xe/2WJq9?= =?us-ascii?Q?uWtjJEbDZKub/yWwz+2QpQOSFxZRETNtaoUOZy2g8dCeS0O4TANFGtFQ1d9t?= =?us-ascii?Q?qJ6NmEP/QgzLdxp/wWmpKnmMX4d2lTcJo5gQAgZ5+heovKxulXK1LwFH6/ES?= =?us-ascii?Q?4jFHe4hFuG5yD0JoqGPfO5PgjENB6O6dhrtBq39Exft2VEmszpXbx80L69W3?= =?us-ascii?Q?3KnbUB1rI9+XcT1AtZ7LkI5fn+EE60yXp9tbcxS+gTW+72xNEEjuDw1sWS8B?= =?us-ascii?Q?u+Ahj2EOw+3wyTIcXyTsB1gcl+8uCMDGTiOWiLCpiBGI2rw16Vz21gIao29b?= =?us-ascii?Q?zhHAtuDfPYfLCNVJHekeCqBTkVS2Xa/TjMnVJHlcdTwwt3F2vR1zPSacvd/7?= =?us-ascii?Q?kYSro0zuTFTQKv5pm3hTZKENb6oP3/FIOORXRlxPR9UKz72bMQddZ6Ox9rOX?= =?us-ascii?Q?fRL5WE9yjGULb1yuRlV8/rgJFcblV+5vOM3g1vFU3b2n8ZBvFk9ob/56UPnj?= =?us-ascii?Q?yiwjSB6ONpu9VWJvPy9HrZ8wlIpzo+XAKP0o1i7RHMx661+iqRaOxff7i4Nk?= =?us-ascii?Q?ujv7cbeH7DbliQBdwzK9zGMcwCFn8lsfXGJ7IIlPCjDjfuJ8ueOSmWMmw70Z?= =?us-ascii?Q?YntVPvWF999ciltkudQWoPsJ6yWBAAtfJzaMMa5t3ZE59fz/9vNRAqW9fJs5?= =?us-ascii?Q?oEOjZw9YGWHaqLqLp6jYoHxp9PeBV8mcjJvUiK+r93eiKchmUkWzdcwbV502?= =?us-ascii?Q?vcscataYvDarfculwLIQhZWAUVsYNtvS1aHvOOa4lzk3p60H6z1EBkdPZQ7b?= =?us-ascii?Q?j0m565p5rP565+FtNv0PZPSRu4VI5RT9Tl8QS+1w?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5888.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a26e47ca-f463-4da3-7a13-08dbadeb768e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2023 08:38:22.0470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tbHsyAX9Iwba/dhpROlNSgHAWxL/nMEPFcjhtaLcAuuCDHpLBJaZLC2DlLTZofEaDlHCpudJQbVoN5ISplAQmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5640 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,linus.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MbCypcfufoujfNXMLGiUwJ7rx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nfm4OfRK; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io ++ Tina , Chen Xiao -----Original Message----- From: devel@edk2.groups.io On Behalf Of Linus Liu Sent: Monday, September 4, 2023 4:38 PM To: devel@edk2.groups.io Cc: Liu, Linus ; Zhang, Qi1 ; Kum= ar, Rahul R ; Yao, Jiewen Subject: [edk2-devel] [PATCH v1] Pyrite support - Secure erase is only avai= lable if encryption is supported. From: Linus Liu https://bugzilla.tianocore.org/show_bug.cgi?id=3D3004 Cc: Qi Zhang Cc: Rahul Kumar Cc: Jiewen Yao --- SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/T= cg/Opal/OpalPassword/OpalDriver.c index e2e77cbc24..88650a28dc 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c @@ -87,7 +87,9 @@ OpalSupportGetAvailableActions ( // Secure erase is performed by generating a new encryption key //= this is only available if encryption is supported //- AvalDiskActio= ns->SecureErase =3D 1;+ if (SupportedAttributes->MediaEncryption) {+ = AvalDiskActions->SecureErase =3D 1;+ } } else { AvalDiskActions-= >PsidRevert =3D 0; AvalDiskActions->SecureErase =3D 0;--=20 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108253): https://edk2.groups.io/g/devel/message/108253 Mute This Topic: https://groups.io/mt/101144585/7575003 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [linus.liu@intel.com] -= =3D-=3D-=3D-=3D-=3D-=3D -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108279): https://edk2.groups.io/g/devel/message/108279 Mute This Topic: https://groups.io/mt/101144585/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-