Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported.

["Linus Liu" <linus.liu@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2617 bytes --]

Hi Ard 
V3 patch has updated.
Please help to check it.
Thanks.

-----Original Message-----
From: Ard Biesheuvel <ardb@kernel.org> 
Sent: Monday, September 11, 2023 9:14 PM
To: devel@edk2.groups.io; Liu, Linus <linus.liu@intel.com>
Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chen, Tina <tina.chen@intel.com>; Chen, Xiao X <xiao.x.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] Pyrite support - Secure erase is only available if encryption is supported.

On Thu, 7 Sept 2023 at 11:02, Linus Liu <linus.liu@intel.com> wrote:
>
> From: Linus Liu <linus.liu@intel.com>
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=3004
>
> Cc: Qi Zhang    <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Jiewen Yao  <jiewen.yao@intel.com>
> Cc: Tina Chen   <tina.chen@intel.com>
> Cc: Xiao X Chen <xiao.x.chen@intel.com>

This patch is missing a signed-off-by line

> ---
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> index e2e77cbc24..ba9fa66c60 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
> @@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
>      // Secure erase is performed by generating a new encryption key
>      // this is only available if encryption is supported
>      //
> -    AvalDiskActions->SecureErase = 1;
> +    if (SupportedAttributes->MediaEncryption) {
> +      AvalDiskActions->SecureErase = 1;
> +    } else {
> +      AvalDiskActions->SecureErase = 0;
> +    }
>    } else {
>      AvalDiskActions->PsidRevert  = 0;
>      AvalDiskActions->SecureErase = 0;
> --
> 2.39.2.windows.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#108368): https://edk2.groups.io/g/devel/message/108368
> Mute This Topic: https://groups.io/mt/101210886/1131722
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org]
> ------------
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108513): https://edk2.groups.io/g/devel/message/108513
Mute This Topic: https://groups.io/mt/101210886/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: message/rfc822, Size: 8088 bytes --]

From: "Liu, Linus" <linus.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Liu, Linus" <linus.liu@intel.com>, "Zhang, Qi1" <qi1.zhang@intel.com>, "Kumar, Rahul R" <rahul.r.kumar@intel.com>, "Yao, Jiewen" <jiewen.yao@intel.com>, "Chen, Tina" <tina.chen@intel.com>, "Chen, Xiao X" <xiao.x.chen@intel.com>
Subject: [edk2-devel] [PATCH v3] Pyrite support - Secure erase is only available if encryption is supported.
Date: Tue, 12 Sep 2023 01:41:59 +0000
Message-ID: <1784033FB294A935.29005@groups.io>

From: Linus Liu <linus.liu@intel.com>

https://bugzilla.tianocore.org/show_bug.cgi?id=3004

Cc: Qi Zhang    <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Jiewen Yao  <jiewen.yao@intel.com>
Cc: Tina Chen   <tina.chen@intel.com>
Cc: Xiao X Chen <xiao.x.chen@intel.com>
Signed-off-by: Linus Liu <linus.liu@intel.com>
---
 SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
index e2e77cbc24..ba9fa66c60 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
@@ -87,7 +87,11 @@ OpalSupportGetAvailableActions (
     // Secure erase is performed by generating a new encryption key

     // this is only available if encryption is supported

     //

-    AvalDiskActions->SecureErase = 1;

+    if (SupportedAttributes->MediaEncryption) {

+      AvalDiskActions->SecureErase = 1;

+    } else {

+      AvalDiskActions->SecureErase = 0;

+    }

   } else {

     AvalDiskActions->PsidRevert  = 0;

     AvalDiskActions->SecureErase = 0;

--
2.39.2.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108511): https://edk2.groups.io/g/devel/message/108511
Mute This Topic: https://groups.io/mt/101307436/7575003
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [linus.liu@intel.com]
-=-=-=-=-=-=