From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 438E8740040 for ; Fri, 21 Jul 2023 16:23:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pPIJMiw3kW+pcuF0MqvX97+XrrmFb8QvVLGbogzC1ZE=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTe nantHeadersStamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689956605; v=1; b=AW95oQjm9jQw/OALyhVb9Md9ji0hGoy4wPhE7ZnkVZ4tn/p+MrLDks/rJ0n5vyZaAEHbftIr odM/Y9GWopDeGInI/aue/jQni7cAdOCFpap6i4xiVH/VQmuS7vjDMRenB6tbFSW2JQoxQt18gvd SaQHpHKI4rsJiokYTQFYFf2g= X-Received: by 127.0.0.2 with SMTP id QMOiYY7687511xyaVRSOv2Zt; Fri, 21 Jul 2023 09:23:25 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.11471.1689956605113906592 for ; Fri, 21 Jul 2023 09:23:25 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="397953454" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="397953454" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 09:23:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="1055605283" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="1055605283" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 21 Jul 2023 09:22:45 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 09:22:45 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 09:22:44 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 21 Jul 2023 09:22:44 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 21 Jul 2023 09:22:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O59gEZDhMp+/o49uQBUV3GKLaPe37Kw+LlmxfKJKBsUBR3a6655Ic0/dEgSNjAj7gQzVn0Hn6IIZyISfm6+jioXTiFMyMHFdiBHB1W1Qsa2dY/dsKa5B789k/b5TCZl2H/UZH9udy1+epdt92axBNpNPMS1uOHidmxPqCdLLlp+IpbdUxmNGpvR3eM5ZXLlSTtKZwYHh02qsDNxpg82YreaQwPlgFeKOERqSi+O+zYaXtYxKokHO60UTrDJQMsZP6HNfO0MKBe9YCxT5RJNigZ7jZsQo+XMpHpFMAKH2g6IW5/h6B3itmcGOXr8ulNooYG2eEzJn//WqlUU68DFXwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkbReJpSi03Is1mirF6NB9aAoqblqkJawCkQO6NpBXw=; b=O1cDlNGoJH6e0Z6sWgxYRu5CgOF/cBspxKOvp4BxJh+zVFrZLzFLW8FRuSGGUvYdznCRRObC/bqKZJ6CNMXLQT+mFJsoBu9MdFueMU7Qr66z1nTM+sh3reNGj52iEEW/WYduGWEpiFu7nXGI1sjB+jl+gxUnk/cvciDoGdQaFC2PVZ6S83UANA2J8DMSZcuMPWVuoYkxD8i51SnFcxX+QRIFGmfpy+O2Nml1NAq+3hnkZOD0vt204Au3M8V0dpGnq1oq448BMBg0tQQ6eeR9Jk1+1yfB7I1M8htTDQwxDR8dHOdTOYUx4ZnGk38zwy/hPMjcGCYWwigATEjMd5G3MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com (2603:10b6:510:13f::19) by BL3PR11MB6435.namprd11.prod.outlook.com (2603:10b6:208:3bb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 16:22:38 +0000 X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::de50:25ee:1951:e347]) by PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::de50:25ee:1951:e347%6]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 16:22:38 +0000 From: "Jayaprakash, N" To: "devel@edk2.groups.io" , "Jayaprakash, N" , "Kinney, Michael D" CC: Rebecca Cran , "Kloper, Dimitry" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global variable Thread-Topic: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global variable Thread-Index: AQHZu+fexxOyN2uhAUeT+nQNinQdUq/EWZOAgAAEqtCAAAjHgA== Date: Fri, 21 Jul 2023 16:22:38 +0000 Message-ID: References: <20230721152652.1761-1-n.jayaprakash@intel.com> <20230721152652.1761-2-n.jayaprakash@intel.com> <1773ECE2212EEB11.21241@groups.io> In-Reply-To: <1773ECE2212EEB11.21241@groups.io> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5943:EE_|BL3PR11MB6435:EE_ x-ms-office365-filtering-correlation-id: de9e97db-5aba-4515-d2aa-08db8a06b33d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: nbKFltPD4fCmcEwzw5WGDuj531eTaqX/EvOGSPM5OVqO7Ig47IWZEyIcVuvuX7tCmwxD7jYIhISryIRH0Qzp0bqVuPNtbhhzWgzq/0hiEFnxiCxrnzf4dhcJgcjCr9hVxomsQBGglPbr48aLmfJizwWEL2618IaWtkCG7ySCnziFesy8JGuYmhPSOOoB1m5nBB61c7vLShxNV65yCaaXTrINjVRNmZL7iOMlfaFmCNURDv/Iu/aIrZ860janSjND/VkQ+yj6xKdhaXpq0e9slLpq3f6PQZAexlA0mSgp1mZqbOuBj2oM5jGJmAgGkjEcuVK8XZhfxDOpwh97jF5uhG/B7ML5FFzR3i199TCCgINj6KRPsaocJKoz5fOR1HeLfG5A8Yvk1QxN/HjTOKDuDm/glc5Av53/PiW7WTftN0yjy8ujXk2OhvYwKhZsU9LYdQDOR8/a+PBEMaH6pEEFyXr9c1O9LxNOYasNqLt25U51OFAEfooBoq1ZbB6oXIKQpuAGTzs4f+mQBN8W8r91fqeLm+Cu8Gyv0aOtmmRR3YGgTW+mMonhSN0q+eBDfO0N9XKrEx+eqYaZiWJXmIHdaCPkBEp4X4lSCvMPfe9/YthlL7Ss7FD3ulDu6adODjWIs/4DjS4NpsHN/jQLk0oM5g== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VRa7UK3ve+3PIpfG2hVMzRDk49rbLJFJRWj66/8DF8jeSEQjTw1mNQ503B8y?= =?us-ascii?Q?D7itkV6WKJfKPAsad1yIlysBjW0hNcBnEVog2PV7ZiGm+T8E0SUdmVUd01Xa?= =?us-ascii?Q?DcC/IIN/31c2uPWdJvQ7W89ky2kjZzS801TLo8EEtp/s07AOEmqXCCkgOnUk?= =?us-ascii?Q?ho/UEDBAk0ABOkr0mOuAOcxgkA0PM60jx/5cPLgLC08ZxslmvGVD66yCC/gJ?= =?us-ascii?Q?fKYTtVovSEVL8FkTMU4y3eeicKU/jCjalIZx4ZEYzoDoRdfw693XtcDVklIf?= =?us-ascii?Q?q0/MzII2g7ivm4BAGbT3E8f8aOKbQC4owquIvmw7Vbc6m6uBs0E1Yncl/P1U?= =?us-ascii?Q?kBYz6BTRxWrTKq3zTF1fqo+ODPlzHBb3mfFQC/twjOHZplJZodDET27NXLRz?= =?us-ascii?Q?AmLZ/BQGXiej8QJKUVmlP4dowJx//dxWK+W3WDpE0cc/Wwd2vDeCwkPn483y?= =?us-ascii?Q?xKcrXW8FIaCif4ppr8goi2+lwizw2ZuITjOXJPRgQaZwqv4dVAD7dVhor/fP?= =?us-ascii?Q?VHiSbztXuyXzX6YtFHOgyYPoRcuUISW8LMNXsyNurkxYaiF/85tvlUDdlqz6?= =?us-ascii?Q?wwkscJjFgYUq9KhYrc3qTdYcAaUGJYS6du4M4/WmKiVpuVyhR1pWDiRYLrxK?= =?us-ascii?Q?CYu+4xtBKWmJfFVFGAkhUd3BrsBVU+X/8GoN38AtVZ7ajCTLv1POiiD/N8ZP?= =?us-ascii?Q?u026u1AKLxHPJexQSpPdv0f5wsA/pOtTQ9GkF/lLBHqgJlHD91PaGlZnpEOs?= =?us-ascii?Q?esy86afWiPxiOQgh1cIcPTWIzQDT4TUez13goGIsTAEfqOTQSNiIdLRkIWpa?= =?us-ascii?Q?B61bREPRohR5QdXts9QX17am+WA0c+WnWwU6rgw2pXW9ZY2jxVAIgdpwUjgC?= =?us-ascii?Q?mDwfKjiiYHjlej5OW+bwq+8IC5UD96A6K5XSnyGIPW4rGX9L2bdtY/RIjVmb?= =?us-ascii?Q?JGfXPbpAkQF3HR5oWWLj7z2dFDDjWGJ2lE6n77sH1HsRbZfZBDCLcZCu3uMc?= =?us-ascii?Q?5AVQPs+KUNzK2GBJ03jB1obFSr5Mgs8xN6+z2LL/u1oBEfwXpFtYqxvIVZh4?= =?us-ascii?Q?W1Zj2BKpyWkFk7YILk5tDr/doFQcuS6uGLUmu0rQ+h+N7W3sWMJLpdvmyfBM?= =?us-ascii?Q?jCXnHiee9G98B1Wzvz2eon3yDSYPOvM1JscTWpwDpc87+V96NjcJWB2WRPh7?= =?us-ascii?Q?ZOk7wg8YzlXFqk8q182HLhwzYie7DaPI1Szczbdq4UJSqqdVHJU9wQXe0n2i?= =?us-ascii?Q?slDlog8fEV8Wk8hfJpqzAKIEDiYUCGmhp+jTiMclt4bWYKctI6c6TMLdkX00?= =?us-ascii?Q?jdpcYKORm/BXiKu5wv2zxq6r8rqaRCN/WeuR64PeeGwkgMlHsEK1Z/ihugtK?= =?us-ascii?Q?epJGu6QuVgsGO/Qx71Mk+mPKhWYjWjp6Mf8+UMp1HRzXfv7u6OrD3Nq9ahDV?= =?us-ascii?Q?j+vwWxTf4CSo+vYeXxKCN2rAxiZeWdvg3mmdmFdll13jYasG9MCJMcWlTQMn?= =?us-ascii?Q?FFtJLPm2U+XYpveAC+4XFs9d7ktNHWdsSDcl0Syx2+9ZHKiVkgJTvWTHNNIV?= =?us-ascii?Q?Ax3xwJNVzBa0x8euS0rSIAWX1nbbQSy+hUh4o076?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5943.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de9e97db-5aba-4515-d2aa-08db8a06b33d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2023 16:22:38.4652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ihFBufkDZl8mFm1r5DDtWU/qu12D3DjeN7OdIaUYKcK+caUNTQtwDvCDgiTx93fscw4oMpCX7NvKJ/pOJ8NWEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6435 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nDjkHDGLioB285NsaIQMWHtjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AW95oQjm; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed by : Jayaprakash N -----Original Message----- From: devel@edk2.groups.io On Behalf Of Jayaprakash,= N Sent: Friday, July 21, 2023 9:22 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Rebecca Cran ; Kloper, Dimitry ; Kloper, Dimitry Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitial= ized global variable Hi Mike, I was trying to explore with Co-authored-by tag as I simplified the patch w= ith minor edits. If it doesn't work I shall remove it. I noticed after sending the patch. So I have sent V2 patch by removing the = , in the names.=20 I will go ahead and merge this change. Regards, JP -----Original Message----- From: Kinney, Michael D Sent: Friday, July 21, 2023 9:03 PM To: Jayaprakash, N ; devel@edk2.groups.io Cc: Rebecca Cran ; Kloper, Dimitry ; Kloper, Dimitry ; Kinney, Michael D Subject: RE: [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global v= ariable Hi JP, I have not seen co-authored-by tag used before. If Dimitry is the author, then please update git commit so Dimitry is the a= uthor and remove that tag. Also, please make sure that names do not contain ','. Should be: Dimity Kloper Thanks, Mike > -----Original Message----- > From: Jayaprakash, N > Sent: Friday, July 21, 2023 8:27 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran=20 > ; Kinney, Michael D=20 > ; Kloper; Kloper, Dimitry=20 > > Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global=20 > variable >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4506 >=20 > res_init() is called from different places in sockets library. It=20 > depends on global _res variable containing a state. The problem is=20 > that if __BIND_RES_TEXT macro is not defined, _res is not initialized. > Depending on compiler and build optimization this can fill the=20 > variable with garbage that is later used by res_init(). > Fix is trivial - explicitly initialize _res. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Co-authored-by: Kloper, Dimitry > Signed-off-by: Jayaprakash N > --- > StdLib/BsdSocketLib/res_init.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/StdLib/BsdSocketLib/res_init.c=20 > b/StdLib/BsdSocketLib/res_init.c index 613a76a..fbc53c5 100644 > --- a/StdLib/BsdSocketLib/res_init.c > +++ b/StdLib/BsdSocketLib/res_init.c > @@ -121,11 +121,11 @@ static u_int32_t net_mask __P((struct in_addr)); > */ >=20 > struct __res_state _res > -# if defined(__BIND_RES_TEXT) > - =3D { RES_TIMEOUT, } /* Motorola, et al. */ > -# endif > - ; > - > +#if defined(__BIND_RES_TEXT) > + =3D { RES_TIMEOUT, }; /* Motorola, et al. */ #else > + =3D {0}; > +#endif >=20 > /* > * Set up default settings. If the configuration file exist, the=20 > values > -- > 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107132): https://edk2.groups.io/g/devel/message/107132 Mute This Topic: https://groups.io/mt/100278658/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-