From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 32ADE7803DF for ; Thu, 26 Oct 2023 15:33:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2MREM8TOVXiH57COD7bWhYJCMtlah6FSk3mKBckLKEo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698334387; v=1; b=KjYkVzzmsINO6b1riL1/EoIR8PwCDEtufhWXtIujrYm6MdL7vp2NvOrJLpDcDGXHfibuOhSw BeCK7YjCJRPcR29Af12h78TsgHLmecoCMG3qpft7cVzCC+uRZrV3mZWMhgBf/sJSYxI+1X5JILa 6R95GOuYrhGbN9MKrM34yj8Q= X-Received: by 127.0.0.2 with SMTP id izD8YY7687511xGfDYDFxOMe; Thu, 26 Oct 2023 08:33:07 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.203560.1698334387246850872 for ; Thu, 26 Oct 2023 08:33:07 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="389669" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="389669" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 08:33:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="825036347" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="825036347" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Oct 2023 08:33:06 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 08:33:05 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 08:33:05 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 26 Oct 2023 08:33:05 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 26 Oct 2023 08:33:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tnxt5pD9/YWzOXmc22rcTAr9XqN+YUngtzrNWsKaUlcjVrqd9U3pUFl1mmEGxegQ3Lak9Z/vJ0//NYbS3HNtHEnwTJeBvzDpa4uw+3mQRUaIG4v6h89sedklgNPfA+Cgkc7EDyrNQ+M/B5B3S2F5ZO0scnGiRby430FxzIt4Nw4CYmjutk2aNgW/ffYCQGaYy0HNPiKExOnxyfj8frXAI016j1TRmLZVNflfgKqKHlD1TXE9F3XWLvMwojSZwtzIP7tQYOQwUIkP441O38fX8iUIYTXrtOL1RyF5KitOHSr1CtkJCL8wpQoebfSLOE48IcxEXywhBGVSzXv+ELTPGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h91ITSmAyWAAnes60h5q0TUhe/1IKZo7S37Xdi4NPQc=; b=ApGRqFmq/IeMnVcHw2tdV+PP0brG/NDk44UWtdWOtT1cjS7pP89XWCPmrQONCV+R+4ErDK/iSz0JuiyuWzTUp9AXiVMGMwVUqCt6YtCX3zbJ/2+UeJYqeLAgGjBAXgmkZIvki6EzlunLH22PqZyPtDUPGFCe6x0rvWHop5S+WIAsy2FC2vH09Dbaxy7AC0DIbG1KDezZYrJgf6A6E46jAap8/IyamdfLdp5IRCz0daOpQ3aVUysbgRVKqYVG1hIVQF2eru5Zil8SH+4ovgY3nAJ89OoBAeJtvm1s1obAwQ+ibsDGNwLhBwPfgioK2obMe32L7Ses+SxAAMpczKoZ8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com (2603:10b6:510:13f::19) by SA2PR11MB4796.namprd11.prod.outlook.com (2603:10b6:806:117::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Thu, 26 Oct 2023 15:33:00 +0000 X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::5d95:6570:48f6:204c]) by PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::5d95:6570:48f6:204c%4]) with mapi id 15.20.6907.032; Thu, 26 Oct 2023 15:33:00 +0000 From: "Jayaprakash, N" To: "devel@edk2.groups.io" CC: Rebecca Cran , "Kinney, Michael D" , "Kloper, Dimitry" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard Thread-Topic: [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard Thread-Index: AQHaCBct3bc0c22QXUOzGsty5b0+ubBcMuSg Date: Thu, 26 Oct 2023 15:33:00 +0000 Message-ID: References: <20231026141716.823-1-n.jayaprakash@intel.com> <20231026141716.823-2-n.jayaprakash@intel.com> In-Reply-To: <20231026141716.823-2-n.jayaprakash@intel.com> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5943:EE_|SA2PR11MB4796:EE_ x-ms-office365-filtering-correlation-id: 3b3fa77d-80bb-490b-a0c2-08dbd638d646 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kNa2ksEz/PnkUPvAQywlSSHdwnrG50TqN0b7YKkka7CC0fRELs8wmZOpd/zlMpqNepB6xXSubARmDT7fejZRR+H15MH0O5rPFVGokNAjxphISv3Mv1pBPxcjyM8Q8FuV7M2M8VnGgo1kVdfByT91Ugn1z7cW+yd+YAB3pbVMfOEL7OlU24xmMPUmmAUI0q7k58RBJKEEB7O1tgkAsELsfMOK0Hn6nikFTG4GrZX4yIlUzuAYGiDyQzcIOdE+9gmQ59ChaLCVa3hVdbR6RpJinCegDpjovuWp+IAwoB2grijNG9GTmMJ1uChdUP2Uvajt+TzpW9wQK30vv5kLFZTgnHMD1j+xZKWxYPt+wgB2apjzQ1CZFqe0y+U0TBOiBPZYY1NlD+xjXqpb7Q6Za8Y5xWkfaF85mBd+of5mc7x9/A41pQnzxi9J8LVkbAtEA2JRRn55I/OcgGPhelp70t6Aas3vMC3lHpNIUkEBB0gtr/45XiELzZIojLGdWRVsH2IlmjYLbhFJa2C1yM3MwVHMHEXndCBrELDZd76dheHiFVjRwmIZQ4PNIOLSQKq8tz2OY3EVxsq+lQUHoZ9dhUPhMwM4vYuUdUgPNyCdAdWYmOlg8MCLMl86eAE1jjGtvcfv4noHANxjVkUKSuySiDAwdw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TQ2rMc8aNiwCcehngF89OIxUaY+KlANONL9ISMKQn/s601eyV99mniGXJrnN?= =?us-ascii?Q?BFZctJlsDvqjA/tMek4AxcLQjIQu56kJhnJIxu0ndOmYdeQh4ESCtDb26L5/?= =?us-ascii?Q?tnS+1imfaYH4qcsdzeDPRpvmUa6IL0jJn/kaLXrYSzonujrP8r4RLzLK9S6B?= =?us-ascii?Q?5jlGq4NJ2klc5SoxvwpJR6jcQPsp9W/WiAEzXajMtTCdlQCY4Dgze5R7Msu8?= =?us-ascii?Q?mjZm7js0GHK4nr6wS4kTQ2e08Bugyp+bqdmU/mYkrjQVQd8cse3Bt50Wrkoi?= =?us-ascii?Q?iiPs76qQc1C0sq4IwUvTofwraJpLmw3o8oYzTTn2VD7rM1Ywy5C1G0ZM10Rd?= =?us-ascii?Q?/buZM4LJDvbsfUT8GjsMbthCT27qntNrypDB9bCw3ZTHhIC0oCka9SmqCWgG?= =?us-ascii?Q?EmXoIdgNXtdYZxwgi9SOfPF9+Q4KNtXC3DKD2QaqVq0jRHEwHE0uR5J2V0JS?= =?us-ascii?Q?4BuNh1pTENSeRuQf9Rd72Cm76PNMHh1g4PwcpdDlZsLUQKSaCZ1bRKpRyOaS?= =?us-ascii?Q?mvusdWN5OrQRhtUldooMXJ09RV6XJHK/VmtzR4mYxCZpcHm33i85BD6ltbnp?= =?us-ascii?Q?WNE2JmP/rXOjEUbqaiuNYMT25afbHnKzHQpmVC5FYqQgzAqUvPiagb06ZPJm?= =?us-ascii?Q?yhgEXkZippgsdaZfeueCKjxyBA3P1iHwRDwhYVxEVP8BUh+n1Bk4JbClWALf?= =?us-ascii?Q?IrvZNsh0x6G4JDDf0V1R7h7zdt5VNIOiclho2Q87prhUpg/1w8QiLWV50j+b?= =?us-ascii?Q?RIHrFKiOjwKB79U7A/pRb81SpxwQO9pSoEtg1G3i4uVUtsWMpTox/Fb3/LXL?= =?us-ascii?Q?GjPrq50igxHrXgjDzTaOBKvdlDfAtefPOmNlbLnmVInfWXtHkZAeSZc4+eab?= =?us-ascii?Q?eC0AhcT29tsfaiD6Gwur8axQGZ50cnagh/10yeujxhjR+aCknK/fOekGn0Bx?= =?us-ascii?Q?R+sm0fdyA4RDZDc+rnr3oGI+WN88aaOJf47kz6olmWKFp0yRDMO35vGNEbu8?= =?us-ascii?Q?+ptdlwxW3Vea+RRb3WdV0BrcypcuhzlSAhTnc2x+EKG6HUGYhI8oPOS31Se3?= =?us-ascii?Q?5jiZVliuQJFgSic4ZISamirKR44rOv8Vmk87OeROXRkcLRb8DNjAQvluVWjW?= =?us-ascii?Q?e5qL7W1H1KLbCDkOpSL776WLsJ2bbmZFOH9ASVsYk6CFSQ01YLQk3jNwxZnb?= =?us-ascii?Q?IEQIxjeV7ZdU6kwYA6SqjkP7XTAISV0pbU7YYl+iTLQJsaGw/5+TjERjIyKw?= =?us-ascii?Q?jU4JMLgJBBU+vB4FZ4lUNMKa0k/MY70ASixRbc/PUH77FGyjZgaIX724aNre?= =?us-ascii?Q?DF6POQvMZHMK13KwO8U8Tg7PIOnOtCaFOqU7AYnHdFwCsOkEEz+9HckwB1GL?= =?us-ascii?Q?c4et6IjDLM7tysHoRUhr2wRzi2hSnxQXycCVjBuF2d2xqv1hX1yoaCxyd0F+?= =?us-ascii?Q?aFifYv1FHyBTcuNSV264ThmNgIH+M26eHjWCiBRhsQEI8vTa0cluoJMCYjHe?= =?us-ascii?Q?R8YNmJG7l5f+QVx2PaclZezMHkWOJTuPlH4WI7bWUJnPb4knwkjPW5/lwjOr?= =?us-ascii?Q?eec6R14kszC/Cp6K4ngqV6p9oLMSyN+U4RlujNxr?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5943.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b3fa77d-80bb-490b-a0c2-08dbd638d646 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 15:33:00.4258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5q/KkHPAWGkWAOtoxNYLf4TjI5QoT5zimXfacRQjObud60evyLpO/ifL1z758BSz0lACdJwGyCk8yXwwWhwiKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4796 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TeExcMwdBSoOxbP42ugqzEjAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KjYkVzzm; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Jayaprakash Nevara It's simple fix to align the function signature as per the standards. Regards, JP -----Original Message----- From: Jayaprakash, N =20 Sent: Thursday, October 26, 2023 7:47 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D ; Kloper, Dimitry Subject: [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn'= t match the standard REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4574 This commit is for processing the below PR on edk2-libc repo https://github.com/tianocore/edk2-libc/pull/10 The realpath function signature in stdlib of edk2-libc doesn't match signat= ure as per the standard definition of this function given below https://pub= s.opengroup.org/onlinepubs/009695399/functions/realpath.html This patch extracted from the above pull request fixes this issue. Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Kloper Dimitry --- StdLib/Include/stdlib.h | 4 ++-- StdLib/LibC/StdLib/realpath.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h index 0b9dfd= 3..022ddbd 100644 --- a/StdLib/Include/stdlib.h +++ b/StdLib/Include/stdlib.h @@ -74,7 +74,7 @@ const wchar_t * __restrict src, size_t limit); =20 ################ Miscelaneous functions for *nix compatibility - char *realpath (char *file_name, char *resolved_name); + char *realpath (const char *file_name, char *resolved_name); const char *getprogname (void); void setprogname (const char *progname); =20 @@ -875,7 +875,7 @@ size_t wcstombs(char * __restrict Dest, const wchar_t = * __restrict Src, size_t @retval NULL An error occured. @retval resolved_name. **/ -char * realpath(char *file_name, char *resolved_name); +char * realpath(const char *file_name, char *resolved_name); =20 /** The getprogname() function returns the name of the program. If the na= me has not been set yet, it will return NULL. diff --git a/StdLib/LibC/StdLib/realpath.c b/StdLib/LibC/StdLib/realpath.c = index 3d4118d..29abe9a 100644 --- a/StdLib/LibC/StdLib/realpath.c +++ b/StdLib/LibC/StdLib/realpath.c @@ -34,7 +34,7 @@ **/ char * realpath( - char *file_name, + const char *file_name, char *resolved_name ) { -- 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110121): https://edk2.groups.io/g/devel/message/110121 Mute This Topic: https://groups.io/mt/102200532/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-