From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D1562AC10D5 for ; Fri, 21 Jul 2023 15:52:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=20A603H2GfbXyFE9eSuGSBMmVvDoU+o1p15tVvYDlBc=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689954741; v=1; b=AY/Fs992g074gmZ0PoHMRKsoybwEsKz4wqKNUqcPTony8UAY5UAVoWXX4uAbHD2LnwS1fAuz LPDjDCsAS0SOPP92GqX7OoWVSaSBkhj7RqOD9gqQqOpMMQwN9X6AdankABNrOXQAQGVPfnCMHIk nPMSIHYO3S88cCJSLJmWh6Lc= X-Received: by 127.0.0.2 with SMTP id pgvbYY7687511xEBr7AToJ9Y; Fri, 21 Jul 2023 08:52:21 -0700 X-Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.10644.1689954740381267852 for ; Fri, 21 Jul 2023 08:52:21 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="357044249" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="357044249" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:52:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="702098134" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="702098134" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 21 Jul 2023 08:52:19 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 08:52:19 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 21 Jul 2023 08:52:19 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 21 Jul 2023 08:52:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bD6F8hEzIRK7jVrvrL8wkYtBi9x9ZW2dYxRp2TChhT+IKWoOQhZnYAJ1lab97ZQqwhjhilqynxxfzgQdr1Q9jUUc+V2dt+ioWUZ6F6n7rHnzEsyJ3DZjNIkxq0CPzAAK78jtaYkYLaWbSpxxuz/IYHt6notAgqDm+VmdWgbT4dknTbgPVtieqHfrvZVG2WvZ8X0p3MyhzC0yj+IQ6HYYl+SWaV4yenEtj7d38Brv2UkyGHm4X+seCLUtHHC/Z6suz23M79twSqXSeOBx93XOJSSs9qImpaYOG5scJUxdIrfzekGgta0IOrBk+mS1RnLgeXEcqHBEuIWaR2eQ51sB4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lEnTAh4fHk7s/96ZKABggPiPFVXjdycd4nl6dCmneY=; b=P99gVUhSm0NoraqnhzwJzvqi0ywAUNcN+sKqFiC6r8iTZNKScbJDp698eBcrNXhPrbbXSRLKkfrpN4BzpCAI/lr3jUUXZhIQRXi4zs6It8nyLo+cU/VW/I0236GMOb46MhOO8PIVUvt70ot1o6nn9mglgb4lTGXlJtL23PCQ1Dctnd6F53JWgnwnwBu+fus/uOUio+dp5qxNqNPWvCs5MH3z0YOeRDH1rJgHkLt2Vym+AO2fheEMpxio3LHLLR8bh7VBaDA+RFgjV/Dwbza++2nX1sbRvm3irDPd2XPlam+rR4bmzACbviTDLQ8eyUpKlYplN7Ydaw+ntLXRU9blew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com (2603:10b6:510:13f::19) by CO1PR11MB4963.namprd11.prod.outlook.com (2603:10b6:303:91::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 15:52:11 +0000 X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::de50:25ee:1951:e347]) by PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::de50:25ee:1951:e347%6]) with mapi id 15.20.6588.031; Fri, 21 Jul 2023 15:52:11 +0000 From: "Jayaprakash, N" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Rebecca Cran , "Kloper, Dimitry" , "Kloper, Dimitry" Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global variable Thread-Topic: [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global variable Thread-Index: AQHZu+fexxOyN2uhAUeT+nQNinQdUq/EWZOAgAAEqtA= Date: Fri, 21 Jul 2023 15:52:11 +0000 Message-ID: References: <20230721152652.1761-1-n.jayaprakash@intel.com> <20230721152652.1761-2-n.jayaprakash@intel.com> In-Reply-To: Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5943:EE_|CO1PR11MB4963:EE_ x-ms-office365-filtering-correlation-id: 03c5e96d-c9d8-4423-3b85-08db8a027281 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: uuyWhxT6mqfLSSx+1fuQg7UjbIQkAL48ygUtF9r0YKbXPYBVh6bemSmShvfh+JWPEMAwMv11QtTo94RfedB8YkIUZ5fm1z9mefucEbJYtiYp5I5rC45jOD1BLvSpvsuVM9Bm9hOO6e0MpDu4G+T53gNh9B9B0A1ih8UEmZaM+KDfu+LjDneOGjgb3XgwUx0BBT/mDAjhOGC9NSO2mOhTWs06vSF0fC4QfRRZwlNnXSnbtUel1oao4H92x8LdttCEUm75tCnM/PaK0WFXIu7YqptEkh3cERtcNHLraFoaI7wOAlyThF00T7MbYJYJNDIUa8zSBPsvvbadm5KGNq8lBpQfkIBvPMUpu0w16VcggsPnxRWEK0/fOKAZZNdbg/szmD0c3qeToc+lWXSIisI148rJBAxhnU6VTLr2J+9ysTlTbC1K2d9HHY5VlIvoKqOR2Ru2S/u9xY1kuDgUZQc1RWXAWYAzFLAwcz5R2ZaB12sGGKAyHrBRFPjEpu7qj17vYMhyrEE6fzhNfDWkE9MnY/m1gRpJb0ApWHK3mOBf+8maDInbsylCVAqW9U++ulMl1dEZh+/lHlHBaFxf9Thyp1q1DbYM4+rLKQvo9S6pLDM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VyS/nCE8a1ByC1jWLKfQkSwE3wHArQMgpLRJJv6wUtpBjDZT6i+v7CM1mqe+?= =?us-ascii?Q?hwe6YcJXxXDqNyKb8SGpr2TFDdQ2TyoQoLJnl0JUIVv+Zxnh462P2MQ5yA3R?= =?us-ascii?Q?ARYxViKw96UTGI5cbXX8+q7V/6X1LSQk/XZDWHnz0WubvZScbUEhzQVigVrl?= =?us-ascii?Q?HyjxncnjIiUincWV90VLkc3Qt604cZlQsnLruScj60mrdY11qs9j7J0aCYX8?= =?us-ascii?Q?FvoDFJe9YEdtigkULUKXl2ZR/tbB6GA0bqgTNYAPDZkIew0w2RBbyfdpu2z2?= =?us-ascii?Q?p/uFyd8ioqL5zhHvzOdyn4nwl9bna1x0dO04Rm7pxPWX3ZrMM1UDjvbC+8U6?= =?us-ascii?Q?YBHg0TFuOZ386ItJmnxkt3D3FA/V0cHUPz9eGUEIO7GikO2UqhMsm05gX3YE?= =?us-ascii?Q?Fep4H/5kgnwids4VlAEV04VVL0enD+d7YJ8v/9jFYHuV0UHS3VWiTvHmSg+k?= =?us-ascii?Q?kSd6NM0HLJFN/0zQidu6QSGggx3nqJDh5octTnajDkuTtp4DyI/xSU+cdOs0?= =?us-ascii?Q?dJ0LLnmq/NR1yJnTrb3zcbPaF9U+bWpup6N3iC+QzS/1OljViqiWScS0EO34?= =?us-ascii?Q?jfyKJ014JdjfmGzk8ZKcJQZiXLa/h48KJfoTWJksagR+XaJwyqk8W2zcXoBh?= =?us-ascii?Q?ovIIYzruKiBA3WZ1bN917cQR6gO96dsnvpkVx+4BfqxSTuvs5RRZBX1gB+zi?= =?us-ascii?Q?V4s9tMFJzCmPOI1p+uj2mZ9eXte2NCawOyJrhg58QnFPoKNIC1jN/074qsvB?= =?us-ascii?Q?AnIfrDM2tuDaMhtNhzcB7pVT7b7W7lPSK9uVMBsuBRJyp7kXFCstCL1zY7Qt?= =?us-ascii?Q?7k18xhxRsqa2xzTB3T+J7VoiY1tMF3DAf762BRQAjYnllDLr6P+ZC8u5DgRH?= =?us-ascii?Q?0FSKpg42RrP0SnJ3ymrJ8Y4cKnjj2Vv29l/YSyXUljZTXlgzQUOmzqvGwIUf?= =?us-ascii?Q?ij5f0RSKSmvLAbKG1g9I6Fouu3jjlQHgPDsoeG2VxUK2yU8vADhJKZK32etL?= =?us-ascii?Q?dNLOgGc+esi8bHqeOgrxzBKJQL6KcP9370yrM5/yM8n2hCN/wmQhc3H/U7M7?= =?us-ascii?Q?CNe2zXaM1vNwcuTiANi47tKzmJIXwAOJW7cTmYtjCxEp3WZuYLWMjIn2J4Uu?= =?us-ascii?Q?7VWdKPUBhV+BnCRY/0JGis6uCQQpecvLK3RADOvBveohR733aeH0hD159Z9C?= =?us-ascii?Q?LrLrh7f6n6/5wVp5WKcwlfb7l1kjrhvIgbK58skV6Sk2zJyJU/wKoyZ4Vdzh?= =?us-ascii?Q?u6AzZ9zMGFOfXTVPLacCo6GMdC0Jwd0utLFm+ibEici8AiOOJaM3DqmykTjG?= =?us-ascii?Q?WKtYMRi/PMkJghw44W/XK3oR32pdu4tKXYSfMc1/vHTYAWPOlOV0hjk2DzEA?= =?us-ascii?Q?qdcEAWRlOoMAUo4vBSTc1Ou+0zyS4wY/fw5Cu1p5Zfq+aoEpqFhamwmSVJP4?= =?us-ascii?Q?070FIDjyfV1I2RmhHQ4KX6WKsETQz0Y8t8G8MV6FE2EigEg2tgPno8EEbjT/?= =?us-ascii?Q?F9G3Kd/EuiroB2jvK3pgcSFC6EQ7VEXIV3VYjQFkHISx86bKcCd+ImQEhaMG?= =?us-ascii?Q?6iVvqyNeM43OWr9DzQZ8YpJQ95JYvjMX0h6+GBJ3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5943.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03c5e96d-c9d8-4423-3b85-08db8a027281 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2023 15:52:11.8688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hCJoGstYoig/L3kPFAT8NFJA2rA7agMDZeMRcaHx9d2h2F65ODNaaZEklCPig1fgkbGRep5fetK1ipEcINwDoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4963 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2wvOhkKU8zPLgzK9UwVyvIzVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="AY/Fs992"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Mike, I was trying to explore with Co-authored-by tag as I simplified the patch w= ith minor edits. If it doesn't work I shall remove it. I noticed after sending the patch. So I have sent V2 patch by removing the = , in the names.=20 I will go ahead and merge this change. Regards, JP -----Original Message----- From: Kinney, Michael D =20 Sent: Friday, July 21, 2023 9:03 PM To: Jayaprakash, N ; devel@edk2.groups.io Cc: Rebecca Cran ; Kloper, Dimitry ; Kloper, Dimitry ; Kinney, Michael D Subject: RE: [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global v= ariable Hi JP, I have not seen co-authored-by tag used before. If Dimitry is the author, then please update git commit so Dimitry is the a= uthor and remove that tag. Also, please make sure that names do not contain ','. Should be: Dimity Kloper Thanks, Mike > -----Original Message----- > From: Jayaprakash, N > Sent: Friday, July 21, 2023 8:27 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran=20 > ; Kinney, Michael D=20 > ; Kloper; Kloper, Dimitry=20 > > Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: Uninitialized global=20 > variable >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4506 >=20 > res_init() is called from different places in sockets library. It=20 > depends on global _res variable containing a state. The problem is=20 > that if __BIND_RES_TEXT macro is not defined, _res is not initialized. > Depending on compiler and build optimization this can fill the=20 > variable with garbage that is later used by res_init(). > Fix is trivial - explicitly initialize _res. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Co-authored-by: Kloper, Dimitry > Signed-off-by: Jayaprakash N > --- > StdLib/BsdSocketLib/res_init.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/StdLib/BsdSocketLib/res_init.c=20 > b/StdLib/BsdSocketLib/res_init.c index 613a76a..fbc53c5 100644 > --- a/StdLib/BsdSocketLib/res_init.c > +++ b/StdLib/BsdSocketLib/res_init.c > @@ -121,11 +121,11 @@ static u_int32_t net_mask __P((struct in_addr)); > */ >=20 > struct __res_state _res > -# if defined(__BIND_RES_TEXT) > - =3D { RES_TIMEOUT, } /* Motorola, et al. */ > -# endif > - ; > - > +#if defined(__BIND_RES_TEXT) > + =3D { RES_TIMEOUT, }; /* Motorola, et al. */ #else > + =3D {0}; > +#endif >=20 > /* > * Set up default settings. If the configuration file exist, the=20 > values > -- > 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107131): https://edk2.groups.io/g/devel/message/107131 Mute This Topic: https://groups.io/mt/100278658/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-