From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E92AA7803CE for ; Fri, 12 Jul 2024 16:47:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CkTIGTnNHVB5zD7GQgtBT+QRJM0vdDFo+VlOVQ2copw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1720802839; v=1; b=IM+4qGfMTPIL3wl3SS4EktKrQe5s4Hk0eWo0TDvsTOnGcLtlVD1sZi17DWKfpxY99r8TDA8c rxSbKUm8DkGk5hwzGTOI1dT+0BCv7EUlPpDKN6oeOmLHW4J5h1KhSZGYhMucmscJbgt43+E18Be UIyTSl8jqF56RH3fI+gqZSw5vy4QgJiuUVqioWqx+vWYQJfT9DCrPtfd8zVyWta+ruQYp5Xcasw 8A0MYQyYhCdIHjYrgBZz31/WU3U9pV8HHxL62WyXm9swaafub8LC81h/D8xWSbnr/PnAOTGgSco ApTFxy7AqHzU7g60K2SCdgl+Axjg9z9Z23TLCg0zT1AVw== X-Received: by 127.0.0.2 with SMTP id i7cYYY7687511xgQ1dy4ie2B; Fri, 12 Jul 2024 09:47:18 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web11.617.1720802837667039529 for ; Fri, 12 Jul 2024 09:47:17 -0700 X-CSE-ConnectionGUID: 9f+09q82TsC8R8Fcj19ggg== X-CSE-MsgGUID: +vH1VRB7RHm3sBc/bQBLNA== X-IronPort-AV: E=McAfee;i="6700,10204,11131"; a="18095371" X-IronPort-AV: E=Sophos;i="6.09,203,1716274800"; d="scan'208";a="18095371" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2024 09:47:16 -0700 X-CSE-ConnectionGUID: cs2pGH2jSsq1FA9UrEkZaA== X-CSE-MsgGUID: gmXGXCG0TBKIEhZCQVb/XA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,203,1716274800"; d="scan'208";a="53325063" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Jul 2024 09:47:15 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 12 Jul 2024 09:47:14 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 12 Jul 2024 09:47:14 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 12 Jul 2024 09:47:14 -0700 X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com (2603:10b6:510:13f::19) by PH7PR11MB8121.namprd11.prod.outlook.com (2603:10b6:510:234::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Fri, 12 Jul 2024 16:47:11 +0000 X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::15cc:b461:7bb8:b69f]) by PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::15cc:b461:7bb8:b69f%4]) with mapi id 15.20.7741.033; Fri, 12 Jul 2024 16:47:11 +0000 From: "Jayaprakash, N" To: "Kinney, Michael D" , "devel@edk2.groups.io" , Leif Lindholm CC: Rebecca Cran Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat Thread-Topic: [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat Thread-Index: AQHa1GfZm9LYfxTVgEqre8KUxOSAQbHzP+cAgAALkSA= Date: Fri, 12 Jul 2024 16:47:11 +0000 Message-ID: References: <20240712142844.1317-1-n.jayaprakash@intel.com> <20240712142844.1317-2-n.jayaprakash@intel.com> In-Reply-To: Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5943:EE_|PH7PR11MB8121:EE_ x-ms-office365-filtering-correlation-id: 54a77477-3371-4e25-e55a-08dca29246a4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?mxYVvQAMDs3zUtTrvKmAFycLyz1VytIN1UB24rBR7+2hZzxAXTkwPSyZ7KBF?= =?us-ascii?Q?h43DI1HDmvolxvUqGOp+uPNuBsU493oN3jSVHqvMVXqRonI8ALsJmf8qUauF?= =?us-ascii?Q?/y47yY1FTc5Z4n2sMFM3W6QUOaLLrIVZX7KtuvENlWP2cZ39Jum4PcIuN7GI?= =?us-ascii?Q?4HKUVrxgVrG+pCN3bqZkg2pQxL21QUJZV6f+qKiv/o2G7/xsJab0rny2EX3L?= =?us-ascii?Q?jNgo7/e0w5DTKYYeGd1AaGWZqaqYzzEUctdRYL/7QPVQWPExvnw4h9u3hD1X?= =?us-ascii?Q?dPeq7kguWiFlXEZ6UkmC2vnCJ4aNVU28SechH8v/rqrFJJpZl3s0OOfa9nHI?= =?us-ascii?Q?n1EKJmHn08geeFhY9hpqmITcedZcJe9fpZIoLq3+YAisqFQ4LN0vSXVErScP?= =?us-ascii?Q?FdeKyM28wlrJhk21Haht59K60biTUAd12sI/k+BlJhdh0/9NIC9rXWWodd2J?= =?us-ascii?Q?tWAmtRR1gvWm414w1QnuR0BLhgPPeNMBRCLRDeS/IrpzbvVm6dBJUMTmWe+E?= =?us-ascii?Q?1zGfcZTrpSzyr09j9+PRnevW6F8bC4jW/AFNx9FBWZg5COGGrY67jFh2C93K?= =?us-ascii?Q?5sc8DNxA1vWicikrQU/iwOXh/MttfG9IV3sEXWi4HjPSRdZc9rvlAqaaytrV?= =?us-ascii?Q?wOYZfmD7drIvb3OTfBaxFr+IfquBfKswPT8NWD44RFkj+vJ27PJ5SUfuN8Cg?= =?us-ascii?Q?WFEj36IdtVD00jgR6isAXq3H84K+OSjA+XWG/Di9SXQDmvvE8Gi6injgwXw7?= =?us-ascii?Q?yg2AwEwts67Rh163KqpHRglQzKRxmoEux5WYCk4c/EzTG2joyKbdSzegoTle?= =?us-ascii?Q?UKDwR1cviLL6cRrCu3rAaiQTeFE55m+5zVJvvqWyETlDlRh70bAY4RqJXpH9?= =?us-ascii?Q?pkoQsjg/faLIxynNlX3e5Qib6UYf3LxhSDbiQfI/nebDDHCkZ1xRNsl2AuAh?= =?us-ascii?Q?T6Xm8ird2VVzAb1U4uZa9mb8KJySSskUdC+o9icpBJJFtpFvC6hsxHJ8UKVh?= =?us-ascii?Q?oqaeHmrkmhrONaxSdKAMpmLeByyLOTrU7uMffmgp/3mZOeVAzun1nBnMMPqr?= =?us-ascii?Q?fjmhjsD4zz1psWxrWvQmPzCZ8aftPBgLaGYrahpTOA3kC3vcXa/olndi1rWl?= =?us-ascii?Q?i3Jn8JkUJC+I5KOPm1CJQiRmv0KJGqIKvfh3P3uv7Uo3wrCmQrd4nBts5Ppb?= =?us-ascii?Q?tT1UYSQW0VcQf2sJ0nIU8yup+Bw7absXI1fmmR35jrGHvqFCMFN4Nr/oklP7?= =?us-ascii?Q?h4KDbV37NtZL2JK91Mux1AUWmnzJsraUL9YTTprfYPGvAr2vbUvIfaWR+S2p?= =?us-ascii?Q?UWACVSiBiN4WNxXsKTYS+8lxwYs9MPrpQ+oOrEqfq04FkRxNTW7RtkmP+Uir?= =?us-ascii?Q?2hHcsjE=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R8qvLJEYxgzviux8Z0GPiyPFdZSaOPlNB8xPIikZWBO7lL5wVgB/qtq/gkOt?= =?us-ascii?Q?DpHUaD79GuLea/R09aZK+D8PQC2gQIs4FDc6NNamc235heKCQ2dVo/wAvy8X?= =?us-ascii?Q?ZICwS9lhDis2mqqYgIx/sUPViXOQP7+EHyA+v5Pc2cWycEVoTZLTXrgF9y3p?= =?us-ascii?Q?8MKsluVDULudHQyCu1AWFXiNjGuptoikdPBZnl2XQarV8JtC9t+PP/NaAR7K?= =?us-ascii?Q?9ToN+vKyC2Jd2Vqsje1iNRsi4UboyOv49K9ZX+0VyqbOXIWXZ+qYRLwIfeMw?= =?us-ascii?Q?HOueRRbyX5KuLkNny/AGioMEk1gRh172E176WhrvdXevEjEOCWXoVhP7LjLP?= =?us-ascii?Q?Fdx9yeRqohpoXCECxFVSXIKkRTxniuWbM027Gd6xeVhTVkjzaNhPQ/sWrXuL?= =?us-ascii?Q?iaCSrVyOWopStqOvbvXY0es7PTA2HHk2sOFkT2LzGAbdt+Vk/jysBgzWal23?= =?us-ascii?Q?cY+95UFj3JAj33Tp3aAawt/erCUV9WEWO10qeXEdx/AuEbvVX+Xw2VwSsAVG?= =?us-ascii?Q?7N34gKkJRh8HfBFfN+5brSfZMB3CMboTYDepAiWyjluZHnd4Y6Pbt+TwJJuU?= =?us-ascii?Q?mllTX4ffzckWSmRR1SkOsRSrGAUn4/lf0VnrBc09MJE3X7h2GeTUF6bCx1Jj?= =?us-ascii?Q?PJX/x346QoMeeTmFjrwXQQM5MyNjafbaaO73QziNL7wQ7qpmorIw9oZLNh/n?= =?us-ascii?Q?nkCVkHjGlvjObxwiqRIkxYDUWNqYKyUm+fHj1pucVbqAwO1f6U/ELpREgu/H?= =?us-ascii?Q?JEMnKosaXOZlZVofAHOcZ+oegIoQIC6ivv8wimFk2Fo0lww+va6W/IUTFEZe?= =?us-ascii?Q?mal7LTapqW+dcoZeepGxaH9pxOhYcL87xz3Z+YYVyy+KOupOVl1PQ8a3kH1O?= =?us-ascii?Q?zn3vJA/w3jH2sQvNuGuyP+muCs9dt0t0v0asEGZEPrp1yLHRUzKhSxo2x0N5?= =?us-ascii?Q?3ZBXtYWsQMz/wYeEqRoMtr6fXEHmisZw4J439gc6KkU/DBW27Jq/yuZOmfNd?= =?us-ascii?Q?n63xL036ajmnhtNLZyrWNsK2rvxR2rxYaYGtiQjSbn2MVinJmfD3U5u5kpuT?= =?us-ascii?Q?zIs/+Jc9YGIgzwlLpDslH4lXuxy5l7DOIo7zV2xbl5C21WIiOVYSiTF4Ju10?= =?us-ascii?Q?OqvzfdghZmrZzlowaEjgtocceqPCN+R0nw3XORQonM08ZLWYIn1G3zrU4k8G?= =?us-ascii?Q?/iCxZyJTfga9B80cdW0iPyQNwC7sLeyc+huBV9Z80hSklb1OoE65XtxSilPv?= =?us-ascii?Q?Ht9Hn+NOoA+kR6fNjYthHohOyGw70HWspzs9VTRSfKKSZxi0Lr/8hfnJPx5w?= =?us-ascii?Q?YvZyWebLj2AoY9WlnjEeiQoQtUJXAds+cFK/ZBZ2CEd7rHhmjZUkTXHZGStC?= =?us-ascii?Q?RKehEVxBuQtfI2IUvr9l/fzuKytWc30SxU+SYjh5SEb+xZeC7xDoBBedIqAB?= =?us-ascii?Q?PdGf8Q6I9j9OllkAepMdkOmtnPXlsR8fDkRcqx08E4C+2UPAlZYx9L87FJcU?= =?us-ascii?Q?QXeVk2/s0ysyTTKZzTQ3ohMvCINoMgLjHnuvzrVNhrvFf5SkO1UpG4sBIs0B?= =?us-ascii?Q?pV+Fp+FT2+y0tVYiot/kJqdOYx45ERIg9oZWP33V?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5943.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54a77477-3371-4e25-e55a-08dca29246a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2024 16:47:11.3537 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ggrTdwkW/bj3nfSaqcXng76nForn6ZiB3F22Emi9cYPN7OPbUwTgJa+9BRXU/QxCZui3pVyieLE+nP9a5a/qfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8121 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 12 Jul 2024 09:47:17 -0700 Resent-From: n.jayaprakash@intel.com Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Jhi7hZ2df5crkQRYNVCaYIOlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=IM+4qGfM; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Mike. Line endings have been a consistent problem creators for me for the .sh and= .bat files while working on Python UEFI project. At times I used to run dos2linux command to convert the .sh scripts line en= dings from \r\n format to \n format to fix the compilation issues on Linux. So, thought of using the .gitattributes feature from github to normalize th= e line endings for these 2 types of text files. Will wait to hear from Leif on the changes being evaluated for Tinocore rep= os on Line endings. Regards, JP -----Original Message----- From: Kinney, Michael D =20 Sent: Friday, July 12, 2024 9:29 PM To: Jayaprakash, N ; devel@edk2.groups.io; Leif Li= ndholm Cc: Rebecca Cran ; Kinney, Michael D Subject: RE: [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure = right line endings in .sh .bat + Leif .gitattributes is not used in other TianoCore repos. This feature changes the line endings locally when checked out. Instead, the edk2 repo uses a CI check like PatchCheck.py to make sure file= s with specific extensions have the correct line endings when they are chec= ked in and files are checked out unmodified. I know Leif has been evaluating some line ending changes to TianoCore Repos= . Don't know if this direction is in alignment with those ideas or not. Mike > -----Original Message----- > From: Jayaprakash, N > Sent: Friday, July 12, 2024 7:27 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran=20 > ; Kinney, Michael D > Subject: [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure=20 > right line endings in .sh .bat >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4809 >=20 > This commit adds .gitattributes file with the right settings to=20 > preserve the correct line endings for .sh and .bat files as per the=20 > Linxu and Windows line ending conventions respectively. >=20 > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .gitattributes | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 .gitattributes >=20 > diff --git a/.gitattributes b/.gitattributes new file mode 100644=20 > index 0000000..3fd9ec8 > --- /dev/null > +++ b/.gitattributes > @@ -0,0 +1,2 @@ > +*.bat text eol=3Dcrlf > +*.sh text eol=3Dlf > \ No newline at end of file > -- > 2.45.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119914): https://edk2.groups.io/g/devel/message/119914 Mute This Topic: https://groups.io/mt/107182920/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-