Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Fix compilation instructions of socket module as builtin module

["Jayaprakash, N" <n.jayaprakash@intel.com>]

It's a documentation change.

Reviewed-by: Jayaprakash N <n.jayaprakash@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jayaprakash, N
Sent: Friday, September 1, 2023 9:48 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N <n.jayaprakash@intel.com>; Rebecca Cran <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Fix compilation instructions of socket module as builtin module

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4548

This change fixes the insufficient documentation instructions to compile socket module as built in module into Python interpreter

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jayaprakash N <n.jayaprakash@intel.com>
Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
---
 .../Python/Python-3.6.8/Py368ReadMe.txt             | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
index eae56b4..2b27c92 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
+++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
@@ -129,13 +129,14 @@ system as follows:
 
 6. Example: Enabling socket support
 ===================================
-  1.  enable {"_socket", init_socket}, in PyMod-3.6.8\Modules\config.c
-  2.  enable LibraryClasses BsdSocketLib and EfiSocketLib in Python368.inf
-  3.  Build Python interpreter application using below command
+  1. Uncomment the statement // {"_socket", init_socket}, in 
+ PyMod-3.6.8\Modules\config.c  2. Uncomment BsdSocketLib and 
+ EfiSocketLib LibraryClasses in Python368.inf  3. Uncomment the 
+ statement #Modules/socketmodule.c in Python368.inf  4. Build Python 
+ interpreter application using below command
           build -a X64 -p AppPkg\AppPkg.dsc
-  6.  copy Build\AppPkg\RELEASE_VS2017\X64\Python.efi to \Efi\Tools on your
-      target system. Replace "RELEASE_VS2017", in the source path, with
-      values appropriate for your tool chain.
+  5. Copy Build\AppPkg\RELEASE_VS2017\X64\Python.efi to \Efi\Tools on your
+     target system. Replace "RELEASE_VS2017", in the source path, with
+     values appropriate for your tool chain.
 
 7. Running Python
 =================
--
2.40.0.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108231): https://edk2.groups.io/g/devel/message/108231
Mute This Topic: https://groups.io/mt/101098720/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-