public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jayaprakash, N" <n.jayaprakash@intel.com>
To: Rebecca Cran <rebecca@bsdio.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat
Date: Mon, 15 Jul 2024 18:14:31 +0000	[thread overview]
Message-ID: <PH7PR11MB5943CC0EB2F523A9F4E8CA83EEA12@PH7PR11MB5943.namprd11.prod.outlook.com> (raw)
In-Reply-To: <c4bee120-4e5b-48d6-aa50-127153c99a23@bsdio.com>

Thanks Rebecca for the feedback. I shall definitely add .env into the list.
Waiting for inputs from Leif as per Mike's suggestion.

Regards,
JP

-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com> 
Sent: Saturday, July 13, 2024 1:34 AM
To: devel@edk2.groups.io; Jayaprakash, N <n.jayaprakash@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat

On 7/12/24 08:27, Jayaprakash, N wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4809
> 
> This commit adds .gitattributes file with the right settings to 
> preserve the correct line endings for .sh and .bat files as per the 
> Linxu and Windows line ending conventions respectively.
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>   .gitattributes | 2 ++
>   1 file changed, 2 insertions(+)
>   create mode 100644 .gitattributes
> 
> diff --git a/.gitattributes b/.gitattributes new file mode 100644 
> index 0000000..3fd9ec8
> --- /dev/null
> +++ b/.gitattributes
> @@ -0,0 +1,2 @@
> +*.bat text eol=crlf
> +*.sh text eol=lf
> \ No newline at end of file

Could you also add .env to allow for files that set environment variables sourced from scripts?

--
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119937): https://edk2.groups.io/g/devel/message/119937
Mute This Topic: https://groups.io/mt/107182920/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-07-15 18:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 14:27 [edk2-devel] [edk2-libc Patch 0/1] add .gitattributes to ensure right line endings in .sh .bat Jayaprakash, N
2024-07-12 14:27 ` [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: " Jayaprakash, N
2024-07-12 15:58   ` Michael D Kinney
2024-07-12 16:47     ` Jayaprakash, N
2024-07-17  5:55     ` Jayaprakash, N
2024-07-17 14:24       ` Leif Lindholm
2024-07-18  6:47         ` Jayaprakash, N
2024-07-18 17:55           ` Leif Lindholm
2024-07-12 20:03   ` Rebecca Cran
2024-07-15 18:14     ` Jayaprakash, N [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB5943CC0EB2F523A9F4E8CA83EEA12@PH7PR11MB5943.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox