From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AD30CD80733 for ; Mon, 31 Jul 2023 05:45:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rLbkx5lIn6RUtRtRKZG0WxiQ4NUCXWKG/JMyvhfcZuE=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690782330; v=1; b=NTBPOg4vJIenCfQWUvfTrPGfZITqd7HVLmcyQhXz6ilngyi8BTtRqGyNL8CiM8ToXHCx0Eqj XfPrmRBrYA+nK/ZG+Wd68mqUlwtqOWMLnTWOowNTJMGAa6bkQ2XXnORVPprdYxgFSWQDD6Egi+K 0Ey3GBuAp8B8uM7xTWmYryuE= X-Received: by 127.0.0.2 with SMTP id HUMGYY7687511xBRewlrGqkg; Sun, 30 Jul 2023 22:45:30 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.1556.1690782329042766498 for ; Sun, 30 Jul 2023 22:45:29 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10787"; a="358961187" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="358961187" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2023 22:45:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10787"; a="705260178" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="705260178" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 30 Jul 2023 22:45:28 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 30 Jul 2023 22:45:28 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 30 Jul 2023 22:45:28 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 30 Jul 2023 22:45:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YcuTujoILBAeloMCpGFqOmMJBb2QeIE22Ew9767Lqyf+NzepYaFMOWP5HZWTDjR7+9WD3B8CDWAwfrLL7Sca06wF8j7QEROeoQbnoFycpnpQWRupuqgKowFc4Vydohs57qrOFzwvp5q9zYpLNtBJI2qvnte495JoazswgvwIhkha4881Jg7fmC4EEFnGtRU6jfI0eVB6kYwtlNwQA9azYi6/HGb9XqeqKKJL7Xv4zF9mALQ/vWMLSmuJf7Xqo5Md57ELKPRajOmTO1IQyp/wfx8+qHsviZ14BBw8qhnhwOvAeMFQpkqKkvkOYZMHP9a+/+7Rrjm83LxD+2IAy+ytYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=smIJEdIqgCZipJ20huA+QuZikHFwwa+wyEMh2+YFh5Y=; b=fnKhtBaaSv/Vp+YsdIiErb1mBqA+05jrfwNovVcb8Q+R7zyuQ0He97NA48RqVlsVrYeHV8DXrll1V5xq1QFJerJtZsmFkOlabhkKiD15BZrZX/3I6UScpiJtxJZa5EIeflLCFINwFGBReQFVd4I//oIFlijMXO8x1yzqcsF0VDwAROZ+3tr9SauUg51VHvQ+d+gUPRRHHkHC6o4S5VRV2p//4EQimiJx20dE1Ie/0+mfwrrR4P/kr1X4NYo2KP/3hjlyE890hw9bj/8H77rn51xSkmamsJhrDXpcv6QmkEwxsRu9qVEcA0hm+wzeGeuWFyval4XWULXmF4of8FpeAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com (2603:10b6:510:13f::19) by PH0PR11MB7658.namprd11.prod.outlook.com (2603:10b6:510:28d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Mon, 31 Jul 2023 05:45:19 +0000 X-Received: from PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::b67b:e5dd:c87b:ce12]) by PH7PR11MB5943.namprd11.prod.outlook.com ([fe80::b67b:e5dd:c87b:ce12%5]) with mapi id 15.20.6631.026; Mon, 31 Jul 2023 05:45:19 +0000 From: "Jayaprakash, N" To: "devel@edk2.groups.io" , "Jayaprakash, N" CC: Rebecca Cran , "Kinney, Michael D" , "Kloper, Dimitry" Subject: Re: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Fix uninitialized global variable Thread-Topic: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Fix uninitialized global variable Thread-Index: AQHZv9fDT5P9lOpbyUWidGZyqxnKVK/TZHcw Date: Mon, 31 Jul 2023 05:45:19 +0000 Message-ID: References: <20230726153848.1584-1-n.jayaprakash@intel.com> <1775750E87670E14.27380@groups.io> In-Reply-To: <1775750E87670E14.27380@groups.io> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5943:EE_|PH0PR11MB7658:EE_ x-ms-office365-filtering-correlation-id: 761d3218-f261-406d-123e-08db9189532d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: PK4so2H6n1kDTVqp0c9m7IoInsZa1YSpuNUnTqDNOH2W/4WuhcGWpyQcRU19MrpFnLPS2lfT9gY5VFZW5lh8T2+vwVOTU+8nTcH2hHaNMGWb85zqktLeS2Op9JNPQLaXEhJ/OJu+ceFiib4q5uHwDnZaw2xqZsj/Nv0qbIa2J0YTfLMJ/TDWQwZ0NsANoZGNgtH/yzy69CASTCQVNnJZVE/2NyTCYZhRlSS4dB/SZAOlqxaPzheZU9C8vNLCRMxdCc6AZjsF2WjsY4nJCNzqu33r7+dzsj4KdAsGTViIGwdKMc8YVMcB6BDQyOpkn0t5LJ3HFpXjr6EKECbrO6VM7DkrSzKZonZlF5kEfsOkPBKJdmRdorgVECFH2JYdaBeTMZgOxQ9rGGEdgmHTY80C1U6aHHFDnsIM4lO2X/SngHbwAxypQEKbWcIXn2+w2w3QXX+uAV8Z14ejqOOMM00o7U2ohM5HaRcEYTJFSJbBw3Acsxegl2iVALj/qhTOgM7G40OpTRF+WP07sYFZ48UF4QXyXN72wK2gUUeZMmFnEjrAA0VfXY2O6HnSnIiHXIhIRj1yOnWcA/09gA9smyfJ6W3oLhFDj1GlK1EMGikedUyU1RNO8Thrcdqn1y6PMXSGT/Yh1wIcqHDZCGrDhLoX4w== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nAAhV57RRxJWp4Ol5qIjDtFJyHFUVai/MmS8IEy0J9x3k1nXdk68pHkjz6It?= =?us-ascii?Q?3TNrYLV+zjLrfV/r8aNqiFTmbWEaKJXJAV++gp4GU3sG/3mZ0GAIn2TlXK1x?= =?us-ascii?Q?UaabV+xRh8Yl2j3MKbGv4qgzx9UNkDTQX9+KfaAtQBmyS2sKGi2nZCeUqR9P?= =?us-ascii?Q?0R39Gzb20CeLIjL4CPZvWEPA7m3IvmSsD3N+LdH8or+LENxThSbFGl3W/UxF?= =?us-ascii?Q?1JtXlSb+q3fM+kagkWMK2XqaiNlGEiriUaUz1JZA1Qh4UtgJ/XnW79+TPm8H?= =?us-ascii?Q?eiJSWfO74003XcMuMbIONIcQl5qk9aVJj0DUciJVofMoxvJ3fXakMuEbhQaj?= =?us-ascii?Q?WKBE753BsoMAjKY7BEaUsBvVEpFOn4EMYwqHWKNPytfMfrczAc5aDlofYfuU?= =?us-ascii?Q?PqK1zVNrG7o3wzhPJEzs0ZTWPSdqewM5ychMa8Xv/0NHbkWVWMxktarGV/r1?= =?us-ascii?Q?VuPuGn9IEgRSzJdRvoIpbYz/z/LEIoPUvh87CXv76njGnmXAzFA/8gSVTr2H?= =?us-ascii?Q?ChWrB9G1q2rkqPq3FyZuUfqkSVrC7GvCzy8po8rl8xn8PENP5uTsd1/iX/EA?= =?us-ascii?Q?lO9nWqHSGUeAwsJrFbIrP2a8io1eXz6BuT0f2DNAk2s8ZGjWx+rIAk0wpLYG?= =?us-ascii?Q?mjBEy0XYOg2l+9V/ub8KFS2KomRkPDoWqODmRYB1fCbMvOcdwjTwOZHY47h8?= =?us-ascii?Q?axUmvYmw0BsrIjX/oMlLzQv0ywvtxsLjj0wY7IEOAD3FeuJ40PGP8ibi6spQ?= =?us-ascii?Q?suziK+BQeCf45Ho1k4JlVQqeTk5Yu6djvXt0NA2vCwLaA+gmOOuCttJ1WD50?= =?us-ascii?Q?Dh0MLXrROjasaZ0/WUzE3bMXDydY9X0PPzm2wt8Kybyr98eQFtguxzNW58Fj?= =?us-ascii?Q?42/fvjuT5pJdm4zEgPxKv4f0Zv8/YZXbQNhCr3nVUsV55sQGSjERfDCtbqqQ?= =?us-ascii?Q?Xb9+RdlNB68yRnGJ6xtW+wzlhyaCK3EIBdcXHX/wNM6VFgfWcvDoQWAmJX1V?= =?us-ascii?Q?WFLMyjABAFdhEZ6WgZUwzLszSajvXUWubw/DH03dMGGWcdo3bOuZnQI3ZVfU?= =?us-ascii?Q?Pr3p/2QhTgurChp6MHZ5o+ST4QC7rTMXuRQGZvnWXXpeCYSt6NYDWWsOvvIi?= =?us-ascii?Q?16ZPopNfFepMUipqWOy8fvlz9qPQPQz4ws+dN+wFuH5HE9G6Bfbb2Nz6wWbF?= =?us-ascii?Q?uwS4jkZ47vZCY7a8HBKYFqfY8iyBR0OJ1OjeO/OcnzY/4BmdkDMCEXtH0AwK?= =?us-ascii?Q?gzTzMg8EKDS6IHuPpgjksA9MNyRavfNxVpO+Hs79YKnbXx34cmiFmh7pJK6W?= =?us-ascii?Q?xBnLFfv2zPrgarmYMA7P3757n9WoSFl+fgtVuohPPslIb80stU3fZbuT6B9v?= =?us-ascii?Q?mO106pZaU6r/RlvFHqK/2isEa+eMOOOh9f+5zyPf1xKpR45W8sYyqOBgY95v?= =?us-ascii?Q?xjjvnMfdfj43cn09vNWSKr8U22EGVkwA+dB+1aZ+p/pkL4xvv71fVQ5//iv2?= =?us-ascii?Q?yUeWSxln+zIiuQWZLoDpWgit1owxSSo1FXBtD46nEQUn3F48vK9x8Puao/Oq?= =?us-ascii?Q?OAd1QvcsC97wFPvD4R0Q7ose91OHUoMf20J+SIhp?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5943.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 761d3218-f261-406d-123e-08db9189532d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2023 05:45:19.5018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zb2VP9d/2n8YOnVR1KT6dwHjpnT9kzizt9WJI9cCw8OBa9UAh6tdBRIs2ZHunSNuxcZHK1bPUuOG4/J9h8Jvuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7658 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SiCDOpFrRdE8FFltc7SEJk7mx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NTBPOg4v; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Jayaprakash N Regards, JP -----Original Message----- From: devel@edk2.groups.io On Behalf Of Jayaprakash,= N Sent: Wednesday, July 26, 2023 9:09 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D ; Kloper, Dimitry Subject: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc/StdLib: Fix uninit= ialized global variable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4506 res_init() is called from different places in sockets library. It depends o= n global _res variable containing a state. The problem is that if __BIND_RES_TEXT macro is not defined, _res is not in= itialized. Depending on compiler and build optimization this can fill the variable wit= h garbage that is later used by res_init(). Fix is trivial - explicitly initialize _res. Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Kloper Dimitry --- StdLib/BsdSocketLib/res_init.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/StdLib/BsdSocketLib/res_init.c b/StdLib/BsdSocketLib/res_init.= c index 613a76a..9df7d4f 100644 --- a/StdLib/BsdSocketLib/res_init.c +++ b/StdLib/BsdSocketLib/res_init.c @@ -121,9 +121,11 @@ static u_int32_t net_mask __P((struct in_addr)); */ =20 struct __res_state _res -# if defined(__BIND_RES_TEXT) +#if defined(__BIND_RES_TEXT) =3D { RES_TIMEOUT, } /* Motorola, et al. */ -# endif +#else + =3D {0} +#endif ; =20 =20 -- 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107394): https://edk2.groups.io/g/devel/message/107394 Mute This Topic: https://groups.io/mt/100456378/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-