From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.11841.1660527994037594419 for ; Sun, 14 Aug 2022 18:46:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=f5nmWCgP; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660527994; x=1692063994; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VpF3L9s+VuCDfU2ffZhAfha/h4WdXCgR0Gu9fRJxvZY=; b=f5nmWCgPItTDuSkXlNraz2V9vksesDbPL1h+PPWDgANHWn2EfgvI4G0W D7cXrgCgsJOdm88Hm27YiG9sdON8UEd1rgu5rMP2+PN2/dfjb9DxDgtLC A118RM2tWJ+eJYxRNoPVVqcvYvvQgXtSP3mcXb0bNqGTH0xtB7b4DZ6Rk lPaAfEgYVUJXuRkqFx2Ix289nFRsHimcaGoVipwupLkSLT0J3ERpfpRTF VSZXpv0Al1KAUbnlSNFlG1m5okfsCac7DS4SyT00b2KQQ7LAUgDXH6L5g jAWLAsZTRNDmljiRyo+2NedDAy77I9KKYttfv4vfhxlGJaqA8m7SpL7F+ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10439"; a="355876006" X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="355876006" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2022 18:46:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="782508734" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 14 Aug 2022 18:46:33 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 14 Aug 2022 18:46:33 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 14 Aug 2022 18:46:32 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Sun, 14 Aug 2022 18:46:32 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Sun, 14 Aug 2022 18:46:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iadnbvRMG9gk4CsJaE9LMDlFNZ/LqFSVtTl0O0lQgqdU9TqwNcZvSbSId5l9T8OosGpmnKPTE11x0FzTPb87ei86CMNLzVYv3bd7s/+S0XjnNSzC+PyVCbfv2XOnAghdUMUUWARjhBBarAalVWMloON0zASKvqz2tgxhQ3siGvdaS0tm1QAmkLu46JAqTcHbPlSGondN0foQfV9giNZXkzfUQu5t9rzXQimkQ0deCuVIpCmtRFob2fB47Q8FYlZsQ2XUDDX+LLh4SKkNf4XyYDjGNNwVpkT5on9Gdxlqt+uN23tfT2d4k0uxZgtwrvO2EuUcbNxu5LG1hhcJ2hGQaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n6zeHvIo2qZ23qDtutERyVL/gDuS/KHUuf+2kq4Hunw=; b=E1zVJ2ORGMaDfM+KgGGqjavr+SfAoWpDVuWwaPBQsKTe9la/Ta0Mqk+JoRqwDN+73fogB9/uRDvYYECh2TX1t/mM5A6HybXjYvrau/lRTKSySmtp1W1Eez/cl3zksP0Gw3FcTvVGI9n8ABQVtJqS6hxlCe9mwsvFaiJJHky+1sZkhKjuS58/wBxAoNcghuXWvDfyNigpw0fG+OygszKKSgOUCyr8q/fz9f8cGrQh6YxDmbVQLZv1bg+73gFjcoa85FSCoFVjDhh1z7qkZU2hE+apkAZe5QSSMqoKRdt1DEX19dy0VxtShXKhLRVPQOr+VS43HZ9sfnPjxAx4swELcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by BN6PR11MB0033.namprd11.prod.outlook.com (2603:10b6:405:63::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 15 Aug 2022 01:46:30 +0000 Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::7d3b:c563:3356:608a]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::7d3b:c563:3356:608a%6]) with mapi id 15.20.5525.011; Mon, 15 Aug 2022 01:46:30 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Gao, Zhichao" , "Xue, Shengfeng" , "Ni, Ray" CC: "Gao, Liming" , "Xue, ShengfengX" Subject: Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17. Thread-Topic: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17. Thread-Index: AQHYqTi2Ia07LaL8vkOhXbAVuEbULK2mWkfggAjkdxA= Date: Mon, 15 Aug 2022 01:46:30 +0000 Message-ID: References: <2fcf297e06328cd25e92756b7fd13ed39cb9231b.1659749541.git.shengfengx.xue@intel.com> <1709A4B7A944DF88.7247@groups.io> In-Reply-To: <1709A4B7A944DF88.7247@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba881f90-605c-44ac-1004-08da7e5ff9b7 x-ms-traffictypediagnostic: BN6PR11MB0033:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X/p2zSEtuUK+yZf1IpQ9iNfRX6hpymn6ZNtXlgoaDC8S7Y0hAJHt2dzBA96x+q0lQTs8o9s9myH6EL7ciDA/8Xd8rmBI+xe+bbh3aDso5Cc5ntuoLwKhm0t46hEYbxfj1aF1TWNU7a5d4I17DYacbGPSAE1RzvIE30GFTWRtYRjcyENcGvDUVR+ny5A1NAM/O6yoLRiuVhPiNs4OyVH8tjJNhWEJwpnBJAeI8kRV1zIBrjPhhbFVTqkMsLgFFoHD0x301dladbl8R8l98fE0JBONdEyP3MNVRKyfzPmBje3Rr8Z+3wLmJ1r/1yE5JelGG+mFbPbAy1VDZekIqF3RCUqctn0TMaNgEJE1F3Iyb/X1yZDjuqVvXuSKsJOKcogeiyUkJhy9ZQpjlocZo7F4LzUEKn8U3apvt7MVvUKjIoRrljm+ljnRuB7avYFJn3VdHbYGPgANqaBYtgnQzLuuUxR8dafIMX2dx3M1oKfU+zAGQB/qz4jSX2QdC7jXQv54qOf9euOlMw+zwDUXeqqEy9nOvpWJvrGktoj8Sq9HyHqLUmewXJZ2J4LJ81bSvkhEVQ9rnqfyDGQd3fKF+OvxawKH4ENetScaT8SW4qG+tlhW6Mbwz28qCdq4+9Imkx75TPCG3Emh6UaUfsNrJXP1ftWOPsua46wAG+NYlr27YZyrufPUhVZdO1hyEw8pNRTQT8SA/oD14GKzayFI0lU8Xv92cQg37LsFg+tdHYD8WehpYeGznPA/h8I63nfXJmSLrEc04AvwwbKpcPHQOhnRxY1ZfzKP5zIi7C01IoIQIKmzsD0KUvslwtSHSqhonY40VxhtLo3pYo061J4tuKGoA2/Gm5F6vV/7IrbAB5fifExiYfH+QQlX8RQNTIOef7yc x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6377.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(39860400002)(396003)(376002)(346002)(6636002)(54906003)(110136005)(86362001)(38100700002)(83380400001)(186003)(966005)(8676002)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(4326008)(71200400001)(316002)(52536014)(5660300002)(8936002)(38070700005)(6506007)(7696005)(2906002)(9686003)(26005)(82960400001)(53546011)(122000001)(107886003)(55016003)(478600001)(41300700001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c5eKutWaJkxL3uyMwwyXT6GmvS3qXvQIhLhkqpCGWL3E1Q/bXQyCSy3xqbar?= =?us-ascii?Q?VXOv1LQ9NSAQ5miomqS7+Hqsjq6qcVN0k5Aq8fNC8O+3QTp6luGEX4HIoUvP?= =?us-ascii?Q?xpCjCJK9R6Fdb2Criaj9wO1D4nuBa6jW7dKfCptFVpmCaeUP4L+jlET78UEw?= =?us-ascii?Q?3eEVDlXMgTSXN63E6qLLqvbreMaXGbLpNNBzO0Y5CHN5cZ8joFHkc8MqhYSG?= =?us-ascii?Q?YVGMCapzTI0C3ksSWhTPXHWAIS/FrvAVnRB010do5EgqDsbHAKG1pPpSMrxy?= =?us-ascii?Q?cM779qw1Kdu0gYU4jNyXgdvOZkJMV8XXmk1ALLOeuZgxwl+8nw1gEayOqtkY?= =?us-ascii?Q?aNciqZrtDEqlClDsV7HeFbiQh6bzmTD7GKznIJx87bL/jc7bLskVbsUGCs2w?= =?us-ascii?Q?aUsjGHGHe0e1rEn9uGbiYyV8ypt1z0wY8k5NjTyxdXdTKeURW+uU4V3jnIQS?= =?us-ascii?Q?jAThbaZMo8lPykimLBC+0xenJZqTqSUNYzOx0KW1hRx7LMSyrUO84XJKGgIY?= =?us-ascii?Q?7aK/M0pxhsdmX27LovVrGNOjb4qya4BgURvlWG7WhJ/nvWf5JDD9uK1K4TK/?= =?us-ascii?Q?xfGOB5uydajwiAOsassni0vHdAN2IKC2aAJ+j4mqqvADZ216iOSynu+g8uxT?= =?us-ascii?Q?bUSa2ROuZF3QlH2lG3lmBYPvCtocZov4DoHnShGc4kLuskhQEtMOrMcswk78?= =?us-ascii?Q?a2IHC0lB/f0DzdfR2ba+TT5x7Hr1OUBZ3v5dH4RNiKwkNJIiXu01VRMwhshY?= =?us-ascii?Q?klViUzK6wLqPKKd1ntdOMqXvKLZp+i0O1EYnLbyTdmHXxCXKb+XDs7hzZ5C/?= =?us-ascii?Q?B/4HIWQb10iIrPKx7TNtATk+Y/tO3xe3+LboOWJ305VqJUkbeynUHV0Ilia9?= =?us-ascii?Q?1/gzcIosH1epi2irB/wvrhInkcyVcRtTyz4A9YPX9yJE4ddplCwNjUpTkO4z?= =?us-ascii?Q?y4Up4zjHqAfOmIW//YVP2dGtbJQ0YfY7Ybj/2BJox8i0CVgC49ILuKDiGq/J?= =?us-ascii?Q?J/L4qvr58I1Yve0glqozVJjapSZAjyEJ9rcrpmbXnkg7L+1wbFhus8P/ijru?= =?us-ascii?Q?IdeGlsLbWfHel81q2MV+sOcV0OG4K0DHztl4ZhQEAM2Y4SEDBwvgCr1Ce76M?= =?us-ascii?Q?0XEeskgrskp5hxZLdH+A+ctfPHwPrkJGkhjWglc16KinqRa/zt0ekPO5XTd5?= =?us-ascii?Q?64qBgLcJbkiRFmWQtCyqrP6aVHP9sHLbOvKAb4c/PU3YOdrY+vKUxk7IGA63?= =?us-ascii?Q?Zn7oEpkQZX71PCAVcmSgYB4kSbtoQBWNSMMktUFUMyh5YtuT05pdZ7wIojtx?= =?us-ascii?Q?Quf11eMDyWB6xoDWckEIBnZHfWYyAMyfApBfM7eGFS1qq0LXI3h/4LnYDkA9?= =?us-ascii?Q?tHdq+/VmSVxzbb5Fara4Y3kkhMpnvHS3nwLvg1FSECWO4Az6f9LFo5W66UYW?= =?us-ascii?Q?4Zl+L29guNnQ9TAIFmKn6qhbGM0Cfjic3B6TmpzMsVUDcZ7aHqeUL0O2LDM6?= =?us-ascii?Q?EhaaKO93C0wO2meIpI+nk7Hd0IeifOirSgErFyALBEqcE9V1LT/+VyYC7tOq?= =?us-ascii?Q?zQB5ueBpmbSivv7x090XIXpiONvAbaH23hTLaNuw?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba881f90-605c-44ac-1004-08da7e5ff9b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 01:46:30.2706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ykNEGPeVr3f+qxBwhw1dYMAKV6qBiJ3WXW6V34o0uhzvpVY6iPWBXJVenoWrR76/3OhBpa1G9mhdos1vVGyRjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0033 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The commit message should be limited within 72 characters. Suggest the new titile "ShellPkg/SmbiosView: Display extended memory info i= n smbiosview -t 17" Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Tuesday, August 9, 2022 5:57 PM > To: Xue, Shengfeng ; > devel@edk2.groups.io; Ni, Ray > Cc: Gao, Liming ; Xue, ShengfengX > > Subject: Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is > not show Extended Speed and Extended Configured Memory Speed in type > 17. >=20 > Reviewed-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: xueshengfeng > > Sent: Saturday, August 6, 2022 10:02 AM > > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > > > Cc: Gao, Liming ; Xue, ShengfengX > > > > Subject: [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show > > Extended Speed and Extended Configured Memory Speed in type 17. > > > > From: Shengfengx Xue > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4014 > > > > if Configured Memory Speed is 65,535 MT/s or greater, and the actual > > speed is stored in the Extended Configured Memory Speed field. but > > current Smbiosview have no this logic. > > > > Signed-off-by: Shengfengx Xue > > --- > > .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > index a0ee286c9a..0ab9f5063a 100644 > > --- > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > +++ > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > @@ -878,6 +878,11 @@ SmbiosPrintStructure ( > > } > > } > > > > + if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)= ) { > > + PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed); > > + PRINT_STRUCT_VALUE_H (Struct, Type17, > > ExtendedConfiguredMemorySpeed); > > + } > > + > > break; > > > > // > > -- > > 2.26.2.windows.1 > > >=20 >=20 >=20 >=20 >=20