public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Xue, Shengfeng" <xueshengfeng@byosoft.com.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Ni, Ray" <ray.ni@intel.com>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Xue, ShengfengX" <shengfengx.xue@intel.com>
Subject: Re: [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17.
Date: Tue, 9 Aug 2022 09:57:22 +0000	[thread overview]
Message-ID: <PH7PR11MB63771F78D7A156EC73B7CD1CF6629@PH7PR11MB6377.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2fcf297e06328cd25e92756b7fd13ed39cb9231b.1659749541.git.shengfengx.xue@intel.com>

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: xueshengfeng <xueshengfeng@byosoft.com.cn>
> Sent: Saturday, August 6, 2022 10:02 AM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Xue, ShengfengX
> <shengfengx.xue@intel.com>
> Subject: [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show
> Extended Speed and Extended Configured Memory Speed in type 17.
> 
> From: Shengfengx Xue <shengfengx.xue@intel.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4014
> 
> if Configured Memory Speed is 65,535 MT/s or greater, and the actual speed
> is stored in the Extended Configured Memory Speed field. but current
> Smbiosview have no this logic.
> 
> Signed-off-by: Shengfengx Xue <shengfengx.xue@intel.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index a0ee286c9a..0ab9f5063a 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -878,6 +878,11 @@ SmbiosPrintStructure (
>          }
>        }
> 
> +      if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
> +        PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
> +        PRINT_STRUCT_VALUE_H (Struct, Type17,
> ExtendedConfiguredMemorySpeed);
> +      }
> +
>        break;
> 
>      //
> --
> 2.26.2.windows.1
> 


  reply	other threads:[~2022-08-09  9:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06  2:02 [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17 xueshengfeng
2022-08-09  9:57 ` Gao, Zhichao [this message]
     [not found] ` <1709A4B7A944DF88.7247@groups.io>
2022-08-15  1:46   ` [edk2-devel] " Gao, Zhichao
2022-08-15  1:53     ` Xue, ShengfengX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB63771F78D7A156EC73B7CD1CF6629@PH7PR11MB6377.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox